| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4821a0bd-5dbe-cdf0-649f-5c49b955c3b1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 953A:1381AE:DC2CC0:13711EF:6978CCC3 |
| html-safe-nonce | e60600aab0ea116b7a29b21a836d85eb5c63fa7a5f680eda3c84ca117211a76f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTNBOjEzODFBRTpEQzJDQzA6MTM3MTFFRjo2OTc4Q0NDMyIsInZpc2l0b3JfaWQiOiIyOTI4NTc0NDIwOTI0MDI2MDUyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | de8f368a9d0a2dc5ea719103617b154ac31d59dfc6576edfbd3a388e7b7a91b4 |
| hovercard-subject-tag | pull_request:1892947266 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/solidjs/solid-refresh/68/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b3ffb8aff09e6fe0f52bad0b2fa5fbc1cc1c9027c7109dc737c8a309737a0f41/solidjs/solid-refresh/pull/68 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b3ffb8aff09e6fe0f52bad0b2fa5fbc1cc1c9027c7109dc737c8a309737a0f41/solidjs/solid-refresh/pull/68 |
| og:image:alt | Hello!
I've spent some time figuring out why it didn't work for me in webpack 5.
And it appears that you need to force webpack to use development export condition.
The simpler way to do thi... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | non25 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 8a71ca1f7ab5436216e1df86f398ef7a51ed3152c90e3f7332fc70cf97fcb9d6 |
| turbo-cache-control | no-preview |
| go-import | github.com/solidjs/solid-refresh git https://github.com/solidjs/solid-refresh.git |
| octolytics-dimension-user_id | 79226042 |
| octolytics-dimension-user_login | solidjs |
| octolytics-dimension-repository_id | 340609080 |
| octolytics-dimension-repository_nwo | solidjs/solid-refresh |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 340609080 |
| octolytics-dimension-repository_network_root_nwo | solidjs/solid-refresh |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | eaed570eead52a9920afef75dc3eb6d826fdc5ef |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsolidjs%2Fsolid-refresh%2Fpull%2F68 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsolidjs%2Fsolid-refresh%2Fpull%2F68 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=solidjs%2Fsolid-refresh |
| Reload | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68 |
| Reload | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68 |
| Reload | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68 |
|
solidjs
| https://patch-diff.githubusercontent.com/solidjs |
| solid-refresh | https://patch-diff.githubusercontent.com/solidjs/solid-refresh |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2Fsolidjs%2Fsolid-refresh |
|
Fork
21
| https://patch-diff.githubusercontent.com/login?return_to=%2Fsolidjs%2Fsolid-refresh |
|
Star
92
| https://patch-diff.githubusercontent.com/login?return_to=%2Fsolidjs%2Fsolid-refresh |
|
Code
| https://patch-diff.githubusercontent.com/solidjs/solid-refresh |
|
Issues
12
| https://patch-diff.githubusercontent.com/solidjs/solid-refresh/issues |
|
Pull requests
3
| https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/solidjs/solid-refresh/actions |
|
Projects
0
| https://patch-diff.githubusercontent.com/solidjs/solid-refresh/projects |
|
Security
0
| https://patch-diff.githubusercontent.com/solidjs/solid-refresh/security |
|
Insights
| https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pulse |
|
Code
| https://patch-diff.githubusercontent.com/solidjs/solid-refresh |
|
Issues
| https://patch-diff.githubusercontent.com/solidjs/solid-refresh/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/solidjs/solid-refresh/actions |
|
Projects
| https://patch-diff.githubusercontent.com/solidjs/solid-refresh/projects |
|
Security
| https://patch-diff.githubusercontent.com/solidjs/solid-refresh/security |
|
Insights
| https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pulse |
| Sign up for GitHub
| https://patch-diff.githubusercontent.com/signup?return_to=%2Fsolidjs%2Fsolid-refresh%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=%2Fsolidjs%2Fsolid-refresh%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68#issue-comment-box |
| non25 | https://patch-diff.githubusercontent.com/non25 |
| solidjs:main | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/tree/main |
| non25:use-solid-dev-for-refresh | https://patch-diff.githubusercontent.com/non25/solid-refresh/tree/use-solid-dev-for-refresh |
|
Troubleshooting steps to make HMR work in complex webpack configs
| https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68#top |
| non25 | https://patch-diff.githubusercontent.com/non25 |
| solidjs:main | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/tree/main |
| non25:use-solid-dev-for-refresh | https://patch-diff.githubusercontent.com/non25/solid-refresh/tree/use-solid-dev-for-refresh |
|
Conversation
13
| https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68 |
|
Commits
1
| https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68/commits |
|
Checks
0
| https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68/checks |
|
Files changed
| https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68/files |
| Please reload this page | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68 |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/non25 |
| non25 | https://patch-diff.githubusercontent.com/non25 |
| May 29, 2024 | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68#issue-2322254638 |
| resolve.conditionNames | https://webpack.js.org/configuration/resolve/#resolveconditionnames |
| Please reload this page | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68 |
| https://patch-diff.githubusercontent.com/vincentfretin |
| vincentfretin | https://patch-diff.githubusercontent.com/vincentfretin |
|
May 29, 2024
| https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68#pullrequestreview-2084732946 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68/files |
| README.md | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5 |
| vincentfretin | https://patch-diff.githubusercontent.com/vincentfretin |
| May 29, 2024 | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68#discussion_r1618480193 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/webpack/webpack/blob/ac8e83a4a2984ed977fd6c23a609da5cb43da492/lib/config/defaults.js#L1506-L1518 | https://github.com/webpack/webpack/blob/ac8e83a4a2984ed977fd6c23a609da5cb43da492/lib/config/defaults.js#L1506-L1518 |
| https://webpack.js.org/configuration/resolve/#resolvemainfields | https://webpack.js.org/configuration/resolve/#resolvemainfields |
| Please reload this page | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68 |
| non25 | https://patch-diff.githubusercontent.com/non25 |
| May 29, 2024 | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68#discussion_r1618833104 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68 |
| vincentfretin | https://patch-diff.githubusercontent.com/vincentfretin |
| May 29, 2024 | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68#discussion_r1619224386 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68 |
| non25 | https://patch-diff.githubusercontent.com/non25 |
| May 29, 2024 | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68#discussion_r1619570036 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68 |
| lxsmnsyc | https://patch-diff.githubusercontent.com/lxsmnsyc |
| May 30, 2024 | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68#discussion_r1619931518 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @non25 | https://github.com/non25 |
| Please reload this page | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68 |
| lxsmnsyc | https://patch-diff.githubusercontent.com/lxsmnsyc |
| Jun 4, 2024 | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68#discussion_r1625896970 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @vincentfretin | https://github.com/vincentfretin |
| Please reload this page | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68 |
| non25 | https://patch-diff.githubusercontent.com/non25 |
| Jun 4, 2024 | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68#discussion_r1626035261 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68 |
| vincentfretin | https://patch-diff.githubusercontent.com/vincentfretin |
| Jun 4, 2024 | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68#discussion_r1626083977 |
| Please reload this page | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/networked-aframe/naf-valid-avatars/blob/main/webpack.config.js | https://github.com/networked-aframe/naf-valid-avatars/blob/main/webpack.config.js |
| Please reload this page | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68 |
| lxsmnsyc | https://patch-diff.githubusercontent.com/lxsmnsyc |
| Jun 5, 2024 | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68#discussion_r1627996092 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @non25 | https://github.com/non25 |
| Please reload this page | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68 |
| non25 | https://patch-diff.githubusercontent.com/non25 |
| Jun 5, 2024 | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68#discussion_r1628012763 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @lxsmnsyc | https://github.com/lxsmnsyc |
| Please reload this page | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68 |
| https://patch-diff.githubusercontent.com/non25 |
| non25 | https://patch-diff.githubusercontent.com/non25 |
| force-pushed | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/compare/d18861b4c8dfb7f1b9993b0d12cce5448e000fea..fe167351b56075f86f49003956e70ec8a1b54e1a |
| d18861b | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/commit/d18861b4c8dfb7f1b9993b0d12cce5448e000fea |
| fe16735 | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/commit/fe167351b56075f86f49003956e70ec8a1b54e1a |
|
Compare
| https://patch-diff.githubusercontent.com/solidjs/solid-refresh/compare/d18861b4c8dfb7f1b9993b0d12cce5448e000fea..fe167351b56075f86f49003956e70ec8a1b54e1a |
| May 29, 2024 23:19 | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68#event-12978196166 |
| https://patch-diff.githubusercontent.com/non25 |
| non25 | https://patch-diff.githubusercontent.com/non25 |
| May 29, 2024 | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68#event-12978197383 |
|
| https://patch-diff.githubusercontent.com/non25 |
| Troubleshooting steps to make HMR work in complex webpack configs | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68/commits/937de6e9ae206976d4ba322606db78546c0624bc |
| 937de6e | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68/commits/937de6e9ae206976d4ba322606db78546c0624bc |
| https://patch-diff.githubusercontent.com/non25 |
| non25 | https://patch-diff.githubusercontent.com/non25 |
| force-pushed | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/compare/fe167351b56075f86f49003956e70ec8a1b54e1a..937de6e9ae206976d4ba322606db78546c0624bc |
| fe16735 | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/commit/fe167351b56075f86f49003956e70ec8a1b54e1a |
| 937de6e | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/commit/937de6e9ae206976d4ba322606db78546c0624bc |
|
Compare
| https://patch-diff.githubusercontent.com/solidjs/solid-refresh/compare/fe167351b56075f86f49003956e70ec8a1b54e1a..937de6e9ae206976d4ba322606db78546c0624bc |
| May 30, 2024 23:23 | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68#event-12992770527 |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in to comment | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsolidjs%2Fsolid-refresh%2Fpull%2F68 |
|
| https://patch-diff.githubusercontent.com/lxsmnsyc |
|
lxsmnsyc
| https://patch-diff.githubusercontent.com/lxsmnsyc |
|
| https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68/files/d18861b4c8dfb7f1b9993b0d12cce5448e000fea |
|
| https://patch-diff.githubusercontent.com/vincentfretin |
|
vincentfretin
| https://patch-diff.githubusercontent.com/vincentfretin |
|
| https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68/files/d18861b4c8dfb7f1b9993b0d12cce5448e000fea |
| Please reload this page | https://patch-diff.githubusercontent.com/solidjs/solid-refresh/pull/68 |
|
| https://patch-diff.githubusercontent.com/non25 |
|
| https://patch-diff.githubusercontent.com/vincentfretin |
|
| https://patch-diff.githubusercontent.com/lxsmnsyc |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |