Title: Fix/findpython development embed by RyanPaulMcKenna · Pull Request #565 · sofa-framework/SofaPython3 · GitHub
Open Graph Title: Fix/findpython development embed by RyanPaulMcKenna · Pull Request #565 · sofa-framework/SofaPython3
X Title: Fix/findpython development embed by RyanPaulMcKenna · Pull Request #565 · sofa-framework/SofaPython3
Description: Title: Fix Python::Python missing when building bindings via SP3_add_python_module (CMake FindPython Development.Embed) Summary This PR fixes a CMake configuration/build failure seen when downstream plugins (e.g. Cosserat) use SofaPython3’s SP3_add_python_module() helper and it internally calls python_add_library(). Problem On newer CMake/FindPython (observed with CMake 3.28 + Python 3.12 on Ubuntu), python_add_library() requires the imported target Python::Python to be defined. In some configurations, Python::Python is not created because find_package(Python … COMPONENTS Development.Embed …) was never requested, leading to: Python_ADD_LIBRARY: dependent target 'Python::Python' is not defined. Did you miss to request COMPONENT 'Development.Embed'? This then causes a cascade (e.g. missing CosseratBindings alias target). Solution Make SP3_add_python_module() self-contained by ensuring Python::Python exists before calling python_add_library(): If Python::Python is not already defined, explicitly call: find_package(Python REQUIRED COMPONENTS Interpreter Development Development.Module Development.Embed) This guarantees the required Python::Python target is present and prevents downstream projects from needing to add extra FindPython boilerplate. Testing Tested locally by building SOFA with SofaPython3 and the Cosserat plugin bindings enabled. After applying this change: CMake configure completes successfully (no Python::Python / Development.Embed error) Build and install succeed Example scenes run as expected.
Open Graph Description: Title: Fix Python::Python missing when building bindings via SP3_add_python_module (CMake FindPython Development.Embed) Summary This PR fixes a CMake configuration/build failure seen when downstrea...
X Description: Title: Fix Python::Python missing when building bindings via SP3_add_python_module (CMake FindPython Development.Embed) Summary This PR fixes a CMake configuration/build failure seen when downstrea...
Opengraph URL: https://github.com/sofa-framework/SofaPython3/pull/565
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d37acea9-9e64-3461-e6e2-af93be27fe74 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A0FA:3B14FD:2DB0F40:3BD91AB:697D6630 |
| html-safe-nonce | 3dd5911b42cdb1fc2f8648d27e5e387eaff18314067196c1809b27c3bf3c778d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMEZBOjNCMTRGRDoyREIwRjQwOjNCRDkxQUI6Njk3RDY2MzAiLCJ2aXNpdG9yX2lkIjoiMTg0NzIwNDc2OTM2NjM2OTg0MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7fc3d4f2bdd44eb2fc58e23bcf9b441fd406881e0ebb19fe2fee82520e4c188a |
| hovercard-subject-tag | pull_request:3178915453 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/sofa-framework/SofaPython3/pull/565/files |
| twitter:image | https://avatars.githubusercontent.com/u/13259735?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/13259735?s=400&v=4 |
| og:image:alt | Title: Fix Python::Python missing when building bindings via SP3_add_python_module (CMake FindPython Development.Embed) Summary This PR fixes a CMake configuration/build failure seen when downstrea... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/sofa-framework/SofaPython3 git https://github.com/sofa-framework/SofaPython3.git |
| octolytics-dimension-user_id | 11028508 |
| octolytics-dimension-user_login | sofa-framework |
| octolytics-dimension-repository_id | 260159147 |
| octolytics-dimension-repository_nwo | sofa-framework/SofaPython3 |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 260159147 |
| octolytics-dimension-repository_network_root_nwo | sofa-framework/SofaPython3 |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7c85641c598ad130c74f7bcc27f58575cac69551 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width