Title: Proposal for code helper to fix the binding docstring to make code documentation and completion happy by damienmarchal · Pull Request #461 · sofa-framework/SofaPython3 · GitHub
Open Graph Title: Proposal for code helper to fix the binding docstring to make code documentation and completion happy by damienmarchal · Pull Request #461 · sofa-framework/SofaPython3
X Title: Proposal for code helper to fix the binding docstring to make code documentation and completion happy by damienmarchal · Pull Request #461 · sofa-framework/SofaPython3
Description: Currently pybind11 generates the function signatures automagically and we use this feature a lot. The problem is that the automagically generates python signatures with type-hints and that these signatures may be invalid (in fact not narrow enough). On way to partially tackle the problem is to change de c++ code to help pybind11 to properly produce the correct signatures. In some case this is minor changes on the c++ side, but in some others this may imply massive refactoring. There is a second issue, when a function should have generic type hint signature (see PEP https://peps.python.org/pep-0695/) there is no way to add that in the automagicall process of pybind11's without changing pybind11 code and have that accepted mainstream. The proposed alternative was fix manually the failing method signatures. The draw back of the approach was that in that case all the docstring autogenerated are disabled. So we have to write every signature for each overload of a method, even if previously they were correct). In addition it was suggested by @bakpaul to have that done not directly in the docstring but in the c++ code. This PR is one possible implementation for such feature. Instead of the classical (which fails on signature generation): p.add_method("addObject", addObjectKwargs, sofapython3::doc::sofa::core::Node::addObjectKwargs); p.add_method("addObject", addObject, sofapython3::doc::sofa::core::Node::addObject); p.add_method("addObject", addObjectGenericType, sofapython3::doc::sofa::core::Node::addObjectGenerictype); Should be written this way (with custom signature generation only on the failing one) def_method(p, "addObject") .add_override(addObjectKwargs, sofapython3::doc::sofa::core::Node::addObjectKwargs) .add_override(addObject, sofapython3::doc::sofa::core::Node::addObject) .add_override("def addObject[T]() -> T", addObjectGenericType, sofapython3::doc::sofa::core::Node::addObjectGenerictype); The complexity of the code is a result of how pybind11 is doing the magic of binding.
Open Graph Description: Currently pybind11 generates the function signatures automagically and we use this feature a lot. The problem is that the automagically generates python signatures with type-hints and that these si...
X Description: Currently pybind11 generates the function signatures automagically and we use this feature a lot. The problem is that the automagically generates python signatures with type-hints and that these si...
Opengraph URL: https://github.com/sofa-framework/SofaPython3/pull/461
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:80f8524b-e860-4013-9a7f-c49aab9b6ad2 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | EC80:27367:18F3968:2024D9C:697F9E55 |
| html-safe-nonce | 61c2945e3b36a3d239192421b75cb403f8313753dffed8d91ccc4df8f53f4d63 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzgwOjI3MzY3OjE4RjM5Njg6MjAyNEQ5Qzo2OTdGOUU1NSIsInZpc2l0b3JfaWQiOiI5MTgzOTU5NDk0NTcxMzAyNDg1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 27893e82d980179555474d85929110796b5db02fc192557a7b385957a84a74e4 |
| hovercard-subject-tag | pull_request:2103671895 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/sofa-framework/SofaPython3/pull/461/checks |
| twitter:image | https://avatars.githubusercontent.com/u/12644882?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/12644882?s=400&v=4 |
| og:image:alt | Currently pybind11 generates the function signatures automagically and we use this feature a lot. The problem is that the automagically generates python signatures with type-hints and that these si... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6 |
| turbo-cache-control | no-preview |
| go-import | github.com/sofa-framework/SofaPython3 git https://github.com/sofa-framework/SofaPython3.git |
| octolytics-dimension-user_id | 11028508 |
| octolytics-dimension-user_login | sofa-framework |
| octolytics-dimension-repository_id | 260159147 |
| octolytics-dimension-repository_nwo | sofa-framework/SofaPython3 |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 260159147 |
| octolytics-dimension-repository_network_root_nwo | sofa-framework/SofaPython3 |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7c85641c598ad130c74f7bcc27f58575cac69551 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width