René's URL Explorer Experiment


Title: Fix context handling, stale test dirs, and resource leak by jmgurney · Pull Request #37 · smartfile/python-libarchive · GitHub

Open Graph Title: Fix context handling, stale test dirs, and resource leak by jmgurney · Pull Request #37 · smartfile/python-libarchive

X Title: Fix context handling, stale test dirs, and resource leak by jmgurney · Pull Request #37 · smartfile/python-libarchive

Description: Sorry, this combines a few fixes all in one, mainly I was dealing w/ a number of them and did a little bit of clean up at the same time. it drops py2 compatibility. it splits _defer_close to not d...

Open Graph Description: Sorry, this combines a few fixes all in one, mainly I was dealing w/ a number of them and did a little bit of clean up at the same time. it drops py2 compatibility. it splits _defer_close to not d...

X Description: Sorry, this combines a few fixes all in one, mainly I was dealing w/ a number of them and did a little bit of clean up at the same time. it drops py2 compatibility. it splits _defer_close to not d...

Opengraph URL: https://github.com/smartfile/python-libarchive/pull/37

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a3f8b9ab-2744-f493-1926-c173a3c76842
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id97DE:64A19:3A20BE1:4ABA875:6980160D
html-safe-nonce5d86c8212eb60b93635bde23d3b11bfdfdbfa5a089264f15b925035675183b7b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5N0RFOjY0QTE5OjNBMjBCRTE6NEFCQTg3NTo2OTgwMTYwRCIsInZpc2l0b3JfaWQiOiIxMTc4NTQ0OTQ2MjU3MzM1ODIxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac67e1f6b935f8cb1c233a506358032524b61d92f3d3cde69d4301c4f02d131eed
hovercard-subject-tagpull_request:1065751840
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/smartfile/python-libarchive/37/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7147bbd0a96e22ebeb90c04c2285e4c07ce5a0a598b5fcf1ffce49b08570f6b2/smartfile/python-libarchive/pull/37
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7147bbd0a96e22ebeb90c04c2285e4c07ce5a0a598b5fcf1ffce49b08570f6b2/smartfile/python-libarchive/pull/37
og:image:altSorry, this combines a few fixes all in one, mainly I was dealing w/ a number of them and did a little bit of clean up at the same time. it drops py2 compatibility. it splits _defer_close to not d...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejmgurney
hostnamegithub.com
expected-hostnamegithub.com
None60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6
turbo-cache-controlno-preview
go-importgithub.com/smartfile/python-libarchive git https://github.com/smartfile/python-libarchive.git
octolytics-dimension-user_id2232208
octolytics-dimension-user_loginsmartfile
octolytics-dimension-repository_id21706845
octolytics-dimension-repository_nwosmartfile/python-libarchive
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id21630086
octolytics-dimension-repository_parent_nwotravcunn/python-libarchive
octolytics-dimension-repository_network_root_id21630086
octolytics-dimension-repository_network_root_nwotravcunn/python-libarchive
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7c85641c598ad130c74f7bcc27f58575cac69551
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsmartfile%2Fpython-libarchive%2Fpull%2F37
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsmartfile%2Fpython-libarchive%2Fpull%2F37
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=smartfile%2Fpython-libarchive
Reloadhttps://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37
Reloadhttps://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37
Reloadhttps://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37
smartfile https://patch-diff.githubusercontent.com/smartfile
python-libarchivehttps://patch-diff.githubusercontent.com/smartfile/python-libarchive
travcunn/python-libarchivehttps://patch-diff.githubusercontent.com/travcunn/python-libarchive
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fsmartfile%2Fpython-libarchive
Fork 16 https://patch-diff.githubusercontent.com/login?return_to=%2Fsmartfile%2Fpython-libarchive
Star 23 https://patch-diff.githubusercontent.com/login?return_to=%2Fsmartfile%2Fpython-libarchive
Code https://patch-diff.githubusercontent.com/smartfile/python-libarchive
Issues 8 https://patch-diff.githubusercontent.com/smartfile/python-libarchive/issues
Pull requests 3 https://patch-diff.githubusercontent.com/smartfile/python-libarchive/pulls
Actions https://patch-diff.githubusercontent.com/smartfile/python-libarchive/actions
Projects 0 https://patch-diff.githubusercontent.com/smartfile/python-libarchive/projects
Wiki https://patch-diff.githubusercontent.com/smartfile/python-libarchive/wiki
Security 0 https://patch-diff.githubusercontent.com/smartfile/python-libarchive/security
Insights https://patch-diff.githubusercontent.com/smartfile/python-libarchive/pulse
Code https://patch-diff.githubusercontent.com/smartfile/python-libarchive
Issues https://patch-diff.githubusercontent.com/smartfile/python-libarchive/issues
Pull requests https://patch-diff.githubusercontent.com/smartfile/python-libarchive/pulls
Actions https://patch-diff.githubusercontent.com/smartfile/python-libarchive/actions
Projects https://patch-diff.githubusercontent.com/smartfile/python-libarchive/projects
Wiki https://patch-diff.githubusercontent.com/smartfile/python-libarchive/wiki
Security https://patch-diff.githubusercontent.com/smartfile/python-libarchive/security
Insights https://patch-diff.githubusercontent.com/smartfile/python-libarchive/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fsmartfile%2Fpython-libarchive%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fsmartfile%2Fpython-libarchive%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37#issue-comment-box
jmgurneyhttps://patch-diff.githubusercontent.com/jmgurney
smartfile:masterhttps://patch-diff.githubusercontent.com/smartfile/python-libarchive/tree/master
jmgurney:test_fixuphttps://patch-diff.githubusercontent.com/jmgurney/python-libarchive/tree/test_fixup
Fix context handling, stale test dirs, and resource leak https://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37#top
jmgurneyhttps://patch-diff.githubusercontent.com/jmgurney
smartfile:masterhttps://patch-diff.githubusercontent.com/smartfile/python-libarchive/tree/master
jmgurney:test_fixuphttps://patch-diff.githubusercontent.com/jmgurney/python-libarchive/tree/test_fixup
Conversation 1 https://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37
Commits 5 https://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37/commits
Checks 0 https://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37/checks
Files changed https://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37/files
Please reload this pagehttps://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/jmgurney
jmgurneyhttps://patch-diff.githubusercontent.com/jmgurney
Sep 23, 2022https://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37#issue-1384304654
Please reload this pagehttps://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37
jmgurneyhttps://patch-diff.githubusercontent.com/jmgurney
September 23, 2022 11:55https://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37#commits-pushed-bee4951
https://patch-diff.githubusercontent.com/jmgurney
drop python2 compatibility, it's been EOL'd for years nowhttps://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37/commits/bee495182e457719a02fb81519bdcb5303db1983
bee4951https://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37/commits/bee495182e457719a02fb81519bdcb5303db1983
https://patch-diff.githubusercontent.com/jmgurney
fix up tests so that the temp dir is cleaned up afterwardhttps://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37/commits/3878bbdfec4ec52b81d8232605bcb72c3b1d60c7
3878bbdhttps://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37/commits/3878bbdfec4ec52b81d8232605bcb72c3b1d60c7
https://patch-diff.githubusercontent.com/jmgurney
separate closing from deferred closing for streams.. make context wor…https://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37/commits/ba5832c545fff8ed1041b37ff22ee6dd21e754b8
ba5832chttps://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37/commits/ba5832c545fff8ed1041b37ff22ee6dd21e754b8
https://patch-diff.githubusercontent.com/jmgurney
make sure that files aren't closed when passed in..https://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37/commits/e658620f3819065f05df1be6307dccaf49247529
e658620https://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37/commits/e658620f3819065f05df1be6307dccaf49247529
https://patch-diff.githubusercontent.com/jmgurney
Merge branch 'master' into test_fixuphttps://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37/commits/f8f68ae0a99edb3ac4b38b0e9f7c069cb2d959c2
f8f68aehttps://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37/commits/f8f68ae0a99edb3ac4b38b0e9f7c069cb2d959c2
https://patch-diff.githubusercontent.com/cabarnes
cabarneshttps://patch-diff.githubusercontent.com/cabarnes
Sep 26, 2022 https://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37#pullrequestreview-1120336174
View reviewed changes https://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37/files/f8f68ae0a99edb3ac4b38b0e9f7c069cb2d959c2
tests.pyhttps://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37/files/f8f68ae0a99edb3ac4b38b0e9f7c069cb2d959c2#diff-f455f302936271d755f6892d443786094d2607b505ff180ca817cb9eeabe1e5e
cabarneshttps://patch-diff.githubusercontent.com/cabarnes
Sep 26, 2022https://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37#discussion_r980106591
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
TemporaryDirectoryhttps://docs.python.org/3/library/tempfile.html#tempfile.TemporaryDirectory
Please reload this pagehttps://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsmartfile%2Fpython-libarchive%2Fpull%2F37
https://patch-diff.githubusercontent.com/cabarnes
cabarnes https://patch-diff.githubusercontent.com/cabarnes
https://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37/files/f8f68ae0a99edb3ac4b38b0e9f7c069cb2d959c2
Please reload this pagehttps://patch-diff.githubusercontent.com/smartfile/python-libarchive/pull/37
https://patch-diff.githubusercontent.com/jmgurney
https://patch-diff.githubusercontent.com/cabarnes
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.