| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1c472811-bebc-5197-7ace-d6791d3a30f2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B99C:98268:1E2B5D6:2A3BF12:696F6017 |
| html-safe-nonce | c38659469c7cb98aa8df2193a0f7b08a5c19a165ae34d82f2657ea46f9697ccf |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTlDOjk4MjY4OjFFMkI1RDY6MkEzQkYxMjo2OTZGNjAxNyIsInZpc2l0b3JfaWQiOiIxOTU0NDkyMzU2NjM0ODI4ODIzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | bc0b4b422044cdd1154723d1bf9051514f4f4503343725ac955668c05f231686 |
| hovercard-subject-tag | pull_request:607878020 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/shapeblue/cloudstack/70/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b4bf29516d97add0c6d1b538ce39035fb6d91dbbc3052ed06ff1b103574fda6e/shapeblue/cloudstack/pull/70 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b4bf29516d97add0c6d1b538ce39035fb6d91dbbc3052ed06ff1b103574fda6e/shapeblue/cloudstack/pull/70 |
| og:image:alt | Description
This PR makes sure no orphaned snapshot details are considered in the cleanup at startup job.
a real solution would be to implement some kind of cascading delete, but as the parent reco... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | DaanHoogland |
| hostname | github.com |
| expected-hostname | github.com |
| None | 774d0922d2c4577043d2dab90427344eb4c6ce1d5579acb1dd504cff1a7e46f8 |
| turbo-cache-control | no-preview |
| go-import | github.com/shapeblue/cloudstack git https://github.com/shapeblue/cloudstack.git |
| octolytics-dimension-user_id | 6001764 |
| octolytics-dimension-user_login | shapeblue |
| octolytics-dimension-repository_id | 35481491 |
| octolytics-dimension-repository_nwo | shapeblue/cloudstack |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | true |
| octolytics-dimension-repository_parent_id | 9759448 |
| octolytics-dimension-repository_parent_nwo | apache/cloudstack |
| octolytics-dimension-repository_network_root_id | 9759448 |
| octolytics-dimension-repository_network_root_nwo | apache/cloudstack |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 650acea592f12d1bd8931d44546c209e0b06ed6e |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fshapeblue%2Fcloudstack%2Fpull%2F70 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fshapeblue%2Fcloudstack%2Fpull%2F70 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=shapeblue%2Fcloudstack |
| Reload | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70 |
| Reload | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70 |
| Reload | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70 |
|
shapeblue
| https://patch-diff.githubusercontent.com/shapeblue |
| cloudstack | https://patch-diff.githubusercontent.com/shapeblue/cloudstack |
| apache/cloudstack | https://patch-diff.githubusercontent.com/apache/cloudstack |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2Fshapeblue%2Fcloudstack |
|
Fork
7
| https://patch-diff.githubusercontent.com/login?return_to=%2Fshapeblue%2Fcloudstack |
|
Star
13
| https://patch-diff.githubusercontent.com/login?return_to=%2Fshapeblue%2Fcloudstack |
|
Code
| https://patch-diff.githubusercontent.com/shapeblue/cloudstack |
|
Issues
0
| https://patch-diff.githubusercontent.com/shapeblue/cloudstack/issues |
|
Pull requests
11
| https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pulls |
|
Discussions
| https://patch-diff.githubusercontent.com/shapeblue/cloudstack/discussions |
|
Projects
0
| https://patch-diff.githubusercontent.com/shapeblue/cloudstack/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://patch-diff.githubusercontent.com/shapeblue/cloudstack/security |
| Please reload this page | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70 |
|
Insights
| https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pulse |
|
Code
| https://patch-diff.githubusercontent.com/shapeblue/cloudstack |
|
Issues
| https://patch-diff.githubusercontent.com/shapeblue/cloudstack/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pulls |
|
Discussions
| https://patch-diff.githubusercontent.com/shapeblue/cloudstack/discussions |
|
Projects
| https://patch-diff.githubusercontent.com/shapeblue/cloudstack/projects |
|
Security
| https://patch-diff.githubusercontent.com/shapeblue/cloudstack/security |
|
Insights
| https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pulse |
| Sign up for GitHub
| https://patch-diff.githubusercontent.com/signup?return_to=%2Fshapeblue%2Fcloudstack%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=%2Fshapeblue%2Fcloudstack%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70#issue-comment-box |
| DaanHoogland | https://patch-diff.githubusercontent.com/DaanHoogland |
| 4.15 | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/tree/4.15 |
| strayDetails | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/tree/strayDetails |
|
protect against stray snapshot-details without snapshot
| https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70#top |
| DaanHoogland | https://patch-diff.githubusercontent.com/DaanHoogland |
| 4.15 | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/tree/4.15 |
| strayDetails | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/tree/strayDetails |
|
Conversation
7
| https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70 |
|
Commits
3
| https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70/commits |
|
Checks
0
| https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70/checks |
|
Files changed
| https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70/files |
| Please reload this page | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70 |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/DaanHoogland |
| DaanHoogland | https://patch-diff.githubusercontent.com/DaanHoogland |
| Apr 2, 2021 | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70#issue-849037613 |
| Please reload this page | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70 |
| protect against stray snapshot-details without snapshot | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70/commits/d775163586204a8de054aa62a3fe839ace2f8145 |
| d775163 | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70/commits/d775163586204a8de054aa62a3fe839ace2f8145 |
| https://patch-diff.githubusercontent.com/DaanHoogland |
| DaanHoogland | https://patch-diff.githubusercontent.com/DaanHoogland |
| sureshanaparti | https://patch-diff.githubusercontent.com/sureshanaparti |
| yadvr | https://patch-diff.githubusercontent.com/yadvr |
| April 2, 2021 07:30 | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70#event-4544717674 |
| https://patch-diff.githubusercontent.com/DaanHoogland |
| DaanHoogland | https://patch-diff.githubusercontent.com/DaanHoogland |
| Apr 2, 2021 | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70#issuecomment-812388717 |
| @sureshanaparti | https://github.com/sureshanaparti |
| Please reload this page | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70 |
| Pearl1594 | https://patch-diff.githubusercontent.com/Pearl1594 |
|
Apr 6, 2021
| https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70#ref-commit-200f89b |
|
| https://docs.github.com/articles/closing-issues-via-commit-messages |
|
| https://patch-diff.githubusercontent.com/RitchieVincent |
|
| https://patch-diff.githubusercontent.com/yadvr |
| storage: Volume storage migration action ( | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/commit/200f89bc089eacc8f58414accabb24c536972597 |
| #72 | https://github.com/shapeblue/cloudstack/pull/72 |
| ) | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/commit/200f89bc089eacc8f58414accabb24c536972597 |
| 200f89b | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/commit/200f89bc089eacc8f58414accabb24c536972597 |
| #70 | https://github.com/shapeblue/cloudstack/pull/70 |
| https://patch-diff.githubusercontent.com/sureshanaparti |
| sureshanaparti | https://patch-diff.githubusercontent.com/sureshanaparti |
| Apr 15, 2021 | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70#issuecomment-820370151 |
| @DaanHoogland | https://github.com/DaanHoogland |
| apache#4130 | https://github.com/apache/cloudstack/pull/4130 |
| apache#2870 | https://github.com/apache/cloudstack/pull/2870 |
| Please reload this page | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70 |
| https://patch-diff.githubusercontent.com/sureshanaparti |
| sureshanaparti | https://patch-diff.githubusercontent.com/sureshanaparti |
|
Apr 15, 2021
| https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70#pullrequestreview-636629699 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70/files/d775163586204a8de054aa62a3fe839ace2f8145 |
| framework/jobs/src/main/java/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70/files/d775163586204a8de054aa62a3fe839ace2f8145#diff-bfe11ecfec08823cde28fa2e4235532c51cc090ffcdea38f83d0d227b676df73 |
| sureshanaparti | https://patch-diff.githubusercontent.com/sureshanaparti |
| Apr 15, 2021 | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70#discussion_r614027866 |
| Please reload this page | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @DaanHoogland | https://github.com/DaanHoogland |
| Please reload this page | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70 |
| sureshanaparti | https://patch-diff.githubusercontent.com/sureshanaparti |
| Apr 16, 2021 | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70#discussion_r614762897 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70 |
| https://patch-diff.githubusercontent.com/sureshanaparti |
| sureshanaparti | https://patch-diff.githubusercontent.com/sureshanaparti |
|
Apr 15, 2021
| https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70#pullrequestreview-636632279 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70/files/d775163586204a8de054aa62a3fe839ace2f8145 |
| ...e/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/SnapshotDataFactoryImpl.java | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70/files/d775163586204a8de054aa62a3fe839ace2f8145#diff-87c6a770e33597044ac426540710db4f9c75051378244fb340dc26defc729be3 |
| sureshanaparti | https://patch-diff.githubusercontent.com/sureshanaparti |
| Apr 15, 2021 | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70#discussion_r614029757 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @DaanHoogland | https://github.com/DaanHoogland |
| Please reload this page | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70 |
| DaanHoogland | https://patch-diff.githubusercontent.com/DaanHoogland |
| Apr 18, 2021 | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70#discussion_r615394240 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70 |
| DaanHoogland | https://patch-diff.githubusercontent.com/DaanHoogland |
| Apr 18, 2021 | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70#discussion_r615396288 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70 |
| https://patch-diff.githubusercontent.com/sureshanaparti |
| sureshanaparti | https://patch-diff.githubusercontent.com/sureshanaparti |
|
Apr 16, 2021
| https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70#pullrequestreview-637598372 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70/files/d775163586204a8de054aa62a3fe839ace2f8145 |
| April 18, 2021 14:59 | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70#commits-pushed-120dd41 |
| extra null checks | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70/commits/120dd41c1d677adf314001c8fe1df8b610576a81 |
| 120dd41 | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70/commits/120dd41c1d677adf314001c8fe1df8b610576a81 |
| remove unused | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70/commits/bd3f6391c506fb54df89e3e169e578ceadc0cd94 |
| bd3f639 | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70/commits/bd3f6391c506fb54df89e3e169e578ceadc0cd94 |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in to comment | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fshapeblue%2Fcloudstack%2Fpull%2F70 |
|
| https://patch-diff.githubusercontent.com/sureshanaparti |
|
sureshanaparti
| https://patch-diff.githubusercontent.com/sureshanaparti |
|
| https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70/files/d775163586204a8de054aa62a3fe839ace2f8145 |
|
| https://patch-diff.githubusercontent.com/yadvr |
|
yadvr
| https://patch-diff.githubusercontent.com/yadvr |
| Please reload this page | https://patch-diff.githubusercontent.com/shapeblue/cloudstack/pull/70 |
|
| https://patch-diff.githubusercontent.com/DaanHoogland |
|
| https://patch-diff.githubusercontent.com/sureshanaparti |
|
| https://patch-diff.githubusercontent.com/apps/copilot-swe-agent |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |