René's URL Explorer Experiment


Title: Fix sign for OK: decode is not needed and break sign for special cases by PhantomYdn · Pull Request #998 · scribejava/scribejava · GitHub

Open Graph Title: Fix sign for OK: decode is not needed and break sign for special cases by PhantomYdn · Pull Request #998 · scribejava/scribejava

X Title: Fix sign for OK: decode is not needed and break sign for special cases by PhantomYdn · Pull Request #998 · scribejava/scribejava

Description: For an unknown reasons, OK signature was using URL decode while the actual value is already decoded. It leads to the situation when value indeed contains special symbols that can be decoded - signature becomes broken. PR fixes this and add few sub test cases to validate that. P.S. Code was not re-indented after try deletion: just to re-highlight actual change.

Open Graph Description: For an unknown reasons, OK signature was using URL decode while the actual value is already decoded. It leads to the situation when value indeed contains special symbols that can be decoded - signa...

X Description: For an unknown reasons, OK signature was using URL decode while the actual value is already decoded. It leads to the situation when value indeed contains special symbols that can be decoded - signa...

Opengraph URL: https://github.com/scribejava/scribejava/pull/998

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c2fb7649-150c-2881-3ce1-f5c22cc33778
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDC14:A458E:DF96CC:13A3664:6970C109
html-safe-nonce08ff77f74473a56df9a1db586970910620f657221c92f128eb9c7d5b1d7b0aef
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzE0OkE0NThFOkRGOTZDQzoxM0EzNjY0OjY5NzBDMTA5IiwidmlzaXRvcl9pZCI6Ijg1MzM0MjcwMTM0NjY2ODgwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacaf3b04205666037115e3ef1e415e6061636427923824052fbe608eb3efecca90
hovercard-subject-tagpull_request:564600831
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/scribejava/scribejava/pull/998/files
twitter:imagehttps://avatars.githubusercontent.com/u/1199285?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1199285?s=400&v=4
og:image:altFor an unknown reasons, OK signature was using URL decode while the actual value is already decoded. It leads to the situation when value indeed contains special symbols that can be decoded - signa...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonebb43a7bc61aba1b91c3c5cf8e7d00342e1e77a0cfe55a141222dbd7f9782d26f
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/scribejava/scribejava git https://github.com/scribejava/scribejava.git
octolytics-dimension-user_id15140551
octolytics-dimension-user_loginscribejava
octolytics-dimension-repository_id889932
octolytics-dimension-repository_nwoscribejava/scribejava
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id889932
octolytics-dimension-repository_network_root_nwoscribejava/scribejava
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release34817b01ad7cdf8b2beb35ea7b0e2a7609004eff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/scribejava/scribejava/pull/998/files#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fscribejava%2Fscribejava%2Fpull%2F998%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fscribejava%2Fscribejava%2Fpull%2F998%2Ffiles
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=scribejava%2Fscribejava
Reloadhttps://patch-diff.githubusercontent.com/scribejava/scribejava/pull/998/files
Reloadhttps://patch-diff.githubusercontent.com/scribejava/scribejava/pull/998/files
Reloadhttps://patch-diff.githubusercontent.com/scribejava/scribejava/pull/998/files
scribejava https://patch-diff.githubusercontent.com/scribejava
scribejavahttps://patch-diff.githubusercontent.com/scribejava/scribejava
Please reload this pagehttps://patch-diff.githubusercontent.com/scribejava/scribejava/pull/998/files
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fscribejava%2Fscribejava
Fork 1.7k https://patch-diff.githubusercontent.com/login?return_to=%2Fscribejava%2Fscribejava
Star 5.5k https://patch-diff.githubusercontent.com/login?return_to=%2Fscribejava%2Fscribejava
Code https://patch-diff.githubusercontent.com/scribejava/scribejava
Issues 44 https://patch-diff.githubusercontent.com/scribejava/scribejava/issues
Pull requests 30 https://patch-diff.githubusercontent.com/scribejava/scribejava/pulls
Actions https://patch-diff.githubusercontent.com/scribejava/scribejava/actions
Projects 0 https://patch-diff.githubusercontent.com/scribejava/scribejava/projects
Wiki https://patch-diff.githubusercontent.com/scribejava/scribejava/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/scribejava/scribejava/security
Please reload this pagehttps://patch-diff.githubusercontent.com/scribejava/scribejava/pull/998/files
Insights https://patch-diff.githubusercontent.com/scribejava/scribejava/pulse
Code https://patch-diff.githubusercontent.com/scribejava/scribejava
Issues https://patch-diff.githubusercontent.com/scribejava/scribejava/issues
Pull requests https://patch-diff.githubusercontent.com/scribejava/scribejava/pulls
Actions https://patch-diff.githubusercontent.com/scribejava/scribejava/actions
Projects https://patch-diff.githubusercontent.com/scribejava/scribejava/projects
Wiki https://patch-diff.githubusercontent.com/scribejava/scribejava/wiki
Security https://patch-diff.githubusercontent.com/scribejava/scribejava/security
Insights https://patch-diff.githubusercontent.com/scribejava/scribejava/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fscribejava%2Fscribejava%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fscribejava%2Fscribejava%2Fissues%2Fnew%2Fchoose
PhantomYdnhttps://patch-diff.githubusercontent.com/PhantomYdn
scribejava:masterhttps://patch-diff.githubusercontent.com/scribejava/scribejava/tree/master
PhantomYdn:fix_ok_signhttps://patch-diff.githubusercontent.com/PhantomYdn/scribejava/tree/fix_ok_sign
Conversation 0 https://patch-diff.githubusercontent.com/scribejava/scribejava/pull/998
Commits 1 https://patch-diff.githubusercontent.com/scribejava/scribejava/pull/998/commits
Checks 0 https://patch-diff.githubusercontent.com/scribejava/scribejava/pull/998/checks
Files changed https://patch-diff.githubusercontent.com/scribejava/scribejava/pull/998/files
Please reload this pagehttps://patch-diff.githubusercontent.com/scribejava/scribejava/pull/998/files
Fix sign for OK: decode is not needed and break sign for special cases https://patch-diff.githubusercontent.com/scribejava/scribejava/pull/998/files#top
Show all changes 1 commit https://patch-diff.githubusercontent.com/scribejava/scribejava/pull/998/files
5e76ed9 Fix sign for OK: decode is not needed and break sign for special cases PhantomYdn Jan 31, 2021 https://patch-diff.githubusercontent.com/scribejava/scribejava/pull/998/commits/5e76ed9f633b6bc1dc09f7808bc4651fa925336d
Clear filters https://patch-diff.githubusercontent.com/scribejava/scribejava/pull/998/files
Please reload this pagehttps://patch-diff.githubusercontent.com/scribejava/scribejava/pull/998/files
Please reload this pagehttps://patch-diff.githubusercontent.com/scribejava/scribejava/pull/998/files
OdnoklassnikiOAuthService.java https://patch-diff.githubusercontent.com/scribejava/scribejava/pull/998/files#diff-b5458d919f528fe061dfdb21acb89e1bb37c598ef205579e9e515b02430faea2
OdnoklassnikiServiceTest.java https://patch-diff.githubusercontent.com/scribejava/scribejava/pull/998/files#diff-3ff907db708793aa9aeefb05762f82dd343cde6afd4c25db0d095db45d8ce1fd
...pis/src/main/java/com/github/scribejava/apis/odnoklassniki/OdnoklassnikiOAuthService.javahttps://patch-diff.githubusercontent.com/scribejava/scribejava/pull/998/files#diff-b5458d919f528fe061dfdb21acb89e1bb37c598ef205579e9e515b02430faea2
View file https://patch-diff.githubusercontent.com/scribejava/scribejava/blob/5e76ed9f633b6bc1dc09f7808bc4651fa925336d/scribejava-apis/src/main/java/com/github/scribejava/apis/odnoklassniki/OdnoklassnikiOAuthService.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/scribejava/scribejava/pull/998/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/scribejava/scribejava/pull/998/files#diff-b5458d919f528fe061dfdb21acb89e1bb37c598ef205579e9e515b02430faea2
https://patch-diff.githubusercontent.com/scribejava/scribejava/pull/998/files#diff-b5458d919f528fe061dfdb21acb89e1bb37c598ef205579e9e515b02430faea2
https://patch-diff.githubusercontent.com/scribejava/scribejava/pull/998/files#diff-b5458d919f528fe061dfdb21acb89e1bb37c598ef205579e9e515b02430faea2
...apis/src/test/java/com/github/scribejava/apis/odnoklassniki/OdnoklassnikiServiceTest.javahttps://patch-diff.githubusercontent.com/scribejava/scribejava/pull/998/files#diff-3ff907db708793aa9aeefb05762f82dd343cde6afd4c25db0d095db45d8ce1fd
View file https://patch-diff.githubusercontent.com/scribejava/scribejava/blob/5e76ed9f633b6bc1dc09f7808bc4651fa925336d/scribejava-apis/src/test/java/com/github/scribejava/apis/odnoklassniki/OdnoklassnikiServiceTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/scribejava/scribejava/pull/998/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/scribejava/scribejava/pull/998/files#diff-3ff907db708793aa9aeefb05762f82dd343cde6afd4c25db0d095db45d8ce1fd
https://patch-diff.githubusercontent.com/scribejava/scribejava/pull/998/files#diff-3ff907db708793aa9aeefb05762f82dd343cde6afd4c25db0d095db45d8ce1fd
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.