Title: Skip FileListPreprocessor for autofill=false parameters by imagejan · Pull Request #423 · scijava/scijava-common · GitHub
Open Graph Title: Skip FileListPreprocessor for autofill=false parameters by imagejan · Pull Request #423 · scijava/scijava-common
X Title: Skip FileListPreprocessor for autofill=false parameters by imagejan · Pull Request #423 · scijava/scijava-common
Description: This pull request is a work in progress. This pull request changes the API of ModuleService and DefaultModuleService to include an optional parameter boolean acrossTypes that allows checking for solitary unresolved parameters within all inputs/outputs independent of their type, while maintaining the backwards-compatible method signatures. This allows to replace some duplicated logic in helper methods of FilePreprocessor and FileListPreprocessor by a call to moduleService.getSingleInput(), which makes them respect an autoFill=false parameter annotation and avoid calling uiService.chooseFile/chooseFiles for those parameters. The intended behavior is verified by two new tests that, before this PR, were failing on their last assertion. NB: The tests added here call uiService.setHeadless(false) in order to set their custom default UI.
Open Graph Description: This pull request is a work in progress. This pull request changes the API of ModuleService and DefaultModuleService to include an optional parameter boolean acrossTypes that allows checking for so...
X Description: This pull request is a work in progress. This pull request changes the API of ModuleService and DefaultModuleService to include an optional parameter boolean acrossTypes that allows checking for so...
Opengraph URL: https://github.com/scijava/scijava-common/pull/423
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5eb89a7a-9c6c-5c2a-6aa5-be5006607082 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C0FE:32E262:1A4A82C:234A4E3:697046A4 |
| html-safe-nonce | 84c402b1bb1d030691f43abfe4a59a11975ce710712f023486bd2029eef5f22c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMEZFOjMyRTI2MjoxQTRBODJDOjIzNEE0RTM6Njk3MDQ2QTQiLCJ2aXNpdG9yX2lkIjoiODM5MzEzOTgxMDc0MTUzNjQyMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1dcd3ccb46e5540b07897a58150c4f00444ffeb6b1489842fe0a899577cbdccb |
| hovercard-subject-tag | pull_request:644167649 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/scijava/scijava-common/pull/423/files |
| twitter:image | https://avatars.githubusercontent.com/u/2033938?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/2033938?s=400&v=4 |
| og:image:alt | This pull request is a work in progress. This pull request changes the API of ModuleService and DefaultModuleService to include an optional parameter boolean acrossTypes that allows checking for so... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9920a62ba22d06470388e2904804fb7e5ec51c9e35f81784e9191394c74b2bd2 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/scijava/scijava-common git https://github.com/scijava/scijava-common.git |
| octolytics-dimension-user_id | 1262770 |
| octolytics-dimension-user_login | scijava |
| octolytics-dimension-repository_id | 3594497 |
| octolytics-dimension-repository_nwo | scijava/scijava-common |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 3594497 |
| octolytics-dimension-repository_network_root_nwo | scijava/scijava-common |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f643964067a552f02067066d6a910b2f90a5721f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width