René's URL Explorer Experiment


Title: Fix Logger Parameter with Ops by maarzt · Pull Request #319 · scijava/scijava-common · GitHub

Open Graph Title: Fix Logger Parameter with Ops by maarzt · Pull Request #319 · scijava/scijava-common

X Title: Fix Logger Parameter with Ops by maarzt · Pull Request #319 · scijava/scijava-common

Description: Previously the LoggerPreprocessor automatically injected Logger Paramters for CommandService. But LoggerPreprocessor didn't work for Ops. This PR fixes this issue: Context injects Logger Parameter Logger extend Optional interface, this make Logger optional during ops matching. The issue is described in http://forum.imagej.net/t/using-the-new-scijava-logging-and-status-service-system-in-an-application/9964/10

Open Graph Description: Previously the LoggerPreprocessor automatically injected Logger Paramters for CommandService. But LoggerPreprocessor didn't work for Ops. This PR fixes this issue: Context injects Logger Param...

X Description: Previously the LoggerPreprocessor automatically injected Logger Paramters for CommandService. But LoggerPreprocessor didn't work for Ops. This PR fixes this issue: Context injects Logger P...

Opengraph URL: https://github.com/scijava/scijava-common/pull/319

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:40a79bdc-0686-1cc1-b0f4-637da55e445c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB894:163660:71123A:9AFEC4:696E7ACE
html-safe-nonce9a4726c72db45ffc73654a9246f0c4fd3211e7c8442360f80ff9f8001f428bfd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODk0OjE2MzY2MDo3MTEyM0E6OUFGRUM0OjY5NkU3QUNFIiwidmlzaXRvcl9pZCI6Ijg1MjU1MjA0MTgwMjAxNjIyNTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac067acc0b2c6d45f764c1aa9cab936c7b43b5691701413d00a033a2561f6381bd
hovercard-subject-tagpull_request:184746195
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/scijava/scijava-common/pull/319/files
twitter:imagehttps://avatars.githubusercontent.com/u/24407711?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/24407711?s=400&v=4
og:image:altPreviously the LoggerPreprocessor automatically injected Logger Paramters for CommandService. But LoggerPreprocessor didn't work for Ops. This PR fixes this issue: Context injects Logger Param...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonefdad15fd2ad43212aa8b8be5f2c2725550f8374ceeeb154a999ad9145b43f3f7
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/scijava/scijava-common git https://github.com/scijava/scijava-common.git
octolytics-dimension-user_id1262770
octolytics-dimension-user_loginscijava
octolytics-dimension-repository_id3594497
octolytics-dimension-repository_nwoscijava/scijava-common
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id3594497
octolytics-dimension-repository_network_root_nwoscijava/scijava-common
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release27b23bc056eb973d350fc95afc848757edb9e7a9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fscijava%2Fscijava-common%2Fpull%2F319%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fscijava%2Fscijava-common%2Fpull%2F319%2Ffiles
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=scijava%2Fscijava-common
Reloadhttps://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files
Reloadhttps://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files
Reloadhttps://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files
scijava https://patch-diff.githubusercontent.com/scijava
scijava-commonhttps://patch-diff.githubusercontent.com/scijava/scijava-common
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fscijava%2Fscijava-common
Fork 53 https://patch-diff.githubusercontent.com/login?return_to=%2Fscijava%2Fscijava-common
Star 90 https://patch-diff.githubusercontent.com/login?return_to=%2Fscijava%2Fscijava-common
Code https://patch-diff.githubusercontent.com/scijava/scijava-common
Issues 169 https://patch-diff.githubusercontent.com/scijava/scijava-common/issues
Pull requests 16 https://patch-diff.githubusercontent.com/scijava/scijava-common/pulls
Actions https://patch-diff.githubusercontent.com/scijava/scijava-common/actions
Projects 0 https://patch-diff.githubusercontent.com/scijava/scijava-common/projects
Wiki https://patch-diff.githubusercontent.com/scijava/scijava-common/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/scijava/scijava-common/security
Please reload this pagehttps://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files
Insights https://patch-diff.githubusercontent.com/scijava/scijava-common/pulse
Code https://patch-diff.githubusercontent.com/scijava/scijava-common
Issues https://patch-diff.githubusercontent.com/scijava/scijava-common/issues
Pull requests https://patch-diff.githubusercontent.com/scijava/scijava-common/pulls
Actions https://patch-diff.githubusercontent.com/scijava/scijava-common/actions
Projects https://patch-diff.githubusercontent.com/scijava/scijava-common/projects
Wiki https://patch-diff.githubusercontent.com/scijava/scijava-common/wiki
Security https://patch-diff.githubusercontent.com/scijava/scijava-common/security
Insights https://patch-diff.githubusercontent.com/scijava/scijava-common/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fscijava%2Fscijava-common%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fscijava%2Fscijava-common%2Fissues%2Fnew%2Fchoose
maarzthttps://patch-diff.githubusercontent.com/maarzt
scijava:masterhttps://patch-diff.githubusercontent.com/scijava/scijava-common/tree/master
maarzt:add-logger-injectionhttps://patch-diff.githubusercontent.com/maarzt/scijava-common/tree/add-logger-injection
Conversation 6 https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319
Commits 3 https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/commits
Checks 0 https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/checks
Files changed https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files
Please reload this pagehttps://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files
Fix Logger Parameter with Ops https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files#top
Show all changes 3 commits https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files
cad0cfe Context: add Logger injection maarzt Apr 27, 2018 https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/commits/cad0cfe8eaa3b4bfa7160b407c9fe1c9db162169
85af399 Remove LoggerPreprocessor maarzt Apr 27, 2018 https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/commits/85af3993de5c25b32f1c11433f214544d1490371
6e15e99 Logger: make Logger an optional parameter for Ops and Commands maarzt Apr 27, 2018 https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/commits/6e15e993d1d111ca074698a6e2ffccf916ccf47a
Clear filters https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files
Please reload this pagehttps://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files
Please reload this pagehttps://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files
Context.java https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files#diff-18548d8dbf9f7cd29b892e3a57d16feddc4e3dcb02b354c04de5591d093ef11d
Logger.java https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files#diff-5803b55dc08495ae4048fcf834d418c55cc85567b32b77aed8434b1606144278
LoggerPreprocessor.java https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files#diff-285a5171c107722aa7651faa742daa2af20ab295f07f137dfcd23f17d9b60fe2
LoggerInjectionTest.java https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files#diff-74b4ad600f943efb74314427beece00a23c13ca2eb0512561f1d6d405b20577c
CommandServiceLoggerIntegrationTest.java https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files#diff-eea42bad3fd53a8d3942d48a6dffb931fdfac8daf9a93929952612c958c17e06
src/main/java/org/scijava/Context.javahttps://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files#diff-18548d8dbf9f7cd29b892e3a57d16feddc4e3dcb02b354c04de5591d093ef11d
View file https://patch-diff.githubusercontent.com/scijava/scijava-common/blob/6e15e993d1d111ca074698a6e2ffccf916ccf47a/src/main/java/org/scijava/Context.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files#diff-18548d8dbf9f7cd29b892e3a57d16feddc4e3dcb02b354c04de5591d093ef11d
https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files#diff-18548d8dbf9f7cd29b892e3a57d16feddc4e3dcb02b354c04de5591d093ef11d
https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files#diff-18548d8dbf9f7cd29b892e3a57d16feddc4e3dcb02b354c04de5591d093ef11d
https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files#diff-18548d8dbf9f7cd29b892e3a57d16feddc4e3dcb02b354c04de5591d093ef11d
src/main/java/org/scijava/log/Logger.javahttps://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files#diff-5803b55dc08495ae4048fcf834d418c55cc85567b32b77aed8434b1606144278
View file https://patch-diff.githubusercontent.com/scijava/scijava-common/blob/6e15e993d1d111ca074698a6e2ffccf916ccf47a/src/main/java/org/scijava/log/Logger.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files#diff-5803b55dc08495ae4048fcf834d418c55cc85567b32b77aed8434b1606144278
https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files#diff-5803b55dc08495ae4048fcf834d418c55cc85567b32b77aed8434b1606144278
https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files#diff-5803b55dc08495ae4048fcf834d418c55cc85567b32b77aed8434b1606144278
src/main/java/org/scijava/module/process/LoggerPreprocessor.javahttps://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files#diff-285a5171c107722aa7651faa742daa2af20ab295f07f137dfcd23f17d9b60fe2
View file https://patch-diff.githubusercontent.com/scijava/scijava-common/blob/81b75fb9f0650bea69199a163e3df3e0ab3972a6/src/main/java/org/scijava/module/process/LoggerPreprocessor.java
Open in desktop https://desktop.github.com
Please reload this pagehttps://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files
src/test/java/org/scijava/log/LoggerInjectionTest.javahttps://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files#diff-74b4ad600f943efb74314427beece00a23c13ca2eb0512561f1d6d405b20577c
View file https://patch-diff.githubusercontent.com/scijava/scijava-common/blob/6e15e993d1d111ca074698a6e2ffccf916ccf47a/src/test/java/org/scijava/log/LoggerInjectionTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/{{ revealButtonHref }}
...odule/process/LoggerPreprocessorTest.java → .../CommandServiceLoggerIntegrationTest.javahttps://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files#diff-eea42bad3fd53a8d3942d48a6dffb931fdfac8daf9a93929952612c958c17e06
View file https://patch-diff.githubusercontent.com/scijava/scijava-common/blob/6e15e993d1d111ca074698a6e2ffccf916ccf47a/src/test/java/org/scijava/module/process/CommandServiceLoggerIntegrationTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files#diff-eea42bad3fd53a8d3942d48a6dffb931fdfac8daf9a93929952612c958c17e06
https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files#diff-eea42bad3fd53a8d3942d48a6dffb931fdfac8daf9a93929952612c958c17e06
https://patch-diff.githubusercontent.com/scijava/scijava-common/pull/319/files#diff-eea42bad3fd53a8d3942d48a6dffb931fdfac8daf9a93929952612c958c17e06
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.