René's URL Explorer Experiment


Title: Rework FFT Ops by gselzer · Pull Request #282 · scijava/scijava · GitHub

Open Graph Title: Rework FFT Ops by gselzer · Pull Request #282 · scijava/scijava

X Title: Rework FFT Ops by gselzer · Pull Request #282 · scijava/scijava

Description: This PR brings a modified version of work that @elevans started to improve FFT operations written as Functions. It now enables (and tests) that the following Op call works: var img = ... var fft = ops.op("filter.fft").input(img).apply(); // output type optional The main modification I added on top was extracting all of the FFT Ops into a single FFT.java class, rewriting them as static methods in the process. This obviates the many miscellaneous, ambiguously-named files in the package.

Open Graph Description: This PR brings a modified version of work that @elevans started to improve FFT operations written as Functions. It now enables (and tests) that the following Op call works: var img = ... var fft = ...

X Description: This PR brings a modified version of work that @elevans started to improve FFT operations written as Functions. It now enables (and tests) that the following Op call works: var img = ... var fft = ...

Opengraph URL: https://github.com/scijava/scijava/pull/282

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b4997610-8f69-53ea-8604-46df34ea04f7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD3A8:13E147:EFF99D1:139119C6:697707B0
html-safe-nonce1611cf73b5b941e4c791fe288c8b9ed10920862729361d55ea7553fe66eac97f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEM0E4OjEzRTE0NzpFRkY5OUQxOjEzOTExOUM2OjY5NzcwN0IwIiwidmlzaXRvcl9pZCI6IjE3MzU3NzM0MTA1MzQyOTU0NzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac97500ee033338d559c778cb8ab69e6ff27e151ed3d6f2407be7660a84c903ca8
hovercard-subject-tagpull_request:2327039554
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/scijava/scijava/pull/282/files
twitter:imagehttps://avatars.githubusercontent.com/u/29754838?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/29754838?s=400&v=4
og:image:altThis PR brings a modified version of work that @elevans started to improve FFT operations written as Functions. It now enables (and tests) that the following Op call works: var img = ... var fft = ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None01d198479908d09a841b2febe8eb105a81af2af7d81830960fe0971e1f4adc09
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/scijava/scijava git https://github.com/scijava/scijava.git
octolytics-dimension-user_id1262770
octolytics-dimension-user_loginscijava
octolytics-dimension-repository_id85618439
octolytics-dimension-repository_nwoscijava/scijava
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id85618439
octolytics-dimension-repository_network_root_nwoscijava/scijava
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef752335dbbea672610081196a1998e39aec5e14b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/scijava/scijava/pull/282/files#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fscijava%2Fscijava%2Fpull%2F282%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fscijava%2Fscijava%2Fpull%2F282%2Ffiles
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=scijava%2Fscijava
Reloadhttps://patch-diff.githubusercontent.com/scijava/scijava/pull/282/files
Reloadhttps://patch-diff.githubusercontent.com/scijava/scijava/pull/282/files
Reloadhttps://patch-diff.githubusercontent.com/scijava/scijava/pull/282/files
scijava https://patch-diff.githubusercontent.com/scijava
scijavahttps://patch-diff.githubusercontent.com/scijava/scijava
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fscijava%2Fscijava
Fork 0 https://patch-diff.githubusercontent.com/login?return_to=%2Fscijava%2Fscijava
Star 8 https://patch-diff.githubusercontent.com/login?return_to=%2Fscijava%2Fscijava
Code https://patch-diff.githubusercontent.com/scijava/scijava
Issues 63 https://patch-diff.githubusercontent.com/scijava/scijava/issues
Pull requests 1 https://patch-diff.githubusercontent.com/scijava/scijava/pulls
Actions https://patch-diff.githubusercontent.com/scijava/scijava/actions
Security 0 https://patch-diff.githubusercontent.com/scijava/scijava/security
Insights https://patch-diff.githubusercontent.com/scijava/scijava/pulse
Code https://patch-diff.githubusercontent.com/scijava/scijava
Issues https://patch-diff.githubusercontent.com/scijava/scijava/issues
Pull requests https://patch-diff.githubusercontent.com/scijava/scijava/pulls
Actions https://patch-diff.githubusercontent.com/scijava/scijava/actions
Security https://patch-diff.githubusercontent.com/scijava/scijava/security
Insights https://patch-diff.githubusercontent.com/scijava/scijava/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fscijava%2Fscijava%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fscijava%2Fscijava%2Fissues%2Fnew%2Fchoose
ctruedenhttps://patch-diff.githubusercontent.com/ctrueden
mainhttps://patch-diff.githubusercontent.com/scijava/scijava/tree/main
scijava-ops-image/fft-functionhttps://patch-diff.githubusercontent.com/scijava/scijava/tree/scijava-ops-image/fft-function
Conversation 2 https://patch-diff.githubusercontent.com/scijava/scijava/pull/282
Commits 2 https://patch-diff.githubusercontent.com/scijava/scijava/pull/282/commits
Checks 1 https://patch-diff.githubusercontent.com/scijava/scijava/pull/282/checks
Files changed https://patch-diff.githubusercontent.com/scijava/scijava/pull/282/files
Please reload this pagehttps://patch-diff.githubusercontent.com/scijava/scijava/pull/282/files
Rework FFT Ops https://patch-diff.githubusercontent.com/scijava/scijava/pull/282/files#top
Show all changes 2 commits https://patch-diff.githubusercontent.com/scijava/scijava/pull/282/files
3d0b19c Create a proper "filter.fft" function op elevans Feb 19, 2024 https://patch-diff.githubusercontent.com/scijava/scijava/pull/282/commits/3d0b19c19fb22df547be6e7168f934c1b61fb5da
7048430 Reorganize FFT Ops gselzer Feb 10, 2025 https://patch-diff.githubusercontent.com/scijava/scijava/pull/282/commits/7048430e5c74b73783d88f4ea62c5002654882dc
Clear filters https://patch-diff.githubusercontent.com/scijava/scijava/pull/282/files
Please reload this pagehttps://patch-diff.githubusercontent.com/scijava/scijava/pull/282/files
Please reload this pagehttps://patch-diff.githubusercontent.com/scijava/scijava/pull/282/files
CreateOutputFFTMethods.java https://patch-diff.githubusercontent.com/scijava/scijava/pull/282/files#diff-1fcca3b3fbb367a47e6ae116843b4f44e1cf8a405fcc1fa89b3d2a3f69fb835b
FFTMethodsOpC.java https://patch-diff.githubusercontent.com/scijava/scijava/pull/282/files#diff-6dfae81ace349d017c306a51947d0bfdc7c68f143a26824c9f897fc724f80393
FFTMethodsOpF.java https://patch-diff.githubusercontent.com/scijava/scijava/pull/282/files#diff-30a2c0b9c794ec0e9634e2be4f716dc8b3a15ee4fd06369b02f736a35d46a401
FFTMethodsUtility.java https://patch-diff.githubusercontent.com/scijava/scijava/pull/282/files#diff-e6e510b351f619ca0f36fe924e3d5d8561507536dc7e140aa6ccc904e43b1683
FFTs.java https://patch-diff.githubusercontent.com/scijava/scijava/pull/282/files#diff-f6372a2bd567fdffcb5f6ed76d97abd06e69a82c721ba9b8a0129480559b31e7
OpRegressionTest.java https://patch-diff.githubusercontent.com/scijava/scijava/pull/282/files#diff-78a6b4d2bac0ca75b89304cf7d2fa5f11fd02d86a72696143f5156a9ef8e2ab2
FFTTest.java https://patch-diff.githubusercontent.com/scijava/scijava/pull/282/files#diff-f034341f6b3299c3751b73de5cf9744ee7f30904d09a619de7a30e83209045ee
scijava-ops-image/src/main/java/org/scijava/ops/image/filter/fft/CreateOutputFFTMethods.javahttps://patch-diff.githubusercontent.com/scijava/scijava/pull/282/files#diff-1fcca3b3fbb367a47e6ae116843b4f44e1cf8a405fcc1fa89b3d2a3f69fb835b
View file https://patch-diff.githubusercontent.com/scijava/scijava/blob/ed80f91e6302341db3f74bce73ee6a53bbbdd206/scijava-ops-image/src/main/java/org/scijava/ops/image/filter/fft/CreateOutputFFTMethods.java
Open in desktop https://desktop.github.com
Please reload this pagehttps://patch-diff.githubusercontent.com/scijava/scijava/pull/282/files
scijava-ops-image/src/main/java/org/scijava/ops/image/filter/fft/FFTMethodsOpC.javahttps://patch-diff.githubusercontent.com/scijava/scijava/pull/282/files#diff-6dfae81ace349d017c306a51947d0bfdc7c68f143a26824c9f897fc724f80393
View file https://patch-diff.githubusercontent.com/scijava/scijava/blob/ed80f91e6302341db3f74bce73ee6a53bbbdd206/scijava-ops-image/src/main/java/org/scijava/ops/image/filter/fft/FFTMethodsOpC.java
Open in desktop https://desktop.github.com
Please reload this pagehttps://patch-diff.githubusercontent.com/scijava/scijava/pull/282/files
scijava-ops-image/src/main/java/org/scijava/ops/image/filter/fft/FFTMethodsOpF.javahttps://patch-diff.githubusercontent.com/scijava/scijava/pull/282/files#diff-30a2c0b9c794ec0e9634e2be4f716dc8b3a15ee4fd06369b02f736a35d46a401
View file https://patch-diff.githubusercontent.com/scijava/scijava/blob/ed80f91e6302341db3f74bce73ee6a53bbbdd206/scijava-ops-image/src/main/java/org/scijava/ops/image/filter/fft/FFTMethodsOpF.java
Open in desktop https://desktop.github.com
Please reload this pagehttps://patch-diff.githubusercontent.com/scijava/scijava/pull/282/files
scijava-ops-image/src/main/java/org/scijava/ops/image/filter/fft/FFTMethodsUtility.javahttps://patch-diff.githubusercontent.com/scijava/scijava/pull/282/files#diff-e6e510b351f619ca0f36fe924e3d5d8561507536dc7e140aa6ccc904e43b1683
View file https://patch-diff.githubusercontent.com/scijava/scijava/blob/ed80f91e6302341db3f74bce73ee6a53bbbdd206/scijava-ops-image/src/main/java/org/scijava/ops/image/filter/fft/FFTMethodsUtility.java
Open in desktop https://desktop.github.com
Please reload this pagehttps://patch-diff.githubusercontent.com/scijava/scijava/pull/282/files
Please reload this pagehttps://patch-diff.githubusercontent.com/scijava/scijava/pull/282/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.