René's URL Explorer Experiment


Title: Add methods to remove entities from Node by jacobperron · Pull Request #110 · ros2-java/ros2_java · GitHub

Open Graph Title: Add methods to remove entities from Node by jacobperron · Pull Request #110 · ros2-java/ros2_java

X Title: Add methods to remove entities from Node by jacobperron · Pull Request #110 · ros2-java/ros2_java

Description: When an entity is disposed, make sure to also remove it from the Node. This resolves an issue where invalid entities may be used by other classes or users. For example, a disposed Subscription bein...

Open Graph Description: When an entity is disposed, make sure to also remove it from the Node. This resolves an issue where invalid entities may be used by other classes or users. For example, a disposed Subscription bein...

X Description: When an entity is disposed, make sure to also remove it from the Node. This resolves an issue where invalid entities may be used by other classes or users. For example, a disposed Subscription bein...

Opengraph URL: https://github.com/ros2-java/ros2_java/pull/110

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c599ed09-97d2-e29d-7679-afaf69ed5ff0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDEEC:10E69B:9182B4:B7F684:697FC8AB
html-safe-nonce6fc81fd6ba5e953f2dd9c420f59dd060268679b1676cc6af047af2d612a77df6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERUVDOjEwRTY5Qjo5MTgyQjQ6QjdGNjg0OjY5N0ZDOEFCIiwidmlzaXRvcl9pZCI6IjM2NDg4OTIyMjA4ODQzNzE2MjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace4b627d760059f00ceda00719d91b375f103069364204d372150f35f388a9d4b
hovercard-subject-tagpull_request:431445411
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/ros2-java/ros2_java/110/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d8725309a30066ba33906a4557fb49cf53de8bfee1a8320b6df9ec4e9315c256/ros2-java/ros2_java/pull/110
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d8725309a30066ba33906a4557fb49cf53de8bfee1a8320b6df9ec4e9315c256/ros2-java/ros2_java/pull/110
og:image:altWhen an entity is disposed, make sure to also remove it from the Node. This resolves an issue where invalid entities may be used by other classes or users. For example, a disposed Subscription bein...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejacobperron
hostnamegithub.com
expected-hostnamegithub.com
None60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6
turbo-cache-controlno-preview
go-importgithub.com/ros2-java/ros2_java git https://github.com/ros2-java/ros2_java.git
octolytics-dimension-user_id23436176
octolytics-dimension-user_loginros2-java
octolytics-dimension-repository_id52850323
octolytics-dimension-repository_nworos2-java/ros2_java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id52850323
octolytics-dimension-repository_network_root_nworos2-java/ros2_java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7c85641c598ad130c74f7bcc27f58575cac69551
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fros2-java%2Fros2_java%2Fpull%2F110
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fros2-java%2Fros2_java%2Fpull%2F110
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=ros2-java%2Fros2_java
Reloadhttps://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110
Reloadhttps://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110
Reloadhttps://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110
ros2-java https://patch-diff.githubusercontent.com/ros2-java
ros2_javahttps://patch-diff.githubusercontent.com/ros2-java/ros2_java
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fros2-java%2Fros2_java
Fork 108 https://patch-diff.githubusercontent.com/login?return_to=%2Fros2-java%2Fros2_java
Star 199 https://patch-diff.githubusercontent.com/login?return_to=%2Fros2-java%2Fros2_java
Code https://patch-diff.githubusercontent.com/ros2-java/ros2_java
Issues 54 https://patch-diff.githubusercontent.com/ros2-java/ros2_java/issues
Pull requests 9 https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pulls
Actions https://patch-diff.githubusercontent.com/ros2-java/ros2_java/actions
Projects 0 https://patch-diff.githubusercontent.com/ros2-java/ros2_java/projects
Security 0 https://patch-diff.githubusercontent.com/ros2-java/ros2_java/security
Insights https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pulse
Code https://patch-diff.githubusercontent.com/ros2-java/ros2_java
Issues https://patch-diff.githubusercontent.com/ros2-java/ros2_java/issues
Pull requests https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pulls
Actions https://patch-diff.githubusercontent.com/ros2-java/ros2_java/actions
Projects https://patch-diff.githubusercontent.com/ros2-java/ros2_java/projects
Security https://patch-diff.githubusercontent.com/ros2-java/ros2_java/security
Insights https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fros2-java%2Fros2_java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fros2-java%2Fros2_java%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110#issue-comment-box
estevehttps://patch-diff.githubusercontent.com/esteve
dashinghttps://patch-diff.githubusercontent.com/ros2-java/ros2_java/tree/dashing
jacob/fix_105https://patch-diff.githubusercontent.com/ros2-java/ros2_java/tree/jacob/fix_105
Add methods to remove entities from Node https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110#top
estevehttps://patch-diff.githubusercontent.com/esteve
dashinghttps://patch-diff.githubusercontent.com/ros2-java/ros2_java/tree/dashing
jacob/fix_105https://patch-diff.githubusercontent.com/ros2-java/ros2_java/tree/jacob/fix_105
Conversation 8 https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110
Commits 3 https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110/commits
Checks 0 https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110/checks
Files changed https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110/files
Please reload this pagehttps://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/jacobperron
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
Jun 8, 2020https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110#issue-634994701
#105https://github.com/ros2-java/ros2_java/issues/105
Please reload this pagehttps://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110
https://patch-diff.githubusercontent.com/esteve
estevehttps://patch-diff.githubusercontent.com/esteve
Jun 9, 2020https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110#event-3424030701
https://patch-diff.githubusercontent.com/esteve
estevehttps://patch-diff.githubusercontent.com/esteve
Jun 9, 2020https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110#issuecomment-641178105
Please reload this pagehttps://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110
@jacobperronhttps://github.com/jacobperron
#109 (comment)https://github.com/ros2-java/ros2_java/pull/109#issuecomment-640813472
Please reload this pagehttps://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110
https://patch-diff.githubusercontent.com/jacobperron
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
Jun 10, 2020 https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110#ref-pullrequest-636601346
Disable flake8 #111 https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/111
https://patch-diff.githubusercontent.com/jacobperron
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
Jun 10, 2020https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110#issuecomment-642312801
#111https://github.com/ros2-java/ros2_java/pull/111
Please reload this pagehttps://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110
https://patch-diff.githubusercontent.com/clalancette
clalancettehttps://patch-diff.githubusercontent.com/clalancette
Jun 23, 2020 https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110#pullrequestreview-436166989
View reviewed changes https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110/files
clalancettehttps://patch-diff.githubusercontent.com/clalancette
https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110#pullrequestreview-436166989
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110
rcljava/src/test/java/org/ros2/rcljava/subscription/SubscriptionTest.javahttps://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110/files#diff-71e179a4f9f5e45c68baa61cd2446784e41017d7fa25496fe3e942e385b900ef
Please reload this pagehttps://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
June 24, 2020 14:10https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110#commits-pushed-b16be6c
https://patch-diff.githubusercontent.com/jacobperron
Add methods to remove entities from Nodehttps://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110/commits/b16be6c8f7f384c6d44dcb2564b38c4eb71e3329
b16be6chttps://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110/commits/b16be6c8f7f384c6d44dcb2564b38c4eb71e3329
#105https://github.com/ros2-java/ros2_java/issues/105
https://patch-diff.githubusercontent.com/jacobperron
Add tests for disposing publishers, services, and clientshttps://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110/commits/085fc24ac1ce3a7c6cdbff716cd78abfb68868bb
085fc24https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110/commits/085fc24ac1ce3a7c6cdbff716cd78abfb68868bb
https://patch-diff.githubusercontent.com/jacobperron
Rename testhttps://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110/commits/c8e5d854181ad9157311946ff1ae751d93da0e0e
c8e5d85https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110/commits/c8e5d854181ad9157311946ff1ae751d93da0e0e
https://patch-diff.githubusercontent.com/jacobperron
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
force-pushedhttps://patch-diff.githubusercontent.com/ros2-java/ros2_java/compare/7972639747e9c51d98345ab4ca7e269f8c178672..c8e5d854181ad9157311946ff1ae751d93da0e0e
7972639https://patch-diff.githubusercontent.com/ros2-java/ros2_java/commit/7972639747e9c51d98345ab4ca7e269f8c178672
c8e5d85https://patch-diff.githubusercontent.com/ros2-java/ros2_java/commit/c8e5d854181ad9157311946ff1ae751d93da0e0e
Compare https://patch-diff.githubusercontent.com/ros2-java/ros2_java/compare/7972639747e9c51d98345ab4ca7e269f8c178672..c8e5d854181ad9157311946ff1ae751d93da0e0e
June 24, 2020 21:10https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110#event-3479401611
https://patch-diff.githubusercontent.com/jacobperron
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
Jun 24, 2020https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110#issuecomment-649073538
Please reload this pagehttps://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110
https://patch-diff.githubusercontent.com/esteve
estevehttps://patch-diff.githubusercontent.com/esteve
June 24, 2020 21:54https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110#event-3479535081
https://patch-diff.githubusercontent.com/jacobperron
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
Jun 30, 2020https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110#issuecomment-652024511
@estevehttps://github.com/esteve
@clalancettehttps://github.com/clalancette
Please reload this pagehttps://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110
https://patch-diff.githubusercontent.com/esteve
estevehttps://patch-diff.githubusercontent.com/esteve
cf2ef07https://patch-diff.githubusercontent.com/ros2-java/ros2_java/commit/cf2ef0707f7420f9b83e6c053775c9d52752a9e2
Jun 30, 2020https://github.com/ros2-java/ros2_java/pull/110#event-3499652548
https://patch-diff.githubusercontent.com/esteve
estevehttps://patch-diff.githubusercontent.com/esteve
Jun 30, 2020https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110#issuecomment-652045407
@jacobperronhttps://github.com/jacobperron
Please reload this pagehttps://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110
https://patch-diff.githubusercontent.com/jacobperron
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
June 30, 2020 21:30https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110#event-3499722352
https://patch-diff.githubusercontent.com/jacobperron
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
Jul 29, 2020 https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110#ref-issue-610877659
Unsubscribe from topic safely #105 https://patch-diff.githubusercontent.com/ros2-java/ros2_java/issues/105
https://patch-diff.githubusercontent.com/jacobperron
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
Aug 26, 2020 https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110#ref-pullrequest-683104610
Autoremove EventHandler from parent entity osrf/ros2_java#16 https://patch-diff.githubusercontent.com/osrf/ros2_java/pull/16
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
May 17, 2021 https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110#ref-commit-d270e67
https://patch-diff.githubusercontent.com/jacobperron
Add methods to remove entities from Node (https://patch-diff.githubusercontent.com/ros2-java/ros2_java/commit/d270e67520e8bff241887e90c400481b68288a52
#110https://github.com/ros2-java/ros2_java/pull/110
)https://patch-diff.githubusercontent.com/ros2-java/ros2_java/commit/d270e67520e8bff241887e90c400481b68288a52
d270e67https://patch-diff.githubusercontent.com/ros2-java/ros2_java/commit/d270e67520e8bff241887e90c400481b68288a52
#105https://github.com/ros2-java/ros2_java/issues/105
jacobperronhttps://patch-diff.githubusercontent.com/jacobperron
May 17, 2021 https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110#ref-commit-31a6bac
https://patch-diff.githubusercontent.com/jacobperron
Add methods to remove entities from Node (https://patch-diff.githubusercontent.com/ros2-java/ros2_java/commit/31a6bacf6d5d8b732c89079334249d44ae59e64b
#110https://github.com/ros2-java/ros2_java/pull/110
)https://patch-diff.githubusercontent.com/ros2-java/ros2_java/commit/31a6bacf6d5d8b732c89079334249d44ae59e64b
31a6bachttps://patch-diff.githubusercontent.com/ros2-java/ros2_java/commit/31a6bacf6d5d8b732c89079334249d44ae59e64b
#105https://github.com/ros2-java/ros2_java/issues/105
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fros2-java%2Fros2_java%2Fpull%2F110
https://patch-diff.githubusercontent.com/esteve
esteve https://patch-diff.githubusercontent.com/esteve
https://patch-diff.githubusercontent.com/clalancette
clalancette https://patch-diff.githubusercontent.com/clalancette
https://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110/files/c8ae3e7e6caa52f9ecd170e83ca1739e69968241
https://patch-diff.githubusercontent.com/esteve
esteve https://patch-diff.githubusercontent.com/esteve
Please reload this pagehttps://patch-diff.githubusercontent.com/ros2-java/ros2_java/pull/110
https://patch-diff.githubusercontent.com/jacobperron
https://patch-diff.githubusercontent.com/esteve
https://patch-diff.githubusercontent.com/clalancette
https://patch-diff.githubusercontent.com/apps/copilot-swe-agent
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.