Title: Would you like "Style" PRs that make some classes final? · Issue #6 · robaho/httpserver · GitHub
Open Graph Title: Would you like "Style" PRs that make some classes final? · Issue #6 · robaho/httpserver
X Title: Would you like "Style" PRs that make some classes final? · Issue #6 · robaho/httpserver
Description: Hi, there are some classes that look to me like they could be final. Are you interested in getting PR's for adding the final modifier to some of these classes? As another style note, I see some methods that implement an interface method ...
Open Graph Description: Hi, there are some classes that look to me like they could be final. Are you interested in getting PR's for adding the final modifier to some of these classes? As another style note, I see some met...
X Description: Hi, there are some classes that look to me like they could be final. Are you interested in getting PR's for adding the final modifier to some of these classes? As another style note, I see some...
Opengraph URL: https://github.com/robaho/httpserver/issues/6
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Would you like \"Style\" PRs that make some classes final?","articleBody":"Hi, there are some classes that look to me like they could be `final`. Are you interested in getting PR's for adding the final modifier to some of these classes? \r\n\r\nAs another style note, I see some methods that implement an interface method are not annotated with `@Override`. Are you interested in PR's that would add `@Override` to these methods [conceptually this improves support for refactoring such as removing methods from interfaces]. \r\n\r\nAre either of these something you'd like to get PR's for?\r\n\r\nCheers, Rob.","author":{"url":"https://github.com/rbygrave","@type":"Person","name":"rbygrave"},"datePublished":"2024-12-03T01:22:37.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/6/httpserver/issues/6"}| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:b8dfb605-bc34-c76d-1de3-77471ed9b8ab |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9210:2946F1:27F0C6C:33F7C52:696D9CB4 |
| html-safe-nonce | 8a418a2f53d7fe50ab94967ab557a8d557aa6370733405e280bef39699aaa21f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjEwOjI5NDZGMToyN0YwQzZDOjMzRjdDNTI6Njk2RDlDQjQiLCJ2aXNpdG9yX2lkIjoiNTIxMzIxMDc2NzExOTk4MTc0OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 85baf705b40864d2946116c7151fb7b11e39440b601d3a57b7b2a1befcccf9d3 |
| hovercard-subject-tag | issue:2713748658 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/robaho/httpserver/6/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c2b32e99c524e6dab74809ac49b6ca79f05f84092d656922f0f72402f9e8cb1d/robaho/httpserver/issues/6 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c2b32e99c524e6dab74809ac49b6ca79f05f84092d656922f0f72402f9e8cb1d/robaho/httpserver/issues/6 |
| og:image:alt | Hi, there are some classes that look to me like they could be final. Are you interested in getting PR's for adding the final modifier to some of these classes? As another style note, I see some met... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | rbygrave |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4922b452d03cd8dbce479d866a11bc25b59ef6ee2da23aa9b0ddefa6bd4d0064 |
| turbo-cache-control | no-preview |
| go-import | github.com/robaho/httpserver git https://github.com/robaho/httpserver.git |
| octolytics-dimension-user_id | 4958833 |
| octolytics-dimension-user_login | robaho |
| octolytics-dimension-repository_id | 705291690 |
| octolytics-dimension-repository_nwo | robaho/httpserver |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 705291690 |
| octolytics-dimension-repository_network_root_nwo | robaho/httpserver |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7e5ae23c70136152637ceee8d6faceb35596ec46 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width