| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d311b3c0-21bd-33c9-8b3f-14fa498c6379 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8438:178552:10A136E:1540177:699190AC |
| html-safe-nonce | b41df79abcd80bb49448e331ef780c13f69846dbd69fe5f5793ffa30c9655544 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDM4OjE3ODU1MjoxMEExMzZFOjE1NDAxNzc6Njk5MTkwQUMiLCJ2aXNpdG9yX2lkIjoiMjg2NTU2MzE0MDQwOTYyNjc5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 76729bc2693311ac3930403daa697082e9d893b560e0ba0ce4bb8480a72111c0 |
| hovercard-subject-tag | pull_request:2412179676 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/roach-php/core/267/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e04963f2a08e6498ce00014d5d8020ecea60b76b03ce09b4c9ed97ea451b228a/roach-php/core/pull/267 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e04963f2a08e6498ce00014d5d8020ecea60b76b03ce09b4c9ed97ea451b228a/roach-php/core/pull/267 |
| og:image:alt | This PR adds exception handling to the downloader and allows middleware to act upon caught exceptions.
Personally, I need this for handling Javascript (Browsershot) exceptions, so I can retry them.... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Fadarrizz |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/roach-php/core git https://github.com/roach-php/core.git |
| octolytics-dimension-user_id | 88873474 |
| octolytics-dimension-user_login | roach-php |
| octolytics-dimension-repository_id | 397134075 |
| octolytics-dimension-repository_nwo | roach-php/core |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 397134075 |
| octolytics-dimension-repository_network_root_nwo | roach-php/core |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/roach-php/core/pull/267#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Froach-php%2Fcore%2Fpull%2F267 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Froach-php%2Fcore%2Fpull%2F267 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=roach-php%2Fcore |
| Reload | https://patch-diff.githubusercontent.com/roach-php/core/pull/267 |
| Reload | https://patch-diff.githubusercontent.com/roach-php/core/pull/267 |
| Reload | https://patch-diff.githubusercontent.com/roach-php/core/pull/267 |
|
roach-php
| https://patch-diff.githubusercontent.com/roach-php |
| core | https://patch-diff.githubusercontent.com/roach-php/core |
| Please reload this page | https://patch-diff.githubusercontent.com/roach-php/core/pull/267 |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2Froach-php%2Fcore |
|
Fork
80
| https://patch-diff.githubusercontent.com/login?return_to=%2Froach-php%2Fcore |
|
Star
1.5k
| https://patch-diff.githubusercontent.com/login?return_to=%2Froach-php%2Fcore |
|
Code
| https://patch-diff.githubusercontent.com/roach-php/core |
|
Issues
19
| https://patch-diff.githubusercontent.com/roach-php/core/issues |
|
Pull requests
14
| https://patch-diff.githubusercontent.com/roach-php/core/pulls |
|
Discussions
| https://patch-diff.githubusercontent.com/roach-php/core/discussions |
|
Actions
| https://patch-diff.githubusercontent.com/roach-php/core/actions |
|
Security
0
| https://patch-diff.githubusercontent.com/roach-php/core/security |
|
Insights
| https://patch-diff.githubusercontent.com/roach-php/core/pulse |
|
Code
| https://patch-diff.githubusercontent.com/roach-php/core |
|
Issues
| https://patch-diff.githubusercontent.com/roach-php/core/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/roach-php/core/pulls |
|
Discussions
| https://patch-diff.githubusercontent.com/roach-php/core/discussions |
|
Actions
| https://patch-diff.githubusercontent.com/roach-php/core/actions |
|
Security
| https://patch-diff.githubusercontent.com/roach-php/core/security |
|
Insights
| https://patch-diff.githubusercontent.com/roach-php/core/pulse |
| Fadarrizz | https://patch-diff.githubusercontent.com/Fadarrizz |
| roach-php:main | https://patch-diff.githubusercontent.com/roach-php/core/tree/main |
| Fadarrizz:exception-handling | https://patch-diff.githubusercontent.com/Fadarrizz/roach-php-core/tree/exception-handling |
| Conversation | https://patch-diff.githubusercontent.com/roach-php/core/pull/267 |
| Commits9 (9) | https://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits |
| Checks | https://patch-diff.githubusercontent.com/roach-php/core/pull/267/checks |
| Files changed | https://patch-diff.githubusercontent.com/roach-php/core/pull/267/files |
| Feat: Exception handling | https://patch-diff.githubusercontent.com/roach-php/core/pull/267#top |
| Fadarrizz | https://patch-diff.githubusercontent.com/Fadarrizz |
| roach-php:main | https://patch-diff.githubusercontent.com/roach-php/core/tree/main |
| Fadarrizz:exception-handling | https://patch-diff.githubusercontent.com/Fadarrizz/roach-php-core/tree/exception-handling |
|
| https://patch-diff.githubusercontent.com/Fadarrizz |
| Fadarrizz | https://patch-diff.githubusercontent.com/Fadarrizz |
| Mar 23, 2025 | https://patch-diff.githubusercontent.com/roach-php/core/pull/267#issue-2941472989 |
| Please reload this page | https://patch-diff.githubusercontent.com/roach-php/core/pull/267 |
| Please reload this page | https://patch-diff.githubusercontent.com/roach-php/core/pull/267 |
| https://patch-diff.githubusercontent.com/Fadarrizz |
| Fadarrizz | https://patch-diff.githubusercontent.com/Fadarrizz |
| ksassnowski | https://patch-diff.githubusercontent.com/ksassnowski |
| code owner | https://patch-diff.githubusercontent.com/roach-php/core/blob/2bd659d99c9ddfeff27042e3baa725ba350ca882/.github/CODEOWNERS#L1 |
| March 23, 2025 20:24 | https://patch-diff.githubusercontent.com/roach-php/core/pull/267#event-16945656526 |
| https://patch-diff.githubusercontent.com/Fadarrizz |
| Fadarrizz | https://patch-diff.githubusercontent.com/Fadarrizz |
| April 15, 2025 20:17 | https://patch-diff.githubusercontent.com/roach-php/core/pull/267#event-17275990636 |
| https://patch-diff.githubusercontent.com/Fadarrizz |
| Fadarrizz | https://patch-diff.githubusercontent.com/Fadarrizz |
| force-pushed | https://patch-diff.githubusercontent.com/roach-php/core/compare/2e6187b20b621130dfdb4f4fcfcbad6306869d9c..4bd182975dad53683013ce6fe72a95560e740f65 |
| 2e6187b | https://patch-diff.githubusercontent.com/roach-php/core/commit/2e6187b20b621130dfdb4f4fcfcbad6306869d9c |
| 4bd1829 | https://patch-diff.githubusercontent.com/roach-php/core/commit/4bd182975dad53683013ce6fe72a95560e740f65 |
|
Compare
| https://patch-diff.githubusercontent.com/roach-php/core/compare/2e6187b20b621130dfdb4f4fcfcbad6306869d9c..4bd182975dad53683013ce6fe72a95560e740f65 |
| April 16, 2025 14:38 | https://patch-diff.githubusercontent.com/roach-php/core/pull/267#event-17290555312 |
| Fadarrizz | https://patch-diff.githubusercontent.com/Fadarrizz |
| April 16, 2025 16:41 | https://patch-diff.githubusercontent.com/roach-php/core/pull/267#commits-pushed-87d17d7 |
|
| https://patch-diff.githubusercontent.com/Fadarrizz |
| Add exception handling to downloader | https://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/87d17d7af4637bb6acbfe57fe0af0a0aa5c9c4c0 |
| 87d17d7 | https://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/87d17d7af4637bb6acbfe57fe0af0a0aa5c9c4c0 |
|
| https://patch-diff.githubusercontent.com/Fadarrizz |
| Log when exception received | https://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/6d8faeac676d869c68adbfcc07b99a6301771e72 |
| 6d8faea | https://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/6d8faeac676d869c68adbfcc07b99a6301771e72 |
|
| https://patch-diff.githubusercontent.com/Fadarrizz |
| Fix test | https://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/c5975b5b9a7370bb68f6deddb75e9e70d6ec37de |
| c5975b5 | https://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/c5975b5b9a7370bb68f6deddb75e9e70d6ec37de |
|
| https://patch-diff.githubusercontent.com/Fadarrizz |
| Set null default for onRejected callback | https://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/3b0e537bb639ed596e4e57d621ee5fde91a3e62a |
| 3b0e537 | https://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/3b0e537bb639ed596e4e57d621ee5fde91a3e62a |
| https://patch-diff.githubusercontent.com/Fadarrizz |
| Fadarrizz | https://patch-diff.githubusercontent.com/Fadarrizz |
| force-pushed | https://patch-diff.githubusercontent.com/roach-php/core/compare/4bd182975dad53683013ce6fe72a95560e740f65..3b0e537bb639ed596e4e57d621ee5fde91a3e62a |
| 4bd1829 | https://patch-diff.githubusercontent.com/roach-php/core/commit/4bd182975dad53683013ce6fe72a95560e740f65 |
| 3b0e537 | https://patch-diff.githubusercontent.com/roach-php/core/commit/3b0e537bb639ed596e4e57d621ee5fde91a3e62a |
|
Compare
| https://patch-diff.githubusercontent.com/roach-php/core/compare/4bd182975dad53683013ce6fe72a95560e740f65..3b0e537bb639ed596e4e57d621ee5fde91a3e62a |
| April 16, 2025 14:41 | https://patch-diff.githubusercontent.com/roach-php/core/pull/267#event-17290614993 |
| https://patch-diff.githubusercontent.com/Fadarrizz |
| Fadarrizz | https://patch-diff.githubusercontent.com/Fadarrizz |
| April 16, 2025 14:45 | https://patch-diff.githubusercontent.com/roach-php/core/pull/267#event-17290695042 |
| https://patch-diff.githubusercontent.com/Fadarrizz |
| Fadarrizz | https://patch-diff.githubusercontent.com/Fadarrizz |
| April 16, 2025 18:44 | https://patch-diff.githubusercontent.com/roach-php/core/pull/267#event-17294143007 |
| https://patch-diff.githubusercontent.com/Fadarrizz |
| Fadarrizz | https://patch-diff.githubusercontent.com/Fadarrizz |
| Apr 16, 2025 | https://patch-diff.githubusercontent.com/roach-php/core/pull/267#issuecomment-2810426276 |
| Please reload this page | https://patch-diff.githubusercontent.com/roach-php/core/pull/267 |
| Fadarrizz | https://patch-diff.githubusercontent.com/Fadarrizz |
| April 26, 2025 12:04 | https://patch-diff.githubusercontent.com/roach-php/core/pull/267#commits-pushed-304bddc |
|
| https://patch-diff.githubusercontent.com/Fadarrizz |
| Allow other exceptions besides guzzle exception in RequestException | https://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/304bddcf3ea3fcdd854695be6f4504154081ce4a |
| 304bddc | https://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/304bddcf3ea3fcdd854695be6f4504154081ce4a |
|
| https://patch-diff.githubusercontent.com/Fadarrizz |
| Track if RequestException is handled or not | https://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/2f5434d1b9e2a1529f53947480c52c3604bf6226 |
| 2f5434d | https://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/2f5434d1b9e2a1529f53947480c52c3604bf6226 |
|
| https://patch-diff.githubusercontent.com/Fadarrizz |
| Make exception handler method in Downloader expect RequestException | https://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/ce24d2d5ad42ad521defdd752457509b50399763 |
| ce24d2d | https://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/ce24d2d5ad42ad521defdd752457509b50399763 |
|
| https://patch-diff.githubusercontent.com/Fadarrizz |
| Throw exception when unhandled by any middleware | https://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/1494d053ad480b885889cdcaf29de15ee47677af |
| 1494d05 | https://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/1494d053ad480b885889cdcaf29de15ee47677af |
| https://patch-diff.githubusercontent.com/Fadarrizz |
| Fadarrizz | https://patch-diff.githubusercontent.com/Fadarrizz |
| April 26, 2025 10:43 | https://patch-diff.githubusercontent.com/roach-php/core/pull/267#event-17415701491 |
| https://patch-diff.githubusercontent.com/Fadarrizz |
| Fadarrizz | https://patch-diff.githubusercontent.com/Fadarrizz |
| Apr 26, 2025 | https://patch-diff.githubusercontent.com/roach-php/core/pull/267#issuecomment-2832030812 |
| @ksassnowski | https://github.com/ksassnowski |
| Please reload this page | https://patch-diff.githubusercontent.com/roach-php/core/pull/267 |
|
| https://patch-diff.githubusercontent.com/Fadarrizz |
| Update request exception in handler, so handled state doesn't have to… | https://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/0ababa0a8c574b5168fabd493a4f03efcff686be |
| 0ababa0 | https://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/0ababa0a8c574b5168fabd493a4f03efcff686be |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/roach-php/core/pull/{{ revealButtonHref }} |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in to comment | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Froach-php%2Fcore%2Fpull%2F267 |
|
| https://patch-diff.githubusercontent.com/ksassnowski |
|
ksassnowski
| https://patch-diff.githubusercontent.com/ksassnowski |
| Please reload this page | https://patch-diff.githubusercontent.com/roach-php/core/pull/267 |
|
| https://patch-diff.githubusercontent.com/Fadarrizz |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |