René's URL Explorer Experiment


Title: Feat: Exception handling by Fadarrizz · Pull Request #267 · roach-php/core · GitHub

Open Graph Title: Feat: Exception handling by Fadarrizz · Pull Request #267 · roach-php/core

X Title: Feat: Exception handling by Fadarrizz · Pull Request #267 · roach-php/core

Description: The complete web scraping toolkit for PHP. Contribute to roach-php/core development by creating an account on GitHub.

Open Graph Description: This PR adds exception handling to the downloader and allows middleware to act upon caught exceptions. Personally, I need this for handling Javascript (Browsershot) exceptions, so I can retry them....

X Description: This PR adds exception handling to the downloader and allows middleware to act upon caught exceptions. Personally, I need this for handling Javascript (Browsershot) exceptions, so I can retry them....

Opengraph URL: https://github.com/roach-php/core/pull/267

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d311b3c0-21bd-33c9-8b3f-14fa498c6379
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8438:178552:10A136E:1540177:699190AC
html-safe-nonceb41df79abcd80bb49448e331ef780c13f69846dbd69fe5f5793ffa30c9655544
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDM4OjE3ODU1MjoxMEExMzZFOjE1NDAxNzc6Njk5MTkwQUMiLCJ2aXNpdG9yX2lkIjoiMjg2NTU2MzE0MDQwOTYyNjc5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac76729bc2693311ac3930403daa697082e9d893b560e0ba0ce4bb8480a72111c0
hovercard-subject-tagpull_request:2412179676
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/roach-php/core/267/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e04963f2a08e6498ce00014d5d8020ecea60b76b03ce09b4c9ed97ea451b228a/roach-php/core/pull/267
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e04963f2a08e6498ce00014d5d8020ecea60b76b03ce09b4c9ed97ea451b228a/roach-php/core/pull/267
og:image:altThis PR adds exception handling to the downloader and allows middleware to act upon caught exceptions. Personally, I need this for handling Javascript (Browsershot) exceptions, so I can retry them....
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameFadarrizz
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/roach-php/core git https://github.com/roach-php/core.git
octolytics-dimension-user_id88873474
octolytics-dimension-user_loginroach-php
octolytics-dimension-repository_id397134075
octolytics-dimension-repository_nworoach-php/core
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id397134075
octolytics-dimension-repository_network_root_nworoach-php/core
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/roach-php/core/pull/267#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Froach-php%2Fcore%2Fpull%2F267
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Froach-php%2Fcore%2Fpull%2F267
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=roach-php%2Fcore
Reloadhttps://patch-diff.githubusercontent.com/roach-php/core/pull/267
Reloadhttps://patch-diff.githubusercontent.com/roach-php/core/pull/267
Reloadhttps://patch-diff.githubusercontent.com/roach-php/core/pull/267
roach-php https://patch-diff.githubusercontent.com/roach-php
corehttps://patch-diff.githubusercontent.com/roach-php/core
Please reload this pagehttps://patch-diff.githubusercontent.com/roach-php/core/pull/267
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Froach-php%2Fcore
Fork 80 https://patch-diff.githubusercontent.com/login?return_to=%2Froach-php%2Fcore
Star 1.5k https://patch-diff.githubusercontent.com/login?return_to=%2Froach-php%2Fcore
Code https://patch-diff.githubusercontent.com/roach-php/core
Issues 19 https://patch-diff.githubusercontent.com/roach-php/core/issues
Pull requests 14 https://patch-diff.githubusercontent.com/roach-php/core/pulls
Discussions https://patch-diff.githubusercontent.com/roach-php/core/discussions
Actions https://patch-diff.githubusercontent.com/roach-php/core/actions
Security 0 https://patch-diff.githubusercontent.com/roach-php/core/security
Insights https://patch-diff.githubusercontent.com/roach-php/core/pulse
Code https://patch-diff.githubusercontent.com/roach-php/core
Issues https://patch-diff.githubusercontent.com/roach-php/core/issues
Pull requests https://patch-diff.githubusercontent.com/roach-php/core/pulls
Discussions https://patch-diff.githubusercontent.com/roach-php/core/discussions
Actions https://patch-diff.githubusercontent.com/roach-php/core/actions
Security https://patch-diff.githubusercontent.com/roach-php/core/security
Insights https://patch-diff.githubusercontent.com/roach-php/core/pulse
Fadarrizzhttps://patch-diff.githubusercontent.com/Fadarrizz
roach-php:mainhttps://patch-diff.githubusercontent.com/roach-php/core/tree/main
Fadarrizz:exception-handlinghttps://patch-diff.githubusercontent.com/Fadarrizz/roach-php-core/tree/exception-handling
Conversationhttps://patch-diff.githubusercontent.com/roach-php/core/pull/267
Commits9 (9)https://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits
Checkshttps://patch-diff.githubusercontent.com/roach-php/core/pull/267/checks
Files changedhttps://patch-diff.githubusercontent.com/roach-php/core/pull/267/files
Feat: Exception handlinghttps://patch-diff.githubusercontent.com/roach-php/core/pull/267#top
Fadarrizzhttps://patch-diff.githubusercontent.com/Fadarrizz
roach-php:mainhttps://patch-diff.githubusercontent.com/roach-php/core/tree/main
Fadarrizz:exception-handlinghttps://patch-diff.githubusercontent.com/Fadarrizz/roach-php-core/tree/exception-handling
https://patch-diff.githubusercontent.com/Fadarrizz
Fadarrizzhttps://patch-diff.githubusercontent.com/Fadarrizz
Mar 23, 2025https://patch-diff.githubusercontent.com/roach-php/core/pull/267#issue-2941472989
Please reload this pagehttps://patch-diff.githubusercontent.com/roach-php/core/pull/267
Please reload this pagehttps://patch-diff.githubusercontent.com/roach-php/core/pull/267
https://patch-diff.githubusercontent.com/Fadarrizz
Fadarrizzhttps://patch-diff.githubusercontent.com/Fadarrizz
ksassnowskihttps://patch-diff.githubusercontent.com/ksassnowski
code ownerhttps://patch-diff.githubusercontent.com/roach-php/core/blob/2bd659d99c9ddfeff27042e3baa725ba350ca882/.github/CODEOWNERS#L1
March 23, 2025 20:24https://patch-diff.githubusercontent.com/roach-php/core/pull/267#event-16945656526
https://patch-diff.githubusercontent.com/Fadarrizz
Fadarrizzhttps://patch-diff.githubusercontent.com/Fadarrizz
April 15, 2025 20:17https://patch-diff.githubusercontent.com/roach-php/core/pull/267#event-17275990636
https://patch-diff.githubusercontent.com/Fadarrizz
Fadarrizzhttps://patch-diff.githubusercontent.com/Fadarrizz
force-pushedhttps://patch-diff.githubusercontent.com/roach-php/core/compare/2e6187b20b621130dfdb4f4fcfcbad6306869d9c..4bd182975dad53683013ce6fe72a95560e740f65
2e6187bhttps://patch-diff.githubusercontent.com/roach-php/core/commit/2e6187b20b621130dfdb4f4fcfcbad6306869d9c
4bd1829https://patch-diff.githubusercontent.com/roach-php/core/commit/4bd182975dad53683013ce6fe72a95560e740f65
Compare https://patch-diff.githubusercontent.com/roach-php/core/compare/2e6187b20b621130dfdb4f4fcfcbad6306869d9c..4bd182975dad53683013ce6fe72a95560e740f65
April 16, 2025 14:38https://patch-diff.githubusercontent.com/roach-php/core/pull/267#event-17290555312
Fadarrizzhttps://patch-diff.githubusercontent.com/Fadarrizz
April 16, 2025 16:41https://patch-diff.githubusercontent.com/roach-php/core/pull/267#commits-pushed-87d17d7
https://patch-diff.githubusercontent.com/Fadarrizz
Add exception handling to downloaderhttps://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/87d17d7af4637bb6acbfe57fe0af0a0aa5c9c4c0
87d17d7https://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/87d17d7af4637bb6acbfe57fe0af0a0aa5c9c4c0
https://patch-diff.githubusercontent.com/Fadarrizz
Log when exception receivedhttps://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/6d8faeac676d869c68adbfcc07b99a6301771e72
6d8faeahttps://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/6d8faeac676d869c68adbfcc07b99a6301771e72
https://patch-diff.githubusercontent.com/Fadarrizz
Fix testhttps://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/c5975b5b9a7370bb68f6deddb75e9e70d6ec37de
c5975b5https://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/c5975b5b9a7370bb68f6deddb75e9e70d6ec37de
https://patch-diff.githubusercontent.com/Fadarrizz
Set null default for onRejected callbackhttps://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/3b0e537bb639ed596e4e57d621ee5fde91a3e62a
3b0e537https://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/3b0e537bb639ed596e4e57d621ee5fde91a3e62a
https://patch-diff.githubusercontent.com/Fadarrizz
Fadarrizzhttps://patch-diff.githubusercontent.com/Fadarrizz
force-pushedhttps://patch-diff.githubusercontent.com/roach-php/core/compare/4bd182975dad53683013ce6fe72a95560e740f65..3b0e537bb639ed596e4e57d621ee5fde91a3e62a
4bd1829https://patch-diff.githubusercontent.com/roach-php/core/commit/4bd182975dad53683013ce6fe72a95560e740f65
3b0e537https://patch-diff.githubusercontent.com/roach-php/core/commit/3b0e537bb639ed596e4e57d621ee5fde91a3e62a
Compare https://patch-diff.githubusercontent.com/roach-php/core/compare/4bd182975dad53683013ce6fe72a95560e740f65..3b0e537bb639ed596e4e57d621ee5fde91a3e62a
April 16, 2025 14:41https://patch-diff.githubusercontent.com/roach-php/core/pull/267#event-17290614993
https://patch-diff.githubusercontent.com/Fadarrizz
Fadarrizzhttps://patch-diff.githubusercontent.com/Fadarrizz
April 16, 2025 14:45https://patch-diff.githubusercontent.com/roach-php/core/pull/267#event-17290695042
https://patch-diff.githubusercontent.com/Fadarrizz
Fadarrizzhttps://patch-diff.githubusercontent.com/Fadarrizz
April 16, 2025 18:44https://patch-diff.githubusercontent.com/roach-php/core/pull/267#event-17294143007
https://patch-diff.githubusercontent.com/Fadarrizz
Fadarrizzhttps://patch-diff.githubusercontent.com/Fadarrizz
Apr 16, 2025https://patch-diff.githubusercontent.com/roach-php/core/pull/267#issuecomment-2810426276
Please reload this pagehttps://patch-diff.githubusercontent.com/roach-php/core/pull/267
Fadarrizzhttps://patch-diff.githubusercontent.com/Fadarrizz
April 26, 2025 12:04https://patch-diff.githubusercontent.com/roach-php/core/pull/267#commits-pushed-304bddc
https://patch-diff.githubusercontent.com/Fadarrizz
Allow other exceptions besides guzzle exception in RequestExceptionhttps://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/304bddcf3ea3fcdd854695be6f4504154081ce4a
304bddchttps://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/304bddcf3ea3fcdd854695be6f4504154081ce4a
https://patch-diff.githubusercontent.com/Fadarrizz
Track if RequestException is handled or nothttps://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/2f5434d1b9e2a1529f53947480c52c3604bf6226
2f5434dhttps://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/2f5434d1b9e2a1529f53947480c52c3604bf6226
https://patch-diff.githubusercontent.com/Fadarrizz
Make exception handler method in Downloader expect RequestExceptionhttps://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/ce24d2d5ad42ad521defdd752457509b50399763
ce24d2dhttps://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/ce24d2d5ad42ad521defdd752457509b50399763
https://patch-diff.githubusercontent.com/Fadarrizz
Throw exception when unhandled by any middlewarehttps://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/1494d053ad480b885889cdcaf29de15ee47677af
1494d05https://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/1494d053ad480b885889cdcaf29de15ee47677af
https://patch-diff.githubusercontent.com/Fadarrizz
Fadarrizzhttps://patch-diff.githubusercontent.com/Fadarrizz
April 26, 2025 10:43https://patch-diff.githubusercontent.com/roach-php/core/pull/267#event-17415701491
https://patch-diff.githubusercontent.com/Fadarrizz
Fadarrizzhttps://patch-diff.githubusercontent.com/Fadarrizz
Apr 26, 2025https://patch-diff.githubusercontent.com/roach-php/core/pull/267#issuecomment-2832030812
@ksassnowskihttps://github.com/ksassnowski
Please reload this pagehttps://patch-diff.githubusercontent.com/roach-php/core/pull/267
https://patch-diff.githubusercontent.com/Fadarrizz
Update request exception in handler, so handled state doesn't have to…https://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/0ababa0a8c574b5168fabd493a4f03efcff686be
0ababa0https://patch-diff.githubusercontent.com/roach-php/core/pull/267/commits/0ababa0a8c574b5168fabd493a4f03efcff686be
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/roach-php/core/pull/{{ revealButtonHref }}
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Froach-php%2Fcore%2Fpull%2F267
https://patch-diff.githubusercontent.com/ksassnowski
ksassnowski https://patch-diff.githubusercontent.com/ksassnowski
Please reload this pagehttps://patch-diff.githubusercontent.com/roach-php/core/pull/267
https://patch-diff.githubusercontent.com/Fadarrizz
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.