Title: semantic_version.match emits a PendingDeprecationWarning · Issue #147 · rbarrois/python-semanticversion · GitHub
Open Graph Title: semantic_version.match emits a PendingDeprecationWarning · Issue #147 · rbarrois/python-semanticversion
X Title: semantic_version.match emits a PendingDeprecationWarning · Issue #147 · rbarrois/python-semanticversion
Description: Summary Calling the top-level match method emits a PendingDeprecationWarning regardless of the provided inputs Environment and Version Python version: 3.11.3 (conda-forge) semantic_version version: '2.10.0' Operating system: Linux x64 St...
Open Graph Description: Summary Calling the top-level match method emits a PendingDeprecationWarning regardless of the provided inputs Environment and Version Python version: 3.11.3 (conda-forge) semantic_version version:...
X Description: Summary Calling the top-level match method emits a PendingDeprecationWarning regardless of the provided inputs Environment and Version Python version: 3.11.3 (conda-forge) semantic_version version:...
Opengraph URL: https://github.com/rbarrois/python-semanticversion/issues/147
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"semantic_version.match emits a PendingDeprecationWarning","articleBody":"## Summary\r\nCalling the top-level `match` method emits a `PendingDeprecationWarning` regardless of the provided inputs\r\n\r\n## Environment and Version\r\n- Python version: 3.11.3 (conda-forge)\r\n- `semantic_version` version: '2.10.0'\r\n- Operating system: Linux x64\r\n\r\n## Steps to Reproduce\r\n\r\n```python\r\n\u003e\u003e\u003e import warnings\r\n\u003e\u003e\u003e import semantic_version as semver\r\n\u003e\u003e\u003e warnings.simplefilter(\"always\")\r\n\u003e\u003e\u003e semver.match(\"\u003e1.19.2\", \"1.19.3\")\r\n```\r\n\r\nproduces:\r\n\r\n```\r\n/path/to/my/virtualenv/lib/python3.11/site-packages/semantic_version/base.py:600: PendingDeprecationWarning: The Spec() class will be removed in 3.1; use SimpleSpec() instead.\r\n return Spec(spec).match(Version(version))\r\nTrue\r\n```\r\n## Workaround\r\n\r\nBeing hyper-explicit in my call:\r\n\r\n```\r\n\u003e\u003e\u003e semver.SimpleSpec(\"\u003e1.19.2\").match(semver.Version(\"1.19.3\"))\r\n```\r\n\r\nwill produce the desired result with no warning\r\n\r\n## Severity\r\nAnnoyance. I'm using this as a dependency in a personal project, and the deprecation shows up all over my test logs. Given that the API seems to be somewhat in flux, I'd prefer to rely on the simple string-matching method, unless that too is deprecated.\r\n\r\n## Desired Outcome\r\nLooking at the current implementation:\r\n\r\nhttps://github.com/rbarrois/python-semanticversion/blob/2cbbee3154d9011cee873ae3a020cd17c669f6df/semantic_version/base.py#L606-L607\r\n\r\nIt seems like it would be a simple matter of changing:\r\n\r\n```diff\r\ndef match(spec, version): \r\n- return Spec(spec).match(Version(version))\r\n+ return SimpleSpec(spec).match(Version(version)) \r\n```\r\n\r\nbut if the intent is to wean users off of the direct `match` method, then the current behavior makes sense.","author":{"url":"https://github.com/OpenBagTwo","@type":"Person","name":"OpenBagTwo"},"datePublished":"2023-05-17T17:22:21.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/147/python-semanticversion/issues/147"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:0b042723-f496-877e-d0d5-edc738bf616c |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9CF2:16ACDA:E0C1AF:11E69E1:699185E2 |
| html-safe-nonce | 86185adfb4e7b34c7fc75f7caa9a21d1eb40f9d54c735764d29b949550666e10 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Q0YyOjE2QUNEQTpFMEMxQUY6MTFFNjlFMTo2OTkxODVFMiIsInZpc2l0b3JfaWQiOiI5MTk5ODQ1NjIwODIyNjcyODY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | e3dc30d2879c065b5e46c5f5719c84fb775ef284907657be9c9c7733dbccfb12 |
| hovercard-subject-tag | issue:1714333901 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/rbarrois/python-semanticversion/147/issue_layout |
| twitter:image | https://opengraph.githubassets.com/bc44ec8c94fe0a64a08ad3b8ac6fbcaa278f9086cb460e6988f1854838b1d272/rbarrois/python-semanticversion/issues/147 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bc44ec8c94fe0a64a08ad3b8ac6fbcaa278f9086cb460e6988f1854838b1d272/rbarrois/python-semanticversion/issues/147 |
| og:image:alt | Summary Calling the top-level match method emits a PendingDeprecationWarning regardless of the provided inputs Environment and Version Python version: 3.11.3 (conda-forge) semantic_version version:... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | OpenBagTwo |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-preview |
| go-import | github.com/rbarrois/python-semanticversion git https://github.com/rbarrois/python-semanticversion.git |
| octolytics-dimension-user_id | 694541 |
| octolytics-dimension-user_login | rbarrois |
| octolytics-dimension-repository_id | 4326308 |
| octolytics-dimension-repository_nwo | rbarrois/python-semanticversion |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 4326308 |
| octolytics-dimension-repository_network_root_nwo | rbarrois/python-semanticversion |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width