Title: 2574 StackOverflow Exception On Super Method Call Fix by rmadsen-ks · Pull Request #2628 · pythonnet/pythonnet · GitHub
Open Graph Title: 2574 StackOverflow Exception On Super Method Call Fix by rmadsen-ks · Pull Request #2628 · pythonnet/pythonnet
X Title: 2574 StackOverflow Exception On Super Method Call Fix by rmadsen-ks · Pull Request #2628 · pythonnet/pythonnet
Description: Update: Does not actually fix #2574, but a similar problem(#2629). I'll provide a fix for 2574 as well. Update 2: Now this also fixes #2574 This fixed an issue with a StackOverflow exception being generated when a virtual method is being called, but a class in the middle of the inheritance tree does not override the method. This happens because the CallVirtual method calls the method on the python object if the wrapper got generated, causing everything to be evaluated again from the top. Doing it this way, causes the the python method only to get invoked if there is an implementation on the class, which can then correctly call super().Method(). For the finalizer fix, we now skip generating the call to PyFinalize if the base class is already a python class, because if that is the case the finalize method has already been added. Additionally it simplifies how the generated code for virtual methods look. Now, a virtual wrapper method is not automatically generated. Only if the method is actually being overwritten by the class it will prompt the generation of a virtual method wrapper. Does this close any currently open issues? This closes #2574, #2627, #2629 Any other comments? ... Checklist Check all those that are applicable and complete. Make sure to include one or more tests for your change If an enhancement PR, please create docs and at best an example Ensure you have signed the .NET Foundation CLA Add yourself to AUTHORS Updated the CHANGELOG
Open Graph Description: Update: Does not actually fix #2574, but a similar problem(#2629). I'll provide a fix for 2574 as well. Update 2: Now this also fixes #2574 This fixed an issue with a StackOverflow exception be...
X Description: Update: Does not actually fix #2574, but a similar problem(#2629). I'll provide a fix for 2574 as well. Update 2: Now this also fixes #2574 This fixed an issue with a StackOverflow exceptio...
Opengraph URL: https://github.com/pythonnet/pythonnet/pull/2628
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:10463573-43b0-dbd6-4a02-d40e74355165 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C326:3DD772:73DBDB:99570F:6973F87C |
| html-safe-nonce | 7117f399860ec12bf69a3a3a3142980aacbdf3042f73f543ab6d4db6f58e3455 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzI2OjNERDc3Mjo3M0RCREI6OTk1NzBGOjY5NzNGODdDIiwidmlzaXRvcl9pZCI6IjY5Njk3OTYxMDg2NzU5NTM4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1c7daffa9835d42b1b6bccf661d79a56afcb96b0b5a380b1277a5ac9c0f6613a |
| hovercard-subject-tag | pull_request:2899831472 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/2628/files |
| twitter:image | https://avatars.githubusercontent.com/u/24250062?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/24250062?s=400&v=4 |
| og:image:alt | Update: Does not actually fix #2574, but a similar problem(#2629). I'll provide a fix for 2574 as well. Update 2: Now this also fixes #2574 This fixed an issue with a StackOverflow exception be... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | edd166dbd7a8c69304dd0f786a2ceae171d7a532d7f82516d7b971b6a831123e |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git |
| octolytics-dimension-user_id | 6050430 |
| octolytics-dimension-user_login | pythonnet |
| octolytics-dimension-repository_id | 14748123 |
| octolytics-dimension-repository_nwo | pythonnet/pythonnet |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 14748123 |
| octolytics-dimension-repository_network_root_nwo | pythonnet/pythonnet |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7f2d62d773fd1f2c679e2ea93329a72fda65310a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width