René's URL Explorer Experiment


Title: 2574 StackOverflow Exception On Super Method Call Fix by rmadsen-ks · Pull Request #2628 · pythonnet/pythonnet · GitHub

Open Graph Title: 2574 StackOverflow Exception On Super Method Call Fix by rmadsen-ks · Pull Request #2628 · pythonnet/pythonnet

X Title: 2574 StackOverflow Exception On Super Method Call Fix by rmadsen-ks · Pull Request #2628 · pythonnet/pythonnet

Description: Update: Does not actually fix #2574, but a similar problem(#2629). I'll provide a fix for 2574 as well. Update 2: Now this also fixes #2574 This fixed an issue with a StackOverflow exception being generated when a virtual method is being called, but a class in the middle of the inheritance tree does not override the method. This happens because the CallVirtual method calls the method on the python object if the wrapper got generated, causing everything to be evaluated again from the top. Doing it this way, causes the the python method only to get invoked if there is an implementation on the class, which can then correctly call super().Method(). For the finalizer fix, we now skip generating the call to PyFinalize if the base class is already a python class, because if that is the case the finalize method has already been added. Additionally it simplifies how the generated code for virtual methods look. Now, a virtual wrapper method is not automatically generated. Only if the method is actually being overwritten by the class it will prompt the generation of a virtual method wrapper. Does this close any currently open issues? This closes #2574, #2627, #2629 Any other comments? ... Checklist Check all those that are applicable and complete. Make sure to include one or more tests for your change If an enhancement PR, please create docs and at best an example Ensure you have signed the .NET Foundation CLA Add yourself to AUTHORS Updated the CHANGELOG

Open Graph Description: Update: Does not actually fix #2574, but a similar problem(#2629). I'll provide a fix for 2574 as well. Update 2: Now this also fixes #2574 This fixed an issue with a StackOverflow exception be...

X Description: Update: Does not actually fix #2574, but a similar problem(#2629). I'll provide a fix for 2574 as well. Update 2: Now this also fixes #2574 This fixed an issue with a StackOverflow exceptio...

Opengraph URL: https://github.com/pythonnet/pythonnet/pull/2628

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/:user_id/:repository/pull/:id/checks(.:format)
route-controllerpull_requests
route-actionchecks
fetch-noncev2:aa2fc9f2-6643-1022-7ee3-29285db93a44
current-catalog-service-hash87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a
request-idE0DC:22A3B:41C3833:5BE318D:69713E2D
html-safe-noncef66c27504a3e69f311c799a1521feacf7fa38460a171a76a65db7917f1d76395
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMERDOjIyQTNCOjQxQzM4MzM6NUJFMzE4RDo2OTcxM0UyRCIsInZpc2l0b3JfaWQiOiIzNDUwOTM4NzIzMTQwMzk4NTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacbe33f244bea6b986a93c6f6abf60ccbad4a5751b4f983d57f3805daa268a4f12
hovercard-subject-tagpull_request:2899831472
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/checks
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/pythonnet/pythonnet/pull/2628/checks
twitter:imagehttps://avatars.githubusercontent.com/u/24250062?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/24250062?s=400&v=4
og:image:altUpdate: Does not actually fix #2574, but a similar problem(#2629). I'll provide a fix for 2574 as well. Update 2: Now this also fixes #2574 This fixed an issue with a StackOverflow exception be...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7899979feb505886f0f29e8086a739254f3a850fd3dbc9fb63ce4ec27831b1fb
turbo-cache-controlno-cache
go-importgithub.com/pythonnet/pythonnet git https://github.com/pythonnet/pythonnet.git
octolytics-dimension-user_id6050430
octolytics-dimension-user_loginpythonnet
octolytics-dimension-repository_id14748123
octolytics-dimension-repository_nwopythonnet/pythonnet
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id14748123
octolytics-dimension-repository_network_root_nwopythonnet/pythonnet
turbo-body-classeslogged-out env-production page-responsive full-width full-width-p-0
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release998d3ef09faa982f8d83ad111166244ae4625572
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/pythonnet/pythonnet/pull/2628/checks#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F2628%2Fchecks
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F2628%2Fchecks
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fchecks&source=header-repo&source_repo=pythonnet%2Fpythonnet
Reloadhttps://patch-diff.githubusercontent.com/pythonnet/pythonnet/pull/2628/checks
Reloadhttps://patch-diff.githubusercontent.com/pythonnet/pythonnet/pull/2628/checks
Reloadhttps://patch-diff.githubusercontent.com/pythonnet/pythonnet/pull/2628/checks
pythonnet https://patch-diff.githubusercontent.com/pythonnet
pythonnethttps://patch-diff.githubusercontent.com/pythonnet/pythonnet
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fpythonnet%2Fpythonnet
Fork 770 https://patch-diff.githubusercontent.com/login?return_to=%2Fpythonnet%2Fpythonnet
Star 5.4k https://patch-diff.githubusercontent.com/login?return_to=%2Fpythonnet%2Fpythonnet
Code https://patch-diff.githubusercontent.com/pythonnet/pythonnet
Issues 155 https://patch-diff.githubusercontent.com/pythonnet/pythonnet/issues
Pull requests 18 https://patch-diff.githubusercontent.com/pythonnet/pythonnet/pulls
Discussions https://patch-diff.githubusercontent.com/pythonnet/pythonnet/discussions
Actions https://patch-diff.githubusercontent.com/pythonnet/pythonnet/actions
Projects 0 https://patch-diff.githubusercontent.com/pythonnet/pythonnet/projects
Wiki https://patch-diff.githubusercontent.com/pythonnet/pythonnet/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/pythonnet/pythonnet/security
Please reload this pagehttps://patch-diff.githubusercontent.com/pythonnet/pythonnet/pull/2628/checks
Insights https://patch-diff.githubusercontent.com/pythonnet/pythonnet/pulse
Code https://patch-diff.githubusercontent.com/pythonnet/pythonnet
Issues https://patch-diff.githubusercontent.com/pythonnet/pythonnet/issues
Pull requests https://patch-diff.githubusercontent.com/pythonnet/pythonnet/pulls
Discussions https://patch-diff.githubusercontent.com/pythonnet/pythonnet/discussions
Actions https://patch-diff.githubusercontent.com/pythonnet/pythonnet/actions
Projects https://patch-diff.githubusercontent.com/pythonnet/pythonnet/projects
Wiki https://patch-diff.githubusercontent.com/pythonnet/pythonnet/wiki
Security https://patch-diff.githubusercontent.com/pythonnet/pythonnet/security
Insights https://patch-diff.githubusercontent.com/pythonnet/pythonnet/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fpythonnet%2Fpythonnet%2Fissues%2Fnew%2Fchoose
rmadsen-kshttps://patch-diff.githubusercontent.com/rmadsen-ks
pythonnet:masterhttps://patch-diff.githubusercontent.com/pythonnet/pythonnet/tree/master
rmadsen-ks:2574-StackOverFlowExceptionOnSuperMethodCallFixhttps://patch-diff.githubusercontent.com/rmadsen-ks/pythonnet/tree/2574-StackOverFlowExceptionOnSuperMethodCallFix
Conversation 2 https://patch-diff.githubusercontent.com/pythonnet/pythonnet/pull/2628
Commits 3 https://patch-diff.githubusercontent.com/pythonnet/pythonnet/pull/2628/commits
Checks 18 https://patch-diff.githubusercontent.com/pythonnet/pythonnet/pull/2628/checks
Files changed https://patch-diff.githubusercontent.com/pythonnet/pythonnet/pull/2628/files
Please reload this pagehttps://patch-diff.githubusercontent.com/pythonnet/pythonnet/pull/2628/checks
Please reload this pagehttps://patch-diff.githubusercontent.com/pythonnet/pythonnet/pull/2628/checks
Sign in for the full log viewhttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpythonnet%2Fpythonnet%2Fpull%2F2628%2Fchecks
2574 StackOverflow Exception On Super Method Call Fix https://patch-diff.githubusercontent.com/pythonnet/pythonnet/pull/2628/checks#top
Please reload this pagehttps://patch-diff.githubusercontent.com/pythonnet/pythonnet/pull/2628/checks
Documentation on: pull_request https://patch-diff.githubusercontent.com/pythonnet/pythonnet/actions/runs/20024919080
build https://patch-diff.githubusercontent.com/pythonnet/pythonnet/actions/runs/20024919080/job/57419986253?pr=2628
deploy https://patch-diff.githubusercontent.com/pythonnet/pythonnet/actions/runs/20024919080/job/57420148159?pr=2628
Main on: pull_request https://patch-diff.githubusercontent.com/pythonnet/pythonnet/actions/runs/20024919085
Build and Test (windows, x64, windows-latest, 3.10) https://patch-diff.githubusercontent.com/pythonnet/pythonnet/actions/runs/20024919085/job/57419986432?pr=2628
Build and Test (windows, x64, windows-latest, 3.11) https://patch-diff.githubusercontent.com/pythonnet/pythonnet/actions/runs/20024919085/job/57419986408?pr=2628
Build and Test (windows, x64, windows-latest, 3.12) https://patch-diff.githubusercontent.com/pythonnet/pythonnet/actions/runs/20024919085/job/57419986417?pr=2628
Build and Test (windows, x64, windows-latest, 3.13) https://patch-diff.githubusercontent.com/pythonnet/pythonnet/actions/runs/20024919085/job/57419986427?pr=2628
Build and Test (ubuntu, x64, ubuntu-22.04, 3.10) https://patch-diff.githubusercontent.com/pythonnet/pythonnet/actions/runs/20024919085/job/57419986414?pr=2628
Build and Test (ubuntu, x64, ubuntu-22.04, 3.11) https://patch-diff.githubusercontent.com/pythonnet/pythonnet/actions/runs/20024919085/job/57419986433?pr=2628
Build and Test (ubuntu, x64, ubuntu-22.04, 3.12) https://patch-diff.githubusercontent.com/pythonnet/pythonnet/actions/runs/20024919085/job/57419986436?pr=2628
Build and Test (ubuntu, x64, ubuntu-22.04, 3.13) https://patch-diff.githubusercontent.com/pythonnet/pythonnet/actions/runs/20024919085/job/57419986457?pr=2628
Build and Test (ubuntu, arm64, ubuntu-22.04-arm, 3.10) https://patch-diff.githubusercontent.com/pythonnet/pythonnet/actions/runs/20024919085/job/57419986450?pr=2628
Build and Test (ubuntu, arm64, ubuntu-22.04-arm, 3.11) https://patch-diff.githubusercontent.com/pythonnet/pythonnet/actions/runs/20024919085/job/57419986434?pr=2628
Build and Test (ubuntu, arm64, ubuntu-22.04-arm, 3.12) https://patch-diff.githubusercontent.com/pythonnet/pythonnet/actions/runs/20024919085/job/57419986447?pr=2628
Build and Test (ubuntu, arm64, ubuntu-22.04-arm, 3.13) https://patch-diff.githubusercontent.com/pythonnet/pythonnet/actions/runs/20024919085/job/57419986459?pr=2628
Build and Test (macos, x64, macos-13, 3.10) https://patch-diff.githubusercontent.com/pythonnet/pythonnet/actions/runs/20024919085/job/57419986443?pr=2628
Build and Test (macos, x64, macos-13, 3.11) https://patch-diff.githubusercontent.com/pythonnet/pythonnet/actions/runs/20024919085/job/57419986454?pr=2628
Build and Test (macos, x64, macos-13, 3.12) https://patch-diff.githubusercontent.com/pythonnet/pythonnet/actions/runs/20024919085/job/57419986514?pr=2628
Build and Test (macos, x64, macos-13, 3.13) https://patch-diff.githubusercontent.com/pythonnet/pythonnet/actions/runs/20024919085/job/57419986466?pr=2628
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.