Title: Multitoken substitution · Issue #74 · python-trio/unasync · GitHub
Open Graph Title: Multitoken substitution · Issue #74 · python-trio/unasync
X Title: Multitoken substitution · Issue #74 · python-trio/unasync
Description: Hey 👋 I recently came across unasync and wanted to commend you on this incredibly promising & useful project. In that vein, I wanted to note that certain substitutions (notably additional_replacements={"@pytest.mark.trio": ""}) effective...
Open Graph Description: Hey 👋 I recently came across unasync and wanted to commend you on this incredibly promising & useful project. In that vein, I wanted to note that certain substitutions (notably additional_replaceme...
X Description: Hey 👋 I recently came across unasync and wanted to commend you on this incredibly promising & useful project. In that vein, I wanted to note that certain substitutions (notably additional_repla...
Opengraph URL: https://github.com/python-trio/unasync/issues/74
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Multitoken substitution","articleBody":"Hey 👋\r\n\r\nI recently came across `unasync` and wanted to commend you on this incredibly promising \u0026 useful project.\r\n\r\nIn that vein, I wanted to note that certain substitutions (notably `additional_replacements={\"@pytest.mark.trio\": \"\"}`) effectively results in a no-op as a result of the tokenization converting `@pytest.mark.trio` to the tokens `@pytest`, `mark` and `trio`.\r\nAlthough token-based execution is theoretically superior, it adds a layer of complexity that [httpcore's `unasync.py` doesn't face](https://github.com/encode/httpcore/blob/0.11.1/unasync.py#L23).\r\n\r\nMy recommendation would be to also tokenize the `additional_replacements` and attempt to match the token streams.\r\nHappy to implement it once we're aligned on a solution.","author":{"url":"https://github.com/david-alm","@type":"Person","name":"david-alm"},"datePublished":"2021-05-07T12:56:44.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":4},"url":"https://github.com/74/unasync/issues/74"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:3fa3a7a7-e885-70c0-d96a-5c7f2aee56f2 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A128:A2D01:78A500:A260BF:696F29D3 |
| html-safe-nonce | e3e051b404f42fb78aac6e5a80f053943edeea63f9f1a8b73b69efe27f8bdb3a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTI4OkEyRDAxOjc4QTUwMDpBMjYwQkY6Njk2RjI5RDMiLCJ2aXNpdG9yX2lkIjoiMjU0NzU5MDY5NTU1MTQ0NTQ1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 223424e0a704a00bae275be0398ba0027ffbd8d8233ebc5d9480f77c00ebda8b |
| hovercard-subject-tag | issue:878956196 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-trio/unasync/74/issue_layout |
| twitter:image | https://opengraph.githubassets.com/cf9e902bcddb49522e779e97abde76265f29a96d234f3c2e9dc816868a36c5a3/python-trio/unasync/issues/74 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/cf9e902bcddb49522e779e97abde76265f29a96d234f3c2e9dc816868a36c5a3/python-trio/unasync/issues/74 |
| og:image:alt | Hey 👋 I recently came across unasync and wanted to commend you on this incredibly promising & useful project. In that vein, I wanted to note that certain substitutions (notably additional_replaceme... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | david-alm |
| hostname | github.com |
| expected-hostname | github.com |
| None | b278ad162d35332b6de714dfb005de04386c4d92df6475522bef910f491a35ee |
| turbo-cache-control | no-preview |
| go-import | github.com/python-trio/unasync git https://github.com/python-trio/unasync.git |
| octolytics-dimension-user_id | 26335827 |
| octolytics-dimension-user_login | python-trio |
| octolytics-dimension-repository_id | 154537846 |
| octolytics-dimension-repository_nwo | python-trio/unasync |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 154537846 |
| octolytics-dimension-repository_network_root_nwo | python-trio/unasync |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 39aed5006635ab6f45e6b77d23e73b08a00272a3 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width