René's URL Explorer Experiment


Title: Add some basic typechecking support by davidshepherd7 · Pull Request #162 · python-smpplib/python-smpplib · GitHub

Open Graph Title: Add some basic typechecking support by davidshepherd7 · Pull Request #162 · python-smpplib/python-smpplib

X Title: Add some basic typechecking support by davidshepherd7 · Pull Request #162 · python-smpplib/python-smpplib

Description: Hi! Are you interested in having type checking for this project? I've been using some type definitions for my own work using the library and figured it would be nice to merge them upstream. So I started out doing that but got a bit carried away and added types for almost everything except the Command objects. I've mostly tried to avoid modifying any code in order to add typechecking. The major exception is that I removed python 2 support because it makes specifying types much easier. I hope that's ok! Other interesting changes: I added a few assertions on the type of things where we would crash anyway, these keep the type checker happy. I was a bit nervous about the (minor) PDU parsing/generating code changes, so I wrote some more unit tests for it. I needed to re-implement #132 to get the tests working. If there are specific changes that you don't want I'm happy to send separate smaller PRs. I did it all as one here because some of the changes rely on each other. If you're happy with this then I can also try to work out a way to add types for the command objects, I think it will be possible with a bit of manual work (and/or keyboard macros).

Open Graph Description: Hi! Are you interested in having type checking for this project? I've been using some type definitions for my own work using the library and figured it would be nice to merge them upstream. So ...

X Description: Hi! Are you interested in having type checking for this project? I've been using some type definitions for my own work using the library and figured it would be nice to merge them upstream....

Opengraph URL: https://github.com/python-smpplib/python-smpplib/pull/162

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:58cc203f-363d-80a3-5781-51a8b099e283
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9A2C:39849D:2F78FE8:40B6373:69737B9A
html-safe-nonce47593c216fd60f14e22b34afd2aaa5b358c71a4e256a3914f64334afd7be7b27
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTJDOjM5ODQ5RDoyRjc4RkU4OjQwQjYzNzM6Njk3MzdCOUEiLCJ2aXNpdG9yX2lkIjoiNDYyNzkxNDA3NzM4MzEzMDAxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb1841a52be8dea17e85e3319acf5ba9eb16d2bf832432fd1c1f207176fe377ae
hovercard-subject-tagpull_request:721948877
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-smpplib/python-smpplib/pull/162/files
twitter:imagehttps://avatars.githubusercontent.com/u/795860?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/795860?s=400&v=4
og:image:altHi! Are you interested in having type checking for this project? I've been using some type definitions for my own work using the library and figured it would be nice to merge them upstream. So ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4cf879a11b0a28a85543899a36aaee9ec9ca2fb7bedad86c0da5731193c95f01
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-smpplib/python-smpplib git https://github.com/python-smpplib/python-smpplib.git
octolytics-dimension-user_id45378833
octolytics-dimension-user_loginpython-smpplib
octolytics-dimension-repository_id9441405
octolytics-dimension-repository_nwopython-smpplib/python-smpplib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id9441405
octolytics-dimension-repository_network_root_nwopython-smpplib/python-smpplib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasefe8be790582ef7a55477ce1918ac0ed16b106d31
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-smpplib%2Fpython-smpplib%2Fpull%2F162%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-smpplib%2Fpython-smpplib%2Fpull%2F162%2Ffiles
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-smpplib%2Fpython-smpplib
Reloadhttps://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files
Reloadhttps://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files
Reloadhttps://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files
python-smpplib https://patch-diff.githubusercontent.com/python-smpplib
python-smpplibhttps://patch-diff.githubusercontent.com/python-smpplib/python-smpplib
Please reload this pagehttps://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-smpplib%2Fpython-smpplib
Fork 143 https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-smpplib%2Fpython-smpplib
Star 187 https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-smpplib%2Fpython-smpplib
Code https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib
Issues 20 https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/issues
Pull requests 15 https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pulls
Discussions https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/discussions
Actions https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/actions
Security 0 https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/security
Insights https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pulse
Code https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib
Issues https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/issues
Pull requests https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pulls
Discussions https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/discussions
Actions https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/actions
Security https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/security
Insights https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fpython-smpplib%2Fpython-smpplib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fpython-smpplib%2Fpython-smpplib%2Fissues%2Fnew%2Fchoose
davidshepherd7https://patch-diff.githubusercontent.com/davidshepherd7
python-smpplib:masterhttps://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/tree/master
davidshepherd7:basic-typechecking-supporthttps://patch-diff.githubusercontent.com/davidshepherd7/python-smpplib/tree/basic-typechecking-support
Conversation 4 https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162
Commits 11 https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/commits
Checks 0 https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/checks
Files changed https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files
Please reload this pagehttps://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files
Add some basic typechecking support https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files#top
Show all changes 11 commits https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files
c98e821 Remove end-of-life'd python versions from circleCI davidshepherd7 Aug 29, 2021 https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/commits/c98e82197e41e2e354a59ccfb3dddbfd3a0ce4a7
bcee943 Fix invalid emacs coding value davidshepherd7 Aug 29, 2021 https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/commits/bcee943933404cfd6b464ead7824d8c930f0175b
12e6bae Remove six dependency davidshepherd7 Aug 29, 2021 https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/commits/12e6baefa16def9b5247266b567dcc47c72898ca
3f4ca13 Fix a test depending on the configured warning filter davidshepherd7 Aug 29, 2021 https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/commits/3f4ca133b3334a93306921b7574e53f27eb599e3
c71141c MVP type checking with minimal code changes davidshepherd7 Aug 29, 2021 https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/commits/c71141cc386788bf0697f0ebd7b77350c2b741f4
9a4464f Fix test mock client having a missing required method davidshepherd7 Aug 29, 2021 https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/commits/9a4464f1c0acf0ff8fe0e8335025d5bee1f142cc
1700848 Explicitly fail when a Param has no max or size davidshepherd7 Aug 29, 2021 https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/commits/17008489d3e6b579dfd5c4259818ba73edf187d0
3a1b17b Add easy types davidshepherd7 Aug 29, 2021 https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/commits/3a1b17b445d6ed44f1f74204afefa198ffd8ded1
daabdbe Add a simpler repr for command objects davidshepherd7 Aug 29, 2021 https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/commits/daabdbe5b294cc38ef4c3ad67cceb2770d13acb0
7bc5c07 Fix inconsistent use of null unicode vs null bytes when generating so… davidshepherd7 Aug 29, 2021 https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/commits/7bc5c07c2dedfbd2c7e143bb6e13a3120807b747
882a784 Add more tests for PDU parsing/generating davidshepherd7 Aug 29, 2021 https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/commits/882a784783c93e0d093b4fadfeb23065e1b05796
Clear filters https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files
Please reload this pagehttps://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files
Please reload this pagehttps://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files
config.yml https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47
Makefile https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52
mypy.ini https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files#diff-6f2d4ba9ca9a357d31014946667b7bed1bfdbc6d2530afc77778fa0a36bee457
setup.py https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
client.py https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files#diff-44da0d6a3abf456b41dad6849388b2131603ea26e3cde18364904d61474a0994
command.py https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files#diff-28325db93226f6ff0c0d200a687a80fc72b381afc7f744179cca4e96277be68f
command_codes.py https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files#diff-440f17eff4fca544710ba1ea97e747a5f14118836a1435be97a8cadb70e7904c
gsm.py https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files#diff-ac9ba485b3bd6ee4aa0b7f8bc05ed8553c97401bfac2b9f8d101c1d50f609d08
pdu.py https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files#diff-7c4dc87b647f93fc0a292f62d9bbfe37b04376195b73d7b30eaa8a441a6565ae
smpp.py https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files#diff-d16b12288d1ccc95cd3a58940f2ad7512e0bba7ef5d35de9148472a79ef78551
test_client.py https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files#diff-8b1c297f229a616a49eb2e942b1bbff53ac1ecff8b00189bc753f65307066f6c
test_command.py https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files#diff-02a263f4d3c0f4e87a556f18bebbebe6a751729b1159fa54be6aca24157d498a
test_gsm.py https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files#diff-e1cff7a18ce0f15479d46bbc3e22f1cdab71f7e3f782e08a4608b0dd7b2dc3f4
https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/blob/master/CODEOWNERS#L1
.circleci/config.ymlhttps://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47
View file https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/blob/882a784783c93e0d093b4fadfeb23065e1b05796/.circleci/config.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47
https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47
https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47
https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/blob/master/CODEOWNERS#L1
Makefilehttps://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52
View file https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/blob/882a784783c93e0d093b4fadfeb23065e1b05796/Makefile
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/blob/master/CODEOWNERS#L1
mypy.inihttps://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files#diff-6f2d4ba9ca9a357d31014946667b7bed1bfdbc6d2530afc77778fa0a36bee457
View file https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/blob/882a784783c93e0d093b4fadfeb23065e1b05796/mypy.ini
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/blob/master/CODEOWNERS#L1
setup.pyhttps://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
View file https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/blob/882a784783c93e0d093b4fadfeb23065e1b05796/setup.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
https://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7
Please reload this pagehttps://patch-diff.githubusercontent.com/python-smpplib/python-smpplib/pull/162/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.