René's URL Explorer Experiment


Title: Fix #241: Implement tilde and caret matching by tomschr · Pull Request #367 · python-semver/python-semver · GitHub

Open Graph Title: Fix #241: Implement tilde and caret matching by tomschr · Pull Request #367 · python-semver/python-semver

X Title: Fix #241: Implement tilde and caret matching by tomschr · Pull Request #367 · python-semver/python-semver

Description: Introduce Spec class to deal with such comparisons Improve documentation Simplify code in Version.match (delegates to Spec.match) Implementation Questions Is the Spec class the right approach here? Any other options? Should we use different names for Spec.match? What about Version.match? Is the VersionRegex class a good idea? It shares some constant regexes between Version and Spec. Or should we better use just variables and share those? The Spec class supports operators like Spec("1.*") == Version(1, 2, 3). I'm wondering if this is useful as we can't use the same for ~ and ^. If we remove operators, the code gets a bit smaller, but then we have to call Spec.match. Good, bad? In the (hopefully near) future, I would like to create a SpecSet class to support extended ranges like <=1.2.3 || >=2.3.4. Any design decisions that should be implemented in regards to this? Where and how could we improve the code?

Open Graph Description: Introduce Spec class to deal with such comparisons Improve documentation Simplify code in Version.match (delegates to Spec.match) Implementation Questions Is the Spec class the right approach her...

X Description: Introduce Spec class to deal with such comparisons Improve documentation Simplify code in Version.match (delegates to Spec.match) Implementation Questions Is the Spec class the right approach her...

Opengraph URL: https://github.com/python-semver/python-semver/pull/367

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8aae421d-b670-3c24-8989-aab30340dbf3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD178:3287BB:1C3D7DB:2555181:69771974
html-safe-nonceb6dd144f9f5d2b0293895b2240c3233821ebcf46102b8d5d0e15c23c63a94e46
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTc4OjMyODdCQjoxQzNEN0RCOjI1NTUxODE6Njk3NzE5NzQiLCJ2aXNpdG9yX2lkIjoiMTgwMjA4NDI3MzkwNTY3MDUxNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7a12c89670a37cc88f237b73e0ab6db84eb7055e1454efd068c1452aca78f804
hovercard-subject-tagpull_request:1123136860
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-semver/python-semver/pull/367/files
twitter:imagehttps://avatars.githubusercontent.com/u/1312925?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1312925?s=400&v=4
og:image:altIntroduce Spec class to deal with such comparisons Improve documentation Simplify code in Version.match (delegates to Spec.match) Implementation Questions Is the Spec class the right approach her...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None01d198479908d09a841b2febe8eb105a81af2af7d81830960fe0971e1f4adc09
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-semver/python-semver git https://github.com/python-semver/python-semver.git
octolytics-dimension-user_id57228994
octolytics-dimension-user_loginpython-semver
octolytics-dimension-repository_id3375726
octolytics-dimension-repository_nwopython-semver/python-semver
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id3375726
octolytics-dimension-repository_network_root_nwopython-semver/python-semver
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef752335dbbea672610081196a1998e39aec5e14b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-semver%2Fpython-semver%2Fpull%2F367%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-semver%2Fpython-semver%2Fpull%2F367%2Ffiles
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-semver%2Fpython-semver
Reloadhttps://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files
Reloadhttps://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files
Reloadhttps://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files
python-semver https://patch-diff.githubusercontent.com/python-semver
python-semverhttps://patch-diff.githubusercontent.com/python-semver/python-semver
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-semver%2Fpython-semver
Fork 96 https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-semver%2Fpython-semver
Star 516 https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-semver%2Fpython-semver
Code https://patch-diff.githubusercontent.com/python-semver/python-semver
Issues 12 https://patch-diff.githubusercontent.com/python-semver/python-semver/issues
Pull requests 3 https://patch-diff.githubusercontent.com/python-semver/python-semver/pulls
Discussions https://patch-diff.githubusercontent.com/python-semver/python-semver/discussions
Actions https://patch-diff.githubusercontent.com/python-semver/python-semver/actions
Projects 0 https://patch-diff.githubusercontent.com/python-semver/python-semver/projects
Security 0 https://patch-diff.githubusercontent.com/python-semver/python-semver/security
Insights https://patch-diff.githubusercontent.com/python-semver/python-semver/pulse
Code https://patch-diff.githubusercontent.com/python-semver/python-semver
Issues https://patch-diff.githubusercontent.com/python-semver/python-semver/issues
Pull requests https://patch-diff.githubusercontent.com/python-semver/python-semver/pulls
Discussions https://patch-diff.githubusercontent.com/python-semver/python-semver/discussions
Actions https://patch-diff.githubusercontent.com/python-semver/python-semver/actions
Projects https://patch-diff.githubusercontent.com/python-semver/python-semver/projects
Security https://patch-diff.githubusercontent.com/python-semver/python-semver/security
Insights https://patch-diff.githubusercontent.com/python-semver/python-semver/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fpython-semver%2Fpython-semver%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fpython-semver%2Fpython-semver%2Fissues%2Fnew%2Fchoose
tomschrhttps://patch-diff.githubusercontent.com/tomschr
python-semver:masterhttps://patch-diff.githubusercontent.com/python-semver/python-semver/tree/master
tomschr:feature/284-matchinghttps://patch-diff.githubusercontent.com/tomschr/python-semver/tree/feature/284-matching
Conversation 2 https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367
Commits 10 https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/commits
Checks 0 https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/checks
Files changed https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files
Please reload this pagehttps://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files
Fix #241: Implement tilde and caret matching https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files#top
Show all changes 10 commits https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files
5d6137e Fix #284: Concise "compatibility" matching tomschr Oct 15, 2022 https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/commits/5d6137ea1de2934e1a532f438cf94c051e182b3d
fb58e48 Fix #241: Implement tilde and caret matching tomschr Nov 13, 2022 https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/commits/fb58e48c42a12d2b9520adcce4d8c5fdb110679e
f3ed97f Reformatted with black tomschr Mar 5, 2023 https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/commits/f3ed97f1fb05c4ff0f7b9ea81a579deecb5f4856
31efb0f Change visibility to public of version parts tomschr Jul 2, 2023 https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/commits/31efb0fdae7f605bc704ca8bbe4f59ea0457274e
7d3e8eb Move NAMES class variable tomschr Jul 2, 2023 https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/commits/7d3e8eb62ebb1f0136d414aa3cec33e1ea5b7068
16ea668 Simplified types tomschr Jul 2, 2023 https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/commits/16ea668ae95afdd4a6183c64e12c54eab540c748
dc60f88 Reformatted with black tomschr Jul 24, 2023 https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/commits/dc60f88ce9f09a4799939465dbdf5eef799d24de
05a133d Exclude .venv dir for flake8 tomschr Jul 24, 2023 https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/commits/05a133d0fd0e6215e856484526b94f40f7649484
ccbc7a3 Remove unused imports tomschr Jul 24, 2023 https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/commits/ccbc7a3ee57a035061a7c8e7026231649fadebaf
a81ee96 Fix typos in doc tomschr Jul 24, 2023 https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/commits/a81ee966991324a4e0018b183b7bca46cffa188c
Clear filters https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files
Please reload this pagehttps://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files
Please reload this pagehttps://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files
api.rst https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files#diff-0ee295c29def16f570f86378eff8ba37315e464d415e731d5d8ea2e67ce16f68
conf.py https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files#diff-85933aa74a2d66c3e4dcdf7a9ad8397f5a7971080d34ef1108296a7c6b69e7e3
compare-versions-through-expression.rst https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files#diff-ed115ce3b21bbe2c034cf1d5a8d165d43aaea8093c4abb6e20e5315d7e304748
setup.cfg https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files#diff-fa602a8a75dc9dcc92261bac5f533c2a85e34fcceaff63b3a3a81d9acde2fc52
__init__.py https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files#diff-2a42260f496bab31cc96e689b7e534b4109230389b20880d7356b65c95fec904
spec.py https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files#diff-75053549aa84d1513a91950de7668281141da7db81b57eddc9271e65fe98b529
version.py https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files#diff-d6e8c013b9e7be774edf21bed5411e65f2a2bf6b43110b67e6c4dccdcab23791
versionregex.py https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files#diff-4ca9198d964f317154e1381e5904d149a45a8262cfa6c15ce9d24b43814e583a
conftest.py https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files#diff-e52e4ddd58b7ef887ab03c04116e676f6280b824ab7469d5d3080e5cba4f2128
test_immutable.py https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files#diff-ecca1242626399f2f5ef83ee4ca193fde7608fbbe920bbece03c289e635cc767
test_match.py https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files#diff-2b22ce50fb090a57a106007280d0785c6c040a132bff2638105523cf88cf69b3
test_spec.py https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files#diff-a5bd467db58a57ac9daef91723a04e6725a185d8d568e53ba5b00606bf566ffe
docs/api.rsthttps://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files#diff-0ee295c29def16f570f86378eff8ba37315e464d415e731d5d8ea2e67ce16f68
View file https://patch-diff.githubusercontent.com/python-semver/python-semver/blob/a81ee966991324a4e0018b183b7bca46cffa188c/docs/api.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files#diff-0ee295c29def16f570f86378eff8ba37315e464d415e731d5d8ea2e67ce16f68
docs/conf.pyhttps://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files#diff-85933aa74a2d66c3e4dcdf7a9ad8397f5a7971080d34ef1108296a7c6b69e7e3
View file https://patch-diff.githubusercontent.com/python-semver/python-semver/blob/a81ee966991324a4e0018b183b7bca46cffa188c/docs/conf.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files#diff-85933aa74a2d66c3e4dcdf7a9ad8397f5a7971080d34ef1108296a7c6b69e7e3
https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files#diff-85933aa74a2d66c3e4dcdf7a9ad8397f5a7971080d34ef1108296a7c6b69e7e3
docs/usage/compare-versions-through-expression.rsthttps://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files#diff-ed115ce3b21bbe2c034cf1d5a8d165d43aaea8093c4abb6e20e5315d7e304748
View file https://patch-diff.githubusercontent.com/python-semver/python-semver/blob/a81ee966991324a4e0018b183b7bca46cffa188c/docs/usage/compare-versions-through-expression.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files#diff-ed115ce3b21bbe2c034cf1d5a8d165d43aaea8093c4abb6e20e5315d7e304748
setup.cfghttps://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files#diff-fa602a8a75dc9dcc92261bac5f533c2a85e34fcceaff63b3a3a81d9acde2fc52
View file https://patch-diff.githubusercontent.com/python-semver/python-semver/blob/a81ee966991324a4e0018b183b7bca46cffa188c/setup.cfg
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files#diff-fa602a8a75dc9dcc92261bac5f533c2a85e34fcceaff63b3a3a81d9acde2fc52
https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files#diff-fa602a8a75dc9dcc92261bac5f533c2a85e34fcceaff63b3a3a81d9acde2fc52
src/semver/__init__.pyhttps://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files#diff-2a42260f496bab31cc96e689b7e534b4109230389b20880d7356b65c95fec904
View file https://patch-diff.githubusercontent.com/python-semver/python-semver/blob/a81ee966991324a4e0018b183b7bca46cffa188c/src/semver/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files#diff-2a42260f496bab31cc96e689b7e534b4109230389b20880d7356b65c95fec904
https://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files#diff-2a42260f496bab31cc96e689b7e534b4109230389b20880d7356b65c95fec904
Please reload this pagehttps://patch-diff.githubusercontent.com/python-semver/python-semver/pull/367/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.