Title: Move code for exporting attributes to the attribute's classes by dragomirecky · Pull Request #82 · python-sdbus/python-sdbus · GitHub
Open Graph Title: Move code for exporting attributes to the attribute's classes by dragomirecky · Pull Request #82 · python-sdbus/python-sdbus
X Title: Move code for exporting attributes to the attribute's classes by dragomirecky · Pull Request #82 · python-sdbus/python-sdbus
Description: Hello, this PR makes some relatively small improvements (in my opinion) to the internal structure of the code. It renames all the DbusSomething classes to DbusAttribute. "Something" referred to method/signal/property of an interface. Looking at sdbus and elsewhere, those are usually called "attributes" of the interface. Together with the other changes in this PR, I believe it makes the code clearer. It renames the classes for bound attributes Discussed here already #65 I believe calling the attributes "bound" is correct, the same way we have "bound methods" in Python. Thus the base classes for bound attributes is "DbusBound". The concrete subclasses representing bound attributes are then called DbusLocalMethodAsync, DbusLocalMethodAsync, etc (as suggested by @igo95862 ; not repeating the "Bound" word, as it doesn't seem to be necessary in that context) Most importantly, it moves some attribute-specific code from DbusInterfaceBaseAsync to the DbusLocalMethodAsync. This change is my main motivation behind this PR. By having the logic of "exporting an attribute to dbus" in the attribute class itself, it gets much easier for clients of this library to extend the library with more advanced attributes (which is my case – I need to be able to implement custom versions of @dbus_property_async and this change makes it much easier to do so). At the same time, it tries to make the code actually simpler (also slightly improving DbusExportHandle).
Open Graph Description: Hello, this PR makes some relatively small improvements (in my opinion) to the internal structure of the code. It renames all the DbusSomething classes to DbusAttribute. "Something" ref...
X Description: Hello, this PR makes some relatively small improvements (in my opinion) to the internal structure of the code. It renames all the DbusSomething classes to DbusAttribute. "Something&q...
Opengraph URL: https://github.com/python-sdbus/python-sdbus/pull/82
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:88fd4079-ae4b-f73b-1e5b-2c636cb78489 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BDB8:60C4F:6E4ADD:973507:698EFBF0 |
| html-safe-nonce | e82839c086610132235cdb615e4c5247413f44dfec8ef6c484c7efa3467409a4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCREI4OjYwQzRGOjZFNEFERDo5NzM1MDc6Njk4RUZCRjAiLCJ2aXNpdG9yX2lkIjoiNTQyNzQyMjc5Nzg4MTA4MDgxNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b9ed5296795f0c6caec1a7f1ec4b042701aec0a4de6a2f2ad30822c8646631a6 |
| hovercard-subject-tag | pull_request:2220503796 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-sdbus/python-sdbus/pull/82/files |
| twitter:image | https://avatars.githubusercontent.com/u/1269664?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1269664?s=400&v=4 |
| og:image:alt | Hello, this PR makes some relatively small improvements (in my opinion) to the internal structure of the code. It renames all the DbusSomething classes to DbusAttribute. "Something" ref... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7f7bf82d8907f81525d95af82e60354b419d083df9534c8631d06bb9c0bf07ac |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python-sdbus/python-sdbus git https://github.com/python-sdbus/python-sdbus.git |
| octolytics-dimension-user_id | 88226657 |
| octolytics-dimension-user_login | python-sdbus |
| octolytics-dimension-repository_id | 311269257 |
| octolytics-dimension-repository_nwo | python-sdbus/python-sdbus |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 311269257 |
| octolytics-dimension-repository_network_root_nwo | python-sdbus/python-sdbus |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 29d97d94d5b31f96c01179273264722362f058e7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width