Title: Change comparison of Quantity (to fix gh-146) by bjodah · Pull Request #147 · python-quantities/python-quantities · GitHub
Open Graph Title: Change comparison of Quantity (to fix gh-146) by bjodah · Pull Request #147 · python-quantities/python-quantities
X Title: Change comparison of Quantity (to fix gh-146) by bjodah · Pull Request #147 · python-quantities/python-quantities
Description: This fixes gh-146 (Quantity with dimension comparing equal to plain numpy arrays). This is a rather big change since it actually changes some tests to expect errors being raised where equality was assumed before. So we might need a deprecation cycle (we can emit warnings where we will raise exceptions / change equality behaviour). Or maybe people even find the change to be too large to even be considered? What do people think?
Open Graph Description: This fixes gh-146 (Quantity with dimension comparing equal to plain numpy arrays). This is a rather big change since it actually changes some tests to expect errors being raised where equality was ...
X Description: This fixes gh-146 (Quantity with dimension comparing equal to plain numpy arrays). This is a rather big change since it actually changes some tests to expect errors being raised where equality was ...
Opengraph URL: https://github.com/python-quantities/python-quantities/pull/147
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:15ac0c19-abe8-412f-beb9-2680aaaba8fb |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | C8D8:3DB89D:C5DB9:FAC5C:69742EA2 |
| html-safe-nonce | fa47be416c53e07e4586b665d5c31767e47c1cbf33545c343a81b69db9c7b975 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOEQ4OjNEQjg5RDpDNURCOTpGQUM1Qzo2OTc0MkVBMiIsInZpc2l0b3JfaWQiOiI3ODMwOTM0NDc0NTQzNzE0OTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d853d3875d5c2023b63a046b11261a75555f5e5be818096601f1065b314d05cb |
| hovercard-subject-tag | pull_request:165576969 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-quantities/python-quantities/pull/147/checks |
| twitter:image | https://avatars.githubusercontent.com/u/485936?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/485936?s=400&v=4 |
| og:image:alt | This fixes gh-146 (Quantity with dimension comparing equal to plain numpy arrays). This is a rather big change since it actually changes some tests to expect errors being raised where equality was ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | f0c542b740cf8c6c6deff23a0eeffd05a0e8bd35565559ca5ec1535bcbb67e5c |
| turbo-cache-control | no-preview |
| go-import | github.com/python-quantities/python-quantities git https://github.com/python-quantities/python-quantities.git |
| octolytics-dimension-user_id | 222003 |
| octolytics-dimension-user_login | python-quantities |
| octolytics-dimension-repository_id | 560911 |
| octolytics-dimension-repository_nwo | python-quantities/python-quantities |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 560911 |
| octolytics-dimension-repository_network_root_nwo | python-quantities/python-quantities |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4e27a77ef0bf22cd9328967ddc1e1c3dfa6ffe51 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width