Title: Refactor parse_xml function to handle external target references (Issue #1349) (old PR #1350) by TommasoPetrolito · Pull Request #1518 · python-openxml/python-docx · GitHub
Open Graph Title: Refactor parse_xml function to handle external target references (Issue #1349) (old PR #1350) by TommasoPetrolito · Pull Request #1518 · python-openxml/python-docx
X Title: Refactor parse_xml function to handle external target references (Issue #1349) (old PR #1350) by TommasoPetrolito · Pull Request #1518 · python-openxml/python-docx
Description: I start from this issue/PR: #1350 Trying to push again for this change to be merged/integrated, as people still face the issue/bug if this won't be merged. In many projects I had to use the custom commits on forks to make it work, the discussion/conversation in PR 1350 shows that the issue is felt by a significant number of users and it would be nice to have this very little change finally merged @scanny THE MODIFICATION IS: The added code checks if self.target_ref exists and if it starts with a "#", which is a common way to denote external references. If both conditions are met, the method returns RTM.EXTERNAL, indicating that the target reference is external. This change improves the robustness of our code by correctly handling and classifying external references. This will prevent potential errors or unexpected behavior when encountering such references. Please merge this change now that the modification is properly aligned with latest code version and has no conflicts.
Open Graph Description: I start from this issue/PR: #1350 Trying to push again for this change to be merged/integrated, as people still face the issue/bug if this won't be merged. In many projects I had to use the cus...
X Description: I start from this issue/PR: #1350 Trying to push again for this change to be merged/integrated, as people still face the issue/bug if this won't be merged. In many projects I had to use the...
Opengraph URL: https://github.com/python-openxml/python-docx/pull/1518
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:e2cdc6b9-aa84-1460-c130-3d1422610db2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 80D8:19C1C9:32C39EA:45A4467:6973D3A6 |
| html-safe-nonce | a74a5048f96d6ac2ca3216961aa86a70270cd3723bfbd177fc4f576073d1a6a0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MEQ4OjE5QzFDOTozMkMzOUVBOjQ1QTQ0Njc6Njk3M0QzQTYiLCJ2aXNpdG9yX2lkIjoiODg5MTE1NzA0ODQyMjgxNDYzMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8c06ffb8c5c137b2d9220d9dbba61efefee847d7174c8a81f82798a3f5c0a554 |
| hovercard-subject-tag | pull_request:2815029813 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-openxml/python-docx/pull/1518/files |
| twitter:image | https://avatars.githubusercontent.com/u/17761623?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/17761623?s=400&v=4 |
| og:image:alt | I start from this issue/PR: #1350 Trying to push again for this change to be merged/integrated, as people still face the issue/bug if this won't be merged. In many projects I had to use the cus... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4c466014c8820edcdcbef69f57f90d1c8041009ca459463b96b062ebca83c424 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python-openxml/python-docx git https://github.com/python-openxml/python-docx.git |
| octolytics-dimension-user_id | 3403760 |
| octolytics-dimension-user_login | python-openxml |
| octolytics-dimension-repository_id | 13592924 |
| octolytics-dimension-repository_nwo | python-openxml/python-docx |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 13592924 |
| octolytics-dimension-repository_network_root_nwo | python-openxml/python-docx |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b4cd3a8af1483283fd4c6bcf6e24fd9fc8ab0e78 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width