René's URL Explorer Experiment


Title: Fix Ascii IFD reading as TIFF6.0 spec by TheZ3ro · Pull Request #1451 · python-openxml/python-docx · GitHub

Open Graph Title: Fix Ascii IFD reading as TIFF6.0 spec by TheZ3ro · Pull Request #1451 · python-openxml/python-docx

X Title: Fix Ascii IFD reading as TIFF6.0 spec by TheZ3ro · Pull Request #1451 · python-openxml/python-docx

Description: This PR fixes #187 The TIFF6 specification writes: Value/Offset To save time and space the Value Offset contains the Value instead of pointing to the Value if and only if the Value fits into 4 bytes. If the Value is shorter than 4 bytes, it is left-justified within the 4-byte Value Offset, i.e., stored in the lower- numbered bytes. Whether the Value fits within 4 bytes is determined by the Type and Count of the field. python-docx by default uses the Value/Offset field as a offset for ASCII IFD, but sometime the Value/Offset field could contain directly the Value (if it contains a string with 4 or less characters including the final NULL byte/string terminator) This is the case for the 2 pictures linked in issue #187 (the Software ASCII field contains 8.3)

Open Graph Description: This PR fixes #187 The TIFF6 specification writes: Value/Offset To save time and space the Value Offset contains the Value instead of pointing to the Value if and only if the Value fits into 4 byt...

X Description: This PR fixes #187 The TIFF6 specification writes: Value/Offset To save time and space the Value Offset contains the Value instead of pointing to the Value if and only if the Value fits into 4 byt...

Opengraph URL: https://github.com/python-openxml/python-docx/pull/1451

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:eeded279-c858-f99e-1a07-d7490efd6866
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD726:122E03:1A25E03:2470EC9:69727CBD
html-safe-nonce62d1408ae4da1794f9a96dd7035138f45ced7123562a0a3b38106da8bb4d0b52
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzI2OjEyMkUwMzoxQTI1RTAzOjI0NzBFQzk6Njk3MjdDQkQiLCJ2aXNpdG9yX2lkIjoiMzY2NzM5NjY0MDgwMTcxNzQzNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6f9ec2820fe16cab7512efe13b2cf04b9b86b28097500a5601bae64c62949540
hovercard-subject-tagpull_request:2207076687
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python-openxml/python-docx/pull/1451/files
twitter:imagehttps://avatars.githubusercontent.com/u/686894?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/686894?s=400&v=4
og:image:altThis PR fixes #187 The TIFF6 specification writes: Value/Offset To save time and space the Value Offset contains the Value instead of pointing to the Value if and only if the Value fits into 4 byt...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef3cc591a09ecfa43f68be4fde9ec95eccfdf6298db2cd7d08e9eae6c9f833329
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python-openxml/python-docx git https://github.com/python-openxml/python-docx.git
octolytics-dimension-user_id3403760
octolytics-dimension-user_loginpython-openxml
octolytics-dimension-repository_id13592924
octolytics-dimension-repository_nwopython-openxml/python-docx
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id13592924
octolytics-dimension-repository_network_root_nwopython-openxml/python-docx
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release208d56d4b5936bcb8a1d3b43096d573261817603
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/python-openxml/python-docx/pull/1451/files#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-openxml%2Fpython-docx%2Fpull%2F1451%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-openxml%2Fpython-docx%2Fpull%2F1451%2Ffiles
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python-openxml%2Fpython-docx
Reloadhttps://patch-diff.githubusercontent.com/python-openxml/python-docx/pull/1451/files
Reloadhttps://patch-diff.githubusercontent.com/python-openxml/python-docx/pull/1451/files
Reloadhttps://patch-diff.githubusercontent.com/python-openxml/python-docx/pull/1451/files
python-openxml https://patch-diff.githubusercontent.com/python-openxml
python-docxhttps://patch-diff.githubusercontent.com/python-openxml/python-docx
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-openxml%2Fpython-docx
Fork 1.3k https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-openxml%2Fpython-docx
Star 5.4k https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-openxml%2Fpython-docx
Code https://patch-diff.githubusercontent.com/python-openxml/python-docx
Issues 577 https://patch-diff.githubusercontent.com/python-openxml/python-docx/issues
Pull requests 124 https://patch-diff.githubusercontent.com/python-openxml/python-docx/pulls
Actions https://patch-diff.githubusercontent.com/python-openxml/python-docx/actions
Projects 0 https://patch-diff.githubusercontent.com/python-openxml/python-docx/projects
Wiki https://patch-diff.githubusercontent.com/python-openxml/python-docx/wiki
Security 0 https://patch-diff.githubusercontent.com/python-openxml/python-docx/security
Insights https://patch-diff.githubusercontent.com/python-openxml/python-docx/pulse
Code https://patch-diff.githubusercontent.com/python-openxml/python-docx
Issues https://patch-diff.githubusercontent.com/python-openxml/python-docx/issues
Pull requests https://patch-diff.githubusercontent.com/python-openxml/python-docx/pulls
Actions https://patch-diff.githubusercontent.com/python-openxml/python-docx/actions
Projects https://patch-diff.githubusercontent.com/python-openxml/python-docx/projects
Wiki https://patch-diff.githubusercontent.com/python-openxml/python-docx/wiki
Security https://patch-diff.githubusercontent.com/python-openxml/python-docx/security
Insights https://patch-diff.githubusercontent.com/python-openxml/python-docx/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fpython-openxml%2Fpython-docx%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fpython-openxml%2Fpython-docx%2Fissues%2Fnew%2Fchoose
TheZ3rohttps://patch-diff.githubusercontent.com/TheZ3ro
python-openxml:masterhttps://patch-diff.githubusercontent.com/python-openxml/python-docx/tree/master
TheZ3ro:tiff-patchhttps://patch-diff.githubusercontent.com/TheZ3ro/python-docx/tree/tiff-patch
Conversation 2 https://patch-diff.githubusercontent.com/python-openxml/python-docx/pull/1451
Commits 1 https://patch-diff.githubusercontent.com/python-openxml/python-docx/pull/1451/commits
Checks 0 https://patch-diff.githubusercontent.com/python-openxml/python-docx/pull/1451/checks
Files changed https://patch-diff.githubusercontent.com/python-openxml/python-docx/pull/1451/files
Please reload this pagehttps://patch-diff.githubusercontent.com/python-openxml/python-docx/pull/1451/files
Fix Ascii IFD reading as TIFF6.0 spec https://patch-diff.githubusercontent.com/python-openxml/python-docx/pull/1451/files#top
Show all changes 1 commit https://patch-diff.githubusercontent.com/python-openxml/python-docx/pull/1451/files
7890e38 fix Ascii IFD reading as TIFF6.0 spec TheZ3ro Nov 29, 2024 https://patch-diff.githubusercontent.com/python-openxml/python-docx/pull/1451/commits/7890e3891070167f44205cb1da9e36684c177573
Clear filters https://patch-diff.githubusercontent.com/python-openxml/python-docx/pull/1451/files
Please reload this pagehttps://patch-diff.githubusercontent.com/python-openxml/python-docx/pull/1451/files
Please reload this pagehttps://patch-diff.githubusercontent.com/python-openxml/python-docx/pull/1451/files
src/docx/image/tiff.pyhttps://patch-diff.githubusercontent.com/python-openxml/python-docx/pull/1451/files#diff-bac48a8a6976d3ce3fb71997cb68d326da98caf2a70b8ddfd81bce7b37f6fc06
View file https://patch-diff.githubusercontent.com/python-openxml/python-docx/blob/7890e3891070167f44205cb1da9e36684c177573/src/docx/image/tiff.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/python-openxml/python-docx/pull/1451/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/python-openxml/python-docx/pull/1451/files#diff-bac48a8a6976d3ce3fb71997cb68d326da98caf2a70b8ddfd81bce7b37f6fc06
https://patch-diff.githubusercontent.com/python-openxml/python-docx/pull/1451/files#diff-bac48a8a6976d3ce3fb71997cb68d326da98caf2a70b8ddfd81bce7b37f6fc06
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.