Title: Fix Ascii IFD reading as TIFF6.0 spec by TheZ3ro · Pull Request #1451 · python-openxml/python-docx · GitHub
Open Graph Title: Fix Ascii IFD reading as TIFF6.0 spec by TheZ3ro · Pull Request #1451 · python-openxml/python-docx
X Title: Fix Ascii IFD reading as TIFF6.0 spec by TheZ3ro · Pull Request #1451 · python-openxml/python-docx
Description: This PR fixes #187 The TIFF6 specification writes: Value/Offset To save time and space the Value Offset contains the Value instead of pointing to the Value if and only if the Value fits into 4 bytes. If the Value is shorter than 4 bytes, it is left-justified within the 4-byte Value Offset, i.e., stored in the lower- numbered bytes. Whether the Value fits within 4 bytes is determined by the Type and Count of the field. python-docx by default uses the Value/Offset field as a offset for ASCII IFD, but sometime the Value/Offset field could contain directly the Value (if it contains a string with 4 or less characters including the final NULL byte/string terminator) This is the case for the 2 pictures linked in issue #187 (the Software ASCII field contains 8.3)
Open Graph Description: This PR fixes #187 The TIFF6 specification writes: Value/Offset To save time and space the Value Offset contains the Value instead of pointing to the Value if and only if the Value fits into 4 byt...
X Description: This PR fixes #187 The TIFF6 specification writes: Value/Offset To save time and space the Value Offset contains the Value instead of pointing to the Value if and only if the Value fits into 4 byt...
Opengraph URL: https://github.com/python-openxml/python-docx/pull/1451
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:a02e59bd-2724-38f9-7952-1edc29f27083 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | A5DC:3676A1:5C8FAF:7F276E:69727EE6 |
| html-safe-nonce | 9651dcf6fee88d75e90a408041e6b0e6eff42e3ed1944a661d82c90dde90831d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNURDOjM2NzZBMTo1QzhGQUY6N0YyNzZFOjY5NzI3RUU2IiwidmlzaXRvcl9pZCI6IjQ5MTY0MzM4OTk5NzA3ODkwOTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 8c783470d79ce9828ebbf4c4ed7ea0d1c34f589e706d93133c793081331e30d2 |
| hovercard-subject-tag | pull_request:2207076687 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-openxml/python-docx/pull/1451/checks |
| twitter:image | https://avatars.githubusercontent.com/u/686894?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/686894?s=400&v=4 |
| og:image:alt | This PR fixes #187 The TIFF6 specification writes: Value/Offset To save time and space the Value Offset contains the Value instead of pointing to the Value if and only if the Value fits into 4 byt... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | f3cc591a09ecfa43f68be4fde9ec95eccfdf6298db2cd7d08e9eae6c9f833329 |
| turbo-cache-control | no-preview |
| go-import | github.com/python-openxml/python-docx git https://github.com/python-openxml/python-docx.git |
| octolytics-dimension-user_id | 3403760 |
| octolytics-dimension-user_login | python-openxml |
| octolytics-dimension-repository_id | 13592924 |
| octolytics-dimension-repository_nwo | python-openxml/python-docx |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 13592924 |
| octolytics-dimension-repository_network_root_nwo | python-openxml/python-docx |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 208d56d4b5936bcb8a1d3b43096d573261817603 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width