René's URL Explorer Experiment


Title: Custom format for unmarshalling doesn't work · python-openapi/openapi-core · Discussion #778 · GitHub

Open Graph Title: Custom format for unmarshalling doesn't work · python-openapi/openapi-core · Discussion #778

X Title: Custom format for unmarshalling doesn't work · python-openapi/openapi-core · Discussion #778

Description: Custom format for unmarshalling doesn't work

Open Graph Description: Hello, Thanks for the openap-core project; it's very helpful. I'm using it to validate my api input. I'm trying to make sure that required values that are blank strings are not allowed. I've tried ...

X Description: Hello, Thanks for the openap-core project; it's very helpful. I'm using it to validate my api input. I'm trying to make sure that required values that are blank strings are not allowed....

Opengraph URL: https://github.com/python-openapi/openapi-core/discussions/778

X: @github

direct link

Domain: patch-diff.githubusercontent.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"QAPage","mainEntity":{"@type":"Question","name":"Custom format for unmarshalling doesn't work","text":"

Hello, Thanks for the openap-core project; it's very helpful. I'm using it to validate my api input. I'm trying to make sure that required values that are blank strings are not allowed. I've tried using the documented YAML specs directly (https://swagger.io/docs/specification/data-models/data-types/#string):

\n
type: string\nminLength: 1\n\n
\n

and

\n
  type: string\n  pattern: '^.+$'\n\n
\n

But the unmarshaller ignores these specifications.

\n

I upgraded to 0.19.0a1 to add a custom validator, per https://openapi-core.readthedocs.io/_/downloads/en/latest/pdf/ by @p1c2u Artur Maciag but his example doesn't seem to do anything:

\n
    from datetime import datetime\n\n    def unmarshal_usdate(value):\n        return datetime.strptime(value, \"%m/%d/%y\").date\n\n    extra_format_unmarshallers = {\n        \"usdate\": unmarshal_usdate,\n    }\n\n    def validate_usdate(value):\n        return bool(re.match(r\"^\\d{1,2}/\\d{1,2}/\\d{4}$\", value))\n\n    extra_format_validators = {\n        \"usdate\": validate_usdate,\n    }\n\n    config = Config(\n        extra_format_validators=extra_format_validators,\n        extra_format_unmarshallers=extra_format_unmarshallers,\n    )\n\n    return OpenAPI.from_file_path(spec_file_path, config=config)\n\n
\n

The unmarshaller for the YAML:

\n
                test:\n                    type: string\n                    description: Test\n                    format: usdate\n\n
\n

Happily returns:

\n
RequestUnmarshalResult(errors=[], body={'test': 'not a date', 'description': 'A multiple choice activity focusing on synonyms', 'binary_result': True, 'directionality': 'passive', 'modality': 'text', 'interaction_type': 'match', 'activity_context': 'synonym', 'activity_visibility': 'public', 'activity_type_name': 'ok ok ok'}, parameters=Parameters(query={}, header={}, cookie={}, path={}), security={})\n
\n

tldr; it would be nice to get this custom validator working, but can anyone give me a workaround in the meantime to make sure a string isn't blank?

\n

Thanks,
\nHeidi

","upvoteCount":1,"answerCount":1,"acceptedAnswer":{"@type":"Answer","text":"

Hi @heidiLinguist

\n

thanks for the report, I prepared fix for that. It's part of 0.19.0a2 version

","upvoteCount":2,"url":"https://github.com/python-openapi/openapi-core/discussions/778#discussioncomment-8431590"}}}

route-pattern/_view_fragments/Voltron::DiscussionsFragmentsController/show/:user_id/:repository/:discussion_number/discussion_layout(.:format)
route-controllervoltron_discussions_fragments
route-actiondiscussion_layout
fetch-noncev2:0323fc5b-bba1-8046-07b5-5189bc7892a0
current-catalog-service-hash9f0abe34da433c9b6db74bffa2466494a717b579a96b30a5d252e5090baea7be
request-id918C:2E1B39:A0CDD0:E323CB:69779AF9
html-safe-noncea2e8c845e15050f7ce7d7ad330c9ca0fc99f94b10c8c3ee6e2c730d5804df447
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MThDOjJFMUIzOTpBMENERDA6RTMyM0NCOjY5Nzc5QUY5IiwidmlzaXRvcl9pZCI6Ijg0ODAxNzc2NDk0MTI5NzEyNTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4515cb9861ed6470a219a5f811288976d784317fea57735b86d63f9d7e9fa739
hovercard-subject-tagdiscussion:6201191
github-keyboard-shortcutsrepository,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/discussions_fragments/discussion_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/Voltron::DiscussionsFragmentsController/show/python-openapi/openapi-core/778/discussion_layout
twitter:imagehttps://opengraph.githubassets.com/2d60f7b448d7325b8f264dbaa16b04981d06eb4c55c7f9082f65e566f67057b6/python-openapi/openapi-core/discussions/778
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2d60f7b448d7325b8f264dbaa16b04981d06eb4c55c7f9082f65e566f67057b6/python-openapi/openapi-core/discussions/778
og:image:altHello, Thanks for the openap-core project; it's very helpful. I'm using it to validate my api input. I'm trying to make sure that required values that are blank strings are not allowed. I've tried ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonefc421f20017e1c727052b30a42d36825c29cf12a25e3e3589a184309309fc08a
turbo-cache-controlno-preview
go-importgithub.com/python-openapi/openapi-core git https://github.com/python-openapi/openapi-core.git
octolytics-dimension-user_id126442889
octolytics-dimension-user_loginpython-openapi
octolytics-dimension-repository_id104200746
octolytics-dimension-repository_nwopython-openapi/openapi-core
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id104200746
octolytics-dimension-repository_network_root_nwopython-openapi/openapi-core
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82eac957e166000cbcf5a2f4595b013b0f5a51aa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-openapi%2Fopenapi-core%2Fdiscussions%2F778
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-openapi%2Fopenapi-core%2Fdiscussions%2F778
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fdiscussions_fragments%2Fdiscussion_layout&source=header-repo&source_repo=python-openapi%2Fopenapi-core
Reloadhttps://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778
Reloadhttps://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778
Reloadhttps://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778
python-openapi https://patch-diff.githubusercontent.com/python-openapi
openapi-corehttps://patch-diff.githubusercontent.com/python-openapi/openapi-core
Please reload this pagehttps://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-openapi%2Fopenapi-core
Fork 136 https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-openapi%2Fopenapi-core
Star 356 https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-openapi%2Fopenapi-core
Code https://patch-diff.githubusercontent.com/python-openapi/openapi-core
Issues 74 https://patch-diff.githubusercontent.com/python-openapi/openapi-core/issues
Pull requests 13 https://patch-diff.githubusercontent.com/python-openapi/openapi-core/pulls
Discussions https://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions
Actions https://patch-diff.githubusercontent.com/python-openapi/openapi-core/actions
Projects 0 https://patch-diff.githubusercontent.com/python-openapi/openapi-core/projects
Security 0 https://patch-diff.githubusercontent.com/python-openapi/openapi-core/security
Insights https://patch-diff.githubusercontent.com/python-openapi/openapi-core/pulse
Code https://patch-diff.githubusercontent.com/python-openapi/openapi-core
Issues https://patch-diff.githubusercontent.com/python-openapi/openapi-core/issues
Pull requests https://patch-diff.githubusercontent.com/python-openapi/openapi-core/pulls
Discussions https://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions
Actions https://patch-diff.githubusercontent.com/python-openapi/openapi-core/actions
Projects https://patch-diff.githubusercontent.com/python-openapi/openapi-core/projects
Security https://patch-diff.githubusercontent.com/python-openapi/openapi-core/security
Insights https://patch-diff.githubusercontent.com/python-openapi/openapi-core/pulse
Answered https://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778#discussioncomment-8431590
p1c2uhttps://patch-diff.githubusercontent.com/p1c2u
heidiLinguist https://patch-diff.githubusercontent.com/heidiLinguist
Q&Ahttps://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/categories/q-a
Custom format for unmarshalling doesn't work https://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778#top
heidiLinguist https://patch-diff.githubusercontent.com/heidiLinguist
Answered https://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778#discussioncomment-8431590
p1c2uhttps://patch-diff.githubusercontent.com/p1c2u
Return to tophttps://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778#top
Please reload this pagehttps://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778
https://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778
Please reload this pagehttps://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778
https://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778
heidiLinguist https://patch-diff.githubusercontent.com/heidiLinguist
Feb 9, 2024 https://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778#discussion-6201191
https://swagger.io/docs/specification/data-models/data-types/#stringhttps://swagger.io/docs/specification/data-models/data-types/#string
https://openapi-core.readthedocs.io/_/downloads/en/latest/pdf/https://openapi-core.readthedocs.io/_/downloads/en/latest/pdf/
@p1c2uhttps://github.com/p1c2u
Give feedback.https://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778
p1c2u https://patch-diff.githubusercontent.com/p1c2u
Feb 11, 2024 https://github.com/python-openapi/openapi-core/discussions/778#discussioncomment-8431590
@heidiLinguisthttps://github.com/heidiLinguist
View full answer https://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778#discussioncomment-8431590
Oldest https://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778?sort=old
Newest https://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778?sort=new
Top https://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778?sort=top
Please reload this pagehttps://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778
https://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778
Please reload this pagehttps://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778
https://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778
p1c2u https://patch-diff.githubusercontent.com/p1c2u
Feb 11, 2024 https://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778#discussioncomment-8431590
@heidiLinguisthttps://github.com/heidiLinguist
Give feedback.https://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778
https://patch-diff.githubusercontent.com/heidiLinguist
Please reload this pagehttps://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778
https://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778
heidiLinguisthttps://patch-diff.githubusercontent.com/heidiLinguist
Feb 12, 2024 https://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778#discussioncomment-8442158
Give feedback.https://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778
p1c2uhttps://patch-diff.githubusercontent.com/p1c2u
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-openapi%2Fopenapi-core%2Fdiscussions%2F778
🙏 Q&A https://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/categories/q-a
https://patch-diff.githubusercontent.com/heidiLinguist
https://patch-diff.githubusercontent.com/p1c2u
https://patch-diff.githubusercontent.com/python-openapi/openapi-core/discussions/778
https://patch-diff.githubusercontent.com/settings/replies?return_to=1
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.