René's URL Explorer Experiment


Title: Add basic Goto Implementation Request support by smheidrich · Pull Request #644 · python-lsp/python-lsp-server · GitHub

Open Graph Title: Add basic Goto Implementation Request support by smheidrich · Pull Request #644 · python-lsp/python-lsp-server

X Title: Add basic Goto Implementation Request support by smheidrich · Pull Request #644 · python-lsp/python-lsp-server

Description: Description As pointed out in #97, support for the LSP Goto Implementation Request (textDocument/implementation) aka implementationProvider capability is still missing. This PR adds basic support f...

Open Graph Description: Description As pointed out in #97, support for the LSP Goto Implementation Request (textDocument/implementation) aka implementationProvider capability is still missing. This PR adds basic support f...

X Description: Description As pointed out in #97, support for the LSP Goto Implementation Request (textDocument/implementation) aka implementationProvider capability is still missing. This PR adds basic support f...

Opengraph URL: https://github.com/python-lsp/python-lsp-server/pull/644

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e83df009-fa90-5e52-dd79-25afc7c98545
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD9A:30D218:313413C:424C0AC:69706025
html-safe-nonce9e7fe08127ab5197bc2432f7171cd4cbb48e2f1839aa26288acbf15b608ac595
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDlBOjMwRDIxODozMTM0MTNDOjQyNEMwQUM6Njk3MDYwMjUiLCJ2aXNpdG9yX2lkIjoiMjM3NzE3MjQ3NDkxOTkzNjAzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8a489e9e65376f71871be150960ae6c9dd4c785bf630ebd928515ed3353b46df
hovercard-subject-tagpull_request:2512194901
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-lsp/python-lsp-server/644/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2cf9978dad0b969cff61817ece2bb303cb20262a1a43db41add7583c387f658c/python-lsp/python-lsp-server/pull/644
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2cf9978dad0b969cff61817ece2bb303cb20262a1a43db41add7583c387f658c/python-lsp/python-lsp-server/pull/644
og:image:altDescription As pointed out in #97, support for the LSP Goto Implementation Request (textDocument/implementation) aka implementationProvider capability is still missing. This PR adds basic support f...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesmheidrich
hostnamegithub.com
expected-hostnamegithub.com
None9920a62ba22d06470388e2904804fb7e5ec51c9e35f81784e9191394c74b2bd2
turbo-cache-controlno-preview
go-importgithub.com/python-lsp/python-lsp-server git https://github.com/python-lsp/python-lsp-server.git
octolytics-dimension-user_id51609341
octolytics-dimension-user_loginpython-lsp
octolytics-dimension-repository_id341006790
octolytics-dimension-repository_nwopython-lsp/python-lsp-server
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id341006790
octolytics-dimension-repository_network_root_nwopython-lsp/python-lsp-server
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7d6181066430cc06553c8396ca201e194ae33cb9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-lsp%2Fpython-lsp-server%2Fpull%2F644
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-lsp%2Fpython-lsp-server%2Fpull%2F644
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-lsp%2Fpython-lsp-server
Reloadhttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644
Reloadhttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644
Reloadhttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644
python-lsp https://patch-diff.githubusercontent.com/python-lsp
python-lsp-serverhttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-lsp%2Fpython-lsp-server
Fork 230 https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-lsp%2Fpython-lsp-server
Star 2.5k https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-lsp%2Fpython-lsp-server
Code https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server
Issues 144 https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/issues
Pull requests 21 https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pulls
Discussions https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/discussions
Actions https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/actions
Projects 0 https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/projects
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/security
Please reload this pagehttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644
Insights https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pulse
Code https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server
Issues https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/issues
Pull requests https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pulls
Discussions https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/discussions
Actions https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/actions
Projects https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/projects
Security https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/security
Insights https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fpython-lsp%2Fpython-lsp-server%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fpython-lsp%2Fpython-lsp-server%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#issue-comment-box
smheidrichhttps://patch-diff.githubusercontent.com/smheidrich
python-lsp:develophttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/tree/develop
smheidrich:implement-basic-goto-implementationhttps://patch-diff.githubusercontent.com/smheidrich/python-lsp-server/tree/implement-basic-goto-implementation
Add basic Goto Implementation Request support https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#top
smheidrichhttps://patch-diff.githubusercontent.com/smheidrich
python-lsp:develophttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/tree/develop
smheidrich:implement-basic-goto-implementationhttps://patch-diff.githubusercontent.com/smheidrich/python-lsp-server/tree/implement-basic-goto-implementation
Conversation 12 https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644
Commits 7 https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644/commits
Checks 10 https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644/checks
Files changed https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644/files
Please reload this pagehttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/smheidrich
smheidrichhttps://patch-diff.githubusercontent.com/smheidrich
May 11, 2025https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#issue-3055067486
Please reload this pagehttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644
#97https://github.com/python-lsp/python-lsp-server/issues/97
Goto Implementation Requesthttps://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_implementation
findit.find_implementations on method call finds implementation for different subclass python-rope/rope#812https://github.com/python-rope/rope/issues/812
Add basic Goto Implementation Request support #644 (comment)https://github.com/python-lsp/python-lsp-server/pull/644#discussion_r2085439327
Please reload this pagehttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644
https://patch-diff.githubusercontent.com/smheidrich
smheidrichhttps://patch-diff.githubusercontent.com/smheidrich
force-pushedhttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/compare/282f64b983a9791afa2c6402ebc2745977975b1a..8604c25b5fe65661e05b2ce04a34b097128adddf
282f64bhttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/commit/282f64b983a9791afa2c6402ebc2745977975b1a
8604c25https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/commit/8604c25b5fe65661e05b2ce04a34b097128adddf
Compare https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/compare/282f64b983a9791afa2c6402ebc2745977975b1a..8604c25b5fe65661e05b2ce04a34b097128adddf
May 11, 2025 16:10https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#event-17606016408
smheidrichhttps://patch-diff.githubusercontent.com/smheidrich
May 11, 2025 22:13https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#commits-pushed-84cb3a5
https://patch-diff.githubusercontent.com/smheidrich
Add basic Goto Implementation Request supporthttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644/commits/84cb3a50e1677ad60a213a785ae5e47c499eba61
84cb3a5https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644/commits/84cb3a50e1677ad60a213a785ae5e47c499eba61
https://patch-diff.githubusercontent.com/smheidrich
Add test_implementation based on test_definitionhttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644/commits/b7fb666a45f29a1cf6fc8eb5f3edb841ef26549b
b7fb666https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644/commits/b7fb666a45f29a1cf6fc8eb5f3edb841ef26549b
https://patch-diff.githubusercontent.com/smheidrich
smheidrichhttps://patch-diff.githubusercontent.com/smheidrich
force-pushedhttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/compare/8604c25b5fe65661e05b2ce04a34b097128adddf..6dd3500952697146d3de383b05efead718e3b9f7
8604c25https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/commit/8604c25b5fe65661e05b2ce04a34b097128adddf
6dd3500https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/commit/6dd3500952697146d3de383b05efead718e3b9f7
Compare https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/compare/8604c25b5fe65661e05b2ce04a34b097128adddf..6dd3500952697146d3de383b05efead718e3b9f7
May 11, 2025 20:32https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#event-17606571543
https://patch-diff.githubusercontent.com/smheidrich
Fix test_implementations by using real on-FS filehttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644/commits/41a8852f1b644f209abd5ae07b963d844eaf9ec6
41a8852https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644/commits/41a8852f1b644f209abd5ae07b963d844eaf9ec6
https://patch-diff.githubusercontent.com/smheidrich
smheidrichhttps://patch-diff.githubusercontent.com/smheidrich
force-pushedhttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/compare/6dd3500952697146d3de383b05efead718e3b9f7..41a8852f1b644f209abd5ae07b963d844eaf9ec6
6dd3500https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/commit/6dd3500952697146d3de383b05efead718e3b9f7
41a8852https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/commit/41a8852f1b644f209abd5ae07b963d844eaf9ec6
Compare https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/compare/6dd3500952697146d3de383b05efead718e3b9f7..41a8852f1b644f209abd5ae07b963d844eaf9ec6
May 11, 2025 20:35https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#event-17606576318
https://patch-diff.githubusercontent.com/smheidrich
smheidrichhttps://patch-diff.githubusercontent.com/smheidrich
May 11, 2025 20:38https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#event-17606584461
https://patch-diff.githubusercontent.com/smheidrich
Determine columns for found implementationshttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644/commits/9c715d1475857e143ee6c8c37d73ccd1d08fb852
9c715d1https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644/commits/9c715d1475857e143ee6c8c37d73ccd1d08fb852
https://patch-diff.githubusercontent.com/krassowski
krassowskihttps://patch-diff.githubusercontent.com/krassowski
May 12, 2025 https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#pullrequestreview-2832303576
View reviewed changes https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644/files/9c715d1475857e143ee6c8c37d73ccd1d08fb852
pylsp/plugins/rope_implementation.pyhttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644/files/9c715d1475857e143ee6c8c37d73ccd1d08fb852#diff-85d43805e2c23b5b4a5498444deb830dc3c3671b65379b3ec186377806f003a1
krassowskihttps://patch-diff.githubusercontent.com/krassowski
May 12, 2025https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#discussion_r2084121434
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
python-lsp-server/pylsp/plugins/rope_completion.pyhttps://github.com/python-lsp/python-lsp-server/blob/04fa3e59e82e05a43759f7d3b5bea2fa7a9b539b/pylsp/plugins/rope_completion.py#L59-L65
04fa3e5https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/commit/04fa3e59e82e05a43759f7d3b5bea2fa7a9b539b
Please reload this pagehttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644
smheidrichhttps://patch-diff.githubusercontent.com/smheidrich
May 12, 2025https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#discussion_r2084405400
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644
pylsp/plugins/rope_implementation.pyhttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644/files/9c715d1475857e143ee6c8c37d73ccd1d08fb852#diff-85d43805e2c23b5b4a5498444deb830dc3c3671b65379b3ec186377806f003a1
krassowskihttps://patch-diff.githubusercontent.com/krassowski
May 12, 2025https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#discussion_r2084125939
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644
smheidrichhttps://patch-diff.githubusercontent.com/smheidrich
May 12, 2025https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#discussion_r2084371175
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
already implementedhttps://github.com/python-lsp/python-lsp-server/blob/04fa3e59e82e05a43759f7d3b5bea2fa7a9b539b/pylsp/plugins/definition.py#L44-L47
Please reload this pagehttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644
krassowskihttps://patch-diff.githubusercontent.com/krassowski
May 12, 2025https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#discussion_r2084381989
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644
smheidrichhttps://patch-diff.githubusercontent.com/smheidrich
May 12, 2025https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#discussion_r2085424213
Please reload this pagehttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644
smheidrichhttps://patch-diff.githubusercontent.com/smheidrich
May 12, 2025https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#discussion_r2085489102
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644
smheidrichhttps://patch-diff.githubusercontent.com/smheidrich
May 12, 2025https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#discussion_r2085555182
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
findit.find_implementations on method call finds implementation for different subclass python-rope/rope#812https://github.com/python-rope/rope/issues/812
Please reload this pagehttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644
https://patch-diff.githubusercontent.com/krassowski
krassowskihttps://patch-diff.githubusercontent.com/krassowski
May 12, 2025https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#issuecomment-2871904858
Please reload this pagehttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644
https://patch-diff.githubusercontent.com/smheidrich
smheidrichhttps://patch-diff.githubusercontent.com/smheidrich
May 12, 2025 https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#pullrequestreview-2832711218
View reviewed changes https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644/files/9c715d1475857e143ee6c8c37d73ccd1d08fb852
test/plugins/test_implementations.pyhttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644/files/9c715d1475857e143ee6c8c37d73ccd1d08fb852#diff-598f96328bd7c94dd05afde8d2a238a05af7295226c0c25449a470844a8b3962
Please reload this pagehttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644
smheidrichhttps://patch-diff.githubusercontent.com/smheidrich
May 12, 2025 12:42https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#commits-pushed-c1437e8
https://patch-diff.githubusercontent.com/smheidrich
Add Python 3.8 support for rope_implementationshttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644/commits/c1437e859b0099d2619629c0064e06e1216392d0
c1437e8https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644/commits/c1437e859b0099d2619629c0064e06e1216392d0
https://patch-diff.githubusercontent.com/smheidrich
Handle Rope find_implementations errors explicitlyhttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644/commits/f38d3eff7229ae1e56fb54e68ba41f116075b26e
f38d3efhttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644/commits/f38d3eff7229ae1e56fb54e68ba41f116075b26e
https://patch-diff.githubusercontent.com/smheidrich
Fix linting issues in rope_implementation & testshttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644/commits/b460f312e97de2dfd0f5c6c58559730ca94524c1
b460f31https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644/commits/b460f312e97de2dfd0f5c6c58559730ca94524c1
https://patch-diff.githubusercontent.com/smheidrich
smheidrichhttps://patch-diff.githubusercontent.com/smheidrich
May 12, 2025 https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#pullrequestreview-2834462106
View reviewed changes https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644/files/b460f312e97de2dfd0f5c6c58559730ca94524c1
pylsp/plugins/rope_implementation.pyhttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644/files/b460f312e97de2dfd0f5c6c58559730ca94524c1#diff-85d43805e2c23b5b4a5498444deb830dc3c3671b65379b3ec186377806f003a1
smheidrichhttps://patch-diff.githubusercontent.com/smheidrich
May 12, 2025https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#discussion_r2085439327
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644
https://patch-diff.githubusercontent.com/smheidrich
smheidrichhttps://patch-diff.githubusercontent.com/smheidrich
May 12, 2025 21:03https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#event-17624113259
https://patch-diff.githubusercontent.com/smheidrich
smheidrichhttps://patch-diff.githubusercontent.com/smheidrich
May 12, 2025 https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#ref-issue-3058196681
findit.find_implementations on method call finds implementation for different subclass python-rope/rope#812 https://patch-diff.githubusercontent.com/python-rope/rope/issues/812
https://patch-diff.githubusercontent.com/Hoblovski
Hoblovskihttps://patch-diff.githubusercontent.com/Hoblovski
May 13, 2025 https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#ref-pullrequest-3059844523
Add support for type definition #645 https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/645
Hoblovskihttps://patch-diff.githubusercontent.com/Hoblovski
May 15, 2025 https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#ref-commit-8d868e8
https://patch-diff.githubusercontent.com/Hoblovski
feat: python parser skeleton with custom pylsphttps://patch-diff.githubusercontent.com/cloudwego/abcoder/commit/8d868e80c16438fe79e32452eeba81a8ae624651
8d868e8https://patch-diff.githubusercontent.com/cloudwego/abcoder/commit/8d868e80c16438fe79e32452eeba81a8ae624651
https://github.com/python-lsp/python-lsp-serverhttps://github.com/python-lsp/python-lsp-server
python-lsp/python-lsp-server#645https://github.com/python-lsp/python-lsp-server/pull/645
python-lsp/python-lsp-server#533https://github.com/python-lsp/python-lsp-server/pull/533
python-lsp/python-lsp-server#644https://github.com/python-lsp/python-lsp-server/pull/644
Hoblovskihttps://patch-diff.githubusercontent.com/Hoblovski
Jul 25, 2025 https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#ref-commit-2fe1f71
https://patch-diff.githubusercontent.com/Hoblovski
Custom pylsp is based on [python-lsp-server](https://patch-diff.githubusercontent.com/cloudwego/abcoder/commit/2fe1f71974938fd3daae240b87b4335f876f5934
https://github.com/pytho…https://github.com/python-lsp/python-lsp-server
2fe1f71https://patch-diff.githubusercontent.com/cloudwego/abcoder/commit/2fe1f71974938fd3daae240b87b4335f876f5934
…n-lsp/python-lsp-serverhttps://github.com/python-lsp/python-lsp-server
python-lsp/python-lsp-server#645https://github.com/python-lsp/python-lsp-server/pull/645
python-lsp/python-lsp-server#533https://github.com/python-lsp/python-lsp-server/pull/533
python-lsp/python-lsp-server#644https://github.com/python-lsp/python-lsp-server/pull/644
Hoblovskihttps://patch-diff.githubusercontent.com/Hoblovski
Jul 30, 2025 https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644#ref-commit-3f6c3ed
https://patch-diff.githubusercontent.com/Hoblovski
Custom pylsp is based on [python-lsp-server](https://patch-diff.githubusercontent.com/cloudwego/abcoder/commit/3f6c3ed083fa115a887b6c63bcd215e9ee06d7b9
https://github.com/pytho…https://github.com/python-lsp/python-lsp-server
3f6c3edhttps://patch-diff.githubusercontent.com/cloudwego/abcoder/commit/3f6c3ed083fa115a887b6c63bcd215e9ee06d7b9
…n-lsp/python-lsp-serverhttps://github.com/python-lsp/python-lsp-server
python-lsp/python-lsp-server#645https://github.com/python-lsp/python-lsp-server/pull/645
python-lsp/python-lsp-server#533https://github.com/python-lsp/python-lsp-server/pull/533
python-lsp/python-lsp-server#644https://github.com/python-lsp/python-lsp-server/pull/644
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-lsp%2Fpython-lsp-server%2Fpull%2F644
https://patch-diff.githubusercontent.com/krassowski
krassowski https://patch-diff.githubusercontent.com/krassowski
https://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644/files/9c715d1475857e143ee6c8c37d73ccd1d08fb852
Please reload this pagehttps://patch-diff.githubusercontent.com/python-lsp/python-lsp-server/pull/644
https://patch-diff.githubusercontent.com/smheidrich
https://patch-diff.githubusercontent.com/krassowski
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.