Title: Fix(LDAPObject): Prevent search attrlist memory error by jkoeniger · Pull Request #555 · python-ldap/python-ldap · GitHub
Open Graph Title: Fix(LDAPObject): Prevent search attrlist memory error by jkoeniger · Pull Request #555 · python-ldap/python-ldap
X Title: Fix(LDAPObject): Prevent search attrlist memory error by jkoeniger · Pull Request #555 · python-ldap/python-ldap
Description: Problem Providing a dictionary to attrlist (LDAPObject.search_ext) results in a memory error. See Issue #556 Root cause Function PySequence_Length can return -1 on iterables like dict. The following PyMem_NEW still succeeds due PyMem_NEW(char *, -1 + 1) being equivalent to char** PyMem_Malloc(1), which then can result in a segmentation fault later on. Solution The expected behavior should be either a raised TypeError or that any iterable which contains only strings can be passed. Commit e18c567 enables the latter which is in itself very unlikely to break anything. I would actually prefer to raise a TypeError in the C extension on encountering a dictionary as it is most likely an error on the callers side, maybe we can add that later. The fix in e18c567 is to use seq and PySequence_Fast_GET_SIZE to determine the size of the sequence. This way any iterable which contains only strings can be used. I added two tests in a1bdf47 which will fail without the fix in e18c567.
Open Graph Description: Problem Providing a dictionary to attrlist (LDAPObject.search_ext) results in a memory error. See Issue #556 Root cause Function PySequence_Length can return -1 on iterables like dict. The followin...
X Description: Problem Providing a dictionary to attrlist (LDAPObject.search_ext) results in a memory error. See Issue #556 Root cause Function PySequence_Length can return -1 on iterables like dict. The followin...
Opengraph URL: https://github.com/python-ldap/python-ldap/pull/555
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:9ee586bc-4dcd-cbfd-2149-8391e23c96d9 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | DAFA:49B4D:1130624:15E7823:6975A886 |
| html-safe-nonce | f4b429c4e1d469e0e23c5daecbca1c375d37aebf2d391f8ee969c215d6a75854 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQUZBOjQ5QjREOjExMzA2MjQ6MTVFNzgyMzo2OTc1QTg4NiIsInZpc2l0b3JfaWQiOiI2ODE3ODc4NDA1MDk0NDE4NTY2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a4c817161d10cfde53412fc4900daf8d0986ae14432cdf213d055b8cdbf1c4ed |
| hovercard-subject-tag | pull_request:1667695393 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-ldap/python-ldap/pull/555/checks |
| twitter:image | https://avatars.githubusercontent.com/u/155648714?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/155648714?s=400&v=4 |
| og:image:alt | Problem Providing a dictionary to attrlist (LDAPObject.search_ext) results in a memory error. See Issue #556 Root cause Function PySequence_Length can return -1 on iterables like dict. The followin... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4a4bf5f4e28041a9d2e5c107d7d20b78b4294ba261cab243b28167c16a623a1f |
| turbo-cache-control | no-cache |
| go-import | github.com/python-ldap/python-ldap git https://github.com/python-ldap/python-ldap.git |
| octolytics-dimension-user_id | 33895877 |
| octolytics-dimension-user_login | python-ldap |
| octolytics-dimension-repository_id | 111794776 |
| octolytics-dimension-repository_nwo | python-ldap/python-ldap |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 111794776 |
| octolytics-dimension-repository_network_root_nwo | python-ldap/python-ldap |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 488b30e96dfd057fbbe44c6665ccbc030b729dde |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width