Title: [python-ldap] Add type hints by Alphix · Pull Request #522 · python-ldap/python-ldap · GitHub
Open Graph Title: [python-ldap] Add type hints by Alphix · Pull Request #522 · python-ldap/python-ldap
X Title: [python-ldap] Add type hints by Alphix · Pull Request #522 · python-ldap/python-ldap
Description: With this patch applied, MYPYPATH=/Stubs mypy --strict Lib/ passes without any warnings. tox also passes for everything from py37 to py11 (and also including doc and pypy3). I've tried my best to not make more modifications than strictly necessary. Most of the time, changes merely serve to make life easier for mypy (i.e. to enable type inference) or to fixup non-type aware code. The patch might look dauntingly large, but once you cut away the trivial stuff (untyped function definitions which have been replaced with types ones, lots and lots of new import statements, etc) the diff is actually not that big.
Open Graph Description: With this patch applied, MYPYPATH=/Stubs mypy --strict Lib/ passes without any warnings. tox also passes for everything from py37 to py11 (and also including doc and pypy3). I've tried my best ...
X Description: With this patch applied, MYPYPATH=/Stubs mypy --strict Lib/ passes without any warnings. tox also passes for everything from py37 to py11 (and also including doc and pypy3). I've tried my b...
Opengraph URL: https://github.com/python-ldap/python-ldap/pull/522
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:093056cc-1d7c-58a9-c27f-51f6ce5a1dfb |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | CFB6:10046D:AED9729:E2923F7:69766788 |
| html-safe-nonce | c8466a72a89262616eb5eb3cc546f1f69c11cd6635467665d067dbe114ee22ba |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRkI2OjEwMDQ2RDpBRUQ5NzI5OkUyOTIzRjc6Njk3NjY3ODgiLCJ2aXNpdG9yX2lkIjoiNTY1Mzc0NDc3MTE0MTczMzIwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 0caf912aac153cd9a3a59baaaf6e65bbf4e12cca0e11ad81622873297d835ddb |
| hovercard-subject-tag | pull_request:1351369906 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-ldap/python-ldap/pull/522/checks |
| twitter:image | https://avatars.githubusercontent.com/u/4029895?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4029895?s=400&v=4 |
| og:image:alt | With this patch applied, MYPYPATH=/Stubs mypy --strict Lib/ passes without any warnings. tox also passes for everything from py37 to py11 (and also including doc and pypy3). I've tried my best ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 032152924a283b83384255d9489e7b93b54ba01da8d380b05ecd3953b3212411 |
| turbo-cache-control | no-cache |
| go-import | github.com/python-ldap/python-ldap git https://github.com/python-ldap/python-ldap.git |
| octolytics-dimension-user_id | 33895877 |
| octolytics-dimension-user_login | python-ldap |
| octolytics-dimension-repository_id | 111794776 |
| octolytics-dimension-repository_nwo | python-ldap/python-ldap |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 111794776 |
| octolytics-dimension-repository_network_root_nwo | python-ldap/python-ldap |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5b577f6be6482e336e3c30e8daefa30144947b17 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width