René's URL Explorer Experiment


Title: HTTP20Adapter.close tests (supersedes #307) by KostyaEsmukov · Pull Request #344 · python-hyper/hyper · GitHub

Open Graph Title: HTTP20Adapter.close tests (supersedes #307) by KostyaEsmukov · Pull Request #344 · python-hyper/hyper

X Title: HTTP20Adapter.close tests (supersedes #307) by KostyaEsmukov · Pull Request #344 · python-hyper/hyper

Description: Add close() method implementation to the requests adapter and integration tests for it. Supersedes #307 Related issue: #306

Open Graph Description: Add close() method implementation to the requests adapter and integration tests for it. Supersedes #307 Related issue: #306

X Description: Add close() method implementation to the requests adapter and integration tests for it. Supersedes #307 Related issue: #306

Opengraph URL: https://github.com/python-hyper/hyper/pull/344

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5741d772-4cbc-da34-ba94-b4582f4ad84a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9EB2:294D3B:20055DA:2AE5D89:69705AB3
html-safe-nonce569ada953bc05671a465a59b9869bccb090842ac17ff3023143ea3a2e6c98b71
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUIyOjI5NEQzQjoyMDA1NURBOjJBRTVEODk6Njk3MDVBQjMiLCJ2aXNpdG9yX2lkIjoiNTEyOTI1ODM1MTM1MDI3NDc0MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccbe926e755b59943131ed08731ec7c8bac768381b3974f1958be1fbff5126a62
hovercard-subject-tagpull_request:133234539
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-hyper/hyper/344/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b1d9a0e1473e0e339a0e4c19c9e44a4ee3d48d9a600cc499adc1524181fbe407/python-hyper/hyper/pull/344
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b1d9a0e1473e0e339a0e4c19c9e44a4ee3d48d9a600cc499adc1524181fbe407/python-hyper/hyper/pull/344
og:image:altAdd close() method implementation to the requests adapter and integration tests for it. Supersedes #307 Related issue: #306
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameKostyaEsmukov
hostnamegithub.com
expected-hostnamegithub.com
None9920a62ba22d06470388e2904804fb7e5ec51c9e35f81784e9191394c74b2bd2
turbo-cache-controlno-preview
go-importgithub.com/python-hyper/hyper git https://github.com/python-hyper/hyper.git
octolytics-dimension-user_id13035907
octolytics-dimension-user_loginpython-hyper
octolytics-dimension-repository_id16165969
octolytics-dimension-repository_nwopython-hyper/hyper
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id16165969
octolytics-dimension-repository_network_root_nwopython-hyper/hyper
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7d6181066430cc06553c8396ca201e194ae33cb9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-hyper%2Fhyper%2Fpull%2F344
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-hyper%2Fhyper%2Fpull%2F344
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-hyper%2Fhyper
Reloadhttps://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344
Reloadhttps://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344
Reloadhttps://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344
python-hyper https://patch-diff.githubusercontent.com/python-hyper
hyperhttps://patch-diff.githubusercontent.com/python-hyper/hyper
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-hyper%2Fhyper
Fork 197 https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-hyper%2Fhyper
Star 1k https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-hyper%2Fhyper
Code https://patch-diff.githubusercontent.com/python-hyper/hyper
Issues 78 https://patch-diff.githubusercontent.com/python-hyper/hyper/issues
Pull requests 23 https://patch-diff.githubusercontent.com/python-hyper/hyper/pulls
Actions https://patch-diff.githubusercontent.com/python-hyper/hyper/actions
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/python-hyper/hyper/security
Please reload this pagehttps://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344
Insights https://patch-diff.githubusercontent.com/python-hyper/hyper/pulse
Code https://patch-diff.githubusercontent.com/python-hyper/hyper
Issues https://patch-diff.githubusercontent.com/python-hyper/hyper/issues
Pull requests https://patch-diff.githubusercontent.com/python-hyper/hyper/pulls
Actions https://patch-diff.githubusercontent.com/python-hyper/hyper/actions
Security https://patch-diff.githubusercontent.com/python-hyper/hyper/security
Insights https://patch-diff.githubusercontent.com/python-hyper/hyper/pulse
Lukasahttps://patch-diff.githubusercontent.com/Lukasa
python-hyper:developmenthttps://patch-diff.githubusercontent.com/python-hyper/hyper/tree/development
KostyaEsmukov:pr/requests_closehttps://patch-diff.githubusercontent.com/KostyaEsmukov/hyper/tree/pr/requests_close
HTTP20Adapter.close tests (supersedes #307) https://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344#top
Lukasahttps://patch-diff.githubusercontent.com/Lukasa
python-hyper:developmenthttps://patch-diff.githubusercontent.com/python-hyper/hyper/tree/development
KostyaEsmukov:pr/requests_closehttps://patch-diff.githubusercontent.com/KostyaEsmukov/hyper/tree/pr/requests_close
Conversation 5 https://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344
Commits 4 https://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344/commits
Checks 0 https://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344/checks
Files changed https://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344/files
Please reload this pagehttps://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/python-hyper/hyper/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/KostyaEsmukov
KostyaEsmukovhttps://patch-diff.githubusercontent.com/KostyaEsmukov
Jul 31, 2017https://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344#issue-246741689
Please reload this pagehttps://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344
#307https://github.com/python-hyper/hyper/pull/307
#306https://github.com/python-hyper/hyper/issues/306
Please reload this pagehttps://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344
allanleihttps://patch-diff.githubusercontent.com/allanlei
July 31, 2017 15:03https://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344#commits-pushed-4d292ab
https://patch-diff.githubusercontent.com/allanlei
https://patch-diff.githubusercontent.com/KostyaEsmukov
Implement HTTP20Adapter.close to close connectionshttps://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344/commits/4d292abc1984af220ddf05bdd4e86df0bf2cc699
4d292abhttps://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344/commits/4d292abc1984af220ddf05bdd4e86df0bf2cc699
https://patch-diff.githubusercontent.com/KostyaEsmukov
Make requests adapter close() tests integrationalhttps://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344/commits/92bac67426f28bc251c2f0a7370e9eacd423bba6
92bac67https://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344/commits/92bac67426f28bc251c2f0a7370e9eacd423bba6
https://patch-diff.githubusercontent.com/Lukasa
Lukasahttps://patch-diff.githubusercontent.com/Lukasa
Jul 31, 2017 https://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344#pullrequestreview-53233944
View reviewed changes https://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344/files/92bac67426f28bc251c2f0a7370e9eacd423bba6
Lukasahttps://patch-diff.githubusercontent.com/Lukasa
https://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344#pullrequestreview-53233944
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344
https://patch-diff.githubusercontent.com/KostyaEsmukov
Ensure that connections are actually closed on closing requests adapterhttps://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344/commits/8587eb363de5ae330aa4172fa2e9b49fbb8f63c1
8587eb3https://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344/commits/8587eb363de5ae330aa4172fa2e9b49fbb8f63c1
https://patch-diff.githubusercontent.com/KostyaEsmukov
KostyaEsmukovhttps://patch-diff.githubusercontent.com/KostyaEsmukov
Jul 31, 2017https://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344#issuecomment-319107726
Please reload this pagehttps://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344
https://patch-diff.githubusercontent.com/Lukasa
Lukasahttps://patch-diff.githubusercontent.com/Lukasa
Jul 31, 2017 https://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344#pullrequestreview-53258368
View reviewed changes https://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344/files/8587eb363de5ae330aa4172fa2e9b49fbb8f63c1
test/test_integration.pyhttps://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344/files/8587eb363de5ae330aa4172fa2e9b49fbb8f63c1#diff-3f12d72fb4f7251c22997c345d4866aa01b84aef3c94298248a94749515ff6f3
Lukasahttps://patch-diff.githubusercontent.com/Lukasa
Jul 31, 2017https://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344#discussion_r130388947
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344
test/test_integration.pyhttps://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344/files/8587eb363de5ae330aa4172fa2e9b49fbb8f63c1#diff-3f12d72fb4f7251c22997c345d4866aa01b84aef3c94298248a94749515ff6f3
Lukasahttps://patch-diff.githubusercontent.com/Lukasa
Jul 31, 2017https://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344#discussion_r130389138
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344
https://patch-diff.githubusercontent.com/KostyaEsmukov
Split an assertion in requests adapter close() testshttps://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344/commits/9a4910637fa2cd46326564c8d69e278a9ac35264
9a49106https://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344/commits/9a4910637fa2cd46326564c8d69e278a9ac35264
https://patch-diff.githubusercontent.com/Lukasa
Lukasahttps://patch-diff.githubusercontent.com/Lukasa
Jul 31, 2017 https://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344#pullrequestreview-53284793
View reviewed changes https://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344/files/9a4910637fa2cd46326564c8d69e278a9ac35264
Lukasahttps://patch-diff.githubusercontent.com/Lukasa
https://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344#pullrequestreview-53284793
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344
https://patch-diff.githubusercontent.com/Lukasa
Lukasahttps://patch-diff.githubusercontent.com/Lukasa
669253fhttps://patch-diff.githubusercontent.com/python-hyper/hyper/commit/669253fe136f28ebe160c9db99257937a1c52a1b
Jul 31, 2017https://github.com/python-hyper/hyper/pull/344#event-1186200517
https://patch-diff.githubusercontent.com/KostyaEsmukov
KostyaEsmukovhttps://patch-diff.githubusercontent.com/KostyaEsmukov
September 2, 2017 07:00https://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344#event-1232256157
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-hyper%2Fhyper%2Fpull%2F344
https://patch-diff.githubusercontent.com/Lukasa
Lukasa https://patch-diff.githubusercontent.com/Lukasa
https://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344/files/9a4910637fa2cd46326564c8d69e278a9ac35264
Please reload this pagehttps://patch-diff.githubusercontent.com/python-hyper/hyper/pull/344
https://patch-diff.githubusercontent.com/KostyaEsmukov
https://patch-diff.githubusercontent.com/Lukasa
https://patch-diff.githubusercontent.com/allanlei
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.