Title: Tests requiring internet · Issue #403 · python-hyper/hyper · GitHub
Open Graph Title: Tests requiring internet · Issue #403 · python-hyper/hyper
X Title: Tests requiring internet · Issue #403 · python-hyper/hyper
Description: It looks like the tests are supposed to work without internet, but I found three which didn't in master. My patch to solve it was commit 5525bd1607ed4af5db7e31c89357a54a8b222728 Author: John Vandenberg
Open Graph Description: It looks like the tests are supposed to work without internet, but I found three which didn't in master. My patch to solve it was commit 5525bd1607ed4af5db7e31c89357a54a8b222728 Author: John Vanden...
X Description: It looks like the tests are supposed to work without internet, but I found three which didn't in master. My patch to solve it was commit 5525bd1607ed4af5db7e31c89357a54a8b222728 Author: John Va...
Opengraph URL: https://github.com/python-hyper/hyper/issues/403
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Tests requiring internet","articleBody":"It looks like the tests are supposed to work without internet, but I found three which didn't in master.\r\n\r\nMy patch to solve it was\r\n```\r\ncommit 5525bd1607ed4af5db7e31c89357a54a8b222728\r\nAuthor: John Vandenberg \u003cjayvdb@gmail.com\u003e\r\nDate: Thu Mar 28 19:13:55 2019 +0700\r\n\r\n Mark internet tests\r\n\r\ndiff --git a/test/test_http11.py b/test/test_http11.py\r\nindex 9f3fd3d..12e4360 100644\r\n--- a/test/test_http11.py\r\n+++ b/test/test_http11.py\r\n@@ -544,6 +544,7 @@ class TestHTTP11Connection(object):\r\n \r\n assert received == expected\r\n \r\n+ @pytest.mark.rpmfail_getaddrinfo\r\n def test_exception_raised_for_illegal_body_type(self):\r\n c = HTTP11Connection('httpbin.org')\r\n \r\n@@ -561,6 +562,7 @@ class TestHTTP11Connection(object):\r\n 'returning bytestrings or an iterable of bytestrings. ' \\\r\n 'Got: {}'.format(type(body)) in str(exc_info)\r\n \r\n+ @pytest.mark.rpmfail_getaddrinfo\r\n def test_exception_raised_for_illegal_elements_in_iterable_body(self):\r\n c = HTTP11Connection('httpbin.org')\r\n \r\n@@ -580,6 +582,7 @@ class TestHTTP11Connection(object):\r\n 'element: {}'.format(rogue_element) \\\r\n in str(exc_info)\r\n \r\n+ @pytest.mark.rpmfail_getaddrinfo\r\n def test_exception_raised_for_filelike_body_not_returning_bytes(self):\r\n c = HTTP11Connection('httpbin.org')\r\n \r\n```\r\n\r\nIf they should be working without internet, I've made a mistake somewhere in packaging/testing.\r\n\r\nIf they do need internet, I'd be happy to submit the above patch so that it is easy for packagers to omit them.\r\n\r\nFull rpm spec and patches at https://build.opensuse.org/request/show/689345\r\n\r\nNote that https://github.com/Lukasa/hyper/pull/402 was needed in development and master.","author":{"url":"https://github.com/jayvdb","@type":"Person","name":"jayvdb"},"datePublished":"2019-03-28T13:10:47.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/403/hyper/issues/403"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:a5f10bd4-c9ac-2841-e766-5f642ff2962d |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | AAD6:4969C:22CA71D:2E76F97:69705F28 |
| html-safe-nonce | 25e7efc5b5fe956fdc053f34dcade4d81a0231890be214bdb16661f895a05d6d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQUQ2OjQ5NjlDOjIyQ0E3MUQ6MkU3NkY5Nzo2OTcwNUYyOCIsInZpc2l0b3JfaWQiOiIyMjc5Nzg5NjE5MTA2MDQ1NzM2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | b7b5e3454ec8f2fac0af4aaf809c9316ebf69e8312a97f6aaa26af4e51597f94 |
| hovercard-subject-tag | issue:426483525 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-hyper/hyper/403/issue_layout |
| twitter:image | https://opengraph.githubassets.com/336b8dbfc2214f3057ec6e630b2151204405780daf4ebd1d36cde02bde937458/python-hyper/hyper/issues/403 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/336b8dbfc2214f3057ec6e630b2151204405780daf4ebd1d36cde02bde937458/python-hyper/hyper/issues/403 |
| og:image:alt | It looks like the tests are supposed to work without internet, but I found three which didn't in master. My patch to solve it was commit 5525bd1607ed4af5db7e31c89357a54a8b222728 Author: John Vanden... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jayvdb |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9920a62ba22d06470388e2904804fb7e5ec51c9e35f81784e9191394c74b2bd2 |
| turbo-cache-control | no-preview |
| go-import | github.com/python-hyper/hyper git https://github.com/python-hyper/hyper.git |
| octolytics-dimension-user_id | 13035907 |
| octolytics-dimension-user_login | python-hyper |
| octolytics-dimension-repository_id | 16165969 |
| octolytics-dimension-repository_nwo | python-hyper/hyper |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 16165969 |
| octolytics-dimension-repository_network_root_nwo | python-hyper/hyper |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7d6181066430cc06553c8396ca201e194ae33cb9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width