René's URL Explorer Experiment


Title: Select and comply with all Ruff rules, minus a curated ignore list by nathanjmcdougall · Pull Request #290 · python-grimp/grimp · GitHub

Open Graph Title: Select and comply with all Ruff rules, minus a curated ignore list by nathanjmcdougall · Pull Request #290 · python-grimp/grimp

X Title: Select and comply with all Ruff rules, minus a curated ignore list by nathanjmcdougall · Pull Request #290 · python-grimp/grimp

Description: Continuing from #282 and #284

Open Graph Description: Continuing from #282 and #284

X Description: Continuing from #282 and #284

Opengraph URL: https://github.com/python-grimp/grimp/pull/290

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3b9b27a2-2cf8-ffb4-7baf-a0e296480c80
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA0BC:385565:1452C74:1B190C8:6978071D
html-safe-nonce3bd27fc403ba95e154fef30403abeb6c69e37a7f6799b8acb1f6f69604db6028
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMEJDOjM4NTU2NToxNDUyQzc0OjFCMTkwQzg6Njk3ODA3MUQiLCJ2aXNpdG9yX2lkIjoiMjUwNTg5NTM2Nzc5MDgyMzE5OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7d14c0c3394f1287b8096f3ed254384700671af0abb6d94d2413d25601026446
hovercard-subject-tagpull_request:3115751552
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-grimp/grimp/290/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4052ab49fe96eee121c5f52386b96315cf9f9496a85ea0760cb6223b5c2ec9f5/python-grimp/grimp/pull/290
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4052ab49fe96eee121c5f52386b96315cf9f9496a85ea0760cb6223b5c2ec9f5/python-grimp/grimp/pull/290
og:image:altContinuing from #282 and #284
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamenathanjmcdougall
hostnamegithub.com
expected-hostnamegithub.com
Nonee71ed39771d00f42ce2fc9320895c8c608c164191e118eae487fc3bd0af6886d
turbo-cache-controlno-preview
go-importgithub.com/python-grimp/grimp git https://github.com/python-grimp/grimp.git
octolytics-dimension-user_id239787624
octolytics-dimension-user_loginpython-grimp
octolytics-dimension-repository_id156248550
octolytics-dimension-repository_nwopython-grimp/grimp
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id156248550
octolytics-dimension-repository_network_root_nwopython-grimp/grimp
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4919f24054c1e9bf76d7b543cb2ac018075b18ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-grimp%2Fgrimp%2Fpull%2F290
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-grimp%2Fgrimp%2Fpull%2F290
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-grimp%2Fgrimp
Reloadhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
Reloadhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
Reloadhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
python-grimp https://patch-diff.githubusercontent.com/python-grimp
grimphttps://patch-diff.githubusercontent.com/python-grimp/grimp
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-grimp%2Fgrimp
Fork 22 https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-grimp%2Fgrimp
Star 108 https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-grimp%2Fgrimp
Code https://patch-diff.githubusercontent.com/python-grimp/grimp
Issues 20 https://patch-diff.githubusercontent.com/python-grimp/grimp/issues
Pull requests 4 https://patch-diff.githubusercontent.com/python-grimp/grimp/pulls
Actions https://patch-diff.githubusercontent.com/python-grimp/grimp/actions
Projects 0 https://patch-diff.githubusercontent.com/python-grimp/grimp/projects
Security 0 https://patch-diff.githubusercontent.com/python-grimp/grimp/security
Insights https://patch-diff.githubusercontent.com/python-grimp/grimp/pulse
Code https://patch-diff.githubusercontent.com/python-grimp/grimp
Issues https://patch-diff.githubusercontent.com/python-grimp/grimp/issues
Pull requests https://patch-diff.githubusercontent.com/python-grimp/grimp/pulls
Actions https://patch-diff.githubusercontent.com/python-grimp/grimp/actions
Projects https://patch-diff.githubusercontent.com/python-grimp/grimp/projects
Security https://patch-diff.githubusercontent.com/python-grimp/grimp/security
Insights https://patch-diff.githubusercontent.com/python-grimp/grimp/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fpython-grimp%2Fgrimp%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fpython-grimp%2Fgrimp%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#issue-comment-box
seddonymhttps://patch-diff.githubusercontent.com/seddonym
python-grimp:mainhttps://patch-diff.githubusercontent.com/python-grimp/grimp/tree/main
nathanjmcdougall:refactor/enable-strict-ruff-confighttps://patch-diff.githubusercontent.com/nathanjmcdougall/grimp/tree/refactor/enable-strict-ruff-config
Select and comply with all Ruff rules, minus a curated ignore list https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#top
seddonymhttps://patch-diff.githubusercontent.com/seddonym
python-grimp:mainhttps://patch-diff.githubusercontent.com/python-grimp/grimp/tree/main
nathanjmcdougall:refactor/enable-strict-ruff-confighttps://patch-diff.githubusercontent.com/nathanjmcdougall/grimp/tree/refactor/enable-strict-ruff-config
Conversation 33 https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
Commits 12 https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits
Checks 18 https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/checks
Files changed https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/nathanjmcdougall
nathanjmcdougallhttps://patch-diff.githubusercontent.com/nathanjmcdougall
Dec 19, 2025https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#issue-3745400891
#282https://github.com/python-grimp/grimp/pull/282
#284https://github.com/python-grimp/grimp/pull/284
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
https://patch-diff.githubusercontent.com/nathanjmcdougall
Select and comply with all Ruff rules, minus a curated ignore listhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/5588928fa4b9bf8981988c33e18ee5051f99815a
5588928https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/5588928fa4b9bf8981988c33e18ee5051f99815a
https://patch-diff.githubusercontent.com/nathanjmcdougall
nathanjmcdougallhttps://patch-diff.githubusercontent.com/nathanjmcdougall
Dec 19, 2025 https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3595842952
View reviewed changes https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a
pyproject.tomlhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
https://patch-diff.githubusercontent.com/nathanjmcdougall
nathanjmcdougallhttps://patch-diff.githubusercontent.com/nathanjmcdougall
Dec 19, 2025 https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3595844911
View reviewed changes https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a
pyproject.tomlhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
https://patch-diff.githubusercontent.com/nathanjmcdougall
nathanjmcdougallhttps://patch-diff.githubusercontent.com/nathanjmcdougall
Dec 19, 2025 https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3595845625
View reviewed changes https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a
src/grimp/adaptors/caching.pyhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-75516d8901a8861f47159a258dbc8e60555b7f6c1fcb4f70c3cb5128b77d4832
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
https://patch-diff.githubusercontent.com/nathanjmcdougall
nathanjmcdougallhttps://patch-diff.githubusercontent.com/nathanjmcdougall
Dec 19, 2025 https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3595849496
View reviewed changes https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a
pyproject.tomlhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
https://patch-diff.githubusercontent.com/nathanjmcdougall
nathanjmcdougallhttps://patch-diff.githubusercontent.com/nathanjmcdougall
Dec 19, 2025 https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3595855672
View reviewed changes https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a
src/grimp/adaptors/caching.pyhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-75516d8901a8861f47159a258dbc8e60555b7f6c1fcb4f70c3cb5128b77d4832
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
https://patch-diff.githubusercontent.com/apps/codspeed-hq
codspeed-hqhttps://patch-diff.githubusercontent.com/apps/codspeed-hq
Dec 19, 2025https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#issuecomment-3672858365
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
CodSpeed Performance Reporthttps://codspeed.io/python-grimp/grimp/branches/nathanjmcdougall%3Arefactor%2Fenable-strict-ruff-config?utm_source=github&utm_medium=comment&utm_content=header
#290https://github.com/python-grimp/grimp/pull/290
2681042https://github.com/python-grimp/grimp/commit/26810427985d65cad6098327f32745712686527f
7fc49c4https://github.com/python-grimp/grimp/commit/7fc49c471f3f569560a57439c376348ad25d8e1e
1https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#user-content-fn-skipped-7c3337f12220859854889146d871a484
click here and archive them to remove them from the performance reportshttps://codspeed.io/python-grimp/grimp/branches/nathanjmcdougall%3Arefactor%2Fenable-strict-ruff-config?sectionId=benchmark-comparison-section-baseline-result-skipped&utm_source=github&utm_medium=comment&utm_content=archive
https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#user-content-fnref-skipped-7c3337f12220859854889146d871a484
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
https://patch-diff.githubusercontent.com/nathanjmcdougall
nathanjmcdougallhttps://patch-diff.githubusercontent.com/nathanjmcdougall
Dec 19, 2025 https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3595857631
View reviewed changes https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a
src/grimp/adaptors/caching.pyhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-75516d8901a8861f47159a258dbc8e60555b7f6c1fcb4f70c3cb5128b77d4832
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
https://patch-diff.githubusercontent.com/nathanjmcdougall
nathanjmcdougallhttps://patch-diff.githubusercontent.com/nathanjmcdougall
Dec 19, 2025 https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3595859035
View reviewed changes https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a
src/grimp/adaptors/modulefinder.pyhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-e0a9bb06036b56119d083a57255a819d6ea4f5bec05b34ed3656d0feb62bfd2b
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
https://patch-diff.githubusercontent.com/nathanjmcdougall
Remove hyphens from docstringhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/c390810732164374c72f479901717ba1b64e352b
c390810https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/c390810732164374c72f479901717ba1b64e352b
https://patch-diff.githubusercontent.com/nathanjmcdougall
nathanjmcdougallhttps://patch-diff.githubusercontent.com/nathanjmcdougall
Dec 19, 2025 https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3595864986
View reviewed changes https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a
src/grimp/adaptors/packagefinder.pyhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-661ef5d5cfd3dce73953b820fa3ef4537972605a38d22a7052a15336874e9304
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
https://patch-diff.githubusercontent.com/nathanjmcdougall
nathanjmcdougallhttps://patch-diff.githubusercontent.com/nathanjmcdougall
Dec 19, 2025 https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3595867446
View reviewed changes https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a
src/grimp/application/config.pyhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-c5de75429d8c71928e05cf2ab81d39cfe2b4a99ba129dbab6eeb2377afa10242
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
https://patch-diff.githubusercontent.com/nathanjmcdougall
Improve docstring format for find_illegal_dependencies_for_layershttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/ed6dbd73d12cf04bbd0fb5db4154a0c85ba0d9a1
ed6dbd7https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/ed6dbd73d12cf04bbd0fb5db4154a0c85ba0d9a1
https://patch-diff.githubusercontent.com/nathanjmcdougall
nathanjmcdougallhttps://patch-diff.githubusercontent.com/nathanjmcdougall
Dec 19, 2025 https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3595902369
View reviewed changes https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a
tests/unit/application/graph/test_layers.pyhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-6ed5914f354751dc4f4b5a3190d7db32ea6c33118556f5f0e02c996fa36a3fe6
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
https://patch-diff.githubusercontent.com/seddonym
seddonymhttps://patch-diff.githubusercontent.com/seddonym
Dec 19, 2025 https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3597838425
View reviewed changes https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/ed6dbd73d12cf04bbd0fb5db4154a0c85ba0d9a1
seddonymhttps://patch-diff.githubusercontent.com/seddonym
https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3597838425
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
src/grimp/adaptors/caching.pyhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-75516d8901a8861f47159a258dbc8e60555b7f6c1fcb4f70c3cb5128b77d4832
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
src/grimp/adaptors/caching.pyhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-75516d8901a8861f47159a258dbc8e60555b7f6c1fcb4f70c3cb5128b77d4832
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
src/grimp/adaptors/caching.pyhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-75516d8901a8861f47159a258dbc8e60555b7f6c1fcb4f70c3cb5128b77d4832
seddonymhttps://patch-diff.githubusercontent.com/seddonym
Dec 19, 2025https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#discussion_r2634446190
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
src/grimp/adaptors/modulefinder.pyhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-e0a9bb06036b56119d083a57255a819d6ea4f5bec05b34ed3656d0feb62bfd2b
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
src/grimp/adaptors/caching.pyhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-75516d8901a8861f47159a258dbc8e60555b7f6c1fcb4f70c3cb5128b77d4832
seddonymhttps://patch-diff.githubusercontent.com/seddonym
Dec 19, 2025https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#discussion_r2634468938
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
nathanjmcdougallhttps://patch-diff.githubusercontent.com/nathanjmcdougall
Dec 19, 2025https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#discussion_r2636221343
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://docs.astral.sh/ruff/rules/#flake8-type-checking-tchttps://docs.astral.sh/ruff/rules/#flake8-type-checking-tc
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
src/grimp/application/graph.pyhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-c4551a4c05cfed3894f52047c2d9ce884a0c82cb34ccd76c0258eccc2733c3aa
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
src/grimp/application/graph.pyhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-c4551a4c05cfed3894f52047c2d9ce884a0c82cb34ccd76c0258eccc2733c3aa
seddonymhttps://patch-diff.githubusercontent.com/seddonym
Dec 19, 2025https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#discussion_r2634495634
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
nathanjmcdougallhttps://patch-diff.githubusercontent.com/nathanjmcdougall
Dec 19, 2025https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#discussion_r2636232404
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
pyproject.tomlhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
pyproject.tomlhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
pyproject.tomlhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
nathanjmcdougallhttps://patch-diff.githubusercontent.com/nathanjmcdougall
December 20, 2025 09:01https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#commits-pushed-f5a681e
https://patch-diff.githubusercontent.com/nathanjmcdougall
Migrate config to ruff.toml and add comments regarding the reasons …https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/f5a681e6f82e6b7a5103ed956ba5ea509559dfe0
f5a681ehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/f5a681e6f82e6b7a5103ed956ba5ea509559dfe0
https://patch-diff.githubusercontent.com/nathanjmcdougall
Merge remote-tracking branch 'upstream/main' into refactor/enable-str…https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/87960276253ff6acd27a74a6c1aa138ba6410d11
8796027https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/87960276253ff6acd27a74a6c1aa138ba6410d11
https://patch-diff.githubusercontent.com/nathanjmcdougall
Ignore S101 rule and revert associated changeshttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/716b13ba2a5c7c75cde11253b89f9f90ebe9097c
716b13bhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/716b13ba2a5c7c75cde11253b89f9f90ebe9097c
https://patch-diff.githubusercontent.com/nathanjmcdougall
Use exception chaining in some cases, use consistent naming e -> exchttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/44ee64df3fed9b0c3d0a69eafeab5265e36b318f
44ee64dhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/44ee64df3fed9b0c3d0a69eafeab5265e36b318f
https://patch-diff.githubusercontent.com/nathanjmcdougall
Disable PYI025 rule and revert aliasing i.e. AbstractSet -> Sethttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/f36e56fbe1b123d4d3acaa4ffbd8b776c81168f0
f36e56fhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/f36e56fbe1b123d4d3acaa4ffbd8b776c81168f0
https://patch-diff.githubusercontent.com/nathanjmcdougall
Revert TC001, TC002, TC003 rule compliance (TYPE_CHECKING guards)https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/842ab5e2943eda2d9ede90d0a39312118ca25f54
842ab5ehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/842ab5e2943eda2d9ede90d0a39312118ca25f54
https://patch-diff.githubusercontent.com/nathanjmcdougall
nathanjmcdougallhttps://patch-diff.githubusercontent.com/nathanjmcdougall
Dec 19, 2025 https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3600035908
View reviewed changes https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/842ab5e2943eda2d9ede90d0a39312118ca25f54
src/grimp/exceptions.pyhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/842ab5e2943eda2d9ede90d0a39312118ca25f54#diff-c43f432b19de3766f7be9ed2905165980c514f511c24a9b4bb07d8a1e9a403ce
nathanjmcdougallhttps://patch-diff.githubusercontent.com/nathanjmcdougall
Dec 19, 2025https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#discussion_r2636241674
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#276https://github.com/python-grimp/grimp/pull/276
https://docs.astral.sh/ruff/rules/private-member-access/https://docs.astral.sh/ruff/rules/private-member-access/
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
https://patch-diff.githubusercontent.com/nathanjmcdougall
nathanjmcdougallhttps://patch-diff.githubusercontent.com/nathanjmcdougall
seddonymhttps://patch-diff.githubusercontent.com/seddonym
December 19, 2025 20:39https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#event-21678235121
https://patch-diff.githubusercontent.com/nathanjmcdougall
Add match arg in pytest.warns for DeprecationWarning of `Namesp…https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/a1811064fe9c686b379c39795b85763fa632b7ba
a181106https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/a1811064fe9c686b379c39795b85763fa632b7ba
https://patch-diff.githubusercontent.com/nathanjmcdougall
nathanjmcdougallhttps://patch-diff.githubusercontent.com/nathanjmcdougall
Dec 19, 2025 https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#ref-pullrequest-3748826637
Add match arg in pytest.warns for DeprecationWarning #291 https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/291
nathanjmcdougallhttps://patch-diff.githubusercontent.com/nathanjmcdougall
December 20, 2025 09:49https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#commits-pushed-76c1335
https://patch-diff.githubusercontent.com/nathanjmcdougall
Merge branch 'fix/comply-with-ruff-rule-for-namespace-deprec' into re…https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/76c1335ed1254e0cf37fe1a6a226784d4bd1e06b
76c1335https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/76c1335ed1254e0cf37fe1a6a226784d4bd1e06b
https://patch-diff.githubusercontent.com/nathanjmcdougall
Merge branch 'main' into refactor/enable-strict-ruff-confighttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/26810427985d65cad6098327f32745712686527f
2681042https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/26810427985d65cad6098327f32745712686527f
https://patch-diff.githubusercontent.com/seddonym
seddonymhttps://patch-diff.githubusercontent.com/seddonym
Dec 22, 2025 https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3603790884
View reviewed changes https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/26810427985d65cad6098327f32745712686527f
seddonymhttps://patch-diff.githubusercontent.com/seddonym
https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3603790884
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
ruff.tomlhttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/26810427985d65cad6098327f32745712686527f#diff-26f436cb29eecc7bb4f9066747b43df8da81ac808955ce95c109f5d7aa778989
seddonymhttps://patch-diff.githubusercontent.com/seddonym
Dec 22, 2025https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#discussion_r2639642231
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
https://patch-diff.githubusercontent.com/seddonym
seddonymhttps://patch-diff.githubusercontent.com/seddonym
ea65558https://patch-diff.githubusercontent.com/python-grimp/grimp/commit/ea6555866acf36830cba19a9af3292445cb2afb5
Dec 22, 2025https://github.com/python-grimp/grimp/pull/290#event-21703304741
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-grimp%2Fgrimp%2Fpull%2F290
https://patch-diff.githubusercontent.com/seddonym
seddonym https://patch-diff.githubusercontent.com/seddonym
https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/26810427985d65cad6098327f32745712686527f
Please reload this pagehttps://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290
https://patch-diff.githubusercontent.com/nathanjmcdougall
https://patch-diff.githubusercontent.com/seddonym
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.