| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3b9b27a2-2cf8-ffb4-7baf-a0e296480c80 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A0BC:385565:1452C74:1B190C8:6978071D |
| html-safe-nonce | 3bd27fc403ba95e154fef30403abeb6c69e37a7f6799b8acb1f6f69604db6028 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMEJDOjM4NTU2NToxNDUyQzc0OjFCMTkwQzg6Njk3ODA3MUQiLCJ2aXNpdG9yX2lkIjoiMjUwNTg5NTM2Nzc5MDgyMzE5OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7d14c0c3394f1287b8096f3ed254384700671af0abb6d94d2413d25601026446 |
| hovercard-subject-tag | pull_request:3115751552 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-grimp/grimp/290/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4052ab49fe96eee121c5f52386b96315cf9f9496a85ea0760cb6223b5c2ec9f5/python-grimp/grimp/pull/290 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4052ab49fe96eee121c5f52386b96315cf9f9496a85ea0760cb6223b5c2ec9f5/python-grimp/grimp/pull/290 |
| og:image:alt | Continuing from #282 and #284 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | nathanjmcdougall |
| hostname | github.com |
| expected-hostname | github.com |
| None | e71ed39771d00f42ce2fc9320895c8c608c164191e118eae487fc3bd0af6886d |
| turbo-cache-control | no-preview |
| go-import | github.com/python-grimp/grimp git https://github.com/python-grimp/grimp.git |
| octolytics-dimension-user_id | 239787624 |
| octolytics-dimension-user_login | python-grimp |
| octolytics-dimension-repository_id | 156248550 |
| octolytics-dimension-repository_nwo | python-grimp/grimp |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 156248550 |
| octolytics-dimension-repository_network_root_nwo | python-grimp/grimp |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4919f24054c1e9bf76d7b543cb2ac018075b18ce |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-grimp%2Fgrimp%2Fpull%2F290 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-grimp%2Fgrimp%2Fpull%2F290 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-grimp%2Fgrimp |
| Reload | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| Reload | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| Reload | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
|
python-grimp
| https://patch-diff.githubusercontent.com/python-grimp |
| grimp | https://patch-diff.githubusercontent.com/python-grimp/grimp |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-grimp%2Fgrimp |
|
Fork
22
| https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-grimp%2Fgrimp |
|
Star
108
| https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-grimp%2Fgrimp |
|
Code
| https://patch-diff.githubusercontent.com/python-grimp/grimp |
|
Issues
20
| https://patch-diff.githubusercontent.com/python-grimp/grimp/issues |
|
Pull requests
4
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/python-grimp/grimp/actions |
|
Projects
0
| https://patch-diff.githubusercontent.com/python-grimp/grimp/projects |
|
Security
0
| https://patch-diff.githubusercontent.com/python-grimp/grimp/security |
|
Insights
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pulse |
|
Code
| https://patch-diff.githubusercontent.com/python-grimp/grimp |
|
Issues
| https://patch-diff.githubusercontent.com/python-grimp/grimp/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/python-grimp/grimp/actions |
|
Projects
| https://patch-diff.githubusercontent.com/python-grimp/grimp/projects |
|
Security
| https://patch-diff.githubusercontent.com/python-grimp/grimp/security |
|
Insights
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pulse |
| Sign up for GitHub
| https://patch-diff.githubusercontent.com/signup?return_to=%2Fpython-grimp%2Fgrimp%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-grimp%2Fgrimp%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#issue-comment-box |
| seddonym | https://patch-diff.githubusercontent.com/seddonym |
| python-grimp:main | https://patch-diff.githubusercontent.com/python-grimp/grimp/tree/main |
| nathanjmcdougall:refactor/enable-strict-ruff-config | https://patch-diff.githubusercontent.com/nathanjmcdougall/grimp/tree/refactor/enable-strict-ruff-config |
|
Select and comply with all Ruff rules, minus a curated ignore list
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#top |
| seddonym | https://patch-diff.githubusercontent.com/seddonym |
| python-grimp:main | https://patch-diff.githubusercontent.com/python-grimp/grimp/tree/main |
| nathanjmcdougall:refactor/enable-strict-ruff-config | https://patch-diff.githubusercontent.com/nathanjmcdougall/grimp/tree/refactor/enable-strict-ruff-config |
|
Conversation
33
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
|
Commits
12
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits |
|
Checks
18
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/checks |
|
Files changed
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/nathanjmcdougall |
| nathanjmcdougall | https://patch-diff.githubusercontent.com/nathanjmcdougall |
| Dec 19, 2025 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#issue-3745400891 |
| #282 | https://github.com/python-grimp/grimp/pull/282 |
| #284 | https://github.com/python-grimp/grimp/pull/284 |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
|
| https://patch-diff.githubusercontent.com/nathanjmcdougall |
| Select and comply with all Ruff rules, minus a curated ignore list | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/5588928fa4b9bf8981988c33e18ee5051f99815a |
| 5588928 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/5588928fa4b9bf8981988c33e18ee5051f99815a |
| https://patch-diff.githubusercontent.com/nathanjmcdougall |
| nathanjmcdougall | https://patch-diff.githubusercontent.com/nathanjmcdougall |
|
Dec 19, 2025
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3595842952 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a |
| pyproject.toml | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711 |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| https://patch-diff.githubusercontent.com/nathanjmcdougall |
| nathanjmcdougall | https://patch-diff.githubusercontent.com/nathanjmcdougall |
|
Dec 19, 2025
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3595844911 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a |
| pyproject.toml | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711 |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| https://patch-diff.githubusercontent.com/nathanjmcdougall |
| nathanjmcdougall | https://patch-diff.githubusercontent.com/nathanjmcdougall |
|
Dec 19, 2025
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3595845625 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a |
| src/grimp/adaptors/caching.py | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-75516d8901a8861f47159a258dbc8e60555b7f6c1fcb4f70c3cb5128b77d4832 |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| https://patch-diff.githubusercontent.com/nathanjmcdougall |
| nathanjmcdougall | https://patch-diff.githubusercontent.com/nathanjmcdougall |
|
Dec 19, 2025
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3595849496 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a |
| pyproject.toml | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711 |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| https://patch-diff.githubusercontent.com/nathanjmcdougall |
| nathanjmcdougall | https://patch-diff.githubusercontent.com/nathanjmcdougall |
|
Dec 19, 2025
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3595855672 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a |
| src/grimp/adaptors/caching.py | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-75516d8901a8861f47159a258dbc8e60555b7f6c1fcb4f70c3cb5128b77d4832 |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| https://patch-diff.githubusercontent.com/apps/codspeed-hq |
| codspeed-hq | https://patch-diff.githubusercontent.com/apps/codspeed-hq |
| Dec 19, 2025 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#issuecomment-3672858365 |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| CodSpeed Performance Report | https://codspeed.io/python-grimp/grimp/branches/nathanjmcdougall%3Arefactor%2Fenable-strict-ruff-config?utm_source=github&utm_medium=comment&utm_content=header |
| #290 | https://github.com/python-grimp/grimp/pull/290 |
| 2681042 | https://github.com/python-grimp/grimp/commit/26810427985d65cad6098327f32745712686527f |
| 7fc49c4 | https://github.com/python-grimp/grimp/commit/7fc49c471f3f569560a57439c376348ad25d8e1e |
| 1 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#user-content-fn-skipped-7c3337f12220859854889146d871a484 |
| click here and archive them to remove them from the performance reports | https://codspeed.io/python-grimp/grimp/branches/nathanjmcdougall%3Arefactor%2Fenable-strict-ruff-config?sectionId=benchmark-comparison-section-baseline-result-skipped&utm_source=github&utm_medium=comment&utm_content=archive |
| ↩ | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#user-content-fnref-skipped-7c3337f12220859854889146d871a484 |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| https://patch-diff.githubusercontent.com/nathanjmcdougall |
| nathanjmcdougall | https://patch-diff.githubusercontent.com/nathanjmcdougall |
|
Dec 19, 2025
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3595857631 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a |
| src/grimp/adaptors/caching.py | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-75516d8901a8861f47159a258dbc8e60555b7f6c1fcb4f70c3cb5128b77d4832 |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| https://patch-diff.githubusercontent.com/nathanjmcdougall |
| nathanjmcdougall | https://patch-diff.githubusercontent.com/nathanjmcdougall |
|
Dec 19, 2025
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3595859035 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a |
| src/grimp/adaptors/modulefinder.py | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-e0a9bb06036b56119d083a57255a819d6ea4f5bec05b34ed3656d0feb62bfd2b |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
|
| https://patch-diff.githubusercontent.com/nathanjmcdougall |
| Remove hyphens from docstring | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/c390810732164374c72f479901717ba1b64e352b |
| c390810 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/c390810732164374c72f479901717ba1b64e352b |
| https://patch-diff.githubusercontent.com/nathanjmcdougall |
| nathanjmcdougall | https://patch-diff.githubusercontent.com/nathanjmcdougall |
|
Dec 19, 2025
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3595864986 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a |
| src/grimp/adaptors/packagefinder.py | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-661ef5d5cfd3dce73953b820fa3ef4537972605a38d22a7052a15336874e9304 |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| https://patch-diff.githubusercontent.com/nathanjmcdougall |
| nathanjmcdougall | https://patch-diff.githubusercontent.com/nathanjmcdougall |
|
Dec 19, 2025
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3595867446 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a |
| src/grimp/application/config.py | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-c5de75429d8c71928e05cf2ab81d39cfe2b4a99ba129dbab6eeb2377afa10242 |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
|
| https://patch-diff.githubusercontent.com/nathanjmcdougall |
| Improve docstring format for find_illegal_dependencies_for_layers | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/ed6dbd73d12cf04bbd0fb5db4154a0c85ba0d9a1 |
| ed6dbd7 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/ed6dbd73d12cf04bbd0fb5db4154a0c85ba0d9a1 |
| https://patch-diff.githubusercontent.com/nathanjmcdougall |
| nathanjmcdougall | https://patch-diff.githubusercontent.com/nathanjmcdougall |
|
Dec 19, 2025
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3595902369 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a |
| tests/unit/application/graph/test_layers.py | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-6ed5914f354751dc4f4b5a3190d7db32ea6c33118556f5f0e02c996fa36a3fe6 |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| https://patch-diff.githubusercontent.com/seddonym |
| seddonym | https://patch-diff.githubusercontent.com/seddonym |
|
Dec 19, 2025
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3597838425 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/ed6dbd73d12cf04bbd0fb5db4154a0c85ba0d9a1 |
| seddonym | https://patch-diff.githubusercontent.com/seddonym |
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3597838425 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| src/grimp/adaptors/caching.py | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-75516d8901a8861f47159a258dbc8e60555b7f6c1fcb4f70c3cb5128b77d4832 |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| src/grimp/adaptors/caching.py | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-75516d8901a8861f47159a258dbc8e60555b7f6c1fcb4f70c3cb5128b77d4832 |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| src/grimp/adaptors/caching.py | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-75516d8901a8861f47159a258dbc8e60555b7f6c1fcb4f70c3cb5128b77d4832 |
| seddonym | https://patch-diff.githubusercontent.com/seddonym |
| Dec 19, 2025 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#discussion_r2634446190 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| src/grimp/adaptors/modulefinder.py | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-e0a9bb06036b56119d083a57255a819d6ea4f5bec05b34ed3656d0feb62bfd2b |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| src/grimp/adaptors/caching.py | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-75516d8901a8861f47159a258dbc8e60555b7f6c1fcb4f70c3cb5128b77d4832 |
| seddonym | https://patch-diff.githubusercontent.com/seddonym |
| Dec 19, 2025 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#discussion_r2634468938 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| nathanjmcdougall | https://patch-diff.githubusercontent.com/nathanjmcdougall |
| Dec 19, 2025 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#discussion_r2636221343 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://docs.astral.sh/ruff/rules/#flake8-type-checking-tc | https://docs.astral.sh/ruff/rules/#flake8-type-checking-tc |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| src/grimp/application/graph.py | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-c4551a4c05cfed3894f52047c2d9ce884a0c82cb34ccd76c0258eccc2733c3aa |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| src/grimp/application/graph.py | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-c4551a4c05cfed3894f52047c2d9ce884a0c82cb34ccd76c0258eccc2733c3aa |
| seddonym | https://patch-diff.githubusercontent.com/seddonym |
| Dec 19, 2025 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#discussion_r2634495634 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| nathanjmcdougall | https://patch-diff.githubusercontent.com/nathanjmcdougall |
| Dec 19, 2025 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#discussion_r2636232404 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| pyproject.toml | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711 |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| pyproject.toml | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711 |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| pyproject.toml | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/5588928fa4b9bf8981988c33e18ee5051f99815a#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711 |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| nathanjmcdougall | https://patch-diff.githubusercontent.com/nathanjmcdougall |
| December 20, 2025 09:01 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#commits-pushed-f5a681e |
|
| https://patch-diff.githubusercontent.com/nathanjmcdougall |
| Migrate config to ruff.toml and add comments regarding the reasons … | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/f5a681e6f82e6b7a5103ed956ba5ea509559dfe0 |
| f5a681e | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/f5a681e6f82e6b7a5103ed956ba5ea509559dfe0 |
|
| https://patch-diff.githubusercontent.com/nathanjmcdougall |
| Merge remote-tracking branch 'upstream/main' into refactor/enable-str… | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/87960276253ff6acd27a74a6c1aa138ba6410d11 |
| 8796027 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/87960276253ff6acd27a74a6c1aa138ba6410d11 |
|
| https://patch-diff.githubusercontent.com/nathanjmcdougall |
| Ignore S101 rule and revert associated changes | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/716b13ba2a5c7c75cde11253b89f9f90ebe9097c |
| 716b13b | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/716b13ba2a5c7c75cde11253b89f9f90ebe9097c |
|
| https://patch-diff.githubusercontent.com/nathanjmcdougall |
| Use exception chaining in some cases, use consistent naming e -> exc | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/44ee64df3fed9b0c3d0a69eafeab5265e36b318f |
| 44ee64d | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/44ee64df3fed9b0c3d0a69eafeab5265e36b318f |
|
| https://patch-diff.githubusercontent.com/nathanjmcdougall |
| Disable PYI025 rule and revert aliasing i.e. AbstractSet -> Set | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/f36e56fbe1b123d4d3acaa4ffbd8b776c81168f0 |
| f36e56f | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/f36e56fbe1b123d4d3acaa4ffbd8b776c81168f0 |
|
| https://patch-diff.githubusercontent.com/nathanjmcdougall |
| Revert TC001, TC002, TC003 rule compliance (TYPE_CHECKING guards) | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/842ab5e2943eda2d9ede90d0a39312118ca25f54 |
| 842ab5e | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/842ab5e2943eda2d9ede90d0a39312118ca25f54 |
| https://patch-diff.githubusercontent.com/nathanjmcdougall |
| nathanjmcdougall | https://patch-diff.githubusercontent.com/nathanjmcdougall |
|
Dec 19, 2025
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3600035908 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/842ab5e2943eda2d9ede90d0a39312118ca25f54 |
| src/grimp/exceptions.py | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/842ab5e2943eda2d9ede90d0a39312118ca25f54#diff-c43f432b19de3766f7be9ed2905165980c514f511c24a9b4bb07d8a1e9a403ce |
| nathanjmcdougall | https://patch-diff.githubusercontent.com/nathanjmcdougall |
| Dec 19, 2025 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#discussion_r2636241674 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #276 | https://github.com/python-grimp/grimp/pull/276 |
| https://docs.astral.sh/ruff/rules/private-member-access/ | https://docs.astral.sh/ruff/rules/private-member-access/ |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| https://patch-diff.githubusercontent.com/nathanjmcdougall |
| nathanjmcdougall | https://patch-diff.githubusercontent.com/nathanjmcdougall |
| seddonym | https://patch-diff.githubusercontent.com/seddonym |
| December 19, 2025 20:39 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#event-21678235121 |
|
| https://patch-diff.githubusercontent.com/nathanjmcdougall |
| Add match arg in pytest.warns for DeprecationWarning of `Namesp… | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/a1811064fe9c686b379c39795b85763fa632b7ba |
| a181106 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/a1811064fe9c686b379c39795b85763fa632b7ba |
| https://patch-diff.githubusercontent.com/nathanjmcdougall |
| nathanjmcdougall | https://patch-diff.githubusercontent.com/nathanjmcdougall |
|
Dec 19, 2025
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#ref-pullrequest-3748826637 |
|
Add match arg in pytest.warns for DeprecationWarning
#291
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/291 |
| nathanjmcdougall | https://patch-diff.githubusercontent.com/nathanjmcdougall |
| December 20, 2025 09:49 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#commits-pushed-76c1335 |
|
| https://patch-diff.githubusercontent.com/nathanjmcdougall |
| Merge branch 'fix/comply-with-ruff-rule-for-namespace-deprec' into re… | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/76c1335ed1254e0cf37fe1a6a226784d4bd1e06b |
| 76c1335 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/76c1335ed1254e0cf37fe1a6a226784d4bd1e06b |
|
| https://patch-diff.githubusercontent.com/nathanjmcdougall |
| Merge branch 'main' into refactor/enable-strict-ruff-config | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/26810427985d65cad6098327f32745712686527f |
| 2681042 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/commits/26810427985d65cad6098327f32745712686527f |
| https://patch-diff.githubusercontent.com/seddonym |
| seddonym | https://patch-diff.githubusercontent.com/seddonym |
|
Dec 22, 2025
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3603790884 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/26810427985d65cad6098327f32745712686527f |
| seddonym | https://patch-diff.githubusercontent.com/seddonym |
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#pullrequestreview-3603790884 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| ruff.toml | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/26810427985d65cad6098327f32745712686527f#diff-26f436cb29eecc7bb4f9066747b43df8da81ac808955ce95c109f5d7aa778989 |
| seddonym | https://patch-diff.githubusercontent.com/seddonym |
| Dec 22, 2025 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290#discussion_r2639642231 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| https://patch-diff.githubusercontent.com/seddonym |
| seddonym | https://patch-diff.githubusercontent.com/seddonym |
| ea65558 | https://patch-diff.githubusercontent.com/python-grimp/grimp/commit/ea6555866acf36830cba19a9af3292445cb2afb5 |
| Dec 22, 2025 | https://github.com/python-grimp/grimp/pull/290#event-21703304741 |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in to comment | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-grimp%2Fgrimp%2Fpull%2F290 |
|
| https://patch-diff.githubusercontent.com/seddonym |
|
seddonym
| https://patch-diff.githubusercontent.com/seddonym |
|
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290/files/26810427985d65cad6098327f32745712686527f |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/290 |
|
| https://patch-diff.githubusercontent.com/nathanjmcdougall |
|
| https://patch-diff.githubusercontent.com/seddonym |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |