| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:9e44fdf6-042c-e34f-9878-c248fe984283 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8618:2C338B:4E381C4:6B39CD7:69781483 |
| html-safe-nonce | e54a52e5ece37ee663bc160f8f69ef47ece08075d2308d327a5701a7dcaa7e7a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjE4OjJDMzM4Qjo0RTM4MUM0OjZCMzlDRDc6Njk3ODE0ODMiLCJ2aXNpdG9yX2lkIjoiMjg5MjAwNTc4MDg3NTY0NjA4MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a1e14283616c948e8c424d52e107ce30bf0b6047daafc6ebde9894fb2dac2b51 |
| hovercard-subject-tag | pull_request:2994768783 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python-grimp/grimp/263/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a4e8f7148e4cd587e3596b7ad699c92b542b95a7dc888a5f78d20c21e3e21cc7/python-grimp/grimp/pull/263 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a4e8f7148e4cd587e3596b7ad699c92b542b95a7dc888a5f78d20c21e3e21cc7/python-grimp/grimp/pull/263 |
| og:image:alt | Closed in favor of
#264
A demo showing a complete port of build_graph to rust, for your interest/consideration @seddonym
The benchmark results from my machine:
just benchmark-build-graph-rust-vs-p... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Peter554 |
| hostname | github.com |
| expected-hostname | github.com |
| None | e71ed39771d00f42ce2fc9320895c8c608c164191e118eae487fc3bd0af6886d |
| turbo-cache-control | no-preview |
| go-import | github.com/python-grimp/grimp git https://github.com/python-grimp/grimp.git |
| octolytics-dimension-user_id | 239787624 |
| octolytics-dimension-user_login | python-grimp |
| octolytics-dimension-repository_id | 156248550 |
| octolytics-dimension-repository_nwo | python-grimp/grimp |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 156248550 |
| octolytics-dimension-repository_network_root_nwo | python-grimp/grimp |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4919f24054c1e9bf76d7b543cb2ac018075b18ce |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#start-of-content |
|
| https://patch-diff.githubusercontent.com/ |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-grimp%2Fgrimp%2Fpull%2F263 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-grimp%2Fgrimp%2Fpull%2F263 |
|
Sign up
| https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python-grimp%2Fgrimp |
| Reload | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263 |
| Reload | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263 |
| Reload | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263 |
|
python-grimp
| https://patch-diff.githubusercontent.com/python-grimp |
| grimp | https://patch-diff.githubusercontent.com/python-grimp/grimp |
|
Notifications
| https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-grimp%2Fgrimp |
|
Fork
22
| https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-grimp%2Fgrimp |
|
Star
108
| https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-grimp%2Fgrimp |
|
Code
| https://patch-diff.githubusercontent.com/python-grimp/grimp |
|
Issues
20
| https://patch-diff.githubusercontent.com/python-grimp/grimp/issues |
|
Pull requests
4
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/python-grimp/grimp/actions |
|
Projects
0
| https://patch-diff.githubusercontent.com/python-grimp/grimp/projects |
|
Security
0
| https://patch-diff.githubusercontent.com/python-grimp/grimp/security |
|
Insights
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pulse |
|
Code
| https://patch-diff.githubusercontent.com/python-grimp/grimp |
|
Issues
| https://patch-diff.githubusercontent.com/python-grimp/grimp/issues |
|
Pull requests
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pulls |
|
Actions
| https://patch-diff.githubusercontent.com/python-grimp/grimp/actions |
|
Projects
| https://patch-diff.githubusercontent.com/python-grimp/grimp/projects |
|
Security
| https://patch-diff.githubusercontent.com/python-grimp/grimp/security |
|
Insights
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pulse |
| Sign up for GitHub
| https://patch-diff.githubusercontent.com/signup?return_to=%2Fpython-grimp%2Fgrimp%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://patch-diff.githubusercontent.com/login?return_to=%2Fpython-grimp%2Fgrimp%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#issue-comment-box |
| Peter554 | https://patch-diff.githubusercontent.com/Peter554 |
| python-grimp:main | https://patch-diff.githubusercontent.com/python-grimp/grimp/tree/main |
| Peter554:build-graph-rust | https://patch-diff.githubusercontent.com/Peter554/grimp/tree/build-graph-rust |
|
Demo: Build graph rust (Parallel)
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#top |
| Peter554 | https://patch-diff.githubusercontent.com/Peter554 |
| python-grimp:main | https://patch-diff.githubusercontent.com/python-grimp/grimp/tree/main |
| Peter554:build-graph-rust | https://patch-diff.githubusercontent.com/Peter554/grimp/tree/build-graph-rust |
|
Conversation
9
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263 |
|
Commits
19
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits |
|
Checks
18
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/checks |
|
Files changed
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/files |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263 |
| https://github.co/hiddenchars |
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/{{ revealButtonHref }} |
|
| https://patch-diff.githubusercontent.com/Peter554 |
| Peter554 | https://patch-diff.githubusercontent.com/Peter554 |
| Nov 10, 2025 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#issue-3607456583 |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263 |
| #264 | https://github.com/python-grimp/grimp/pull/264 |
| @seddonym | https://github.com/seddonym |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263 |
| Peter554 | https://patch-diff.githubusercontent.com/Peter554 |
| November 10, 2025 09:01 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#commits-pushed-02eb0f6 |
|
| https://patch-diff.githubusercontent.com/Peter554 |
| Implement stub GraphBuilder | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/02eb0f61f06a42ff43f3bc944577146d28dfd423 |
| 02eb0f6 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/02eb0f61f06a42ff43f3bc944577146d28dfd423 |
|
| https://patch-diff.githubusercontent.com/Peter554 |
| Add build_graph_rust usecase | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/f6c351e4a84455a526a0dae0451a827407850376 |
| f6c351e | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/f6c351e4a84455a526a0dae0451a827407850376 |
| https://patch-diff.githubusercontent.com/Peter554 |
| Peter554 | https://patch-diff.githubusercontent.com/Peter554 |
| Nov 10, 2025 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#event-20833189585 |
| https://patch-diff.githubusercontent.com/apps/codspeed-hq |
| codspeed-hq | https://patch-diff.githubusercontent.com/apps/codspeed-hq |
| Nov 10, 2025 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#issuecomment-3510918513 |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263 |
| CodSpeed Performance Report | https://codspeed.io/python-grimp/grimp/branches/Peter554%3Abuild-graph-rust?utm_source=github&utm_medium=comment&utm_content=header |
| #263 | https://github.com/python-grimp/grimp/pull/263 |
| efa9e4b | https://github.com/python-grimp/grimp/commit/efa9e4bdd58c1b565901eb94de0f0ab84b86ab53 |
| 558e62c | https://github.com/python-grimp/grimp/commit/558e62c378c4c3df6494678f7a4dafa7955fd52e |
| 1 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#user-content-fn-skipped-5e5be7ef05c41a3bd02acebb9feaffc6 |
| test_build_django_from_cache_a_few_misses[15] | https://codspeed.io/python-grimp/grimp/branches/Peter554%3Abuild-graph-rust?uri=tests%2Fbenchmarking%2Ftest_benchmarking.py%3A%3Atest_build_django_from_cache_a_few_misses%5B15%5D&runnerMode=WallTime&utm_source=github&utm_medium=comment&utm_content=benchmark |
| test_build_django_from_cache_a_few_misses[2] | https://codspeed.io/python-grimp/grimp/branches/Peter554%3Abuild-graph-rust?uri=tests%2Fbenchmarking%2Ftest_benchmarking.py%3A%3Atest_build_django_from_cache_a_few_misses%5B2%5D&runnerMode=WallTime&utm_source=github&utm_medium=comment&utm_content=benchmark |
| test_build_django_from_cache_a_few_misses[350] | https://codspeed.io/python-grimp/grimp/branches/Peter554%3Abuild-graph-rust?uri=tests%2Fbenchmarking%2Ftest_benchmarking.py%3A%3Atest_build_django_from_cache_a_few_misses%5B350%5D&runnerMode=WallTime&utm_source=github&utm_medium=comment&utm_content=benchmark |
| test_build_django_from_cache_no_misses | https://codspeed.io/python-grimp/grimp/branches/Peter554%3Abuild-graph-rust?uri=tests%2Fbenchmarking%2Ftest_benchmarking.py%3A%3Atest_build_django_from_cache_no_misses&runnerMode=WallTime&utm_source=github&utm_medium=comment&utm_content=benchmark |
| test_build_django_uncached | https://codspeed.io/python-grimp/grimp/branches/Peter554%3Abuild-graph-rust?uri=tests%2Fbenchmarking%2Ftest_benchmarking.py%3A%3Atest_build_django_uncached&runnerMode=WallTime&utm_source=github&utm_medium=comment&utm_content=benchmark |
| click here and archive them to remove them from the performance reports | https://codspeed.io/python-grimp/grimp/branches/Peter554%3Abuild-graph-rust?sectionId=benchmark-comparison-section-baseline-result-skipped&utm_source=github&utm_medium=comment&utm_content=archive |
| ↩ | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#user-content-fnref-skipped-5e5be7ef05c41a3bd02acebb9feaffc6 |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263 |
| https://patch-diff.githubusercontent.com/Peter554 |
| Peter554 | https://patch-diff.githubusercontent.com/Peter554 |
|
don't merge
| https://patch-diff.githubusercontent.com/python-grimp/grimp/issues?q=state%3Aopen%20label%3A%22don%27t%20merge%22 |
| Nov 10, 2025 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#event-20834072145 |
| https://patch-diff.githubusercontent.com/Peter554 |
| Peter554 | https://patch-diff.githubusercontent.com/Peter554 |
| force-pushed | https://patch-diff.githubusercontent.com/python-grimp/grimp/compare/2faf7b7788649f9b87c52de7381a04392ef5cca0..820a72408ac19eeb36e0d537350287f7c9a8fb14 |
| 2faf7b7 | https://patch-diff.githubusercontent.com/python-grimp/grimp/commit/2faf7b7788649f9b87c52de7381a04392ef5cca0 |
| 820a724 | https://patch-diff.githubusercontent.com/python-grimp/grimp/commit/820a72408ac19eeb36e0d537350287f7c9a8fb14 |
|
Compare
| https://patch-diff.githubusercontent.com/python-grimp/grimp/compare/2faf7b7788649f9b87c52de7381a04392ef5cca0..820a72408ac19eeb36e0d537350287f7c9a8fb14 |
| November 10, 2025 11:37 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#event-20834115920 |
| Peter554 | https://patch-diff.githubusercontent.com/Peter554 |
| November 10, 2025 12:39 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#commits-pushed-5654566 |
|
| https://patch-diff.githubusercontent.com/Peter554 |
| TEMP Add benchmark script | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/56545662cac428b095bc7cf4b9613b0558b7faa2 |
| 5654566 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/56545662cac428b095bc7cf4b9613b0558b7faa2 |
|
| https://patch-diff.githubusercontent.com/Peter554 |
| Implement parallelism in graph building | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/ab992a8532c5ab8590e07081e60a1990a252962c |
| ab992a8 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/ab992a8532c5ab8590e07081e60a1990a252962c |
|
| https://patch-diff.githubusercontent.com/Peter554 |
| Implement caching | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/f2032621c8a8e708d529e92955aab53cd5956120 |
| f203262 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/f2032621c8a8e708d529e92955aab53cd5956120 |
|
| https://patch-diff.githubusercontent.com/Peter554 |
| Also use parallelism to discover Python modules | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/a13685170998f3c0d772d60615d49fe880fc811e |
| a136851 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/a13685170998f3c0d772d60615d49fe880fc811e |
|
| https://patch-diff.githubusercontent.com/Peter554 |
| TEMP Update benchmarks to use build_graph_rust | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/a539f95dd5bb5d9d46628f16748017fc6dc252eb |
| a539f95 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/a539f95dd5bb5d9d46628f16748017fc6dc252eb |
| https://patch-diff.githubusercontent.com/Peter554 |
| Peter554 | https://patch-diff.githubusercontent.com/Peter554 |
| force-pushed | https://patch-diff.githubusercontent.com/python-grimp/grimp/compare/820a72408ac19eeb36e0d537350287f7c9a8fb14..a539f95dd5bb5d9d46628f16748017fc6dc252eb |
| 820a724 | https://patch-diff.githubusercontent.com/python-grimp/grimp/commit/820a72408ac19eeb36e0d537350287f7c9a8fb14 |
| a539f95 | https://patch-diff.githubusercontent.com/python-grimp/grimp/commit/a539f95dd5bb5d9d46628f16748017fc6dc252eb |
|
Compare
| https://patch-diff.githubusercontent.com/python-grimp/grimp/compare/820a72408ac19eeb36e0d537350287f7c9a8fb14..a539f95dd5bb5d9d46628f16748017fc6dc252eb |
| November 10, 2025 11:39 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#event-20834172888 |
| https://patch-diff.githubusercontent.com/seddonym |
| seddonym | https://patch-diff.githubusercontent.com/seddonym |
| November 10, 2025 12:55 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#event-20836245125 |
| https://patch-diff.githubusercontent.com/seddonym |
| seddonym | https://patch-diff.githubusercontent.com/seddonym |
|
Nov 10, 2025
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#pullrequestreview-3443151414 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/files/a539f95dd5bb5d9d46628f16748017fc6dc252eb |
| seddonym | https://patch-diff.githubusercontent.com/seddonym |
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#pullrequestreview-3443151414 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263 |
| src/grimp/application/usecases.py | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/files/a539f95dd5bb5d9d46628f16748017fc6dc252eb#diff-d16dad5abbd5445150957c49631816311ed4218869bd0974a143609a41720a0e |
| seddonym | https://patch-diff.githubusercontent.com/seddonym |
| Nov 10, 2025 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#discussion_r2510500366 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263 |
| Peter554 | https://patch-diff.githubusercontent.com/Peter554 |
| Nov 10, 2025 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#discussion_r2510934521 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263 |
| src/grimp/application/usecases.py | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/files/a539f95dd5bb5d9d46628f16748017fc6dc252eb#diff-d16dad5abbd5445150957c49631816311ed4218869bd0974a143609a41720a0e |
| seddonym | https://patch-diff.githubusercontent.com/seddonym |
| Nov 10, 2025 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#discussion_r2510507873 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263 |
| Peter554 | https://patch-diff.githubusercontent.com/Peter554 |
| Nov 10, 2025 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#discussion_r2510942803 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263 |
|
| https://patch-diff.githubusercontent.com/Peter554 |
| Make build_graph a simple function | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/16b59b22d3b0d937c35ce647f555867cd7b1f15b |
| 16b59b2 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/16b59b22d3b0d937c35ce647f555867cd7b1f15b |
| https://patch-diff.githubusercontent.com/Peter554 |
| Peter554 | https://patch-diff.githubusercontent.com/Peter554 |
|
Nov 10, 2025
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#pullrequestreview-3443562684 |
|
View reviewed changes
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/files/02eb0f61f06a42ff43f3bc944577146d28dfd423 |
| rust/src/graph/builder/mod.rs | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/files/02eb0f61f06a42ff43f3bc944577146d28dfd423#diff-740abf19f2475b5d546514617be91b8406be7387dfe340fcb5f55eafd3fa0c99 |
| Peter554 | https://patch-diff.githubusercontent.com/Peter554 |
| Nov 10, 2025 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#discussion_r2510798513 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 0c28293 | https://github.com/python-grimp/grimp/commit/0c28293a6fd948ec6be152dde280c1a4d6dbad30 |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263 |
| https://patch-diff.githubusercontent.com/Peter554 |
| Peter554 | https://patch-diff.githubusercontent.com/Peter554 |
| force-pushed | https://patch-diff.githubusercontent.com/python-grimp/grimp/compare/fb44e8b3ba2653de17293e880dabd0fed10d4ebd..5a803899dcfdaff1aa711dd0352901538ecd336f |
| fb44e8b | https://patch-diff.githubusercontent.com/python-grimp/grimp/commit/fb44e8b3ba2653de17293e880dabd0fed10d4ebd |
| 5a80389 | https://patch-diff.githubusercontent.com/python-grimp/grimp/commit/5a803899dcfdaff1aa711dd0352901538ecd336f |
|
Compare
| https://patch-diff.githubusercontent.com/python-grimp/grimp/compare/fb44e8b3ba2653de17293e880dabd0fed10d4ebd..5a803899dcfdaff1aa711dd0352901538ecd336f |
| November 10, 2025 14:46 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#event-20838863086 |
| Peter554 | https://patch-diff.githubusercontent.com/Peter554 |
| November 10, 2025 16:01 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#commits-pushed-c80031c |
|
| https://patch-diff.githubusercontent.com/Peter554 |
| Implement error handling in build_graph | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/c80031c5c5f04b28504504277194fbe26c7e03e0 |
| c80031c | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/c80031c5c5f04b28504504277194fbe26c7e03e0 |
|
| https://patch-diff.githubusercontent.com/Peter554 |
| Extract helper functions to get number of threads | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/ca84423e90dd3bd577fb66cee548c9e90bc67e58 |
| ca84423 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/ca84423e90dd3bd577fb66cee548c9e90bc67e58 |
|
| https://patch-diff.githubusercontent.com/Peter554 |
| Reduce channel capacities | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/d3091f28efaa2471c3867b8b39a9f4571a83e109 |
| d3091f2 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/d3091f28efaa2471c3867b8b39a9f4571a83e109 |
| https://patch-diff.githubusercontent.com/Peter554 |
| Peter554 | https://patch-diff.githubusercontent.com/Peter554 |
| force-pushed | https://patch-diff.githubusercontent.com/python-grimp/grimp/compare/5a803899dcfdaff1aa711dd0352901538ecd336f..d3091f28efaa2471c3867b8b39a9f4571a83e109 |
| 5a80389 | https://patch-diff.githubusercontent.com/python-grimp/grimp/commit/5a803899dcfdaff1aa711dd0352901538ecd336f |
| d3091f2 | https://patch-diff.githubusercontent.com/python-grimp/grimp/commit/d3091f28efaa2471c3867b8b39a9f4571a83e109 |
|
Compare
| https://patch-diff.githubusercontent.com/python-grimp/grimp/compare/5a803899dcfdaff1aa711dd0352901538ecd336f..d3091f28efaa2471c3867b8b39a9f4571a83e109 |
| November 10, 2025 15:07 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#event-20839407829 |
| Peter554 | https://patch-diff.githubusercontent.com/Peter554 |
| November 10, 2025 16:10 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#commits-pushed-8034e99 |
|
| https://patch-diff.githubusercontent.com/Peter554 |
| Create ImportGraph.from_rustgraph | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/8034e9955c3074965f1c2ddb4154b50cd6368f55 |
| 8034e99 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/8034e9955c3074965f1c2ddb4154b50cd6368f55 |
|
| https://patch-diff.githubusercontent.com/Peter554 |
| More tweaks | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/70223f23bdc38ed5dc20b878483e136bef562862 |
| 70223f2 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/70223f23bdc38ed5dc20b878483e136bef562862 |
|
| https://patch-diff.githubusercontent.com/Peter554 |
| Add distill_external_module logic to handle namespace packages | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/dd95e72731875d8bfef64c630d4e1c5b8985437e |
| dd95e72 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/dd95e72731875d8bfef64c630d4e1c5b8985437e |
| https://patch-diff.githubusercontent.com/Peter554 |
| Peter554 | https://patch-diff.githubusercontent.com/Peter554 |
| force-pushed | https://patch-diff.githubusercontent.com/python-grimp/grimp/compare/7f73cbf1764199fbbf869b08b1fdda023377d248..dd95e72731875d8bfef64c630d4e1c5b8985437e |
| 7f73cbf | https://patch-diff.githubusercontent.com/python-grimp/grimp/commit/7f73cbf1764199fbbf869b08b1fdda023377d248 |
| dd95e72 | https://patch-diff.githubusercontent.com/python-grimp/grimp/commit/dd95e72731875d8bfef64c630d4e1c5b8985437e |
|
Compare
| https://patch-diff.githubusercontent.com/python-grimp/grimp/compare/7f73cbf1764199fbbf869b08b1fdda023377d248..dd95e72731875d8bfef64c630d4e1c5b8985437e |
| November 10, 2025 19:43 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#event-20845373443 |
| https://patch-diff.githubusercontent.com/Peter554 |
| Peter554 | https://patch-diff.githubusercontent.com/Peter554 |
| Nov 10, 2025 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#issuecomment-3513858452 |
| @seddonym | https://github.com/seddonym |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263 |
| Peter554 | https://patch-diff.githubusercontent.com/Peter554 |
| November 11, 2025 02:51 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#commits-pushed-ae0ef85 |
|
| https://patch-diff.githubusercontent.com/Peter554 |
| Support multiple packages, fix a few bugs | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/ae0ef856152983a1700712d5a63ef9c744ab56c5 |
| ae0ef85 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/ae0ef856152983a1700712d5a63ef9c744ab56c5 |
|
| https://patch-diff.githubusercontent.com/Peter554 |
| TEMP Run all functional tests for build_graph_rust | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/0accb849c004886aaf3f1ba2a0e375ccbb303f1f |
| 0accb84 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/0accb849c004886aaf3f1ba2a0e375ccbb303f1f |
|
| https://patch-diff.githubusercontent.com/Peter554 |
| Cache improvements | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/8a0b7a8a85bd2a99a3613acc6b8d3c68116abc6c |
| 8a0b7a8 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/8a0b7a8a85bd2a99a3613acc6b8d3c68116abc6c |
|
| https://patch-diff.githubusercontent.com/Peter554 |
| Move python file reading utils to own file | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/76a732ce0f3318a5c171859355f79c5a0afc363e |
| 76a732c | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/76a732ce0f3318a5c171859355f79c5a0afc363e |
| https://patch-diff.githubusercontent.com/Peter554 |
| Peter554 | https://patch-diff.githubusercontent.com/Peter554 |
|
Nov 11, 2025
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#ref-pullrequest-3604498890 |
|
Demo: Benchmark comparing powerwalk vs os.walk for package discovery
#262
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/262 |
|
| https://patch-diff.githubusercontent.com/Peter554 |
| Demo rust unit test with temp file system | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/efa9e4bdd58c1b565901eb94de0f0ab84b86ab53 |
| efa9e4b | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/commits/efa9e4bdd58c1b565901eb94de0f0ab84b86ab53 |
| https://patch-diff.githubusercontent.com/Peter554 |
| Peter554 | https://patch-diff.githubusercontent.com/Peter554 |
|
Nov 12, 2025
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#ref-pullrequest-3615959816 |
|
Demo: Build graph rust (Sequential)
#264
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/264 |
| https://patch-diff.githubusercontent.com/Peter554 |
| Peter554 | https://patch-diff.githubusercontent.com/Peter554 |
| Nov 12, 2025 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#event-20885031102 |
| https://patch-diff.githubusercontent.com/Peter554 |
| Peter554 | https://patch-diff.githubusercontent.com/Peter554 |
| Nov 12, 2025 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#issuecomment-3522853534 |
| #264 | https://github.com/python-grimp/grimp/pull/264 |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263 |
| https://patch-diff.githubusercontent.com/Peter554 |
| Peter554 | https://patch-diff.githubusercontent.com/Peter554 |
| Nov 12, 2025 | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263#event-20893287605 |
| Sign up for free | https://patch-diff.githubusercontent.com/join?source=comment-repo |
| Sign in to comment | https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython-grimp%2Fgrimp%2Fpull%2F263 |
|
| https://patch-diff.githubusercontent.com/seddonym |
|
seddonym
| https://patch-diff.githubusercontent.com/seddonym |
|
| https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263/files/a539f95dd5bb5d9d46628f16748017fc6dc252eb |
|
| https://patch-diff.githubusercontent.com/Peter554 |
|
Peter554
| https://patch-diff.githubusercontent.com/Peter554 |
|
don't merge
| https://patch-diff.githubusercontent.com/python-grimp/grimp/issues?q=state%3Aopen%20label%3A%22don%27t%20merge%22 |
| Please reload this page | https://patch-diff.githubusercontent.com/python-grimp/grimp/pull/263 |
|
| https://patch-diff.githubusercontent.com/Peter554 |
|
| https://patch-diff.githubusercontent.com/seddonym |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |