Title: Add initial support for manipulation of LDAP links by costela · Pull Request #151 · python-gitlab/python-gitlab · GitHub
Open Graph Title: Add initial support for manipulation of LDAP links by costela · Pull Request #151 · python-gitlab/python-gitlab
X Title: Add initial support for manipulation of LDAP links by costela · Pull Request #151 · python-gitlab/python-gitlab
Description: This PR add support for group.ldaplinks.create() and group.ldaplinks.delete(). It's unclear to me what the best way to implement .list() would be. Since the API returns the LDAP information embedded in the group, I see two options (maybe I'm missing something obvious): hide the ldap_group_links attribute behind a manager and add a list() method that fetches the group again, ignoring all info but the LDAP links keep the .ldap_group_links and the .ldaplinks manager separate, but somehow update the .ldap_group_links list when we perform changes (currently the list remains out-dated whenever we perform changes, which obviously sucks) Not sure how any of these could be implemented... :)
Open Graph Description: This PR add support for group.ldaplinks.create() and group.ldaplinks.delete(). It's unclear to me what the best way to implement .list() would be. Since the API returns the LDAP information emb...
X Description: This PR add support for group.ldaplinks.create() and group.ldaplinks.delete(). It's unclear to me what the best way to implement .list() would be. Since the API returns the LDAP information...
Opengraph URL: https://github.com/python-gitlab/python-gitlab/pull/151
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:3034a69d-419e-b765-2e04-829986aeb3d9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B01E:2EEC4B:234DCA5:2D43F6E:6975F3E6 |
| html-safe-nonce | 11e4a48f7fa628ca7cf5655ee79ceb120ac097dc24216eb986d3f25e0140d4ea |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDFFOjJFRUM0QjoyMzREQ0E1OjJENDNGNkU6Njk3NUYzRTYiLCJ2aXNpdG9yX2lkIjoiMzg4MDg5NDkzODE5MDU3NDU2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c6716d4b91ebe8bcc71a7a9c15b1a08b3a6ee95160e93a721a93ca422d1df82c |
| hovercard-subject-tag | pull_request:85589167 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-gitlab/python-gitlab/pull/151/files |
| twitter:image | https://avatars.githubusercontent.com/u/94699?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/94699?s=400&v=4 |
| og:image:alt | This PR add support for group.ldaplinks.create() and group.ldaplinks.delete(). It's unclear to me what the best way to implement .list() would be. Since the API returns the LDAP information emb... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2bce766e7450b03e00b2fc5badd417927ce33a860e78cda3e4ecb9bbd1374cc6 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python-gitlab/python-gitlab git https://github.com/python-gitlab/python-gitlab.git |
| octolytics-dimension-user_id | 28886265 |
| octolytics-dimension-user_login | python-gitlab |
| octolytics-dimension-repository_id | 8077625 |
| octolytics-dimension-repository_nwo | python-gitlab/python-gitlab |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 8077625 |
| octolytics-dimension-repository_network_root_nwo | python-gitlab/python-gitlab |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | fcca2b8ef702b5f7f91427a6e920fa44446fe312 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width