Title: Get rid of all custom URL encoding · Issue #1356 · python-gitlab/python-gitlab · GitHub
Open Graph Title: Get rid of all custom URL encoding · Issue #1356 · python-gitlab/python-gitlab
X Title: Get rid of all custom URL encoding · Issue #1356 · python-gitlab/python-gitlab
Description: See also #1336, #1080, #1079. On the other hand, need to check #1006 and the current state of python-gitlab/gitlab/client.py Lines 513 to 524 in 96d2805 # Requests assumes that `.` should not be encoded as . and will make # changes to ...
Open Graph Description: See also #1336, #1080, #1079. On the other hand, need to check #1006 and the current state of python-gitlab/gitlab/client.py Lines 513 to 524 in 96d2805 # Requests assumes that `.` should not be en...
X Description: See also #1336, #1080, #1079. On the other hand, need to check #1006 and the current state of python-gitlab/gitlab/client.py Lines 513 to 524 in 96d2805 # Requests assumes that `.` should not be en...
Opengraph URL: https://github.com/python-gitlab/python-gitlab/issues/1356
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Get rid of all custom URL encoding","articleBody":"See also https://github.com/python-gitlab/python-gitlab/pull/1336, https://github.com/python-gitlab/python-gitlab/pull/1080, https://github.com/python-gitlab/python-gitlab/issues/1079.\r\n\r\nOn the other hand, need to check https://github.com/python-gitlab/python-gitlab/issues/1006 and the current state of https://github.com/python-gitlab/python-gitlab/blob/96d2805b5bf372cb79c2b7db5c1e499c41e477c1/gitlab/client.py#L513-L524\r\nIf proxies handle it differently maybe an additional arg for e.g. `encode_xyz=True` might help.\r\n\r\n---\r\n\r\n```\r\ngitlab/utils.py: return id.replace(\"/\", \"%2F\").replace(\"#\", \"%23\")\r\ngitlab/utils.py: return value.replace(\"/\", \"%2F\")\r\ngitlab/utils.py: new_path = parsed.path.replace(\".\", \"%2E\")\r\ngitlab/v4/objects/branches.py: id = self.get_id().replace(\"/\", \"%2F\")\r\ngitlab/v4/objects/branches.py: id = self.get_id().replace(\"/\", \"%2F\")\r\ngitlab/v4/objects/features.py: path = \"%s/%s\" % (self.path, name.replace(\"/\", \"%2F\"))\r\ngitlab/v4/objects/files.py: self.file_path = self.file_path.replace(\"/\", \"%2F\")\r\ngitlab/v4/objects/files.py: file_path = self.get_id().replace(\"/\", \"%2F\")\r\ngitlab/v4/objects/files.py: file_path = file_path.replace(\"/\", \"%2F\")\r\ngitlab/v4/objects/files.py: file_path = new_data.pop(\"file_path\").replace(\"/\", \"%2F\")\r\ngitlab/v4/objects/files.py: file_path = file_path.replace(\"/\", \"%2F\")\r\ngitlab/v4/objects/files.py: path = \"%s/%s\" % (self.path, file_path.replace(\"/\", \"%2F\"))\r\ngitlab/v4/objects/files.py: file_path = file_path.replace(\"/\", \"%2F\").replace(\".\", \"%2E\")\r\ngitlab/v4/objects/files.py: file_path = file_path.replace(\"/\", \"%2F\").replace(\".\", \"%2E\")\r\ngitlab/v4/objects/repositories.py: submodule = submodule.replace(\"/\", \"%2F\") # .replace('.', '%2E')\r\ngitlab/v4/objects/tags.py: id = self.get_id().replace(\"/\", \"%2F\")\r\n```","author":{"url":"https://github.com/nejch","@type":"Person","name":"nejch"},"datePublished":"2021-03-02T23:52:05.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/1356/python-gitlab/issues/1356"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:8762b6bb-7576-a784-6a97-ab8ef304501e |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9676:12504B:793C8F:A4323A:69735E46 |
| html-safe-nonce | 72befe169c972d4fc3bf31b7d0b99318f782e4dae31969306e3fd6296d1425ea |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Njc2OjEyNTA0Qjo3OTNDOEY6QTQzMjNBOjY5NzM1RTQ2IiwidmlzaXRvcl9pZCI6IjQ5NzMzMjE3ODU0ODM0MTkyMDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b6f8ed3a62d633c93096186889fa2841f51f16bbe61e880f2cd8c3bc4330f6c6 |
| hovercard-subject-tag | issue:820487624 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python-gitlab/python-gitlab/1356/issue_layout |
| twitter:image | https://opengraph.githubassets.com/a9d1822b45b8a3f84f4114b2fe0a7bf3ba17871876f226ae44f2a3099886a3fc/python-gitlab/python-gitlab/issues/1356 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a9d1822b45b8a3f84f4114b2fe0a7bf3ba17871876f226ae44f2a3099886a3fc/python-gitlab/python-gitlab/issues/1356 |
| og:image:alt | See also #1336, #1080, #1079. On the other hand, need to check #1006 and the current state of python-gitlab/gitlab/client.py Lines 513 to 524 in 96d2805 # Requests assumes that `.` should not be en... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | nejch |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4cf879a11b0a28a85543899a36aaee9ec9ca2fb7bedad86c0da5731193c95f01 |
| turbo-cache-control | no-preview |
| go-import | github.com/python-gitlab/python-gitlab git https://github.com/python-gitlab/python-gitlab.git |
| octolytics-dimension-user_id | 28886265 |
| octolytics-dimension-user_login | python-gitlab |
| octolytics-dimension-repository_id | 8077625 |
| octolytics-dimension-repository_nwo | python-gitlab/python-gitlab |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 8077625 |
| octolytics-dimension-repository_network_root_nwo | python-gitlab/python-gitlab |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | fe8be790582ef7a55477ce1918ac0ed16b106d31 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width