Title: Port away from requests -> urllib3 for thread-safety. Resolves #144. by ShaheedHaque · Pull Request #258 · python-consul/python-consul · GitHub
Open Graph Title: Port away from requests -> urllib3 for thread-safety. Resolves #144. by ShaheedHaque · Pull Request #258 · python-consul/python-consul
X Title: Port away from requests -> urllib3 for thread-safety. Resolves #144. by ShaheedHaque · Pull Request #258 · python-consul/python-consul
Description: This is not yet ready to merge as I running some integration level tests with our software. The problems I reported in #144 were hard to reproduce, so I need to do a few runs before there is a reasonable chance that I can conclude all is well. In the meantime, I would appreciate feedback. It is worth noticing that the fix involves porting to urllib3>=1.25; that is because it is this version which introduces certificate checking as an option. I also note in passing that there is a Python3.7 compatibility issue which make it hard for me to get a clean run: /usr/lib/python3.7/ast.py:35: in parse return compile(source, filename, mode, PyCF_ONLY_AST) E File "/main/srhaque/kdedev/python-consul/tests/test_aio.py", line 77 E fut = asyncio.async(put(), loop=loop) E ^ E SyntaxError: invalid syntax so I have ignored that for now (these also show up as reserved word warning in 3.6).
Open Graph Description: This is not yet ready to merge as I running some integration level tests with our software. The problems I reported in #144 were hard to reproduce, so I need to do a few runs before there is a reas...
X Description: This is not yet ready to merge as I running some integration level tests with our software. The problems I reported in #144 were hard to reproduce, so I need to do a few runs before there is a reas...
Opengraph URL: https://github.com/python-consul/python-consul/pull/258
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:e5925541-1851-a9e8-47ff-ca0edf8d2e39 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AE64:232A6D:7D8B0F:A34781:6976D8C0 |
| html-safe-nonce | 9d870bd158e60cdfe90d23cd3585bce90ea1095d6060a4bef5170954ea5ec2aa |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTY0OjIzMkE2RDo3RDhCMEY6QTM0NzgxOjY5NzZEOEMwIiwidmlzaXRvcl9pZCI6IjgxNzgwMTI4ODMyMjk1MzAzMDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | dde388dfb03eb8d171fa2db9aae9e836d8041aac20304300424ae7fc73892a11 |
| hovercard-subject-tag | pull_request:296609082 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python-consul/python-consul/pull/258/files |
| twitter:image | https://avatars.githubusercontent.com/u/4881193?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4881193?s=400&v=4 |
| og:image:alt | This is not yet ready to merge as I running some integration level tests with our software. The problems I reported in #144 were hard to reproduce, so I need to do a few runs before there is a reas... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 01d198479908d09a841b2febe8eb105a81af2af7d81830960fe0971e1f4adc09 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python-consul/python-consul git https://github.com/python-consul/python-consul.git |
| octolytics-dimension-user_id | 143416393 |
| octolytics-dimension-user_login | python-consul |
| octolytics-dimension-repository_id | 24473148 |
| octolytics-dimension-repository_nwo | python-consul/python-consul |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24473148 |
| octolytics-dimension-repository_network_root_nwo | python-consul/python-consul |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f752335dbbea672610081196a1998e39aec5e14b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width