René's URL Explorer Experiment


Title: Fix manifest parsing by mdboom · Pull Request #250 · python/pyperformance · GitHub

Open Graph Title: Fix manifest parsing by mdboom · Pull Request #250 · python/pyperformance

X Title: Fix manifest parsing by mdboom · Pull Request #250 · python/pyperformance

Description: I'm a little unclear about how the manifest parsing is supposed to work, so I'm not sure this is the correct solution. To reproduce the bug, use a "meta" manifest file that loads both the pyperform...

Open Graph Description: I'm a little unclear about how the manifest parsing is supposed to work, so I'm not sure this is the correct solution. To reproduce the bug, use a "meta" manifest file that loads ...

X Description: I'm a little unclear about how the manifest parsing is supposed to work, so I'm not sure this is the correct solution. To reproduce the bug, use a "meta" manifest ...

Opengraph URL: https://github.com/python/pyperformance/pull/250

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:46d3811a-e3bc-b2b5-3dca-d9ca2969c222
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE51C:2CE99D:CB2B1C:11BF0EE:6970BEAE
html-safe-nonce0827d7c1f219c6e94b9ddefb4ca0f5c445dd3c111989502c67512df8be7b80e5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTFDOjJDRTk5RDpDQjJCMUM6MTFCRjBFRTo2OTcwQkVBRSIsInZpc2l0b3JfaWQiOiIxMzg4ODM1MjAyNDYzNjU4NzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac50b819a0f89467167e70a5811833ca12d742eaae834c3ba0cd618f0c68d1ffb9
hovercard-subject-tagpull_request:1143395538
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/pyperformance/250/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4866f0ab666317ce3cf575417b749f2c7a9c51fddd47cec950aee81198a90796/python/pyperformance/pull/250
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4866f0ab666317ce3cf575417b749f2c7a9c51fddd47cec950aee81198a90796/python/pyperformance/pull/250
og:image:altI'm a little unclear about how the manifest parsing is supposed to work, so I'm not sure this is the correct solution. To reproduce the bug, use a "meta" manifest file that loads ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemdboom
hostnamegithub.com
expected-hostnamegithub.com
Nonebb43a7bc61aba1b91c3c5cf8e7d00342e1e77a0cfe55a141222dbd7f9782d26f
turbo-cache-controlno-preview
go-importgithub.com/python/pyperformance git https://github.com/python/pyperformance.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id65949828
octolytics-dimension-repository_nwopython/pyperformance
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id65949828
octolytics-dimension-repository_network_root_nwopython/pyperformance
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release34817b01ad7cdf8b2beb35ea7b0e2a7609004eff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/python/pyperformance/pull/250#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fpyperformance%2Fpull%2F250
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fpyperformance%2Fpull%2F250
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fpyperformance
Reloadhttps://patch-diff.githubusercontent.com/python/pyperformance/pull/250
Reloadhttps://patch-diff.githubusercontent.com/python/pyperformance/pull/250
Reloadhttps://patch-diff.githubusercontent.com/python/pyperformance/pull/250
python https://patch-diff.githubusercontent.com/python
pyperformancehttps://patch-diff.githubusercontent.com/python/pyperformance
Please reload this pagehttps://patch-diff.githubusercontent.com/python/pyperformance/pull/250
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fpython%2Fpyperformance
Fork 201 https://patch-diff.githubusercontent.com/login?return_to=%2Fpython%2Fpyperformance
Star 977 https://patch-diff.githubusercontent.com/login?return_to=%2Fpython%2Fpyperformance
Code https://patch-diff.githubusercontent.com/python/pyperformance
Issues 45 https://patch-diff.githubusercontent.com/python/pyperformance/issues
Pull requests 26 https://patch-diff.githubusercontent.com/python/pyperformance/pulls
Actions https://patch-diff.githubusercontent.com/python/pyperformance/actions
Projects 0 https://patch-diff.githubusercontent.com/python/pyperformance/projects
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/python/pyperformance/security
Please reload this pagehttps://patch-diff.githubusercontent.com/python/pyperformance/pull/250
Insights https://patch-diff.githubusercontent.com/python/pyperformance/pulse
Code https://patch-diff.githubusercontent.com/python/pyperformance
Issues https://patch-diff.githubusercontent.com/python/pyperformance/issues
Pull requests https://patch-diff.githubusercontent.com/python/pyperformance/pulls
Actions https://patch-diff.githubusercontent.com/python/pyperformance/actions
Projects https://patch-diff.githubusercontent.com/python/pyperformance/projects
Security https://patch-diff.githubusercontent.com/python/pyperformance/security
Insights https://patch-diff.githubusercontent.com/python/pyperformance/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fpython%2Fpyperformance%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fpython%2Fpyperformance%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/python/pyperformance/pull/250#issue-comment-box
mdboomhttps://patch-diff.githubusercontent.com/mdboom
python:mainhttps://patch-diff.githubusercontent.com/python/pyperformance/tree/main
mdboom:fix-manifest-parsinghttps://patch-diff.githubusercontent.com/mdboom/pyperformance/tree/fix-manifest-parsing
Fix manifest parsing https://patch-diff.githubusercontent.com/python/pyperformance/pull/250#top
mdboomhttps://patch-diff.githubusercontent.com/mdboom
python:mainhttps://patch-diff.githubusercontent.com/python/pyperformance/tree/main
mdboom:fix-manifest-parsinghttps://patch-diff.githubusercontent.com/mdboom/pyperformance/tree/fix-manifest-parsing
Conversation 2 https://patch-diff.githubusercontent.com/python/pyperformance/pull/250
Commits 2 https://patch-diff.githubusercontent.com/python/pyperformance/pull/250/commits
Checks 0 https://patch-diff.githubusercontent.com/python/pyperformance/pull/250/checks
Files changed https://patch-diff.githubusercontent.com/python/pyperformance/pull/250/files
Please reload this pagehttps://patch-diff.githubusercontent.com/python/pyperformance/pull/250
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/python/pyperformance/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/mdboom
mdboomhttps://patch-diff.githubusercontent.com/mdboom
Dec 2, 2022https://patch-diff.githubusercontent.com/python/pyperformance/pull/250#issue-1473044333
Please reload this pagehttps://patch-diff.githubusercontent.com/python/pyperformance/pull/250
https://patch-diff.githubusercontent.com/mdboom
Fix manifest parsinghttps://patch-diff.githubusercontent.com/python/pyperformance/pull/250/commits/b4871bdc3e0227227605935188581950dd49908e
b4871bdhttps://patch-diff.githubusercontent.com/python/pyperformance/pull/250/commits/b4871bdc3e0227227605935188581950dd49908e
https://patch-diff.githubusercontent.com/mdboom
mdboomhttps://patch-diff.githubusercontent.com/mdboom
ericsnowcurrentlyhttps://patch-diff.githubusercontent.com/ericsnowcurrently
December 2, 2022 15:26https://patch-diff.githubusercontent.com/python/pyperformance/pull/250#event-7941653442
https://patch-diff.githubusercontent.com/ericsnowcurrently
ericsnowcurrentlyhttps://patch-diff.githubusercontent.com/ericsnowcurrently
Dec 3, 2022 https://patch-diff.githubusercontent.com/python/pyperformance/pull/250#pullrequestreview-1203260491
View reviewed changes https://patch-diff.githubusercontent.com/python/pyperformance/pull/250/files/b4871bdc3e0227227605935188581950dd49908e
pyperformance/_manifest.pyhttps://patch-diff.githubusercontent.com/python/pyperformance/pull/250/files/b4871bdc3e0227227605935188581950dd49908e#diff-4e4d82a04519e5fdfccf5b47632addcf45e1bfb4bf21bd3608571ed6c01e91d2
ericsnowcurrentlyhttps://patch-diff.githubusercontent.com/ericsnowcurrently
Dec 3, 2022https://patch-diff.githubusercontent.com/python/pyperformance/pull/250#discussion_r1038647965
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/python/pyperformance/pull/250
pyperformance/_manifest.pyhttps://patch-diff.githubusercontent.com/python/pyperformance/pull/250/files/b4871bdc3e0227227605935188581950dd49908e#diff-4e4d82a04519e5fdfccf5b47632addcf45e1bfb4bf21bd3608571ed6c01e91d2
ericsnowcurrentlyhttps://patch-diff.githubusercontent.com/ericsnowcurrently
Dec 3, 2022https://patch-diff.githubusercontent.com/python/pyperformance/pull/250#discussion_r1038648954
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/python/pyperformance/pull/250
https://patch-diff.githubusercontent.com/mdboom
mdboomhttps://patch-diff.githubusercontent.com/mdboom
force-pushedhttps://patch-diff.githubusercontent.com/python/pyperformance/compare/cbbdc0ee38d97570b4c631b8c840df0d81bba5b8..b4871bdc3e0227227605935188581950dd49908e
cbbdc0ehttps://patch-diff.githubusercontent.com/python/pyperformance/commit/cbbdc0ee38d97570b4c631b8c840df0d81bba5b8
b4871bdhttps://patch-diff.githubusercontent.com/python/pyperformance/commit/b4871bdc3e0227227605935188581950dd49908e
Compare https://patch-diff.githubusercontent.com/python/pyperformance/compare/cbbdc0ee38d97570b4c631b8c840df0d81bba5b8..b4871bdc3e0227227605935188581950dd49908e
December 8, 2022 17:15https://patch-diff.githubusercontent.com/python/pyperformance/pull/250#event-7991208115
https://patch-diff.githubusercontent.com/mdboom
Merge remote-tracking branch 'upstream/main' into fix-manifest-parsinghttps://patch-diff.githubusercontent.com/python/pyperformance/pull/250/commits/0c4cd53754d30e09e822f49e46a44b638386d2a4
0c4cd53https://patch-diff.githubusercontent.com/python/pyperformance/pull/250/commits/0c4cd53754d30e09e822f49e46a44b638386d2a4
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fpyperformance%2Fpull%2F250
https://patch-diff.githubusercontent.com/ericsnowcurrently
ericsnowcurrently https://patch-diff.githubusercontent.com/ericsnowcurrently
https://patch-diff.githubusercontent.com/python/pyperformance/pull/250/files/b4871bdc3e0227227605935188581950dd49908e
Please reload this pagehttps://patch-diff.githubusercontent.com/python/pyperformance/pull/250
https://patch-diff.githubusercontent.com/mdboom
https://patch-diff.githubusercontent.com/ericsnowcurrently
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.