Title: gh-143995: Eliminate redundant refcounting in the JIT from LOAD_ATTR_MODULE by aisk · Pull Request #143996 · python/cpython · GitHub
Open Graph Title: gh-143995: Eliminate redundant refcounting in the JIT from LOAD_ATTR_MODULE by aisk · Pull Request #143996 · python/cpython
X Title: gh-143995: Eliminate redundant refcounting in the JIT from LOAD_ATTR_MODULE by aisk · Pull Request #143996 · python/cpython
Description: Generated `uops` before: _START_EXECUTOR _MAKE_WARM _SET_IP _CHECK_PERIODIC _CHECK_VALIDITY _ITER_CHECK_RANGE _GUARD_NOT_EXHAUSTED_RANGE _ITER_NEXT_RANGE _SET_IP _SWAP_FAST_3 _SPILL_OR_RELOAD _POP_TOP _CHECK_VALIDITY _LOAD_FAST_BORROW_1 _SET_IP _LOAD_ATTR_MODULE _CHECK_VALIDITY _SET_IP _SWAP_FAST_4 _POP_TOP _CHECK_VALIDITY _LOAD_FAST_BORROW_4 _SET_IP _TO_BOOL _CHECK_VALIDITY _GUARD_IS_TRUE_POP _LOAD_FAST_BORROW_2 _LOAD_CONST_INLINE_BORROW _GUARD_NOS_INT _BINARY_OP_ADD_INT _POP_TOP_NOP _POP_TOP_NOP _SWAP_FAST_2 _POP_TOP_INT _JUMP_TO_TOP _DEOPT _ERROR_POP_N _DEOPT _EXIT_TRACE _EXIT_TRACE _ERROR_POP_N _DEOPT _DEOPT _DEOPT _DEOPT _ERROR_POP_N _DEOPT _EXIT_TRACE _EXIT_TRACE Generated `uops` after: _START_EXECUTOR _MAKE_WARM _SET_IP _CHECK_PERIODIC _CHECK_VALIDITY _ITER_CHECK_RANGE _GUARD_NOT_EXHAUSTED_RANGE _ITER_NEXT_RANGE _SET_IP _SWAP_FAST_3 _SPILL_OR_RELOAD _POP_TOP _CHECK_VALIDITY _LOAD_FAST_BORROW_1 _LOAD_ATTR_MODULE _POP_TOP_NOP _SET_IP _SWAP_FAST_4 _POP_TOP _CHECK_VALIDITY _LOAD_FAST_BORROW_4 _SET_IP _TO_BOOL _CHECK_VALIDITY _GUARD_IS_TRUE_POP _LOAD_FAST_BORROW_2 _LOAD_CONST_INLINE_BORROW _GUARD_NOS_INT _BINARY_OP_ADD_INT _POP_TOP_NOP _POP_TOP_NOP _SWAP_FAST_2 _POP_TOP_INT _JUMP_TO_TOP _DEOPT _ERROR_POP_N _DEOPT _EXIT_TRACE _EXIT_TRACE _ERROR_POP_N _DEOPT _DEOPT _DEOPT _ERROR_POP_N _DEOPT _EXIT_TRACE _EXIT_TRACE Diff: _START_EXECUTOR _START_EXECUTOR _MAKE_WARM _MAKE_WARM _SET_IP _SET_IP _CHECK_PERIODIC _CHECK_PERIODIC _CHECK_VALIDITY _CHECK_VALIDITY _ITER_CHECK_RANGE _ITER_CHECK_RANGE _GUARD_NOT_EXHAUSTED_RANGE _GUARD_NOT_EXHAUSTED_RANGE _ITER_NEXT_RANGE _ITER_NEXT_RANGE _SET_IP _SET_IP _SWAP_FAST_3 _SWAP_FAST_3 _SPILL_OR_RELOAD _SPILL_OR_RELOAD _POP_TOP _POP_TOP _CHECK_VALIDITY _CHECK_VALIDITY _LOAD_FAST_BORROW_1 _LOAD_FAST_BORROW_1 _SET_IP < _LOAD_ATTR_MODULE _LOAD_ATTR_MODULE _CHECK_VALIDITY | _POP_TOP_NOP _SET_IP _SET_IP _SWAP_FAST_4 _SWAP_FAST_4 _POP_TOP _POP_TOP _CHECK_VALIDITY _CHECK_VALIDITY _LOAD_FAST_BORROW_4 _LOAD_FAST_BORROW_4 _SET_IP _SET_IP _TO_BOOL _TO_BOOL _CHECK_VALIDITY _CHECK_VALIDITY _GUARD_IS_TRUE_POP _GUARD_IS_TRUE_POP _LOAD_FAST_BORROW_2 _LOAD_FAST_BORROW_2 _LOAD_CONST_INLINE_BORROW _LOAD_CONST_INLINE_BORROW _GUARD_NOS_INT _GUARD_NOS_INT _BINARY_OP_ADD_INT _BINARY_OP_ADD_INT _POP_TOP_NOP _POP_TOP_NOP _POP_TOP_NOP _POP_TOP_NOP _SWAP_FAST_2 _SWAP_FAST_2 _POP_TOP_INT _POP_TOP_INT _JUMP_TO_TOP _JUMP_TO_TOP _DEOPT _DEOPT _ERROR_POP_N _ERROR_POP_N _DEOPT _DEOPT _EXIT_TRACE _EXIT_TRACE _EXIT_TRACE _EXIT_TRACE _ERROR_POP_N _ERROR_POP_N _DEOPT < _DEOPT _DEOPT _DEOPT _DEOPT _DEOPT _DEOPT _ERROR_POP_N _ERROR_POP_N _DEOPT _DEOPT _EXIT_TRACE _EXIT_TRACE _EXIT_TRACE _EXIT_TRACE The time cost for 1000000 iterations in the testfunc in the test case is reduced from approximately 126 seconds to 120 seconds. Issue: gh-143995
Open Graph Description: Generated `uops` before: _START_EXECUTOR _MAKE_WARM _SET_IP _CHECK_PERIODIC _CHECK_VALIDITY _ITER_CHECK_RANGE _GUARD_NOT_EXHAUSTED_RANGE _ITER_NEXT_RANGE _SET_IP _SWAP_FAST_3 _SPILL_OR_RELOAD _PO...
X Description: Generated `uops` before: _START_EXECUTOR _MAKE_WARM _SET_IP _CHECK_PERIODIC _CHECK_VALIDITY _ITER_CHECK_RANGE _GUARD_NOT_EXHAUSTED_RANGE _ITER_NEXT_RANGE _SET_IP _SWAP_FAST_3 _SPILL_OR_RELOAD _PO...
Opengraph URL: https://github.com/python/cpython/pull/143996
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:6bd02a81-5e86-897f-f8e0-ad490473b7ee |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B038:306893:5E4701:8548D9:696E5B19 |
| html-safe-nonce | 19b61bb87bb8090eb8ee05a0d419b24428c25081516c39923a92d1e0ae877a1f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDM4OjMwNjg5Mzo1RTQ3MDE6ODU0OEQ5OjY5NkU1QjE5IiwidmlzaXRvcl9pZCI6IjUzMDYxMzk5ODY2NjExMDQ0MDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 761fbc02af77a24c421061baadd905e472d5c7bf075e36a4612c37b96cf768b7 |
| hovercard-subject-tag | pull_request:3185326665 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/143996/files |
| twitter:image | https://avatars.githubusercontent.com/u/699636?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/699636?s=400&v=4 |
| og:image:alt | Generated `uops` before: _START_EXECUTOR _MAKE_WARM _SET_IP _CHECK_PERIODIC _CHECK_VALIDITY _ITER_CHECK_RANGE _GUARD_NOT_EXHAUSTED_RANGE _ITER_NEXT_RANGE _SET_IP _SWAP_FAST_3 _SPILL_OR_RELOAD _PO... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | f68b42d371252b0f236260d6234f4304a806fe5ac43d59faa21fb59d80df103b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6b74bc8dbcd10b5d69fd9ee9d2cfdc8b35e18a4c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width