Title: gh-143995: Eliminate redundant refcounting in the JIT from LOAD_ATTR_MODULE by aisk · Pull Request #143996 · python/cpython · GitHub
Open Graph Title: gh-143995: Eliminate redundant refcounting in the JIT from LOAD_ATTR_MODULE by aisk · Pull Request #143996 · python/cpython
X Title: gh-143995: Eliminate redundant refcounting in the JIT from LOAD_ATTR_MODULE by aisk · Pull Request #143996 · python/cpython
Description: Generated `uops` before: _START_EXECUTOR _MAKE_WARM _SET_IP _CHECK_PERIODIC _CHECK_VALIDITY _ITER_CHECK_RANGE _GUARD_NOT_EXHAUSTED_RANGE _ITER_NEXT_RANGE _SET_IP _SWAP_FAST_3 _SPILL_OR_RELOAD _POP_TOP _CHECK_VALIDITY _LOAD_FAST_BORROW_1 _SET_IP _LOAD_ATTR_MODULE _CHECK_VALIDITY _SET_IP _SWAP_FAST_4 _POP_TOP _CHECK_VALIDITY _LOAD_FAST_BORROW_4 _SET_IP _TO_BOOL _CHECK_VALIDITY _GUARD_IS_TRUE_POP _LOAD_FAST_BORROW_2 _LOAD_CONST_INLINE_BORROW _GUARD_NOS_INT _BINARY_OP_ADD_INT _POP_TOP_NOP _POP_TOP_NOP _SWAP_FAST_2 _POP_TOP_INT _JUMP_TO_TOP _DEOPT _ERROR_POP_N _DEOPT _EXIT_TRACE _EXIT_TRACE _ERROR_POP_N _DEOPT _DEOPT _DEOPT _DEOPT _ERROR_POP_N _DEOPT _EXIT_TRACE _EXIT_TRACE Generated `uops` after: _START_EXECUTOR _MAKE_WARM _SET_IP _CHECK_PERIODIC _CHECK_VALIDITY _ITER_CHECK_RANGE _GUARD_NOT_EXHAUSTED_RANGE _ITER_NEXT_RANGE _SET_IP _SWAP_FAST_3 _SPILL_OR_RELOAD _POP_TOP _CHECK_VALIDITY _LOAD_FAST_BORROW_1 _LOAD_ATTR_MODULE _POP_TOP_NOP _SET_IP _SWAP_FAST_4 _POP_TOP _CHECK_VALIDITY _LOAD_FAST_BORROW_4 _SET_IP _TO_BOOL _CHECK_VALIDITY _GUARD_IS_TRUE_POP _LOAD_FAST_BORROW_2 _LOAD_CONST_INLINE_BORROW _GUARD_NOS_INT _BINARY_OP_ADD_INT _POP_TOP_NOP _POP_TOP_NOP _SWAP_FAST_2 _POP_TOP_INT _JUMP_TO_TOP _DEOPT _ERROR_POP_N _DEOPT _EXIT_TRACE _EXIT_TRACE _ERROR_POP_N _DEOPT _DEOPT _DEOPT _ERROR_POP_N _DEOPT _EXIT_TRACE _EXIT_TRACE Diff: _START_EXECUTOR _START_EXECUTOR _MAKE_WARM _MAKE_WARM _SET_IP _SET_IP _CHECK_PERIODIC _CHECK_PERIODIC _CHECK_VALIDITY _CHECK_VALIDITY _ITER_CHECK_RANGE _ITER_CHECK_RANGE _GUARD_NOT_EXHAUSTED_RANGE _GUARD_NOT_EXHAUSTED_RANGE _ITER_NEXT_RANGE _ITER_NEXT_RANGE _SET_IP _SET_IP _SWAP_FAST_3 _SWAP_FAST_3 _SPILL_OR_RELOAD _SPILL_OR_RELOAD _POP_TOP _POP_TOP _CHECK_VALIDITY _CHECK_VALIDITY _LOAD_FAST_BORROW_1 _LOAD_FAST_BORROW_1 _SET_IP < _LOAD_ATTR_MODULE _LOAD_ATTR_MODULE _CHECK_VALIDITY | _POP_TOP_NOP _SET_IP _SET_IP _SWAP_FAST_4 _SWAP_FAST_4 _POP_TOP _POP_TOP _CHECK_VALIDITY _CHECK_VALIDITY _LOAD_FAST_BORROW_4 _LOAD_FAST_BORROW_4 _SET_IP _SET_IP _TO_BOOL _TO_BOOL _CHECK_VALIDITY _CHECK_VALIDITY _GUARD_IS_TRUE_POP _GUARD_IS_TRUE_POP _LOAD_FAST_BORROW_2 _LOAD_FAST_BORROW_2 _LOAD_CONST_INLINE_BORROW _LOAD_CONST_INLINE_BORROW _GUARD_NOS_INT _GUARD_NOS_INT _BINARY_OP_ADD_INT _BINARY_OP_ADD_INT _POP_TOP_NOP _POP_TOP_NOP _POP_TOP_NOP _POP_TOP_NOP _SWAP_FAST_2 _SWAP_FAST_2 _POP_TOP_INT _POP_TOP_INT _JUMP_TO_TOP _JUMP_TO_TOP _DEOPT _DEOPT _ERROR_POP_N _ERROR_POP_N _DEOPT _DEOPT _EXIT_TRACE _EXIT_TRACE _EXIT_TRACE _EXIT_TRACE _ERROR_POP_N _ERROR_POP_N _DEOPT < _DEOPT _DEOPT _DEOPT _DEOPT _DEOPT _DEOPT _ERROR_POP_N _ERROR_POP_N _DEOPT _DEOPT _EXIT_TRACE _EXIT_TRACE _EXIT_TRACE _EXIT_TRACE The time cost for 1000000 iterations in the testfunc in the test case is reduced from approximately 126 seconds to 120 seconds. Issue: gh-143995
Open Graph Description: Generated `uops` before: _START_EXECUTOR _MAKE_WARM _SET_IP _CHECK_PERIODIC _CHECK_VALIDITY _ITER_CHECK_RANGE _GUARD_NOT_EXHAUSTED_RANGE _ITER_NEXT_RANGE _SET_IP _SWAP_FAST_3 _SPILL_OR_RELOAD _PO...
X Description: Generated `uops` before: _START_EXECUTOR _MAKE_WARM _SET_IP _CHECK_PERIODIC _CHECK_VALIDITY _ITER_CHECK_RANGE _GUARD_NOT_EXHAUSTED_RANGE _ITER_NEXT_RANGE _SET_IP _SWAP_FAST_3 _SPILL_OR_RELOAD _PO...
Opengraph URL: https://github.com/python/cpython/pull/143996
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:44b911b6-3bf4-d70e-bd92-22ede8df60dc |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | 85D2:DEE16:9123DE:BF6266:696EDF02 |
| html-safe-nonce | e08d1b71312fe0461263140c1c0115c635fc1fb6bf8d8077fa9688443dc6e7c2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NUQyOkRFRTE2OjkxMjNERTpCRjYyNjY6Njk2RURGMDIiLCJ2aXNpdG9yX2lkIjoiNDMxNTU4ODA3MTQxMjEyOTUzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 752c1abf5d92420ff6d943f499b93f83b349877e778752c351843a063f70de5b |
| hovercard-subject-tag | pull_request:3185326665 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/143996/checks |
| twitter:image | https://avatars.githubusercontent.com/u/699636?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/699636?s=400&v=4 |
| og:image:alt | Generated `uops` before: _START_EXECUTOR _MAKE_WARM _SET_IP _CHECK_PERIODIC _CHECK_VALIDITY _ITER_CHECK_RANGE _GUARD_NOT_EXHAUSTED_RANGE _ITER_NEXT_RANGE _SET_IP _SWAP_FAST_3 _SPILL_OR_RELOAD _PO... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b278ad162d35332b6de714dfb005de04386c4d92df6475522bef910f491a35ee |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 39aed5006635ab6f45e6b77d23e73b08a00272a3 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width