René's URL Explorer Experiment


Title: GH-143948: Explain graphlib's cycle-finding code by tim-one · Pull Request #143950 · python/cpython · GitHub

Open Graph Title: GH-143948: Explain graphlib's cycle-finding code by tim-one · Pull Request #143950 · python/cpython

X Title: GH-143948: Explain graphlib's cycle-finding code by tim-one · Pull Request #143950 · python/cpython

Description: gh-143948: Explain graphlib's cycle-finding code Long overdue comments explaining what's going on, and why. No code changes, just comments.

Open Graph Description: gh-143948: Explain graphlib's cycle-finding code Long overdue comments explaining what's going on, and why. No code changes, just comments.

X Description: gh-143948: Explain graphlib's cycle-finding code Long overdue comments explaining what's going on, and why. No code changes, just comments.

Opengraph URL: https://github.com/python/cpython/pull/143950

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:80faa3b3-a844-73d5-e56e-138d84911f28
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9ED8:3790:49852FF:624B6DB:696DFA66
html-safe-nonce5b86dafe70028f47ef025eea43547baf74a6e83188ce7a66ffb3bee7eaf53c2f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUQ4OjM3OTA6NDk4NTJGRjo2MjRCNkRCOjY5NkRGQTY2IiwidmlzaXRvcl9pZCI6IjI5NTE5MTg5NDI1NjY2MTE1NTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4eab3cd55affacd7deee3e956deda0f12c3865b1879005c255ff1449b70d4385
hovercard-subject-tagpull_request:3183202641
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/143950/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/823970089faf108dfd4334497689a9d9fc0ea8ade4dfca357ebca47e106beffa/python/cpython/pull/143950
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/823970089faf108dfd4334497689a9d9fc0ea8ade4dfca357ebca47e106beffa/python/cpython/pull/143950
og:image:altgh-143948: Explain graphlib's cycle-finding code Long overdue comments explaining what's going on, and why. No code changes, just comments.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametim-one
hostnamegithub.com
expected-hostnamegithub.com
None4922b452d03cd8dbce479d866a11bc25b59ef6ee2da23aa9b0ddefa6bd4d0064
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7e5ae23c70136152637ceee8d6faceb35596ec46
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/python/cpython/pull/143950#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F143950
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F143950
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://patch-diff.githubusercontent.com/python/cpython/pull/143950
Reloadhttps://patch-diff.githubusercontent.com/python/cpython/pull/143950
Reloadhttps://patch-diff.githubusercontent.com/python/cpython/pull/143950
python https://patch-diff.githubusercontent.com/python
cpythonhttps://patch-diff.githubusercontent.com/python/cpython
Please reload this pagehttps://patch-diff.githubusercontent.com/python/cpython/pull/143950
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://patch-diff.githubusercontent.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://patch-diff.githubusercontent.com/login?return_to=%2Fpython%2Fcpython
Code https://patch-diff.githubusercontent.com/python/cpython
Issues 5k+ https://patch-diff.githubusercontent.com/python/cpython/issues
Pull requests 2.1k https://patch-diff.githubusercontent.com/python/cpython/pulls
Actions https://patch-diff.githubusercontent.com/python/cpython/actions
Projects 31 https://patch-diff.githubusercontent.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/python/cpython/security
Please reload this pagehttps://patch-diff.githubusercontent.com/python/cpython/pull/143950
Insights https://patch-diff.githubusercontent.com/python/cpython/pulse
Code https://patch-diff.githubusercontent.com/python/cpython
Issues https://patch-diff.githubusercontent.com/python/cpython/issues
Pull requests https://patch-diff.githubusercontent.com/python/cpython/pulls
Actions https://patch-diff.githubusercontent.com/python/cpython/actions
Projects https://patch-diff.githubusercontent.com/python/cpython/projects
Security https://patch-diff.githubusercontent.com/python/cpython/security
Insights https://patch-diff.githubusercontent.com/python/cpython/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/python/cpython/pull/143950#issue-comment-box
tim-onehttps://patch-diff.githubusercontent.com/tim-one
python:mainhttps://patch-diff.githubusercontent.com/python/cpython/tree/main
tim-one:cyclehttps://patch-diff.githubusercontent.com/tim-one/cpython/tree/cycle
GH-143948: Explain graphlib's cycle-finding code https://patch-diff.githubusercontent.com/python/cpython/pull/143950#top
tim-onehttps://patch-diff.githubusercontent.com/tim-one
python:mainhttps://patch-diff.githubusercontent.com/python/cpython/tree/main
tim-one:cyclehttps://patch-diff.githubusercontent.com/tim-one/cpython/tree/cycle
Conversation 5 https://patch-diff.githubusercontent.com/python/cpython/pull/143950
Commits 6 https://patch-diff.githubusercontent.com/python/cpython/pull/143950/commits
Checks 41 https://patch-diff.githubusercontent.com/python/cpython/pull/143950/checks
Files changed 1 https://patch-diff.githubusercontent.com/python/cpython/pull/143950/files
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/python/cpython/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/tim-one
tim-onehttps://patch-diff.githubusercontent.com/tim-one
Jan 17, 2026https://patch-diff.githubusercontent.com/python/cpython/pull/143950#issue-3824223031
gh-143948https://github.com/python/cpython/issues/143948
Please reload this pagehttps://patch-diff.githubusercontent.com/python/cpython/pull/143950
https://patch-diff.githubusercontent.com/tim-one
Explain topsort's cycle-finding algorithm, and why it's written that …https://patch-diff.githubusercontent.com/python/cpython/pull/143950/commits/5d2bdb4c542105137d8968289d18c33ee82b1a70
5d2bdb4https://patch-diff.githubusercontent.com/python/cpython/pull/143950/commits/5d2bdb4c542105137d8968289d18c33ee82b1a70
https://patch-diff.githubusercontent.com/apps/bedevere-app
bedevere-apphttps://patch-diff.githubusercontent.com/apps/bedevere-app
awaiting core review https://patch-diff.githubusercontent.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jan 17, 2026https://patch-diff.githubusercontent.com/python/cpython/pull/143950#event-22108900348
https://patch-diff.githubusercontent.com/tim-one
tim-onehttps://patch-diff.githubusercontent.com/tim-one
Jan 17, 2026https://patch-diff.githubusercontent.com/python/cpython/pull/143950#event-22108905870
https://patch-diff.githubusercontent.com/tim-one
tim-onehttps://patch-diff.githubusercontent.com/tim-one
skip news https://patch-diff.githubusercontent.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
stdlib https://patch-diff.githubusercontent.com/python/cpython/issues?q=state%3Aopen%20label%3Astdlib
Jan 17, 2026https://patch-diff.githubusercontent.com/python/cpython/pull/143950#event-22108912362
https://patch-diff.githubusercontent.com/tim-one
tim-onehttps://patch-diff.githubusercontent.com/tim-one
Jan 17, 2026https://patch-diff.githubusercontent.com/python/cpython/pull/143950#event-22108915687
Explain graphlib's cycle-finding code #143948 https://patch-diff.githubusercontent.com/python/cpython/issues/143948
https://patch-diff.githubusercontent.com/tim-one
Merge branch 'main' into cyclehttps://patch-diff.githubusercontent.com/python/cpython/pull/143950/commits/103b6403b68f406a26d819f47c9185224ff0ba5e
103b640https://patch-diff.githubusercontent.com/python/cpython/pull/143950/commits/103b6403b68f406a26d819f47c9185224ff0ba5e
https://patch-diff.githubusercontent.com/tim-one
tim-onehttps://patch-diff.githubusercontent.com/tim-one
Jan 17, 2026https://patch-diff.githubusercontent.com/python/cpython/pull/143950#event-22108923830
https://patch-diff.githubusercontent.com/apps/bedevere-app
bedevere-apphttps://patch-diff.githubusercontent.com/apps/bedevere-app
Jan 17, 2026 https://patch-diff.githubusercontent.com/python/cpython/pull/143950#ref-issue-3824154135
Explain graphlib's cycle-finding code #143948 https://patch-diff.githubusercontent.com/python/cpython/issues/143948
tim-onehttps://patch-diff.githubusercontent.com/tim-one
January 16, 2026 20:05https://patch-diff.githubusercontent.com/python/cpython/pull/143950#commits-pushed-2e2c3cc
https://patch-diff.githubusercontent.com/tim-one
typohttps://patch-diff.githubusercontent.com/python/cpython/pull/143950/commits/2e2c3cc2769e23cc35f7f68ac666e3dbda9d2ca4
2e2c3cchttps://patch-diff.githubusercontent.com/python/cpython/pull/143950/commits/2e2c3cc2769e23cc35f7f68ac666e3dbda9d2ca4
https://patch-diff.githubusercontent.com/tim-one
Merge remote-tracking branch 'upstream/main' into cyclehttps://patch-diff.githubusercontent.com/python/cpython/pull/143950/commits/8d11ebfd1cdef6768aed2de374a084027d9c78d7
8d11ebfhttps://patch-diff.githubusercontent.com/python/cpython/pull/143950/commits/8d11ebfd1cdef6768aed2de374a084027d9c78d7
https://patch-diff.githubusercontent.com/tim-one
Merge branch 'cycle' ofhttps://patch-diff.githubusercontent.com/python/cpython/pull/143950/commits/7dd5e1604fb144fff8570895d6b72fcddab9998c
https://github.com/tim-one/cpythonhttps://github.com/tim-one/cpython
into cyclehttps://patch-diff.githubusercontent.com/python/cpython/pull/143950/commits/7dd5e1604fb144fff8570895d6b72fcddab9998c
7dd5e16https://patch-diff.githubusercontent.com/python/cpython/pull/143950/commits/7dd5e1604fb144fff8570895d6b72fcddab9998c
https://patch-diff.githubusercontent.com/tim-one
Typo.https://patch-diff.githubusercontent.com/python/cpython/pull/143950/commits/437593a834d8911c2dc239dde09f888d11a80af5
437593ahttps://patch-diff.githubusercontent.com/python/cpython/pull/143950/commits/437593a834d8911c2dc239dde09f888d11a80af5
https://patch-diff.githubusercontent.com/picnixz
picnixzhttps://patch-diff.githubusercontent.com/picnixz
Jan 18, 2026 https://patch-diff.githubusercontent.com/python/cpython/pull/143950#pullrequestreview-3675825659
View reviewed changes https://patch-diff.githubusercontent.com/python/cpython/pull/143950/files/437593a834d8911c2dc239dde09f888d11a80af5
Lib/graphlib.pyhttps://patch-diff.githubusercontent.com/python/cpython/pull/143950/files/437593a834d8911c2dc239dde09f888d11a80af5#diff-194691095e8943761551bf8e2c2cad2085c62434f9216b720218d5061448119f
picnixzhttps://patch-diff.githubusercontent.com/picnixz
Jan 18, 2026https://patch-diff.githubusercontent.com/python/cpython/pull/143950#discussion_r2702800780
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/python/cpython/pull/143950
Lib/graphlib.pyhttps://patch-diff.githubusercontent.com/python/cpython/pull/143950/files/437593a834d8911c2dc239dde09f888d11a80af5#diff-194691095e8943761551bf8e2c2cad2085c62434f9216b720218d5061448119f
picnixzhttps://patch-diff.githubusercontent.com/picnixz
Jan 18, 2026https://patch-diff.githubusercontent.com/python/cpython/pull/143950#discussion_r2702801210
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/python/cpython/pull/143950
Lib/graphlib.pyhttps://patch-diff.githubusercontent.com/python/cpython/pull/143950/files/437593a834d8911c2dc239dde09f888d11a80af5#diff-194691095e8943761551bf8e2c2cad2085c62434f9216b720218d5061448119f
picnixzhttps://patch-diff.githubusercontent.com/picnixz
Jan 18, 2026https://patch-diff.githubusercontent.com/python/cpython/pull/143950#discussion_r2702801522
Please reload this pagehttps://patch-diff.githubusercontent.com/python/cpython/pull/143950
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/python/cpython/pull/143950
Lib/graphlib.pyhttps://patch-diff.githubusercontent.com/python/cpython/pull/143950/files/437593a834d8911c2dc239dde09f888d11a80af5#diff-194691095e8943761551bf8e2c2cad2085c62434f9216b720218d5061448119f
picnixzhttps://patch-diff.githubusercontent.com/picnixz
Jan 18, 2026https://patch-diff.githubusercontent.com/python/cpython/pull/143950#discussion_r2702801855
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/python/cpython/pull/143950
Lib/graphlib.pyhttps://patch-diff.githubusercontent.com/python/cpython/pull/143950/files/437593a834d8911c2dc239dde09f888d11a80af5#diff-194691095e8943761551bf8e2c2cad2085c62434f9216b720218d5061448119f
picnixzhttps://patch-diff.githubusercontent.com/picnixz
Jan 18, 2026https://patch-diff.githubusercontent.com/python/cpython/pull/143950#discussion_r2702812780
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/python/cpython/pull/143950
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F143950
https://patch-diff.githubusercontent.com/picnixz
picnixz https://patch-diff.githubusercontent.com/picnixz
https://patch-diff.githubusercontent.com/python/cpython/pull/143950/files/437593a834d8911c2dc239dde09f888d11a80af5
https://patch-diff.githubusercontent.com/tim-one
tim-one https://patch-diff.githubusercontent.com/tim-one
awaiting core review https://patch-diff.githubusercontent.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
skip news https://patch-diff.githubusercontent.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
stdlib https://patch-diff.githubusercontent.com/python/cpython/issues?q=state%3Aopen%20label%3Astdlib
Explain graphlib's cycle-finding code https://github.com/python/cpython/issues/143948
Please reload this pagehttps://patch-diff.githubusercontent.com/python/cpython/pull/143950
https://patch-diff.githubusercontent.com/tim-one
https://patch-diff.githubusercontent.com/picnixz
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.