René's URL Explorer Experiment

Title: gh-140232: Do not track frozenset objects with immutables by eendebakpt · Pull Request #140234 · python/cpython · GitHub

Open Graph Title: gh-140232: Do not track frozenset objects with immutables by eendebakpt · Pull Request #140234 · python/cpython

X Title: gh-140232: Do not track frozenset objects with immutables by eendebakpt · Pull Request #140234 · python/cpython

Description: In the PR we untrack frozen tuples for the normal constructors. There are a few methods shared between the set and frozenset (for example set_intersection in setobject.c) where we have not added the untracking. (this is possible, but I am not sure this is worthwhile to do). Here is a small script to test the idea: import gc import time from statistics import mean number_of_iterations = 20 number_of_gc_iterations = 50 deltas = [] gc.disable() gc.collect() for kk in range(number_of_iterations): t0 = time.perf_counter() for jj in range(number_of_gc_iterations): gc.collect() dt = time.perf_counter() - t0 deltas.append(dt) print(f"time per collection: mean {1e3 * mean(deltas) / number_of_iterations:.3f} [ms], min {1e3 * min(deltas) / number_of_iterations:.3f} [ms]") sets = [frozenset([ii]) for ii in range(10_000)] deltas = [] print("---") gc.disable() gc.collect() for kk in range(number_of_iterations): t0 = time.perf_counter() for jj in range(number_of_gc_iterations): gc.collect() dt = time.perf_counter() - t0 deltas.append(dt) print(f"time per collection: mean {1e3 * mean(deltas) / number_of_iterations:.3f} [ms], min {1e3 * min(deltas) / number_of_iterations:.3f} [ms]") #%% Show statistics of frozen containers gc.collect() def candidate(obj): return all(not gc.is_tracked(x) for x in obj) for immutable_type in (tuple, frozenset): number_of_objects_tracked = 0 number_of_candidates = 0 number_of_immutable_candidates = 0 for obj in gc.get_objects(): number_of_objects_tracked += 1 if type(obj) is immutable_type: number_of_candidates += 1 # print(f"{type(obj)} = {obj}") if candidate(obj): number_of_immutable_candidates += 1 print(f"type {immutable_type}") print(f" {number_of_objects_tracked=}") print(f" {number_of_candidates=}") print(f" {number_of_immutable_candidates=}") It measures the performance of garbage collection, and outputs some statistics for the numbers of frozen containers. Main: time per collection: mean 1.311 [ms], min 1.301 [ms] --- time per collection: mean 2.467 [ms], min 2.272 [ms] type number_of_objects_tracked=18330 number_of_candidates=546 number_of_immutable_candidates=1 type number_of_objects_tracked=18330 number_of_candidates=10059 number_of_immutable_candidates=10057 PR time per collection: mean 1.285 [ms], min 1.251 [ms] --- time per collection: mean 1.424 [ms], min 1.396 [ms] type number_of_objects_tracked=8273 number_of_candidates=546 number_of_immutable_candidates=6 type number_of_objects_tracked=8273 number_of_candidates=2 number_of_immutable_candidates=0 Issue: gh-140232

Open Graph Description: In the PR we untrack frozen tuples for the normal constructors. There are a few methods shared between the set and frozenset (for example set_intersection in setobject.c) where we have not added th...

X Description: In the PR we untrack frozen tuples for the normal constructors. There are a few methods shared between the set and frozenset (for example set_intersection in setobject.c) where we have not added th...

Opengraph URL: https://github.com/python/cpython/pull/140234

X: @github

direct link

Domain: patch-diff.githubusercontent.com

Links:

Viewport: width=device-width