René's URL Explorer Experiment


Title: 3.14 regression: slot dataclasses classes leak original class · Issue #135228 · python/cpython · GitHub

Open Graph Title: 3.14 regression: slot dataclasses classes leak original class · Issue #135228 · python/cpython

X Title: 3.14 regression: slot dataclasses classes leak original class · Issue #135228 · python/cpython

Description: Bug report Bug description: While trying to test cattrs on 3.14 I ran into this issue. Here's a simple reproducer that passes on 3.13, but doesn't on 3.14. import gc from dataclasses import dataclass @dataclass(slots=True) class B: b: in...

Open Graph Description: Bug report Bug description: While trying to test cattrs on 3.14 I ran into this issue. Here's a simple reproducer that passes on 3.13, but doesn't on 3.14. import gc from dataclasses import datacla...

X Description: Bug report Bug description: While trying to test cattrs on 3.14 I ran into this issue. Here's a simple reproducer that passes on 3.13, but doesn't on 3.14. import gc from dataclasses import...

Opengraph URL: https://github.com/python/cpython/issues/135228

X: @github

direct link

Domain: patch-diff.githubusercontent.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"3.14 regression: slot dataclasses classes leak original class","articleBody":"# Bug report\n\n### Bug description:\n\nWhile trying to test cattrs on 3.14 I ran into this issue. Here's a simple reproducer that passes on 3.13, but doesn't on 3.14.\n\n```python\nimport gc\nfrom dataclasses import dataclass\n\n\n@dataclass(slots=True)\nclass B:\n    b: int\n\n\ngc.collect()\n\nassert [\n    o for o in gc.get_objects() if hasattr(o, \"__name__\") and o.__name__ == \"B\"\n] == [B]\n```\n\nOriginally I ran into this issue with slotted _attrs_ classes but the core problem is the same. Since slotness cannot be added to a class, dataclasses and attrs classes create a class copy with slots instead. The old class used to hang around until a GC collection happened (guess there are some reference cycles, but I never investigated thoroughly).\n\nOn 3.14, a full GC collection does not clean up the original class, causing a leak. Apart from leaking, in case of subclassing the original class will remain in the list of the parent `.__subclasses__()`, causing an issue.\n\n### CPython versions tested on:\n\n3.14\n\n### Operating systems tested on:\n\nmacOS\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-135230\n* gh-136893\n* gh-136960\n* gh-136966\n* gh-137013\n* gh-137014\n* gh-137047\n* gh-137666\n* gh-144021\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/Tinche","@type":"Person","name":"Tinche"},"datePublished":"2025-06-06T23:15:44.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":30},"url":"https://github.com/135228/cpython/issues/135228"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:23222788-6c91-8880-adec-4a2f6c98ba2b
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9C76:B22A0:2CD23E5:3C11E16:696EF3AD
html-safe-nonce203e855002b19c06052392aba0e20b7ba6008f818384155cf5e4e9022843d32f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Qzc2OkIyMkEwOjJDRDIzRTU6M0MxMUUxNjo2OTZFRjNBRCIsInZpc2l0b3JfaWQiOiIzMzY0MDkzMDI1Mzg0ODU0NDQ2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac100ec0226bc6ac9b6655610e4f9620b69cb405fd312c1346bd93ec2d2bb28ffa
hovercard-subject-tagissue:3126086443
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/135228/issue_layout
twitter:imagehttps://opengraph.githubassets.com/e7ec9ca9e132eaab04d422dea6407962d6bc5a0372d4f65cd9766b42bb527cea/python/cpython/issues/135228
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e7ec9ca9e132eaab04d422dea6407962d6bc5a0372d4f65cd9766b42bb527cea/python/cpython/issues/135228
og:image:altBug report Bug description: While trying to test cattrs on 3.14 I ran into this issue. Here's a simple reproducer that passes on 3.13, but doesn't on 3.14. import gc from dataclasses import datacla...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTinche
hostnamegithub.com
expected-hostnamegithub.com
Noneb278ad162d35332b6de714dfb005de04386c4d92df6475522bef910f491a35ee
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release39aed5006635ab6f45e6b77d23e73b08a00272a3
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/python/cpython/issues/135228#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F135228
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F135228
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://patch-diff.githubusercontent.com/python/cpython/issues/135228
Reloadhttps://patch-diff.githubusercontent.com/python/cpython/issues/135228
Reloadhttps://patch-diff.githubusercontent.com/python/cpython/issues/135228
python https://patch-diff.githubusercontent.com/python
cpythonhttps://patch-diff.githubusercontent.com/python/cpython
Please reload this pagehttps://patch-diff.githubusercontent.com/python/cpython/issues/135228
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://patch-diff.githubusercontent.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://patch-diff.githubusercontent.com/login?return_to=%2Fpython%2Fcpython
Code https://patch-diff.githubusercontent.com/python/cpython
Issues 5k+ https://patch-diff.githubusercontent.com/python/cpython/issues
Pull requests 2.1k https://patch-diff.githubusercontent.com/python/cpython/pulls
Actions https://patch-diff.githubusercontent.com/python/cpython/actions
Projects 31 https://patch-diff.githubusercontent.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/python/cpython/security
Please reload this pagehttps://patch-diff.githubusercontent.com/python/cpython/issues/135228
Insights https://patch-diff.githubusercontent.com/python/cpython/pulse
Code https://patch-diff.githubusercontent.com/python/cpython
Issues https://patch-diff.githubusercontent.com/python/cpython/issues
Pull requests https://patch-diff.githubusercontent.com/python/cpython/pulls
Actions https://patch-diff.githubusercontent.com/python/cpython/actions
Projects https://patch-diff.githubusercontent.com/python/cpython/projects
Security https://patch-diff.githubusercontent.com/python/cpython/security
Insights https://patch-diff.githubusercontent.com/python/cpython/pulse
New issuehttps://patch-diff.githubusercontent.com/login?return_to=https://github.com/python/cpython/issues/135228
New issuehttps://patch-diff.githubusercontent.com/login?return_to=https://github.com/python/cpython/issues/135228
3.14 regression: slot dataclasses classes leak original classhttps://patch-diff.githubusercontent.com/python/cpython/issues/135228#top
https://patch-diff.githubusercontent.com/JelleZijlstra
3.14bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.14%22
3.15new features, bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.15%22
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
topic-dataclasseshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-dataclasses%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
https://github.com/Tinche
https://github.com/Tinche
Tinchehttps://github.com/Tinche
on Jun 6, 2025https://github.com/python/cpython/issues/135228#issue-3126086443
gh-135228: Break reference cycle between class and descriptors #135230https://github.com/python/cpython/pull/135230
gh-135228: When @dataclass(slots=True) replaces a dataclass, make the original class collectible #136893https://github.com/python/cpython/pull/136893
[3.14] gh-135228: When @dataclass(slots=True) replaces a dataclass, make the original class collectible (GH-136893) #136960https://github.com/python/cpython/pull/136960
gh-135228: Create __dict__ and __weakref__ descriptors for object #136966https://github.com/python/cpython/pull/136966
[3.14] Revert "[3.14] gh-135228: When @dataclass(slots=True) replaces… #137013https://github.com/python/cpython/pull/137013
Revert "gh-135228: When @dataclass(slots=True) replaces a dataclass, make the original class collectible (#136893)" #137014https://github.com/python/cpython/pull/137014
gh-135228: When @dataclass(slots=True) replaces a dataclass, make the original class collectible (take 2) #137047https://github.com/python/cpython/pull/137047
[3.14] gh-135228: When @dataclass(slots=True) replaces a dataclass, make the original class collectible (take 2) (GH-137047) #137666https://github.com/python/cpython/pull/137666
gh-135228: Properly update closure cells for __setattr__ and __detattr__ in frozen dataclasses with slots #144021https://github.com/python/cpython/pull/144021
JelleZijlstrahttps://patch-diff.githubusercontent.com/JelleZijlstra
3.14bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.14%22
3.15new features, bugs and security fixeshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%223.15%22
stdlibStandard Library Python modules in the Lib/ directoryhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22stdlib%22
topic-dataclasseshttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-dataclasses%22
type-bugAn unexpected behavior, bug, or errorhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-bug%22
Release and Deferred blockers 🚫https://github.com/orgs/python/projects/2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.