René's URL Explorer Experiment


Title: Better constant narrowing in the JIT optimizer · Issue #130415 · python/cpython · GitHub

Open Graph Title: Better constant narrowing in the JIT optimizer · Issue #130415 · python/cpython

X Title: Better constant narrowing in the JIT optimizer · Issue #130415 · python/cpython

Description: Please don't work on this. I'm planning on sprinting on this with new contributors at an event this weekend. Currently, the JIT optimizer uses the _COMPARE_OP family, _CONTAINS_OP, _IS_OP, and the _TO_BOOL family to narrow the types of t...

Open Graph Description: Please don't work on this. I'm planning on sprinting on this with new contributors at an event this weekend. Currently, the JIT optimizer uses the _COMPARE_OP family, _CONTAINS_OP, _IS_OP, and the ...

X Description: Please don't work on this. I'm planning on sprinting on this with new contributors at an event this weekend. Currently, the JIT optimizer uses the _COMPARE_OP family, _CONTAINS_OP, _IS_OP, ...

Opengraph URL: https://github.com/python/cpython/issues/130415

X: @github

direct link

Domain: patch-diff.githubusercontent.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Better constant narrowing in the JIT optimizer","articleBody":"**Please don't work on this. I'm planning on sprinting on this with new contributors at an event this weekend.**\n\nCurrently, the JIT optimizer uses the `_COMPARE_OP` family, `_CONTAINS_OP`, `_IS_OP`, and the `_TO_BOOL` family to narrow the *types* of the input values and the type of the output value.\n\nHowever, by \"peeking ahead\" and seeing how a value will be used, we can narrow these types to constants as well. As a simple example, consider `_TO_BOOL_INT + _GUARD_IS_FALSE_CHECK` on an unknown value. After the `_TO_BOOL_INT`, it can be narrowed to a known class, `int` (we do this today). However, after the `_GUARD_IS_FALSE_CHECK`, we can actually narrow it to a constant value, `0`.\n\nAn example implementation of this idea for `_TO_BOOL_BOOL` is here: https://github.com/python/cpython/compare/main...brandtbucher:cpython:hack-night-to-bool-bool\n \nI've divided this work into 3 \"waves\" of increasing complexity. Tasks in **bold** are probably a bit harder, tasks in *italics* are probably a bit easier.\n\n## Narrow types to constants in branches involving truthiness:\n\n- [x] **`_TO_BOOL + _GUARD_IS_*_POP`** [gh-130659](https://github.com/python/cpython/pull/130659)\n- [x] *`_TO_BOOL_BOOL + _GUARD_IS_*_POP`* [gh-130659](https://github.com/python/cpython/pull/130659)\n- [x] `_TO_BOOL_INT + _GUARD_IS_*_POP` [gh-130772](https://github.com/python/cpython/pull/130772)\n- [ ] ~**`_TO_BOOL_LIST + _GUARD_IS_*_POP`**~\n- [x] `_TO_BOOL_STR + _GUARD_IS_*_POP` [gh-130476](https://github.com/python/cpython/pull/130476)\n\n## Narrow types to constants in branches involving comparisons with a constant:\n\n- [ ] **`_COMPARE_OP + _GUARD_IS_*_POP` (`==`, `!=`)**\n- [ ] `_COMPARE_OP_FLOAT + _GUARD_IS_*_POP` (`==`, `!=`)\n- [ ] `_COMPARE_OP_INT + _GUARD_IS_*_POP` (`==`, `!=`)\n- [ ] `_COMPARE_OP_STR + _GUARD_IS_*_POP` (`==`, `!=`)\n- [ ] **`_CONTAINS_OP + _GUARD_IS_*_POP` (`in`, `not in`)**\n- [ ] *`_IS_OP + _GUARD_IS_*_POP` (`is`, `is not`)*\n\n## Evaluate comparisons involving two constants:\n\nThis is related, but a bit more involved, since we need a way to pop two values from the stack and push a constant (`_POP_TWO_LOAD_CONST_INLINE_BORROW`). We should also teach `remove_unneeded_uops` about this new instruction.\n\n- [x] **`_COMPARE_OP`** (`==`, `!=`, `\u003c`, `\u003e`, `\u003c=`, `\u003e=`)\n- [x] `_COMPARE_OP_FLOAT` (`==`, `!=`, `\u003c`, `\u003e`, `\u003c=`, `\u003e=`) [gh-137062](https://github.com/python/cpython/pull/137062)\n- [x] `_COMPARE_OP_INT` (`==`, `!=`, `\u003c`, `\u003e`, `\u003c=`, `\u003e=`) [gh-131489](https://github.com/python/cpython/pull/131489) \n- [x] `_COMPARE_OP_STR` (`==`, `!=`, `\u003c`, `\u003e`, `\u003c=`, `\u003e=`) [gh-137062](https://github.com/python/cpython/pull/137062)\n- [x] **`_CONTAINS_OP` (`in`, `not in`)**\n- [ ] ~*`_IS_OP` (`is`, `is not`)*~\n\n\u003c!-- gh-linked-prs --\u003e\n### Linked PRs\n* gh-130476\n* gh-130477\n* gh-130659\n* gh-130772\n* gh-131489\n* gh-131778\n* gh-132333\n* gh-132708\n* gh-134241\n* gh-137062\n* gh-143895\n\u003c!-- /gh-linked-prs --\u003e\n","author":{"url":"https://github.com/brandtbucher","@type":"Person","name":"brandtbucher"},"datePublished":"2025-02-21T17:23:01.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":16},"url":"https://github.com/130415/cpython/issues/130415"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:0393a27c-08a1-5b14-1ab7-fa122c3f3181
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE0EE:3C0C98:17A5438:1F573C1:696ED38A
html-safe-nonce740bb59e699689661c3b0837a892fade411fafab18594f649169b545ff732bce
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMEVFOjNDMEM5ODoxN0E1NDM4OjFGNTczQzE6Njk2RUQzOEEiLCJ2aXNpdG9yX2lkIjoiNTc1Mzc5NTgyNTEwMzcyMTM1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac652bcb4fd87a94d39be6cc9e27f2bbaef640cda86e3bea7325423c119a29df46
hovercard-subject-tagissue:2869613568
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/cpython/130415/issue_layout
twitter:imagehttps://opengraph.githubassets.com/8961c24ad29b7386524a86aa934d38131215dc4e4407fb380d2ec49c652e6bb3/python/cpython/issues/130415
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8961c24ad29b7386524a86aa934d38131215dc4e4407fb380d2ec49c652e6bb3/python/cpython/issues/130415
og:image:altPlease don't work on this. I'm planning on sprinting on this with new contributors at an event this weekend. Currently, the JIT optimizer uses the _COMPARE_OP family, _CONTAINS_OP, _IS_OP, and the ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebrandtbucher
hostnamegithub.com
expected-hostnamegithub.com
Noneb278ad162d35332b6de714dfb005de04386c4d92df6475522bef910f491a35ee
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release39aed5006635ab6f45e6b77d23e73b08a00272a3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/python/cpython/issues/130415#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F130415
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fissues%2F130415
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://patch-diff.githubusercontent.com/python/cpython/issues/130415
Reloadhttps://patch-diff.githubusercontent.com/python/cpython/issues/130415
Reloadhttps://patch-diff.githubusercontent.com/python/cpython/issues/130415
python https://patch-diff.githubusercontent.com/python
cpythonhttps://patch-diff.githubusercontent.com/python/cpython
Please reload this pagehttps://patch-diff.githubusercontent.com/python/cpython/issues/130415
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://patch-diff.githubusercontent.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://patch-diff.githubusercontent.com/login?return_to=%2Fpython%2Fcpython
Code https://patch-diff.githubusercontent.com/python/cpython
Issues 5k+ https://patch-diff.githubusercontent.com/python/cpython/issues
Pull requests 2.1k https://patch-diff.githubusercontent.com/python/cpython/pulls
Actions https://patch-diff.githubusercontent.com/python/cpython/actions
Projects 31 https://patch-diff.githubusercontent.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://patch-diff.githubusercontent.com/python/cpython/security
Please reload this pagehttps://patch-diff.githubusercontent.com/python/cpython/issues/130415
Insights https://patch-diff.githubusercontent.com/python/cpython/pulse
Code https://patch-diff.githubusercontent.com/python/cpython
Issues https://patch-diff.githubusercontent.com/python/cpython/issues
Pull requests https://patch-diff.githubusercontent.com/python/cpython/pulls
Actions https://patch-diff.githubusercontent.com/python/cpython/actions
Projects https://patch-diff.githubusercontent.com/python/cpython/projects
Security https://patch-diff.githubusercontent.com/python/cpython/security
Insights https://patch-diff.githubusercontent.com/python/cpython/pulse
New issuehttps://patch-diff.githubusercontent.com/login?return_to=https://github.com/python/cpython/issues/130415
New issuehttps://patch-diff.githubusercontent.com/login?return_to=https://github.com/python/cpython/issues/130415
Better constant narrowing in the JIT optimizerhttps://patch-diff.githubusercontent.com/python/cpython/issues/130415#top
https://patch-diff.githubusercontent.com/brandtbucher
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
performancePerformance or resource usagehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22performance%22
topic-JIThttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-JIT%22
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
https://github.com/brandtbucher
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
on Feb 21, 2025https://github.com/python/cpython/issues/130415#issue-2869613568
main...brandtbucher:cpython:hack-night-to-bool-boolhttps://github.com/python/cpython/compare/main...brandtbucher:cpython:hack-night-to-bool-bool
gh-130659https://github.com/python/cpython/pull/130659
gh-130659https://github.com/python/cpython/pull/130659
gh-130772https://github.com/python/cpython/pull/130772
gh-130476https://github.com/python/cpython/pull/130476
gh-137062https://github.com/python/cpython/pull/137062
gh-131489https://github.com/python/cpython/pull/131489
gh-137062https://github.com/python/cpython/pull/137062
GH-130415: Narrow str to "" based on boolean tests #130476https://github.com/python/cpython/pull/130476
GH-130415: Optimize JIT path for _TO_BOOL_INT branching  #130477https://github.com/python/cpython/pull/130477
GH-130415: Use boolean guards to narrow types to values in the JIT #130659https://github.com/python/cpython/pull/130659
GH-130415: Narrow int to 0 based on boolean tests #130772https://github.com/python/cpython/pull/130772
GH-130415: Optimize constant comparison in JIT builds #131489https://github.com/python/cpython/pull/131489
GH-130415: Remove redundant sym_matches_type calls in the JIT optimizer #131778https://github.com/python/cpython/pull/131778
GH-130415: Improve the JIT's unneeded uop removal pass #132333https://github.com/python/cpython/pull/132333
gh-130415: Eliminate guards for constant CALL_BUILTIN_O/FAST #132708https://github.com/python/cpython/pull/132708
GH-130415: Use POP_TWO_LOAD_CONST_INLINE_BORROW #134241https://github.com/python/cpython/pull/134241
GH-132732: Use pure op machinery to optimize COMPARE_OP_INT/FLOAT/STR #137062https://github.com/python/cpython/pull/137062
gh-130415: Narrowing to constants in branches involving is comparisons with a constant #143895https://github.com/python/cpython/pull/143895
brandtbucherhttps://patch-diff.githubusercontent.com/brandtbucher
interpreter-core(Objects, Python, Grammar, and Parser dirs)https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22interpreter-core%22
performancePerformance or resource usagehttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22performance%22
topic-JIThttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22topic-JIT%22
type-featureA feature request or enhancementhttps://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22type-feature%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.