Title: Require keeping an unreviewed PR open for a period of time · Issue #541 · python/core-workflow · GitHub
Open Graph Title: Require keeping an unreviewed PR open for a period of time · Issue #541 · python/core-workflow
X Title: Require keeping an unreviewed PR open for a period of time · Issue #541 · python/core-workflow
Description: In order to encourage reviews, and to prevent PRs from being created and merged without reviews within a short period of time (sometimes within one hour!), it has multiple times been suggested (on Discord, informally in discussions on Py...
Open Graph Description: In order to encourage reviews, and to prevent PRs from being created and merged without reviews within a short period of time (sometimes within one hour!), it has multiple times been suggested (on ...
X Description: In order to encourage reviews, and to prevent PRs from being created and merged without reviews within a short period of time (sometimes within one hour!), it has multiple times been suggested (on ...
Opengraph URL: https://github.com/python/core-workflow/issues/541
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Require keeping an unreviewed PR open for a period of time","articleBody":"In order to encourage reviews, and to prevent PRs from being created and merged without reviews within a short period of time (sometimes within one hour!), it has multiple times been suggested (on Discord, informally in discussions on PyCon) to add tooling that prevents an unreviewed reviewed PR to be merged unless a predetermined period of time has passed.\r\n\r\nI think we should add a check that for _unreviewed_ PRs will require a certain period of time to pass before the PR can be merged. This check will reset if new commits are added. If a review is performed, the check is dismissed. If a review if performed and new commits are added, the check is reset and a new review must be performed in order to dismiss the check again.\r\n\r\nFor discussion:\r\n\r\n- Should this check be dismissed only when a core dev or triager has reviewed the PR, or should we allow external reviews?\r\n- How long should the delay be? I suggest somewhere between 1 and 2 weeks. IMO, 2 days or even 3 days is too short.","author":{"url":"https://github.com/erlend-aasland","@type":"Person","name":"erlend-aasland"},"datePublished":"2024-06-10T07:41:57.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":7},"url":"https://github.com/541/core-workflow/issues/541"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:bdb2b663-d21f-acad-2296-b6388f7eb3bb |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DC50:EF2BE:77B871:AA9728:696F8AC8 |
| html-safe-nonce | d60b244e2a050d8aa772a32712e92841e61f4994cca8da2fab705c42d2ee0c9e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzUwOkVGMkJFOjc3Qjg3MTpBQTk3Mjg6Njk2RjhBQzgiLCJ2aXNpdG9yX2lkIjoiNDg4MjgwODg4NDQ3ODA1MzA2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c1bea03446170ce6a0a57a74d1ffa84679773a617657b661112fbaa639e6e249 |
| hovercard-subject-tag | issue:2343121324 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/core-workflow/541/issue_layout |
| twitter:image | https://opengraph.githubassets.com/7324ebe6f2c8169bc72cc4b2cd5082e9a66831cbdc25d5efee239ceeda8eb7f2/python/core-workflow/issues/541 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7324ebe6f2c8169bc72cc4b2cd5082e9a66831cbdc25d5efee239ceeda8eb7f2/python/core-workflow/issues/541 |
| og:image:alt | In order to encourage reviews, and to prevent PRs from being created and merged without reviews within a short period of time (sometimes within one hour!), it has multiple times been suggested (on ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | erlend-aasland |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0ca8d8c65612640b9a1a588b3eed68222ca723ed2d028b18fe81b28936d535eb |
| turbo-cache-control | no-preview |
| go-import | github.com/python/core-workflow git https://github.com/python/core-workflow.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 76080865 |
| octolytics-dimension-repository_nwo | python/core-workflow |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 76080865 |
| octolytics-dimension-repository_network_root_nwo | python/core-workflow |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 95f60616ce2765d1114fe6da4af405a58c6d26d2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width