Title: PR checks should require tests like they require docs · Issue #480 · python/core-workflow · GitHub
Open Graph Title: PR checks should require tests like they require docs · Issue #480 · python/core-workflow
X Title: PR checks should require tests like they require docs · Issue #480 · python/core-workflow
Description: tests are as standard a requirement as doc changes. New PR authors who are not aware of this could be helped by a check failing due to lack of tests (rather than waiting for someone to comment on that, which can take years in some cases)...
Open Graph Description: tests are as standard a requirement as doc changes. New PR authors who are not aware of this could be helped by a check failing due to lack of tests (rather than waiting for someone to comment on t...
X Description: tests are as standard a requirement as doc changes. New PR authors who are not aware of this could be helped by a check failing due to lack of tests (rather than waiting for someone to comment on t...
Opengraph URL: https://github.com/python/core-workflow/issues/480
X: @github
Domain: patch-diff.githubusercontent.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"PR checks should require tests like they require docs","articleBody":"\r\n\r\ntests are as standard a requirement as doc changes. New PR authors who are not aware of this could be helped by a check failing due to lack of tests (rather than waiting for someone to comment on that, which can take years in some cases).\r\n\r\nSo the suggestion is:\r\n\r\nAny PR that touches code must also touch the tests, or have a skip-tests label.\r\n","author":{"url":"https://github.com/iritkatriel","@type":"Person","name":"iritkatriel"},"datePublished":"2022-11-27T11:10:15.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":8},"url":"https://github.com/480/core-workflow/issues/480"}| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:d6932c01-9493-0e20-edea-8d29b3b0366f |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9A06:2F3D0F:2CF9BF:3AF83E:696EC6E3 |
| html-safe-nonce | 9100a86cf9216493f85088767ed43e7a3f50ae73b13202f78061a96394285198 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTA2OjJGM0QwRjoyQ0Y5QkY6M0FGODNFOjY5NkVDNkUzIiwidmlzaXRvcl9pZCI6IjIxMjg4OTYwODc4NzM3MzQzNzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 045a15757e22a29243e723440332448ed8b2beeda9b0419af1a4b5450bf3b153 |
| hovercard-subject-tag | issue:1465406442 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/core-workflow/480/issue_layout |
| twitter:image | https://opengraph.githubassets.com/cb7bc10e8396f9097ebfdb9ea5dec9cba2c284bcc2427241a5d2c4617011567b/python/core-workflow/issues/480 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/cb7bc10e8396f9097ebfdb9ea5dec9cba2c284bcc2427241a5d2c4617011567b/python/core-workflow/issues/480 |
| og:image:alt | tests are as standard a requirement as doc changes. New PR authors who are not aware of this could be helped by a check failing due to lack of tests (rather than waiting for someone to comment on t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | iritkatriel |
| hostname | github.com |
| expected-hostname | github.com |
| None | b278ad162d35332b6de714dfb005de04386c4d92df6475522bef910f491a35ee |
| turbo-cache-control | no-preview |
| go-import | github.com/python/core-workflow git https://github.com/python/core-workflow.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 76080865 |
| octolytics-dimension-repository_nwo | python/core-workflow |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 76080865 |
| octolytics-dimension-repository_network_root_nwo | python/core-workflow |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 39aed5006635ab6f45e6b77d23e73b08a00272a3 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width