Title: Remove need for --begin-sql comments by akdor1154 · Pull Request #4 · ptweir/python-string-sql · GitHub
Open Graph Title: Remove need for --begin-sql comments by akdor1154 · Pull Request #4 · ptweir/python-string-sql
X Title: Remove need for --begin-sql comments by akdor1154 · Pull Request #4 · ptweir/python-string-sql
Description: I've been stuffing around with this for ages, and I finally think I've managed to remove the need for --begin-sql and --end-sql or ; delimiters for the syntax block. The strategy is to detect "select", "with", or "--", and just mark from there to the end of the string as SQL. This fits my usage perfectly.. unsure if it is useful for everyone (e.g. you might want to add "INSERT", etc, or you might not like this approach at all..) I've updated demo.py|png to show this in action, along with the readme: Additionally I've set the name of the matched section to meta.embedded.SQL to set the language mode to SQL - this fixes some final highlight stuff, and makes VSCode's bracket matching and comment/uncomment features work properly as well. You might want to pinch this even if you don't like the rest of this PR. One drawback is that I can't force the string to start with select|with|--; it has to just find it at any point in the string (due to the single-line-context-only property of the highlighting system). So if you have something like str = """ I'd like to go and select some nice flowers """, ^^^ sql from here it will "mis-fire". I'm not aware of any way to prevent this. Cheers Jarrad
Open Graph Description: I've been stuffing around with this for ages, and I finally think I've managed to remove the need for --begin-sql and --end-sql or ; delimiters for the syntax block. The strategy is to dete...
X Description: I've been stuffing around with this for ages, and I finally think I've managed to remove the need for --begin-sql and --end-sql or ; delimiters for the syntax block. The strategy is...
Opengraph URL: https://github.com/ptweir/python-string-sql/pull/4
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d706fc70-db88-12fe-903c-e883e38e68cd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E5A4:7E6BE:7DA264D:A20C020:6975BFEA |
| html-safe-nonce | 7a42a1829eb17f64548a6d387f9e2f1998c456d4c9da0f4ebde6e9f5973e54da |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNUE0OjdFNkJFOjdEQTI2NEQ6QTIwQzAyMDo2OTc1QkZFQSIsInZpc2l0b3JfaWQiOiI3OTE0NjI0MjI0MjU1NjU1OTE0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 82ee7f7380d608a6dfd97837fe5d070eb85a5f663ac79d0a92b28d20f3750778 |
| hovercard-subject-tag | pull_request:592274921 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/ptweir/python-string-sql/pull/4/files |
| twitter:image | https://avatars.githubusercontent.com/u/6732831?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/6732831?s=400&v=4 |
| og:image:alt | I've been stuffing around with this for ages, and I finally think I've managed to remove the need for --begin-sql and --end-sql or ; delimiters for the syntax block. The strategy is to dete... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4a4bf5f4e28041a9d2e5c107d7d20b78b4294ba261cab243b28167c16a623a1f |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/ptweir/python-string-sql git https://github.com/ptweir/python-string-sql.git |
| octolytics-dimension-user_id | 165875 |
| octolytics-dimension-user_login | ptweir |
| octolytics-dimension-repository_id | 147387233 |
| octolytics-dimension-repository_nwo | ptweir/python-string-sql |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | true |
| octolytics-dimension-repository_parent_id | 119871378 |
| octolytics-dimension-repository_parent_nwo | 0x00000001A/es6-string-html |
| octolytics-dimension-repository_network_root_id | 119871378 |
| octolytics-dimension-repository_network_root_nwo | 0x00000001A/es6-string-html |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 488b30e96dfd057fbbe44c6665ccbc030b729dde |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width
