René's URL Explorer Experiment


Title: Return an explicit 500 if there's an exception generating metrics by FauxFaux · Pull Request #85 · prometheus/client_python · GitHub

Open Graph Title: Return an explicit 500 if there's an exception generating metrics by FauxFaux · Pull Request #85 · prometheus/client_python

X Title: Return an explicit 500 if there's an exception generating metrics by FauxFaux · Pull Request #85 · prometheus/client_python

Description: The current behaviour observed in #84 is pretty bad. This implements the simplest possible fix: if there's any exception of any kind generating metrics, log it as we are now, but change the response code to a 500. send_error is used, which dumps a random bit of html into the response, which doesn't seem like a problem. send_response(500) could be used instead, to get a 500 with a blank body.

Open Graph Description: The current behaviour observed in #84 is pretty bad. This implements the simplest possible fix: if there's any exception of any kind generating metrics, log it as we are now, but change the res...

X Description: The current behaviour observed in #84 is pretty bad. This implements the simplest possible fix: if there's any exception of any kind generating metrics, log it as we are now, but change the...

Opengraph URL: https://github.com/prometheus/client_python/pull/85

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2915c14c-7f66-b2e9-c4f7-21b06343b758
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCF76:FFF42:17F220C:1F29DAB:6990910A
html-safe-noncead6665256f0cb81481d9a93953906f4253cd95a801fe227ec4b733955dad82c4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjc2OkZGRjQyOjE3RjIyMEM6MUYyOURBQjo2OTkwOTEwQSIsInZpc2l0b3JfaWQiOiI2MDUxMjc4MzI5NjEyMzc0MjgyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc34921e206e7e7743554070aba97e027067124f69ec989674889a65f615fde4d
hovercard-subject-tagpull_request:74049111
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/prometheus/client_python/pull/85/files
twitter:imagehttps://avatars.githubusercontent.com/u/328180?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/328180?s=400&v=4
og:image:altThe current behaviour observed in #84 is pretty bad. This implements the simplest possible fix: if there's any exception of any kind generating metrics, log it as we are now, but change the res...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/prometheus/client_python git https://github.com/prometheus/client_python.git
octolytics-dimension-user_id3380462
octolytics-dimension-user_loginprometheus
octolytics-dimension-repository_id30618733
octolytics-dimension-repository_nwoprometheus/client_python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id30618733
octolytics-dimension-repository_network_root_nwoprometheus/client_python
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/files#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fprometheus%2Fclient_python%2Fpull%2F85%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fprometheus%2Fclient_python%2Fpull%2F85%2Ffiles
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=prometheus%2Fclient_python
Reloadhttps://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/files
Reloadhttps://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/files
Reloadhttps://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/files
prometheus https://patch-diff.githubusercontent.com/prometheus
client_pythonhttps://patch-diff.githubusercontent.com/prometheus/client_python
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fprometheus%2Fclient_python
Fork 842 https://patch-diff.githubusercontent.com/login?return_to=%2Fprometheus%2Fclient_python
Star 4.3k https://patch-diff.githubusercontent.com/login?return_to=%2Fprometheus%2Fclient_python
Code https://patch-diff.githubusercontent.com/prometheus/client_python
Issues 105 https://patch-diff.githubusercontent.com/prometheus/client_python/issues
Pull requests 28 https://patch-diff.githubusercontent.com/prometheus/client_python/pulls
Discussions https://patch-diff.githubusercontent.com/prometheus/client_python/discussions
Actions https://patch-diff.githubusercontent.com/prometheus/client_python/actions
Projects 0 https://patch-diff.githubusercontent.com/prometheus/client_python/projects
Wiki https://patch-diff.githubusercontent.com/prometheus/client_python/wiki
Security 0 https://patch-diff.githubusercontent.com/prometheus/client_python/security
Insights https://patch-diff.githubusercontent.com/prometheus/client_python/pulse
Code https://patch-diff.githubusercontent.com/prometheus/client_python
Issues https://patch-diff.githubusercontent.com/prometheus/client_python/issues
Pull requests https://patch-diff.githubusercontent.com/prometheus/client_python/pulls
Discussions https://patch-diff.githubusercontent.com/prometheus/client_python/discussions
Actions https://patch-diff.githubusercontent.com/prometheus/client_python/actions
Projects https://patch-diff.githubusercontent.com/prometheus/client_python/projects
Wiki https://patch-diff.githubusercontent.com/prometheus/client_python/wiki
Security https://patch-diff.githubusercontent.com/prometheus/client_python/security
Insights https://patch-diff.githubusercontent.com/prometheus/client_python/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fprometheus%2Fclient_python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fprometheus%2Fclient_python%2Fissues%2Fnew%2Fchoose
FauxFauxhttps://patch-diff.githubusercontent.com/FauxFaux
prometheus:masterhttps://patch-diff.githubusercontent.com/prometheus/client_python/tree/master
FauxFaux:masterhttps://patch-diff.githubusercontent.com/FauxFaux/client_python/tree/master
Conversation 7 https://patch-diff.githubusercontent.com/prometheus/client_python/pull/85
Commits 1 https://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/commits
Checks 0 https://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/checks
Files changed https://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/files
Please reload this pagehttps://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/files
Return an explicit 500 if there's an exception generating metrics https://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/files#top
Show all changes 1 commit https://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/files
7d1284c Return an explicit 500 if there's an exception generating metrics FauxFaux Jun 16, 2016 https://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/commits/7d1284c1beb57a00aa113bd9688106243709e224
Clear filters https://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/files
Please reload this pagehttps://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/files
Please reload this pagehttps://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/files
prometheus_client/exposition.pyhttps://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/files#diff-31616dde80dc7c3540794d368828f5fdf09536ba95ceb8fef6463e76c35c97e6
View file https://patch-diff.githubusercontent.com/FauxFaux/client_python/blob/7d1284c1beb57a00aa113bd9688106243709e224/prometheus_client/exposition.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/files#diff-31616dde80dc7c3540794d368828f5fdf09536ba95ceb8fef6463e76c35c97e6
https://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/files#diff-31616dde80dc7c3540794d368828f5fdf09536ba95ceb8fef6463e76c35c97e6
https://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/files#diff-31616dde80dc7c3540794d368828f5fdf09536ba95ceb8fef6463e76c35c97e6
brian-brazilhttps://patch-diff.githubusercontent.com/brian-brazil
Jun 16, 2016https://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/files#r67314708
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/files
FauxFauxhttps://patch-diff.githubusercontent.com/FauxFaux
Jun 16, 2016https://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/files#r67319005
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/files
brian-brazilhttps://patch-diff.githubusercontent.com/brian-brazil
Jun 16, 2016https://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/files#r67322957
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/files
FauxFauxhttps://patch-diff.githubusercontent.com/FauxFaux
Jun 16, 2016https://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/files#r67334745
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/files
brian-brazilhttps://patch-diff.githubusercontent.com/brian-brazil
Jun 16, 2016https://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/files#r67335944
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/files
ulopehttps://patch-diff.githubusercontent.com/ulope
Jun 21, 2016https://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/files#r67933368
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/files
https://patch-diff.githubusercontent.com/prometheus/client_python/pull/85/files#diff-31616dde80dc7c3540794d368828f5fdf09536ba95ceb8fef6463e76c35c97e6
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.