Title: Return an explicit 500 if there's an exception generating metrics by FauxFaux · Pull Request #85 · prometheus/client_python · GitHub
Open Graph Title: Return an explicit 500 if there's an exception generating metrics by FauxFaux · Pull Request #85 · prometheus/client_python
X Title: Return an explicit 500 if there's an exception generating metrics by FauxFaux · Pull Request #85 · prometheus/client_python
Description: The current behaviour observed in #84 is pretty bad. This implements the simplest possible fix: if there's any exception of any kind generating metrics, log it as we are now, but change the response code to a 500. send_error is used, which dumps a random bit of html into the response, which doesn't seem like a problem. send_response(500) could be used instead, to get a 500 with a blank body.
Open Graph Description: The current behaviour observed in #84 is pretty bad. This implements the simplest possible fix: if there's any exception of any kind generating metrics, log it as we are now, but change the res...
X Description: The current behaviour observed in #84 is pretty bad. This implements the simplest possible fix: if there's any exception of any kind generating metrics, log it as we are now, but change the...
Opengraph URL: https://github.com/prometheus/client_python/pull/85
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:df89392f-c744-50b1-4fad-ffca4b69bafa |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | 9506:EB239:516491:66E9D2:69912F45 |
| html-safe-nonce | 6eee5ac6a89c3b27f0406c8a2f0f778495c801473192310ac8026972eee8ba1b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTA2OkVCMjM5OjUxNjQ5MTo2NkU5RDI6Njk5MTJGNDUiLCJ2aXNpdG9yX2lkIjoiODM0NDE4OTU1NzM3MDA3MjkwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7fa5460540c34bc69b046f8e8b06224a1d0edee027dd4e08e6069d796cc5b1f5 |
| hovercard-subject-tag | pull_request:74049111 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/prometheus/client_python/pull/85/checks |
| twitter:image | https://avatars.githubusercontent.com/u/328180?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/328180?s=400&v=4 |
| og:image:alt | The current behaviour observed in #84 is pretty bad. This implements the simplest possible fix: if there's any exception of any kind generating metrics, log it as we are now, but change the res... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-preview |
| go-import | github.com/prometheus/client_python git https://github.com/prometheus/client_python.git |
| octolytics-dimension-user_id | 3380462 |
| octolytics-dimension-user_login | prometheus |
| octolytics-dimension-repository_id | 30618733 |
| octolytics-dimension-repository_nwo | prometheus/client_python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 30618733 |
| octolytics-dimension-repository_network_root_nwo | prometheus/client_python |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width