René's URL Explorer Experiment

Title: Create multiprocess files with process uuid by ethervoid · Pull Request #694 · prometheus/client_python · GitHub

Open Graph Title: Create multiprocess files with process uuid by ethervoid · Pull Request #694 · prometheus/client_python

X Title: Create multiprocess files with process uuid by ethervoid · Pull Request #694 · prometheus/client_python

Description: This is a draft open to discussion In order to be able to clean-up the process files once it's stopped or destroyed, we need to identify those files with a UUID. If not, those files are going to be processed and collected and will keep growing until we restart the server or master process to perform the cleanup of the metrics directory This change uses the psutil library that gives a hash based on PID+Process creation time in order to differentiate two processes with the same PID but those are different. I have some questions about the feasibility of this change: Is the approach ok? Mainly is respectful in case of exception and even though some files could be left behind is not the same situation as we have now. Also, there is an improvement that I can add and is marking those files I couldn't delete as "type_pid_uuid_defunct" so we can do something to directly remove those files Is it ok to start using an external library? I've seen you're trying to avoid it Tests are failing because the test process is not running and the unittest.mock library is only from 3.3 it's ok to move all the multiprocess tests to required that version to run? This change aims to fix #568 // @csmarchbanks Signed-off-by: Mario de Frutos mario@defrutos.org

Open Graph Description: This is a draft open to discussion In order to be able to clean-up the process files once it's stopped or destroyed, we need to identify those files with a UUID. If not, those files are going t...

X Description: This is a draft open to discussion In order to be able to clean-up the process files once it's stopped or destroyed, we need to identify those files with a UUID. If not, those files are goi...

Opengraph URL: https://github.com/prometheus/client_python/pull/694

X: @github

direct link

Domain: patch-diff.githubusercontent.com

Links:

Viewport: width=device-width