Title: added _max to summary allowed_names by AFriemann · Pull Request #264 · prometheus/client_python · GitHub
Open Graph Title: added _max to summary allowed_names by AFriemann · Pull Request #264 · prometheus/client_python
X Title: added _max to summary allowed_names by AFriemann · Pull Request #264 · prometheus/client_python
Description: @brian-brazil We have a few teams using the micrometer metrics library and it comes with a "Timer" metric (which is actually a summary). Unfortunately that metric seems to produce "_max" metrics in addition to "_sum" and "_count". # HELP jvm_gc_pause_seconds Time spent in GC pause # TYPE jvm_gc_pause_seconds summary jvm_gc_pause_seconds_count{action="end of minor GC",cause="Allocation Failure",} 6.0 jvm_gc_pause_seconds_sum{action="end of minor GC",cause="Allocation Failure",} 0.135 jvm_gc_pause_seconds_max{action="end of minor GC",cause="Allocation Failure",} 0.0 jvm_gc_pause_seconds_count{action="end of minor GC",cause="Metadata GC Threshold",} 2.0 jvm_gc_pause_seconds_sum{action="end of minor GC",cause="Metadata GC Threshold",} 0.022 jvm_gc_pause_seconds_max{action="end of minor GC",cause="Metadata GC Threshold",} 0.0 jvm_gc_pause_seconds_count{action="end of major GC",cause="Metadata GC Threshold",} 2.0 jvm_gc_pause_seconds_sum{action="end of major GC",cause="Metadata GC Threshold",} 0.308 jvm_gc_pause_seconds_max{action="end of major GC",cause="Metadata GC Threshold",} 0.0 This results in the parser producing invalid Output: # HELP jvm_gc_pause_seconds Time spent in GC pause # TYPE jvm_gc_pause_seconds summary jvm_gc_pause_seconds_count{action="end of minor GC",cause="Allocation Failure"} 16.0 jvm_gc_pause_seconds_sum{action="end of minor GC",cause="Allocation Failure"} 0.363 # HELP jvm_gc_pause_seconds_max # TYPE jvm_gc_pause_seconds_max untyped jvm_gc_pause_seconds_max{action="end of minor GC",cause="Allocation Failure"} 0.0 jvm_gc_pause_seconds_max{action="end of minor GC",cause="Metadata GC Threshold"} 0.0 jvm_gc_pause_seconds_max{action="end of major GC",cause="Metadata GC Threshold"} 0.0 # HELP jvm_gc_pause_seconds_count # TYPE jvm_gc_pause_seconds_count untyped jvm_gc_pause_seconds_count{action="end of minor GC",cause="Metadata GC Threshold"} 2.0 jvm_gc_pause_seconds_count{action="end of major GC",cause="Metadata GC Threshold"} 2.0 # HELP jvm_gc_pause_seconds_sum # TYPE jvm_gc_pause_seconds_sum untyped jvm_gc_pause_seconds_sum{action="end of minor GC",cause="Metadata GC Threshold"} 0.074 jvm_gc_pause_seconds_sum{action="end of major GC",cause="Metadata GC Threshold"} 0.312 While I don't see this anywhere in the Prometheus documentation and absolutely understand if it is being rejected, I hope this is sensible enough to make it upstream.
Open Graph Description: @brian-brazil We have a few teams using the micrometer metrics library and it comes with a "Timer" metric (which is actually a summary). Unfortunately that metric seems to produce "_...
X Description: @brian-brazil We have a few teams using the micrometer metrics library and it comes with a "Timer" metric (which is actually a summary). Unfortunately that metric seems to produce...
Opengraph URL: https://github.com/prometheus/client_python/pull/264
X: @github
Domain: patch-diff.githubusercontent.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:2bbc8e28-084c-4737-500f-2a000bfaf51f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AAA6:146535:C575B1:FA687D:699016FA |
| html-safe-nonce | 242a4467daf0a4cac88dc812bbe28b48019ff70b4c243529fedb7d50ec64325b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQUE2OjE0NjUzNTpDNTc1QjE6RkE2ODdEOjY5OTAxNkZBIiwidmlzaXRvcl9pZCI6IjYwODQ1NzQ1MDUyMjg4MzQ1NTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ede9c8ee7c90e9e1d410618df465ee0b47c2bb3a14eed5737f27136711bdd8ce |
| hovercard-subject-tag | pull_request:177493934 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/prometheus/client_python/pull/264/files |
| twitter:image | https://avatars.githubusercontent.com/u/1730315?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1730315?s=400&v=4 |
| og:image:alt | @brian-brazil We have a few teams using the micrometer metrics library and it comes with a "Timer" metric (which is actually a summary). Unfortunately that metric seems to produce "_... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/prometheus/client_python git https://github.com/prometheus/client_python.git |
| octolytics-dimension-user_id | 3380462 |
| octolytics-dimension-user_login | prometheus |
| octolytics-dimension-repository_id | 30618733 |
| octolytics-dimension-repository_nwo | prometheus/client_python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 30618733 |
| octolytics-dimension-repository_network_root_nwo | prometheus/client_python |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width