René's URL Explorer Experiment


Title: avoid the breaking change in PrometheusNaming by zeitlinger · Pull Request #1561 · prometheus/client_java · GitHub

Open Graph Title: avoid the breaking change in PrometheusNaming by zeitlinger · Pull Request #1561 · prometheus/client_java

X Title: avoid the breaking change in PrometheusNaming by zeitlinger · Pull Request #1561 · prometheus/client_java

Description: Fixes #1548 PrometheusNaming changes were incompatible - so deprecating instead and create e new PrometheusNames

Open Graph Description: Fixes #1548 PrometheusNaming changes were incompatible - so deprecating instead and create e new PrometheusNames

X Description: Fixes #1548 PrometheusNaming changes were incompatible - so deprecating instead and create e new PrometheusNames

Opengraph URL: https://github.com/prometheus/client_java/pull/1561

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a38e4e80-f274-b17a-ab41-2750b96fdd6e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8BCE:1AD3B8:1628C84:1DE62D1:69733A20
html-safe-nonce37f1ce8c9de68b6a5fab363ba007ae5a0f51b23a30db868379361fd8f21d0622
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QkNFOjFBRDNCODoxNjI4Qzg0OjFERTYyRDE6Njk3MzNBMjAiLCJ2aXNpdG9yX2lkIjoiMjg0Njc3MDc2MDExMjA5MzcyOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac17a196ac80836ecc5a33cd720258a369e0228f3cb0371dd8ad3cc03552d56b4e
hovercard-subject-tagpull_request:2815961764
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/prometheus/client_java/1561/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a911df5b5da17ef20e1256a5978ac756adbd7f11db5143e4dff82811112276ee/prometheus/client_java/pull/1561
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a911df5b5da17ef20e1256a5978ac756adbd7f11db5143e4dff82811112276ee/prometheus/client_java/pull/1561
og:image:altFixes #1548 PrometheusNaming changes were incompatible - so deprecating instead and create e new PrometheusNames
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamezeitlinger
hostnamegithub.com
expected-hostnamegithub.com
None44ab3188c1dcfe3be0f9c3feca2e04e14fb79f120939ce2395e4f15ab96ec1d4
turbo-cache-controlno-preview
go-importgithub.com/prometheus/client_java git https://github.com/prometheus/client_java.git
octolytics-dimension-user_id3380462
octolytics-dimension-user_loginprometheus
octolytics-dimension-repository_id7997879
octolytics-dimension-repository_nwoprometheus/client_java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7997879
octolytics-dimension-repository_network_root_nwoprometheus/client_java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release75e56b01124e79ebbaa7864231f25e58fc1b5f25
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fprometheus%2Fclient_java%2Fpull%2F1561
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fprometheus%2Fclient_java%2Fpull%2F1561
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=prometheus%2Fclient_java
Reloadhttps://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561
Reloadhttps://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561
Reloadhttps://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561
prometheus https://patch-diff.githubusercontent.com/prometheus
client_javahttps://patch-diff.githubusercontent.com/prometheus/client_java
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fprometheus%2Fclient_java
Fork 830 https://patch-diff.githubusercontent.com/login?return_to=%2Fprometheus%2Fclient_java
Star 2.3k https://patch-diff.githubusercontent.com/login?return_to=%2Fprometheus%2Fclient_java
Code https://patch-diff.githubusercontent.com/prometheus/client_java
Issues 103 https://patch-diff.githubusercontent.com/prometheus/client_java/issues
Pull requests 27 https://patch-diff.githubusercontent.com/prometheus/client_java/pulls
Actions https://patch-diff.githubusercontent.com/prometheus/client_java/actions
Projects 0 https://patch-diff.githubusercontent.com/prometheus/client_java/projects
Security 0 https://patch-diff.githubusercontent.com/prometheus/client_java/security
Insights https://patch-diff.githubusercontent.com/prometheus/client_java/pulse
Code https://patch-diff.githubusercontent.com/prometheus/client_java
Issues https://patch-diff.githubusercontent.com/prometheus/client_java/issues
Pull requests https://patch-diff.githubusercontent.com/prometheus/client_java/pulls
Actions https://patch-diff.githubusercontent.com/prometheus/client_java/actions
Projects https://patch-diff.githubusercontent.com/prometheus/client_java/projects
Security https://patch-diff.githubusercontent.com/prometheus/client_java/security
Insights https://patch-diff.githubusercontent.com/prometheus/client_java/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fprometheus%2Fclient_java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fprometheus%2Fclient_java%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561#issue-comment-box
zeitlingerhttps://patch-diff.githubusercontent.com/zeitlinger
mainhttps://patch-diff.githubusercontent.com/prometheus/client_java/tree/main
sanitize-metric-namehttps://patch-diff.githubusercontent.com/prometheus/client_java/tree/sanitize-metric-name
avoid the breaking change in PrometheusNaming https://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561#top
zeitlingerhttps://patch-diff.githubusercontent.com/zeitlinger
mainhttps://patch-diff.githubusercontent.com/prometheus/client_java/tree/main
sanitize-metric-namehttps://patch-diff.githubusercontent.com/prometheus/client_java/tree/sanitize-metric-name
Conversation 7 https://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561
Commits 6 https://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561/commits
Checks 7 https://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561/checks
Files changed https://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561/files
Please reload this pagehttps://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/prometheus/client_java/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/zeitlinger
zeitlingerhttps://patch-diff.githubusercontent.com/zeitlinger
Sep 10, 2025https://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561#issue-3402965504
Please reload this pagehttps://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561
#1548https://github.com/prometheus/client_java/issues/1548
Please reload this pagehttps://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561
zeitlingerhttps://patch-diff.githubusercontent.com/zeitlinger
September 10, 2025 17:26https://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561#commits-pushed-0738a68
https://patch-diff.githubusercontent.com/zeitlinger
PrometheusNaming changes were incompatible - so deprecating insteadhttps://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561/commits/0738a6846fdd07cadf3f42f53cc50e3ec7e6b343
0738a68https://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561/commits/0738a6846fdd07cadf3f42f53cc50e3ec7e6b343
https://patch-diff.githubusercontent.com/zeitlinger
PrometheusNaming changes were incompatible - so deprecating insteadhttps://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561/commits/39d7f3eae8fe5cf7c2810247ba75fda41f07fb26
39d7f3ehttps://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561/commits/39d7f3eae8fe5cf7c2810247ba75fda41f07fb26
https://patch-diff.githubusercontent.com/zeitlinger
PrometheusNaming changes were incompatible - so deprecating insteadhttps://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561/commits/25b91e64fb156c766cfe502c35ecac7887ae7ffa
25b91e6https://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561/commits/25b91e64fb156c766cfe502c35ecac7887ae7ffa
https://patch-diff.githubusercontent.com/zeitlinger
zeitlingerhttps://patch-diff.githubusercontent.com/zeitlinger
fstabhttps://patch-diff.githubusercontent.com/fstab
September 10, 2025 15:39https://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561#event-19616177569
https://patch-diff.githubusercontent.com/zeitlinger
zeitlingerhttps://patch-diff.githubusercontent.com/zeitlinger
Sep 10, 2025https://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561#event-19616213900
https://patch-diff.githubusercontent.com/jaydeluca
jaydelucahttps://patch-diff.githubusercontent.com/jaydeluca
Sep 10, 2025 https://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561#pullrequestreview-3207214037
View reviewed changes https://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561/files/25b91e64fb156c766cfe502c35ecac7887ae7ffa
...etheus-metrics-core/src/test/java/io/prometheus/metrics/core/metrics/CallbackMetricTest.javahttps://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561/files/25b91e64fb156c766cfe502c35ecac7887ae7ffa#diff-397fdbe03d1ca682ca83f033145cd951857ee999c03dbaa99c944bbd54ed4e3a
Please reload this pagehttps://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561
...theus-metrics-model/src/main/java/io/prometheus/metrics/model/snapshots/PrometheusNames.javahttps://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561/files/25b91e64fb156c766cfe502c35ecac7887ae7ffa#diff-9c24338d0f53c32aab41b8266d597b4e1d9414ca0ab8de38f5c771cb70cb0b65
jaydelucahttps://patch-diff.githubusercontent.com/jaydeluca
Sep 10, 2025https://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561#discussion_r2337489391
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561
zeitlingerhttps://patch-diff.githubusercontent.com/zeitlinger
Sep 11, 2025https://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561#discussion_r2339097718
Please reload this pagehttps://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
add option to disable metric suffixes #1557https://github.com/prometheus/client_java/pull/1557
Please reload this pagehttps://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561
...theus-metrics-model/src/main/java/io/prometheus/metrics/model/snapshots/PrometheusNames.javahttps://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561/files/25b91e64fb156c766cfe502c35ecac7887ae7ffa#diff-9c24338d0f53c32aab41b8266d597b4e1d9414ca0ab8de38f5c771cb70cb0b65
jaydelucahttps://patch-diff.githubusercontent.com/jaydeluca
Sep 10, 2025https://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561#discussion_r2337515919
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561
zeitlingerhttps://patch-diff.githubusercontent.com/zeitlinger
Sep 11, 2025https://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561#discussion_r2339647451
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561
...s-metrics-model/src/test/java/io/prometheus/metrics/model/snapshots/PrometheusNamesTest.javahttps://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561/files/25b91e64fb156c766cfe502c35ecac7887ae7ffa#diff-a28b0087b7c2c20a957aa546c80b3b94ff4d9976e692b054316a6f03542f4f27
Please reload this pagehttps://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561
https://patch-diff.githubusercontent.com/shakuzen
shakuzenhttps://patch-diff.githubusercontent.com/shakuzen
Sep 11, 2025 https://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561#ref-issue-3377335293
: does not get converted to _ #1548 https://patch-diff.githubusercontent.com/prometheus/client_java/issues/1548
zeitlingerhttps://patch-diff.githubusercontent.com/zeitlinger
September 11, 2025 11:10https://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561#commits-pushed-bc01f4c
https://patch-diff.githubusercontent.com/zeitlinger
https://patch-diff.githubusercontent.com/jaydeluca
Update prometheus-metrics-model/src/test/java/io/prometheus/metrics/m…https://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561/commits/bc01f4c19605e69a4a34b0afacdb5f742615daf9
bc01f4chttps://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561/commits/bc01f4c19605e69a4a34b0afacdb5f742615daf9
https://patch-diff.githubusercontent.com/zeitlinger
revert manual testhttps://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561/commits/9413db634cdbad7fb17feb6002fea126a8458383
9413db6https://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561/commits/9413db634cdbad7fb17feb6002fea126a8458383
https://patch-diff.githubusercontent.com/zeitlinger
move name escaping to separate classhttps://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561/commits/48fbef3c2a9e3ed792c5c5847b408ff94f457521
48fbef3https://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561/commits/48fbef3c2a9e3ed792c5c5847b408ff94f457521
https://patch-diff.githubusercontent.com/zeitlinger
zeitlingerhttps://patch-diff.githubusercontent.com/zeitlinger
September 19, 2025 10:49https://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561#event-19796880635
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fprometheus%2Fclient_java%2Fpull%2F1561
https://patch-diff.githubusercontent.com/jaydeluca
jaydeluca https://patch-diff.githubusercontent.com/jaydeluca
https://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561/files/25b91e64fb156c766cfe502c35ecac7887ae7ffa
https://patch-diff.githubusercontent.com/fstab
fstab https://patch-diff.githubusercontent.com/fstab
https://patch-diff.githubusercontent.com/zeitlinger
zeitlinger https://patch-diff.githubusercontent.com/zeitlinger
: does not get converted to _ https://github.com/prometheus/client_java/issues/1548
Please reload this pagehttps://patch-diff.githubusercontent.com/prometheus/client_java/pull/1561
https://patch-diff.githubusercontent.com/zeitlinger
https://patch-diff.githubusercontent.com/jaydeluca
https://patch-diff.githubusercontent.com/apps/copilot-swe-agent
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.