René's URL Explorer Experiment


Title: Remove unnecessary SELECT and DELETE when saving a page with page/pagetable fields by tuomassalo · Pull Request #314 · processwire/processwire · GitHub

Open Graph Title: Remove unnecessary SELECT and DELETE when saving a page with page/pagetable fields by tuomassalo · Pull Request #314 · processwire/processwire

X Title: Remove unnecessary SELECT and DELETE when saving a page with page/pagetable fields by tuomassalo · Pull Request #314 · processwire/processwire

Description: I noticed that when saving pages, the value of each Page and PageTable field is queried. With a big number of such fields this is bad for performance. I believe guess this PR is safe since Fieldtyp...

Open Graph Description: I noticed that when saving pages, the value of each Page and PageTable field is queried. With a big number of such fields this is bad for performance. I believe guess this PR is safe since Fieldtyp...

X Description: I noticed that when saving pages, the value of each Page and PageTable field is queried. With a big number of such fields this is bad for performance. I believe guess this PR is safe since Fieldtyp...

Opengraph URL: https://github.com/processwire/processwire/pull/314

X: @github

direct link

Domain: patch-diff.githubusercontent.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f3d90777-95bf-388e-88b4-d754e41b42cb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB3E8:101868:3C5F3C2:52F38BD:6980C0C6
html-safe-nonced51adb5a007893ac0bae77241a0c7e677aedbdd821a82b16e98c6781f95d798c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCM0U4OjEwMTg2ODozQzVGM0MyOjUyRjM4QkQ6Njk4MEMwQzYiLCJ2aXNpdG9yX2lkIjoiODE2NzkzMTc1MzE3Mjg3NzUxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace7f4a8797c53800945893234fd0405486d814f7828093b7c805254f0bc927201
hovercard-subject-tagpull_request:2301977717
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/processwire/processwire/314/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fd6f8edde562a3c3e592e20fad1a618f9aa19a390bdd966cccb9b09f78b7c2e0/processwire/processwire/pull/314
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fd6f8edde562a3c3e592e20fad1a618f9aa19a390bdd966cccb9b09f78b7c2e0/processwire/processwire/pull/314
og:image:altI noticed that when saving pages, the value of each Page and PageTable field is queried. With a big number of such fields this is bad for performance. I believe guess this PR is safe since Fieldtyp...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametuomassalo
hostnamegithub.com
expected-hostnamegithub.com
Nonefb936832e40deb3175641d9cfedc8432372f91b0bc899576222953095fc7879e
turbo-cache-controlno-preview
go-importgithub.com/processwire/processwire git https://github.com/processwire/processwire.git
octolytics-dimension-user_id944567
octolytics-dimension-user_loginprocesswire
octolytics-dimension-repository_id66832303
octolytics-dimension-repository_nwoprocesswire/processwire
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id66832303
octolytics-dimension-repository_network_root_nwoprocesswire/processwire
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3e9b7987a76a2b9d08066d02bb64947a61943332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://patch-diff.githubusercontent.com/processwire/processwire/pull/314#start-of-content
https://patch-diff.githubusercontent.com/
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fprocesswire%2Fprocesswire%2Fpull%2F314
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fprocesswire%2Fprocesswire%2Fpull%2F314
Sign up https://patch-diff.githubusercontent.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=processwire%2Fprocesswire
Reloadhttps://patch-diff.githubusercontent.com/processwire/processwire/pull/314
Reloadhttps://patch-diff.githubusercontent.com/processwire/processwire/pull/314
Reloadhttps://patch-diff.githubusercontent.com/processwire/processwire/pull/314
processwire https://patch-diff.githubusercontent.com/processwire
processwirehttps://patch-diff.githubusercontent.com/processwire/processwire
Notifications https://patch-diff.githubusercontent.com/login?return_to=%2Fprocesswire%2Fprocesswire
Fork 204 https://patch-diff.githubusercontent.com/login?return_to=%2Fprocesswire%2Fprocesswire
Star 1k https://patch-diff.githubusercontent.com/login?return_to=%2Fprocesswire%2Fprocesswire
Code https://patch-diff.githubusercontent.com/processwire/processwire
Issues 1 https://patch-diff.githubusercontent.com/processwire/processwire/issues
Pull requests 70 https://patch-diff.githubusercontent.com/processwire/processwire/pulls
Projects 0 https://patch-diff.githubusercontent.com/processwire/processwire/projects
Security 0 https://patch-diff.githubusercontent.com/processwire/processwire/security
Insights https://patch-diff.githubusercontent.com/processwire/processwire/pulse
Code https://patch-diff.githubusercontent.com/processwire/processwire
Issues https://patch-diff.githubusercontent.com/processwire/processwire/issues
Pull requests https://patch-diff.githubusercontent.com/processwire/processwire/pulls
Projects https://patch-diff.githubusercontent.com/processwire/processwire/projects
Security https://patch-diff.githubusercontent.com/processwire/processwire/security
Insights https://patch-diff.githubusercontent.com/processwire/processwire/pulse
Sign up for GitHub https://patch-diff.githubusercontent.com/signup?return_to=%2Fprocesswire%2Fprocesswire%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://patch-diff.githubusercontent.com/login?return_to=%2Fprocesswire%2Fprocesswire%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://patch-diff.githubusercontent.com/processwire/processwire/pull/314#issue-comment-box
tuomassalohttps://patch-diff.githubusercontent.com/tuomassalo
processwire:devhttps://patch-diff.githubusercontent.com/processwire/processwire/tree/dev
tuomassalo:optimize-pagetable-savehttps://patch-diff.githubusercontent.com/tuomassalo/processwire/tree/optimize-pagetable-save
Remove unnecessary SELECT and DELETE when saving a page with page/pagetable fields https://patch-diff.githubusercontent.com/processwire/processwire/pull/314#top
tuomassalohttps://patch-diff.githubusercontent.com/tuomassalo
processwire:devhttps://patch-diff.githubusercontent.com/processwire/processwire/tree/dev
tuomassalo:optimize-pagetable-savehttps://patch-diff.githubusercontent.com/tuomassalo/processwire/tree/optimize-pagetable-save
Conversation 1 https://patch-diff.githubusercontent.com/processwire/processwire/pull/314
Commits 4 https://patch-diff.githubusercontent.com/processwire/processwire/pull/314/commits
Checks 0 https://patch-diff.githubusercontent.com/processwire/processwire/pull/314/checks
Files changed https://patch-diff.githubusercontent.com/processwire/processwire/pull/314/files
Please reload this pagehttps://patch-diff.githubusercontent.com/processwire/processwire/pull/314
https://github.co/hiddenchars
https://patch-diff.githubusercontent.com/processwire/processwire/pull/{{ revealButtonHref }}
https://patch-diff.githubusercontent.com/tuomassalo
tuomassalohttps://patch-diff.githubusercontent.com/tuomassalo
Jan 28, 2025https://patch-diff.githubusercontent.com/processwire/processwire/pull/314#issue-2815341916
identical logichttps://github.com/processwire/processwire/blob/dev/wire/core/Fieldtype.php#L1310
Please reload this pagehttps://patch-diff.githubusercontent.com/processwire/processwire/pull/314
tuomassalohttps://patch-diff.githubusercontent.com/tuomassalo
January 28, 2025 12:55https://patch-diff.githubusercontent.com/processwire/processwire/pull/314#commits-pushed-97f35c2
https://patch-diff.githubusercontent.com/tuomassalo
remove unnecessary select when saving a page with page/pagetable fieldshttps://patch-diff.githubusercontent.com/processwire/processwire/pull/314/commits/97f35c27e2826bb29be0a0eec9229b00471ad557
97f35c2https://patch-diff.githubusercontent.com/processwire/processwire/pull/314/commits/97f35c27e2826bb29be0a0eec9229b00471ad557
https://patch-diff.githubusercontent.com/tuomassalo
page/pagetable field optimization: skip unneeded DELETE FROM ... WHER…https://patch-diff.githubusercontent.com/processwire/processwire/pull/314/commits/67da4a654a4c953dac9ef76a1f82ce05ce59cbf9
67da4a6https://patch-diff.githubusercontent.com/processwire/processwire/pull/314/commits/67da4a654a4c953dac9ef76a1f82ce05ce59cbf9
https://patch-diff.githubusercontent.com/tuomassalo
tuomassalohttps://patch-diff.githubusercontent.com/tuomassalo
Jan 31, 2025https://patch-diff.githubusercontent.com/processwire/processwire/pull/314#issuecomment-2626869525
Please reload this pagehttps://patch-diff.githubusercontent.com/processwire/processwire/pull/314
https://patch-diff.githubusercontent.com/tuomassalo
tuomassalohttps://patch-diff.githubusercontent.com/tuomassalo
Jan 31, 2025https://patch-diff.githubusercontent.com/processwire/processwire/pull/314#event-16137295835
tuomassalohttps://patch-diff.githubusercontent.com/tuomassalo
January 31, 2025 12:48https://patch-diff.githubusercontent.com/processwire/processwire/pull/314#commits-pushed-580b4ec
https://patch-diff.githubusercontent.com/tuomassalo
clarified the commentshttps://patch-diff.githubusercontent.com/processwire/processwire/pull/314/commits/580b4eca2f75221c409fb350dc8cd45c043dde48
580b4echttps://patch-diff.githubusercontent.com/processwire/processwire/pull/314/commits/580b4eca2f75221c409fb350dc8cd45c043dde48
https://patch-diff.githubusercontent.com/tuomassalo
fixed a case where e.g. this failed: $p=$users->add("foo"); $p->save();https://patch-diff.githubusercontent.com/processwire/processwire/pull/314/commits/1b4cb173f9fd47cf043a3d9e5507f30b3ab877c7
1b4cb17https://patch-diff.githubusercontent.com/processwire/processwire/pull/314/commits/1b4cb173f9fd47cf043a3d9e5507f30b3ab877c7
Sign up for freehttps://patch-diff.githubusercontent.com/join?source=comment-repo
Sign in to commenthttps://patch-diff.githubusercontent.com/login?return_to=https%3A%2F%2Fgithub.com%2Fprocesswire%2Fprocesswire%2Fpull%2F314
Please reload this pagehttps://patch-diff.githubusercontent.com/processwire/processwire/pull/314
https://patch-diff.githubusercontent.com/tuomassalo
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.